On Wed, 29 Feb 2012 15:25:29 +0100 Paolo Bonzini <pbonz...@redhat.com> wrote:
> Il 29/02/2012 14:37, Paolo Bonzini ha scritto: > > + assert(!(dev_info->snapshot->has_format && format)); > > Oops, this wanted to be > > assert(dev_info->snapshot->has_format == (format != NULL)); > > but it can just be omitted, I wasn't sure of how QAPI handled optionals. Do you now? All optionals will be accompanied of a 'bool has_OPTIONAL_NAME', this bool will be true if the optional has been passed by the caller/client or false otherwise (in which case you shouldn't trust it).