Re: [Qemu-devel] [PATCH 1/4] usb-desc: fix user trigerrable segfaults (!config)

2012-02-28 Thread Alon Levy
On Sun, Feb 26, 2012 at 05:09:21PM +0100, Alon Levy wrote: > Check for dev->config being NULL in two places: > USB_REQ_GET_CONFIGURATION and USB_REQ_GET_STATUS. > Ping. > The behavior of USB_REQ_GET_STATUS is unspecified in the Default state, > that corresponds to dev->config being NULL (it def

Re: [Qemu-devel] [PATCH 1/4] qapi-schema: fix typos and explain 'spice' auth

2012-02-28 Thread Alon Levy
On Fri, Feb 24, 2012 at 11:22:02PM +0200, Alon Levy wrote: > Signed-off-by: Alon Levy Ping. > --- > qapi-schema.json | 18 ++ > 1 files changed, 10 insertions(+), 8 deletions(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index d0b6792..72b17f1 100644 > --- a/qapi-

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-28 Thread Wen Congyang
At 02/28/2012 01:26 PM, Wen Congyang Wrote: > At 02/27/2012 11:08 PM, Jan Kiszka Wrote: >> On 2012-02-27 04:01, Wen Congyang wrote: >>> We can know the guest is paniced when the guest runs on xen. >>> But we do not have such feature on kvm. This patch implemnts >>> this feature, and the implementat

Re: [Qemu-devel] [PATCH v2] TCG: Convert global variables to be TLS.

2012-02-28 Thread Peter Maydell
On 28 February 2012 03:13, Evgeny Voevodin wrote: > I wanted to get some feedback and points to show up a direction to move in > this field. > And qomification of translation caches is an interesting suggestion I think. If you're serious about multithreading TCG then I think the first steps are:

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-28 Thread Wen Congyang
At 02/27/2012 11:08 PM, Jan Kiszka Wrote: > On 2012-02-27 04:01, Wen Congyang wrote: >> We can know the guest is paniced when the guest runs on xen. >> But we do not have such feature on kvm. This patch implemnts >> this feature, and the implementation is the same as xen: >> register panic notifier

Re: [Qemu-devel] [PATCH] qxl: properly handle upright and non-shared surfaces

2012-02-28 Thread Gerd Hoffmann
>> -dprint(qxl, 1, "%s: stride %d, [%d, %d, %d, %d]\n", __func__, >> +dprint(qxl, 2, "%s: stride %d, [%d, %d, %d, %d]\n", __func__, > > You know 2 is used right now for high frequency stuff, like > interface_get_command? I think this should be lower. Anyway, not a big > deal. /me used '1'

Re: [Qemu-devel] [PATCH] qxl: properly handle upright and non-shared surfaces

2012-02-28 Thread Alon Levy
On Tue, Feb 28, 2012 at 09:29:38AM +0100, Gerd Hoffmann wrote: > >> -dprint(qxl, 1, "%s: stride %d, [%d, %d, %d, %d]\n", __func__, > >> +dprint(qxl, 2, "%s: stride %d, [%d, %d, %d, %d]\n", __func__, > > > > You know 2 is used right now for high frequency stuff, like > > interface_get_comma

Re: [Qemu-devel] qemu-kvm-1.0 crashes with threaded vnc server?

2012-02-28 Thread Corentin Chary
On Mon, Feb 13, 2012 at 10:24 AM, Peter Lieven wrote: > > Am 11.02.2012 um 09:55 schrieb Corentin Chary: > >> On Thu, Feb 9, 2012 at 7:08 PM, Peter Lieven wrote: >>> Hi, >>> >>> is anyone aware if there are still problems when enabling the threaded vnc >>> server? >>> I saw some VMs crashing when

Re: [Qemu-devel] [PATCH] qom: if @instance_size==0, assign size of object to parent object size

2012-02-28 Thread Paolo Bonzini
Il 28/02/2012 08:18, Igor Mitsyanko ha scritto: > QOM documentation states that for objects of type with @instance_size == 0 > size > will be assigned to match parent object's size. But currently this feauture is > not implemented and qemu asserts during creation of object with zero > instance_si

[Qemu-devel] [PATCH 1/2] qdev: accept empty string properties

2012-02-28 Thread Paolo Bonzini
These were stored as NULL due to wrong cut-and-paste from set_pointer. Reported-by: Gerhard Wiesinger Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 0423af1..bff9

[Qemu-devel] [PATCH 2/2] qom: fix device hot-unplug

2012-02-28 Thread Paolo Bonzini
Property removal modifies the list, so it is not safe to continue iteration. We know anyway that each object can have only one parent (see object_property_add_child), so exit after finding the requested object. Reported-by: Michael S. Tsirkin Signed-off-by: Paolo Bonzini --- qom/object.c |

[Qemu-devel] [PATCH 0/2] Two small QOM fixes

2012-02-28 Thread Paolo Bonzini
Two fixes for bugs that were reported on the list. Paolo Bonzini (2): qdev: accept empty string properties qom: fix device hot-unplug hw/qdev-properties.c |4 qom/object.c |7 ++- 2 files changed, 2 insertions(+), 9 deletions(-) -- 1.7.7.6

[Qemu-devel] [PATCH 0/3] qemu-iotests: add image streaming tests

2012-02-28 Thread Stefan Hajnoczi
This series adds the image streaming test suite to qemu-iotests. It covers the 'block_stream', 'block_job_cancel', 'block_job_set_speed', and 'query-block-jobs' QMP interfaces. Since these tests involve QMP it is no longer convenient to write them in bash. Instead these tests are written in Pytho

[Qemu-devel] [PATCH 1/3] qemu-iotests: export TEST_DIR for non-bash tests

2012-02-28 Thread Stefan Hajnoczi
Since qemu-iotests may need to create large image files it is possible to specify the test directory. The TEST_DIR variable needs to be exported so non-bash tests can make use of it. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/common.config |2 ++ 1 files changed, 2 insertions(+),

[Qemu-devel] [PATCH 2/3] qemu-iotests: add iotests Python module

2012-02-28 Thread Stefan Hajnoczi
Block layer tests that involve QMP commands rather than qemu-img or qemu-io are not well-suited for shell scripting. This patch adds a Python module which allows tests to be written in Python instead. The basic API is: VM - class for launching and interacting with a VM QMPTestCase -

[Qemu-devel] [PATCH 3/3] test: add image streaming tests

2012-02-28 Thread Stefan Hajnoczi
This patch adds a test suite for the image streaming feature. It exercises the 'block_stream', 'block_job_cancel', 'block_job_set_speed', and 'query-block-jobs' QMP commands. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/030 | 151 tests

Re: [Qemu-devel] [PATCH] qcow2: Fix offset in qcow2_read_extensions

2012-02-28 Thread Stefan Hajnoczi
On Mon, Feb 27, 2012 at 4:27 PM, Kevin Wolf wrote: > The spec says that the length of extensions is padded to 8 bytes, not > the offset. Currently this is the same because the header size is a > multiple of 8, so this is only about compatibility with future changes > to the header size. > > While

Re: [Qemu-devel] [PATCH] qcow2: Reject unrealistically large header extensions

2012-02-28 Thread Stefan Hajnoczi
On Mon, Feb 27, 2012 at 4:27 PM, Kevin Wolf wrote: > +        if (ext.len > 65536) { > +            error_report("Header extension larger than 64k - this looks > wrong"); > +            return -ENOTSUP; > +        } This is an implementation limit and not in the spec, but I think it's reasonable

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-28 Thread Jan Kiszka
On 2012-02-28 09:23, Wen Congyang wrote: > At 02/27/2012 11:08 PM, Jan Kiszka Wrote: >> On 2012-02-27 04:01, Wen Congyang wrote: >>> We can know the guest is paniced when the guest runs on xen. >>> But we do not have such feature on kvm. This patch implemnts >>> this feature, and the implementation

Re: [Qemu-devel] converting the block layer from coroutines to threads

2012-02-28 Thread Paolo Bonzini
Il 24/02/2012 22:01, Anthony Liguori ha scritto: >> Once you can issue I/O from two threads at the same-time (such as >> streaming in the iothread and guest I/O in the virtqueue thread), >> everything already needs to be thread-safe. It is a pretty short step >> from there to thread pools for ever

Re: [Qemu-devel] [PATCH] qom: if @instance_size==0, assign size of object to parent object size

2012-02-28 Thread Igor Mitsyanko
On 02/28/2012 12:39 PM, Paolo Bonzini wrote: Il 28/02/2012 08:18, Igor Mitsyanko ha scritto: QOM documentation states that for objects of type with @instance_size == 0 size will be assigned to match parent object's size. But currently this feauture is not implemented and qemu asserts during crea

Re: [Qemu-devel] [PATCH] qcow2: Reject unrealistically large header extensions

2012-02-28 Thread Kevin Wolf
Am 28.02.2012 10:33, schrieb Stefan Hajnoczi: > On Mon, Feb 27, 2012 at 4:27 PM, Kevin Wolf wrote: >> +if (ext.len > 65536) { >> +error_report("Header extension larger than 64k - this looks >> wrong"); >> +return -ENOTSUP; >> +} > > This is an implementati

[Qemu-devel] Wireshark SCSI dissectors for new transports

2012-02-28 Thread Stefan Hajnoczi
Wireshark today supports SCSI dissectors for iSCSI. In the QEMU system emulator we have an emulated SCSI target which handles devices for SCSI Parallel Interface (SPI), USB Mass Storage Device, and now supports the new virtio-scsi transport (for efficient virtual machine SCSI I/O). Cong and I wou

Re: [Qemu-devel] [PATCH] qcow2: Reject unrealistically large header extensions

2012-02-28 Thread Stefan Hajnoczi
On Tue, Feb 28, 2012 at 9:47 AM, Kevin Wolf wrote: > Am 28.02.2012 10:33, schrieb Stefan Hajnoczi: >> On Mon, Feb 27, 2012 at 4:27 PM, Kevin Wolf wrote: >>> +        if (ext.len > 65536) { >>> +            error_report("Header extension larger than 64k - this looks >>> wrong"); >>> +            

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-28 Thread Wen Congyang
At 02/28/2012 05:34 PM, Jan Kiszka Wrote: > On 2012-02-28 09:23, Wen Congyang wrote: >> At 02/27/2012 11:08 PM, Jan Kiszka Wrote: >>> On 2012-02-27 04:01, Wen Congyang wrote: We can know the guest is paniced when the guest runs on xen. But we do not have such feature on kvm. This patch im

Re: [Qemu-devel] [PATCH] qom: if @instance_size==0, assign size of object to parent object size

2012-02-28 Thread Paolo Bonzini
Il 28/02/2012 10:43, Igor Mitsyanko ha scritto: > On 02/28/2012 12:39 PM, Paolo Bonzini wrote: >> Il 28/02/2012 08:18, Igor Mitsyanko ha scritto: >>> QOM documentation states that for objects of type with @instance_size >>> == 0 size >>> will be assigned to match parent object's size. But currently

Re: [Qemu-devel] [PATCH] qcow2: Reject unrealistically large header extensions

2012-02-28 Thread Kevin Wolf
Am 28.02.2012 11:00, schrieb Stefan Hajnoczi: > On Tue, Feb 28, 2012 at 9:47 AM, Kevin Wolf wrote: >> Am 28.02.2012 10:33, schrieb Stefan Hajnoczi: >>> On Mon, Feb 27, 2012 at 4:27 PM, Kevin Wolf wrote: +if (ext.len > 65536) { +error_report("Header extension larger t

Re: [Qemu-devel] Wireshark SCSI dissectors for new transports

2012-02-28 Thread ronnie sahlberg
Hi Stefan. Wireshark supports a lot more than just SCSI over iSCSI It dissects SCSI over USB, FCOE, raw-FC, FCIP, iFCP (I never got access to traces for mFCP :-( ) and also over NDMP. I never got access to HyperSCSI traces either, so that is missing too. Since I never got HyperSCSI or mFCP (

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-28 Thread Jan Kiszka
On 2012-02-28 10:42, Wen Congyang wrote: > At 02/28/2012 05:34 PM, Jan Kiszka Wrote: >> On 2012-02-28 09:23, Wen Congyang wrote: >>> At 02/27/2012 11:08 PM, Jan Kiszka Wrote: On 2012-02-27 04:01, Wen Congyang wrote: > We can know the guest is paniced when the guest runs on xen. > But w

[Qemu-devel] [PATCH 14/21] usb-ehci: Handle ISO packets failing with an error other then NAK

2012-02-28 Thread Gerd Hoffmann
From: Hans de Goede Before this patch the ehci code was not checking for any other errors other then USB_RET_NAK. This causes 2 problems: 1) Other errors are not reported to the guest. 2) When transactions with the ITD_XACT_IOC bit set completing with another error would not result in USBSTS_I

[Qemu-devel] [PATCH 21/21] usb: Resolve warnings about unassigned bus on usb device creation

2012-02-28 Thread Gerd Hoffmann
From: Jan Kiszka When creating an USB device the old way, there is no way to specify the target bus. Thus the warning issued by usb_create makes no sense and rather confuses our users. Resolve this by passing a bus reference to the usbdevice_init handler and letting those handlers forward it to

[Qemu-devel] [PULL] usb patch queue

2012-02-28 Thread Gerd Hoffmann
Hi, Next batch of usb updates. This one brings packet queuing for uhci and xhci, so we have per-endpoint queues at usb-bus level now. Need to bring those to the usb drivers as next step, so they (especially usb-host) can pipeline requests. Also a bunch of bugfixes in ehci, smartcard emulation

[Qemu-devel] [PATCH] Consolidate reads and writes in nbd block device into one common routine

2012-02-28 Thread Michael Tokarev
This removes quite some duplicated code. Signed-off-By: Michael Tokarev --- block/nbd.c | 94 +++ 1 files changed, 30 insertions(+), 64 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index 161b299..82f2964 100644 --- a/block/nbd.c +

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-02-28 Thread Liu, Jinsong
> > My point is that > > qemu-version-A [-cpu whatever] > > should provide the same VM as > > qemu-version-B -machine pc-A [-cpu whatever] > > specifically if you leave out the cpu specification. > > So the compat machine could establish a feature mask (e.g. append some > "-tsc_deadline"

[Qemu-devel] [PATCH 20/21] usb-redir: Return USB_RET_NAK when we've no data for an interrupt endpoint

2012-02-28 Thread Gerd Hoffmann
From: Hans de Goede We should return USB_RET_NAK, rather then a 0 sized packet, when we've no data for an interrupt IN endpoint. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- usb-redir.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/usb-redir.c b

[Qemu-devel] [PATCH 10/21] usb-desc: fix user trigerrable segfaults (!config)

2012-02-28 Thread Gerd Hoffmann
From: Alon Levy Check for dev->config being NULL in two places: USB_REQ_GET_CONFIGURATION and USB_REQ_GET_STATUS. The behavior of USB_REQ_GET_STATUS is unspecified in the Default state, that corresponds to dev->config being NULL (it defaults to NULL and is reset whenever a SET_CONFIGURATION wit

[Qemu-devel] [PATCH 03/21] usb-uhci: cleanup UHCIAsync allocation & initialization.

2012-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb-uhci.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 2280dc7..ca87290 100644 --- a/hw/usb-uhci.c +++ b/hw/usb-uhci.c @@ -159,15 +159,9 @@ typedef struct UHCI_QH { static UHCIAsync *uhc

[Qemu-devel] [PATCH 18/21] usb-redir: Let the usb-host know about our device filtering

2012-02-28 Thread Gerd Hoffmann
From: Hans de Goede libusbredirparser-0.3.4 adds 2 new packets which allows us to notify the usb-host: -about the usb device filter we have (if any), so that it knows not the even try to redirect certain devices -when we reject a device based on filtering (in case it tries anyways) Signed-off-b

[Qemu-devel] [PATCH 04/21] usb-uhci: add UHCIQueue

2012-02-28 Thread Gerd Hoffmann
UHCIAsync structs (in-flight requests) grouped in UHCIQueue now. Each (active) usb endpoint gets its own UHCIQueue. Signed-off-by: Gerd Hoffmann --- hw/usb-uhci.c | 209 - 1 files changed, 118 insertions(+), 91 deletions(-) diff --git a/h

[Qemu-devel] [PATCH 02/21] usb-ehci: fix reset

2012-02-28 Thread Gerd Hoffmann
Two reset fixes: * pick up s->usbcmd value after ehci_reset call to make sure it keeps the reset value and doesn't get rubbish filled in when val is written back to the mmio register array later on. * make sure the frame timer is zapped on reset. Signed-off-by: Gerd Hoffmann --- hw/u

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-28 Thread Gleb Natapov
On Tue, Feb 28, 2012 at 11:19:47AM +0100, Jan Kiszka wrote: > On 2012-02-28 10:42, Wen Congyang wrote: > > At 02/28/2012 05:34 PM, Jan Kiszka Wrote: > >> On 2012-02-28 09:23, Wen Congyang wrote: > >>> At 02/27/2012 11:08 PM, Jan Kiszka Wrote: > On 2012-02-27 04:01, Wen Congyang wrote: > >

[Qemu-devel] [PATCH 06/21] usb-uhci: implement packet queuing

2012-02-28 Thread Gerd Hoffmann
When a usb device is busy processing a packet (and returns USB_RET_ASYNC), continue walking the transfer descriptor list and process them to fill the request queue. Signed-off-by: Gerd Hoffmann --- hw/usb-uhci.c | 33 +++-- 1 files changed, 31 insertions(+), 2 delet

Re: [Qemu-devel] Wireshark SCSI dissectors for new transports

2012-02-28 Thread Stefan Hajnoczi
On Tue, Feb 28, 2012 at 10:19 AM, ronnie sahlberg wrote: > Since I never got HyperSCSI or mFCP (very short-lived attempt from HBA > vendors)  those two are the only ones today I think where we miss > decode. > virt-scsi from QEMU sounds interesting! Great, thanks for your help. > First you need

[Qemu-devel] [PATCH 15/21] ehci: drop old stuff

2012-02-28 Thread Gerd Hoffmann
Drop the "ehci under development" banner. Drop unused & inactive (#if 0) code. Signed-off-by: Gerd Hoffmann --- hw/usb-ehci.c | 30 +- 1 files changed, 1 insertions(+), 29 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index b95773f..afc8ccf 100644 --- a/h

[Qemu-devel] [PATCH 08/21] usb: add tracepoint for usb packet state changes.

2012-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb.c | 27 +-- trace-events |3 +++ 2 files changed, 8 insertions(+), 22 deletions(-) diff --git a/hw/usb.c b/hw/usb.c index e5b8f33..57fc5e3 100644 --- a/hw/usb.c +++ b/hw/usb.c @@ -26,6 +26,7 @@ #include "qemu-common.h" #

Re: [Qemu-devel] [PATCH] qom: if @instance_size==0, assign size of object to parent object size

2012-02-28 Thread Igor Mitsyanko
On 02/28/2012 02:03 PM, Paolo Bonzini wrote: Il 28/02/2012 10:43, Igor Mitsyanko ha scritto: On 02/28/2012 12:39 PM, Paolo Bonzini wrote: Il 28/02/2012 08:18, Igor Mitsyanko ha scritto: QOM documentation states that for objects of type with @instance_size == 0 size will be assigned to match pa

[Qemu-devel] [PATCH 19/21] usb-redir: Limit return values returned by iso packets

2012-02-28 Thread Gerd Hoffmann
From: Hans de Goede The usbredir protocol uses a status of usb_redir_stall to indicate that an iso data stream has stopped (ie because the urbs failed on resubmit), but iso packets should never return a result of USB_RET_STALL, since iso endpoints cannot stall. So instead simply always return USB

[Qemu-devel] [PATCH v2] Consolidate reads and writes in nbd block device into one common routine

2012-02-28 Thread Michael Tokarev
This removes quite some duplicated code. v2 fixes a bug (uninitialized reply.error) and makes the loop more natural. Signed-off-By: Michael Tokarev --- block/nbd.c | 95 +++--- 1 files changed, 31 insertions(+), 64 deletions(-) diff --git a

[Qemu-devel] [PATCH v2] qcow2: Reject too large header extensions

2012-02-28 Thread Kevin Wolf
Image files that make qemu-img info read several gigabytes into the unknown header extensions list are bad. Just fail opening the image if an extension claims to be larger than the header extension area. Signed-off-by: Kevin Wolf --- block/qcow2.c |5 + 1 files changed, 5 insertions(+),

Re: [Qemu-devel] [PATCH V7 06/11] pci.c: Add pci_check_bar_overlap

2012-02-28 Thread Anthony PERARD
On Sun, Feb 19, 2012 at 13:35, Michael S. Tsirkin wrote: > On Fri, Feb 17, 2012 at 05:08:40PM +, Anthony PERARD wrote: >> From: Yuji Shimada >> >> This function helps Xen PCI Passthrough device to check for overlap. >> >> Signed-off-by: Yuji Shimada >> Signed-off-by: Anthony PERARD > > As f

Re: [Qemu-devel] [PATCH] qom: if @instance_size==0, assign size of object to parent object size

2012-02-28 Thread Paolo Bonzini
Il 28/02/2012 12:09, Igor Mitsyanko ha scritto: > > Perhaps >> type_late_init would be a better name. > > How about simple type_initialization()? We use verbs, so it would be type_initialize, but yes. Paolo

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-28 Thread Avi Kivity
On 02/27/2012 05:01 AM, Wen Congyang wrote: > We can know the guest is paniced when the guest runs on xen. > But we do not have such feature on kvm. This patch implemnts > this feature, and the implementation is the same as xen: > register panic notifier, and call hypercall when the guest > is pani

[Qemu-devel] [PATCH v2 0/3] New sigaltstack backend for coroutine

2012-02-28 Thread Alex Barcelo
This series of patches implements coroutines method with sigaltstack. The flow of creation and management of the coroutines is quite similar to the coroutine-ucontext.c. The way to use sigaltstack to achieve the needed stack manipulation is done in a way quite similar to the GNU Portable Threads (

[Qemu-devel] [PATCH v2 1/3] coroutine: adding sigaltstack method (.c source)

2012-02-28 Thread Alex Barcelo
This file is based in both coroutine-ucontext.c and pth_mctx.c (from the GNU Portable Threads library). The mechanism used to change stacks is the sigaltstack function (variant 2 of the pth library). v2: Some corrections. Moving global variables into thread storage (CoroutineThreadState). Signed

[Qemu-devel] [PATCH v2 3/3] coroutine: adding configure option for sigaltstack coroutine backend

2012-02-28 Thread Alex Barcelo
It's possible to use sigaltstack backend with --with-coroutine=sigaltstack v2: changed from enable/disable configure flags Signed-off-by: Alex Barcelo --- Makefile.objs |4 configure |6 +- 2 files changed, 9 insertions(+), 1 deletions(-) diff --git a/Makefile.objs b/Makef

[Qemu-devel] [PATCH v2 2/3] coroutine: adding configure choose mechanism for coroutine backend

2012-02-28 Thread Alex Barcelo
Configure tries, as a default, ucontext functions for the coroutines. But now the user can force another backend by --with-coroutine=BACKEND option v2: Using --with-coroutine=BACKEND instead of enable disable individual configure options Signed-off-by: Alex Barcelo --- configure | 37

[Qemu-devel] [PATCH 05/21] usb-uhci: process uhci_handle_td return code via switch.

2012-02-28 Thread Gerd Hoffmann
Restruct the uhci_handle_td return code processing to make the control flow more clear and the code more readable. Signed-off-by: Gerd Hoffmann --- hw/usb-uhci.c | 66 +--- 1 files changed, 39 insertions(+), 27 deletions(-) diff --git a/hw/u

[Qemu-devel] [PATCH 11/21] libcacard: link with glib for g_strndup

2012-02-28 Thread Gerd Hoffmann
From: Alon Levy Without it the produced library for make libcacard.la has an unresolved symbol. Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index f9d5330..87474e9 100755 -

[Qemu-devel] [PATCH 01/21] usb-hid: fix tablet activation

2012-02-28 Thread Gerd Hoffmann
Activate usb hid pointer devices (mouse+tablet) unconditionally on polls, even if we NAK the poll due to lack of new events. Signed-off-by: Gerd Hoffmann --- hw/usb-hid.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/usb-hid.c b/hw/usb-hid.c index 7fc0bd8..37bca78

[Qemu-devel] [PATCH 13/21] libcacard: fix reported ATR length

2012-02-28 Thread Gerd Hoffmann
From: Alon Levy Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann --- libcacard/vcardt.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libcacard/vcardt.h b/libcacard/vcardt.h index 538bdde..d4d8e2e 100644 --- a/libcacard/vcardt.h +++ b/libcacard/vcardt.h @@ -2

Re: [Qemu-devel] [PATCH v2] Consolidate reads and writes in nbd block device into one common routine

2012-02-28 Thread Paolo Bonzini
Il 28/02/2012 11:24, Michael Tokarev ha scritto: > This removes quite some duplicated code. > > v2 fixes a bug (uninitialized reply.error) and makes the loop more natural. > > Signed-off-By: Michael Tokarev > --- > block/nbd.c | 95 +++--- >

[Qemu-devel] [PATCH 09/21] usb-ehci: sanity-check iso xfers

2012-02-28 Thread Gerd Hoffmann
This patch adds a sanity check to itd processing to make sure the endpoint addressed by the guest is actually an iso endpoint. Also verify that usb drivers don't return USB_RET_ASYNC which is illegal for iso xfers. Signed-off-by: Gerd Hoffmann --- hw/usb-ehci.c | 16 ++-- 1 files

[Qemu-devel] [PATCH 12/21] usb-ccid: advertise SELF_POWERED

2012-02-28 Thread Gerd Hoffmann
From: Alon Levy Before commit ed5a83ddd8c1d8ec7b1015315530cf29949e7c48 each device provided it's own response to USB_REQ_GET_STATUS, but after it that response was based on bmAttributes, which was errounously set for usb-ccid as 0xa0 and not 0xe0. Signed-off-by: Alon Levy Signed-off-by: Gerd Ho

Re: [Qemu-devel] linux guests and ksm performance

2012-02-28 Thread Peter Lieven
On 24.02.2012 08:23, Stefan Hajnoczi wrote: On Fri, Feb 24, 2012 at 6:53 AM, Stefan Hajnoczi wrote: On Fri, Feb 24, 2012 at 6:41 AM, Stefan Hajnoczi wrote: On Thu, Feb 23, 2012 at 7:08 PM, peter.lie...@gmail.com wrote: Stefan Hajnoczi schrieb: On Thu, Feb 23, 2012 at 3:40 PM, Peter Lieve

[Qemu-devel] Qemu disaggregation in Xen environment

2012-02-28 Thread Julien Grall
Hello, In the current model, only one instance of qemu is running for each running HVM domain. We are looking at disaggregating qemu to have, for example, an instance to emulate only network controllers, another to emulate block devices, etc... Multiple instances of qemu would run for a singl

Re: [Qemu-devel] qemu-kvm-1.0 crashes with threaded vnc server?

2012-02-28 Thread Peter Lieven
On 28.02.2012 09:37, Corentin Chary wrote: On Mon, Feb 13, 2012 at 10:24 AM, Peter Lieven wrote: Am 11.02.2012 um 09:55 schrieb Corentin Chary: On Thu, Feb 9, 2012 at 7:08 PM, Peter Lieven wrote: Hi, is anyone aware if there are still problems when enabling the threaded vnc server? I saw s

Re: [Qemu-devel] [PATCH v3 1/2] qapi: Introduce blockdev-group-snapshot-sync command

2012-02-28 Thread Kevin Wolf
Am 28.02.2012 01:33, schrieb Jeff Cody: > This is a QAPI/QMP only command to take a snapshot of a group of > devices. This is similar to the blockdev-snapshot-sync command, except > blockdev-group-snapshot-sync accepts a list devices, filenames, and > formats. > > It is attempted to keep the snaps

[Qemu-devel] [PATCH 17/21] usb-redir: Always clear device state on filter reject

2012-02-28 Thread Gerd Hoffmann
From: Hans de Goede Always call usbredir_device_disconnect() when usbredir_check_filter() fails to clean up all the device state (ie received endpoint info). Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- usb-redir.c | 11 +++ 1 files changed, 7 insertions(+), 4 delet

[Qemu-devel] [PATCH V2 0/2] QOM: small object creation fix

2012-02-28 Thread Igor Mitsyanko
Eliminate impossibility of creating objects of types with @instance_size == 0. v1->v2: type's instance size now initialized during type initialization. type_class_init() renamed (in additional patch) Igor Mitsyanko (2): qom: if @instance_size==0, assign size of object to parent object

[Qemu-devel] [PATCH V2 1/2] qom: if @instance_size==0, assign size of object to parent object size

2012-02-28 Thread Igor Mitsyanko
QOM documentation states that for objects of type with @instance_size == 0 size will be assigned to match parent object's size. But currently this feauture is not implemented and qemu asserts during creation of object with zero instance_size. Set appropriate value for type instance_size during ty

[Qemu-devel] [PATCH V2 2/2] qom/object.c: rename type_class_init() to type_initialize()

2012-02-28 Thread Igor Mitsyanko
Function name type_class_init() gave us a wrong impression of separation of type's "class" and "object" entities initialization. Name type_initialize() is more appropriate for type_class_init() function (considering what operations it performs). Signed-off-by: Igor Mitsyanko --- qom/object.c |

Re: [Qemu-devel] [PATCH V2 0/2] QOM: small object creation fix

2012-02-28 Thread Paolo Bonzini
Il 28/02/2012 12:57, Igor Mitsyanko ha scritto: > Eliminate impossibility of creating objects of types with @instance_size == 0. > > v1->v2: type's instance size now initialized during type initialization. > type_class_init() renamed (in additional patch) > > Igor Mitsyanko (2): > qom:

[Qemu-devel] [PATCH 07/21] usb-xhci: enable packet queuing

2012-02-28 Thread Gerd Hoffmann
qemu usb core has packet queues now, so flip lets the switch. Signed-off-by: Gerd Hoffmann --- hw/usb-xhci.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/hw/usb-xhci.c b/hw/usb-xhci.c index 008b0b5..fc5b542 100644 --- a/hw/usb-xhci.c +++ b/hw/usb-xhci.c @@ -1769,

[Qemu-devel] [PATCH 16/21] usb-redir: Fix printing of device version

2012-02-28 Thread Gerd Hoffmann
From: Hans de Goede The device version is in bcd format, which requires some special handling to print. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- usb-redir.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/usb-redir.c b/usb-redir.c index a59b3

Re: [Qemu-devel] [PATCH v2] qcow2: Reject too large header extensions

2012-02-28 Thread Stefan Hajnoczi
On Tue, Feb 28, 2012 at 10:26 AM, Kevin Wolf wrote: > Image files that make qemu-img info read several gigabytes into the > unknown header extensions list are bad. Just fail opening the image > if an extension claims to be larger than the header extension area. > > Signed-off-by: Kevin Wolf > ---

Re: [Qemu-devel] [PATCH v6 2/4] cadence_ttc: initial version of device model

2012-02-28 Thread Paul Brook
> > Thinking about that, I realised why I don't like the following line: > >> +s->reg_value = (uint32_t)((x + interval) % interval); > > > > This assumes x > -interval, which is not always true. > > This would mean you have wrapped twice or more in one time step, which > I am assuming is a fa

Re: [Qemu-devel] linux guests and ksm performance

2012-02-28 Thread Peter Lieven
On 28.02.2012 13:05, Stefan Hajnoczi wrote: On Tue, Feb 28, 2012 at 11:46 AM, Peter Lieven wrote: On 24.02.2012 08:23, Stefan Hajnoczi wrote: On Fri, Feb 24, 2012 at 6:53 AM, Stefan Hajnoczi wrote: On Fri, Feb 24, 2012 at 6:41 AM, Stefan Hajnoczi wrote: On Thu, Feb 23, 2012 at 7:08 PM, p

[Qemu-devel] [PULL] Memory core space reduction

2012-02-28 Thread Avi Kivity
This is the current memory queue (posted as two separate series before my vacation). When applied, the overhead of 16 bytes/page is reduced to basically nil. Avi Kivity (30): ioport: change portio_list not to use memory_region

[Qemu-devel] [PULL] Memory core space reduction

2012-02-28 Thread Avi Kivity
[repost with pull info, brain not yet back up to speed] This is the current memory queue (posted as two separate series before my vacation). When applied, the overhead of 16 bytes/page is reduced to basically nil. Please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/cor

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-28 Thread Avi Kivity
On 02/28/2012 02:25 PM, Avi Kivity wrote: > [repost with pull info, brain not yet back up to speed] > > This is the current memory queue (posted as two separate series before > my vacation). When applied, the overhead of 16 bytes/page is reduced to > basically nil. > > Please pull from: > > git:

Re: [Qemu-devel] [PATCH 6/6] kvm: Fix dirty tracking with large kernel page size

2012-02-28 Thread Avi Kivity
On 02/24/2012 02:23 AM, David Gibson wrote: > From: Benjamin Herrenschmidt > > If the kernel page size is larger than TARGET_PAGE_SIZE, which > happens for example on ppc64 with kernels compiled for 64K pages, > the dirty tracking doesn't work. > > Cc: Avi Kivity > Cc: Marcelo Tossatti > > Signe

Re: [Qemu-devel] [PATCH v2] Consolidate reads and writes in nbd block device into one common routine

2012-02-28 Thread Michael Tokarev
On 28.02.2012 15:35, Paolo Bonzini wrote: > Il 28/02/2012 11:24, Michael Tokarev ha scritto: >> This removes quite some duplicated code. [] >> +static int nbd_co_rwv(BlockDriverState *bs, int64_t sector_num, >> + int nb_sectors, QEMUIOVector *qiov, int iswrite) > > Call this n

[Qemu-devel] [Bug 942299] Re: Regression in booting HelenOS/ppc under Qemu

2012-02-28 Thread Artyom Tarasenko
Just for the reference, commit 41557447d30eeb944e42069513df13585f5e6c7f Author: Alexander Graf Date: Fri Sep 10 15:08:34 2010 + PPC: Redesign interrupt trigger path According to the Book3S spec, the interrupt context starts with an MSR value that is rather simple. If we leave

Re: [Qemu-devel] [PATCH v2] Consolidate reads and writes in nbd block device into one common routine

2012-02-28 Thread Paolo Bonzini
Il 28/02/2012 13:35, Michael Tokarev ha scritto: > On 28.02.2012 15:35, Paolo Bonzini wrote: >> Il 28/02/2012 11:24, Michael Tokarev ha scritto: >>> This removes quite some duplicated code. > [] >>> +static int nbd_co_rwv(BlockDriverState *bs, int64_t sector_num, >>> + int nb_s

Re: [Qemu-devel] linux guests and ksm performance

2012-02-28 Thread Avi Kivity
On 02/23/2012 06:42 PM, Stefan Hajnoczi wrote: > On Thu, Feb 23, 2012 at 3:40 PM, Peter Lieven wrote: > > However, in a virtual machine I have not observed the above slow down to > > that extend > > while the benefit of zero after free in a virtualisation environment is > > obvious: > > > > 1) zer

Re: [Qemu-devel] linux guests and ksm performance

2012-02-28 Thread Avi Kivity
On 02/24/2012 08:41 AM, Stefan Hajnoczi wrote: > > > > I dont think that it is cpu intense. All user pages are zeroed anyway, but > > at allocation time it shouldnt be a big difference in terms of cpu power. > > It's easy to find a scenario where eagerly zeroing pages is wasteful. > Imagine a proc

Re: [Qemu-devel] [PATCH v2] Consolidate reads and writes in nbd block device into one common routine

2012-02-28 Thread Michael Tokarev
On 28.02.2012 17:03, Paolo Bonzini wrote: > Il 28/02/2012 13:35, Michael Tokarev ha scritto: >> On 28.02.2012 15:35, Paolo Bonzini wrote: >>> Il 28/02/2012 11:24, Michael Tokarev ha scritto: This removes quite some duplicated code. >> [] +static int nbd_co_rwv(BlockDriverState *bs, int64_

Re: [Qemu-devel] linux guests and ksm performance

2012-02-28 Thread Peter Lieven
On 28.02.2012 14:16, Avi Kivity wrote: On 02/24/2012 08:41 AM, Stefan Hajnoczi wrote: I dont think that it is cpu intense. All user pages are zeroed anyway, but at allocation time it shouldnt be a big difference in terms of cpu power. It's easy to find a scenario where eagerly zeroing pages is

[Qemu-devel] [PATCH] We should check virtio_load return code

2012-02-28 Thread Orit Wasserman
Otherwise we crash on error. Signed-off-by: Orit Wasserman Signed-off-by: Ulrich Obergfell --- hw/virtio-balloon.c|6 +- hw/virtio-blk.c|7 ++- hw/virtio-net.c|6 +- hw/virtio-scsi.c |7 ++- hw/virtio-serial-bus.c |6 +- 5 files

Re: [Qemu-devel] qemu assertion failed with usb on current git master!

2012-02-28 Thread Erik Rull
On February 27, 2012 at 5:53 PM Erik Rull wrote: > Gerd Hoffmann wrote: > >Hi, > > > >> I'm really sorry, but I don't understand what's happening - I copied the > >> qemu executable on my target system before executing it, but gdb complains > >> that the core file does not match the execut

Re: [Qemu-devel] [PATCH] We should check virtio_load return code

2012-02-28 Thread Paolo Bonzini
Il 28/02/2012 14:31, Orit Wasserman ha scritto: > Otherwise we crash on error. > > Signed-off-by: Orit Wasserman > Signed-off-by: Ulrich Obergfell > --- > hw/virtio-balloon.c|6 +- > hw/virtio-blk.c|7 ++- > hw/virtio-net.c|6 +- > hw/virtio-scsi.c

Re: [Qemu-devel] [PATCH v6 2/4] cadence_ttc: initial version of device model

2012-02-28 Thread Peter Crosthwaite
On Tue, Feb 28, 2012 at 10:07 PM, Paul Brook wrote: >> > Thinking about that, I realised why I don't like the following line: >> >> +    s->reg_value = (uint32_t)((x + interval) % interval); >> > >> > This assumes x > -interval, which is not always true. >> >> This would mean you have wrapped twic

Re: [Qemu-devel] linux guests and ksm performance

2012-02-28 Thread Avi Kivity
On 02/28/2012 03:20 PM, Peter Lieven wrote: > On 28.02.2012 14:16, Avi Kivity wrote: >> On 02/24/2012 08:41 AM, Stefan Hajnoczi wrote: I dont think that it is cpu intense. All user pages are zeroed anyway, but at allocation time it shouldnt be a big difference in terms of cpu power.

[Qemu-devel] [PATCH 3/3] qemu-ga: add guest-suspend-hybrid

2012-02-28 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qapi-schema-guest.json | 23 +++ qga/commands-posix.c | 10 ++ 2 files changed, 33 insertions(+), 0 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json index b102311..6a75552 100644 --- a/qapi-schema-guest

[Qemu-devel] [PATCH 1/3] qemu-ga: add guest-suspend-disk

2012-02-28 Thread Luiz Capitulino
As the command name implies, this command suspends the guest to disk. The suspend operation is implemented by two functions: bios_supports_mode() and guest_suspend(). Both functions are generic enough to be used by other suspend modes (introduced by next commits). Both functions will try to use t

Re: [Qemu-devel] [PATCH 6/8] gtk: add support for screen scaling and full screen (v2)

2012-02-28 Thread Kevin Wolf
Am 27.02.2012 21:10, schrieb Stefan Weil: > Am 27.02.2012 00:46, schrieb Anthony Liguori: >> Basic menu items to enter full screen mode and zoom in/out. Unlike SDL, we >> don't allow arbitrary scaling based on window resizing. The current >> behavior >> with SDL causes a lot of problems for me. >>

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-28 Thread Luiz Capitulino
On Mon, 27 Feb 2012 20:07:28 -0600 Michael Roth wrote: > What about something like this instead: > > { 'enum': 'GuestIpAddressType', > 'data': [ 'ipv4', 'ipv6' ] } > > { 'type': 'GuestIpAddress', > 'data': {'ip-address': 'str', >'ip-address-type': 'GuestIpAddressType', >

[Qemu-devel] [PATCH v4 2/2] QMP: Add qmp command for blockdev-group-snapshot-sync

2012-02-28 Thread Jeff Cody
This adds the QMP command for blockdev-group-snapshot-sync. It takes an array in as the input, for the argument devlist. The array consists of the following elements: + device:device to snapshot. e.g. "ide-hd0", "virtio0" + snapshot-file: path & file for the snapshot image. e.g. "

[Qemu-devel] [PATCH v4 1/2] qapi: Introduce blockdev-group-snapshot-sync command

2012-02-28 Thread Jeff Cody
This is a QAPI/QMP only command to take a snapshot of a group of devices. This is similar to the blockdev-snapshot-sync command, except blockdev-group-snapshot-sync accepts a list devices, filenames, and formats. It is attempted to keep the snapshot of the group atomic; if the creation or open of

[Qemu-devel] [PATCH] usb: queue can have async packets too

2012-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/usb.c b/hw/usb.c index 57fc5e3..fc41d62 100644 --- a/hw/usb.c +++ b/hw/usb.c @@ -356,6 +356,9 @@ void usb_packet_complete(USBDevice *dev, USBPacket *p) while (!QTAILQ_EMP

  1   2   3   >