[Qemu-devel] [PATCH 1/2] slirp: remove duplicate definition

2012-02-15 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- slirp/if.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/slirp/if.c b/slirp/if.c index 2852396..8e0cac2 100644 --- a/slirp/if.c +++ b/slirp/if.c @@ -8,8 +8,6 @@ #include #include "qemu-timer.h" -#define ifs_init(i

[Qemu-devel] [PATCH 2/2] slirp: fix packet requeue issue in batchq

2012-02-15 Thread zwu . kernel
From: Zhi Yong Wu This patch fixes the slirp crash in current QEMU upstream. Signed-off-by: Zhi Yong Wu --- slirp/if.c | 37 ++--- slirp/mbuf.c |3 +-- 2 files changed, 31 insertions(+), 9 deletions(-) diff --git a/slirp/if.c b/slirp/if.c index 8e0cac2.

[Qemu-devel] [PATCH] input: send kbd+mouse events only to running guests.

2012-02-15 Thread Gerd Hoffmann
Trying to interact with a stopped guest will queue up the events, then send them all at once when the guest continues running, with a high chance to have them cause unwanted actions. Avoid that by only injecting the input events only when the guest is in running state. Signed-off-by: Gerd Hoffman

[Qemu-devel] [Bug 932539] Re: qemu exits with -11 when connecting to a port redirect before the service starts listening

2012-02-15 Thread Serge Hallyn
I was thinking 1ab74cea060d776b19857c3babc64d729bbdba5c might have introduced it, but at that commit it doesn't happen. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/932539 Title: qemu exits with -

Re: [Qemu-devel] [PATCH 1/2] slirp: remove duplicate definition

2012-02-15 Thread Jan Kiszka
On 2012-02-15 09:12, zwu.ker...@gmail.com wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > --- > slirp/if.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/slirp/if.c b/slirp/if.c > index 2852396..8e0cac2 100644 > --- a/slirp/if.c > +++ b/slirp/if.c >

Re: [Qemu-devel] [PATCH 2/2] slirp: fix packet requeue issue in batchq

2012-02-15 Thread Jan Kiszka
On 2012-02-15 09:13, zwu.ker...@gmail.com wrote: > From: Zhi Yong Wu > > This patch fixes the slirp crash in current QEMU upstream. > > Signed-off-by: Zhi Yong Wu > --- > slirp/if.c | 37 ++--- > slirp/mbuf.c |3 +-- > 2 files changed, 31 insertions(+),

Re: [Qemu-devel] [TRIVIAL v2] Bad zero comparison for sas_ss_flags on powerpc

2012-02-15 Thread Alexander Graf
On 15.02.2012, at 07:55, Alex Barcelo wrote: > ping? is this ok? Or it is not trivial at all, and better do a normal patch? > And write it better? The patch is fine, but it's not trivial. It's a ppc patch, hence it should've gotten CC'ed to qemu-ppc :). Also, whatever mailer you used to send t

Re: [Qemu-devel] [RFC][PATCH 01/16 v6] monitor: introduce qemu_suspend_monitor()/qemu_resume_monitor()

2012-02-15 Thread Jan Kiszka
On 2012-02-15 03:54, Wen Congyang wrote: > At 02/15/2012 12:19 AM, Jan Kiszka Wrote: >> On 2012-02-09 04:19, Wen Congyang wrote: >>> Sync command needs these two APIs to suspend/resume monitor. >>> >>> Signed-off-by: Wen Congyang >>> --- >>> monitor.c | 27 +++ >>> monit

Re: [Qemu-devel] [PATCH v15 00/10] ARM: Samsung Exynos4210-based boards support.

2012-02-15 Thread Peter Maydell
On 15 February 2012 04:16, Evgeny Voevodin wrote: >> On 14.02.2012 23:51, Peter Maydell wrote: >>> Have you tried booting this with the 'earlyprintk' kernel option? >>> I tried this with a 3.2.0 kernel and the exynos4 defconfig and it >>> crashes > > My suggestion is that this is a kernel issue. T

Re: [Qemu-devel] [PATCH 0/6] qapi: Convert migrate

2012-02-15 Thread Jan Kiszka
On 2012-02-10 20:31, Luiz Capitulino wrote: > This is a rebase of Anthony's conversion, from his glib branch; and this is > also the beginning of the conversion of complex commands to the qapi. > > There are two important changes that should be observed: > > 1. patch 5/6 purges the 'mon' object

[Qemu-devel] [Bug 932539] Re: qemu exits with -11 when connecting to a port redirect before the service starts listening

2012-02-15 Thread Serge Hallyn
Oddly, a bisect suggests this was introduced by commit e3a110b527f749a2acec079c261f4481aadd3edc: slirp: Only start packet expiration for delayed ones which seems rather innocent. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. h

Re: [Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything to do with monitors

2012-02-15 Thread Jan Kiszka
On 2012-02-10 20:31, Luiz Capitulino wrote: > The Monitor object is passed back and forth within the migration/savevm > code so that it can print errors and progress to the user. > > However, that approach assumes a HMP monitor, being completely invalid > in QMP. > > This commit drops almost ever

Re: [Qemu-devel] [PATCH v2 0/5] qemu-queue cleanups

2012-02-15 Thread Paolo Bonzini
On 01/13/2012 05:34 PM, Paolo Bonzini wrote: > These patches slighly change the assortment of lists provided by > qemu-queue. QCIRCLEQ is dropped, since it provides no real advantage > over QTAILQ (and in fact is unused). QSLIST is introduced and used for > free lists. > > QSIMPLEQ is left in, s

Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background

2012-02-15 Thread Jan Kiszka
On 2012-02-15 04:47, Wen Congyang wrote: > At 02/15/2012 02:27 AM, Jan Kiszka Wrote: >> On 2012-02-14 19:05, Jan Kiszka wrote: >>> On 2012-02-09 04:28, Wen Congyang wrote: The new monitor command dump may take long time to finish. So we need run it at the background. >>> >>> How doe

Re: [Qemu-devel] [RFC][PATCH 08/16 v6] target-i386: add API to get dump info

2012-02-15 Thread Wen Congyang
At 02/15/2012 05:05 PM, Jan Kiszka Wrote: > On 2012-02-15 04:30, Wen Congyang wrote: diff --git a/dump.h b/dump.h new file mode 100644 index 000..a36468b --- /dev/null +++ b/dump.h @@ -0,0 +1,10 @@ >>> >>> License header missing. >> >> There is no license in other

Re: [Qemu-devel] [RFC][PATCH 08/16 v6] target-i386: add API to get dump info

2012-02-15 Thread Peter Maydell
On 9 February 2012 03:26, Wen Congyang wrote: > +int cpu_get_dump_info(ArchDumpInfo *info) > +{ > +    bool lma = false; > +    RAMBlock *block; > + > +#ifdef TARGET_X86_64 > +    lma = !!(first_cpu->hflags & HF_LMA_MASK); > +#endif > + > +    if (lma) { > +        info->d_machine = EM_X86_64; > +

Re: [Qemu-devel] [RFC][PATCH 08/16 v6] target-i386: add API to get dump info

2012-02-15 Thread Wen Congyang
At 02/15/2012 05:12 PM, Peter Maydell Wrote: > On 9 February 2012 03:26, Wen Congyang wrote: >> +int cpu_get_dump_info(ArchDumpInfo *info) >> +{ >> +bool lma = false; >> +RAMBlock *block; >> + >> +#ifdef TARGET_X86_64 >> +lma = !!(first_cpu->hflags & HF_LMA_MASK); >> +#endif >> + >> +

Re: [Qemu-devel] [RFC][PATCH 05/16 v6] Add API to get memory mapping

2012-02-15 Thread Jan Kiszka
On 2012-02-15 05:07, Wen Congyang wrote: > At 02/15/2012 01:21 AM, Jan Kiszka Wrote: >> On 2012-02-09 04:22, Wen Congyang wrote: >>> Add API to get all virtual address and physical address mapping. >>> If there is no virtual address for some physical address, the virtual >>> address is 0. >>> >>> S

Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background

2012-02-15 Thread Wen Congyang
At 02/15/2012 05:07 PM, Jan Kiszka Wrote: > On 2012-02-15 04:47, Wen Congyang wrote: >> At 02/15/2012 02:27 AM, Jan Kiszka Wrote: >>> On 2012-02-14 19:05, Jan Kiszka wrote: On 2012-02-09 04:28, Wen Congyang wrote: > The new monitor command dump may take long time to finish. So we need run

[Qemu-devel] [PATCH v2 1/2] qxl: set only off-screen surfaces dirty instead of the whole vram

2012-02-15 Thread Yonit Halperin
We used to assure the guest surfaces were saved before migration by setting the whole vram dirty. This patch sets dirty only the areas that are actually used in the vram. Signed-off-by: Yonit Halperin --- hw/qxl.c | 53 - 1 files changed, 44

[Qemu-devel] [PATCH v2 2/2] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-15 Thread Yonit Halperin
RHBZ #790083 Signed-off-by: Yonit Halperin --- hw/qxl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index df55de1..10137f9 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1470,7 +1470,7 @@ static void qxl_dirty_surfaces(PCIQXLDevice *qxl) intptr_t

Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background

2012-02-15 Thread Jan Kiszka
On 2012-02-15 10:22, Wen Congyang wrote: > At 02/15/2012 05:07 PM, Jan Kiszka Wrote: >> On 2012-02-15 04:47, Wen Congyang wrote: >>> At 02/15/2012 02:27 AM, Jan Kiszka Wrote: On 2012-02-14 19:05, Jan Kiszka wrote: > On 2012-02-09 04:28, Wen Congyang wrote: >> The new monitor command du

Re: [Qemu-devel] [PATCH 4/6] Error: Introduce error_copy()

2012-02-15 Thread Paolo Bonzini
On 02/10/2012 08:31 PM, Luiz Capitulino wrote: > +err_new = g_malloc0(sizeof(*err)); > +err_new->obj = qdict_copy(err->obj); > +err_new->msg = g_strdup(err->msg); > +err_new->fmt = err->fmt; > + > +return err_new; > +} Why isn't an incref sufficient? QDicts should be constant

Re: [Qemu-devel] qemu-kvm-1.0 regression with usb tablet after live migration

2012-02-15 Thread Peter Lieven
Anyone? Peter Lieven wrote: > Hi, > > i recently started updating our VMs to qemu-kvm 1.0. Since that I see > that the usb tablet device (used for as pointer device for accurate > mouse positioning) becomes unavailable after live migrating. > If I migrate a few times a Windows 7 VM reliable stops

Re: [Qemu-devel] [RFC][PATCH 07/16 v6] target-i386: Add API to add extra memory mapping

2012-02-15 Thread Jan Kiszka
On 2012-02-15 06:19, Wen Congyang wrote: > At 02/15/2012 01:35 AM, Jan Kiszka Wrote: >> On 2012-02-09 04:24, Wen Congyang wrote: >>> Crash needs extra memory mapping to determine phys_base. >>> >>> Signed-off-by: Wen Congyang >>> --- >>> cpu-all.h |2 ++ >>> target-i386/arch-dum

Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background

2012-02-15 Thread Wen Congyang
At 02/15/2012 05:21 PM, Jan Kiszka Wrote: > On 2012-02-15 10:22, Wen Congyang wrote: >> At 02/15/2012 05:07 PM, Jan Kiszka Wrote: >>> On 2012-02-15 04:47, Wen Congyang wrote: At 02/15/2012 02:27 AM, Jan Kiszka Wrote: > On 2012-02-14 19:05, Jan Kiszka wrote: >> On 2012-02-09 04:28, Wen

Re: [Qemu-devel] [PATCH 6/6] qapi: Convert migrate

2012-02-15 Thread Wen Congyang
At 02/11/2012 03:31 AM, Luiz Capitulino Wrote: > The migrate command is one of those commands where HMP and QMP completely > mix up together. This made the conversion to the QAPI (which separates the > command into QMP and HMP parts) a bit difficult. > > The first important change to be noticed is

Re: [Qemu-devel] [Spice-devel] [PATCH v2 1/2] qxl: set only off-screen surfaces dirty instead of the whole vram

2012-02-15 Thread Alon Levy
On Wed, Feb 15, 2012 at 11:22:15AM +0200, Yonit Halperin wrote: > We used to assure the guest surfaces were saved before migration by > setting the whole vram dirty. This patch sets dirty only the areas > that are actually used in the vram. > Series is Reviewed-by: Alon Levy > Signed-off-by: Yo

Re: [Qemu-devel] [PATCH 1/2] slirp: remove duplicate definition

2012-02-15 Thread Michael S. Tsirkin
On Wed, Feb 15, 2012 at 09:30:23AM +0100, Jan Kiszka wrote: > On 2012-02-15 09:12, zwu.ker...@gmail.com wrote: > > From: Zhi Yong Wu > > > > Signed-off-by: Zhi Yong Wu > > --- > > slirp/if.c |2 -- > > 1 files changed, 0 insertions(+), 2 deletions(-) > > > > diff --git a/slirp/if.c b/slirp

Re: [Qemu-devel] [PATCH v15 00/10] ARM: Samsung Exynos4210-based boards support.

2012-02-15 Thread Evgeny Voevodin
15.02.2012 12:56, Peter Maydell пишет: On 15 February 2012 04:16, Evgeny Voevodin wrote: On 14.02.2012 23:51, Peter Maydell wrote: Have you tried booting this with the 'earlyprintk' kernel option? I tried this with a 3.2.0 kernel and the exynos4 defconfig and it crashes My suggestion is that

Re: [Qemu-devel] [RFC][PATCH 05/16 v6] Add API to get memory mapping

2012-02-15 Thread Wen Congyang
At 02/15/2012 05:17 PM, Jan Kiszka Wrote: > On 2012-02-15 05:07, Wen Congyang wrote: >> At 02/15/2012 01:21 AM, Jan Kiszka Wrote: >>> On 2012-02-09 04:22, Wen Congyang wrote: Add API to get all virtual address and physical address mapping. If there is no virtual address for some physical

Re: [Qemu-devel] [RFC][PATCH 08/16 v6] target-i386: add API to get dump info

2012-02-15 Thread Jan Kiszka
On 2012-02-15 04:30, Wen Congyang wrote: >>> diff --git a/dump.h b/dump.h >>> new file mode 100644 >>> index 000..a36468b >>> --- /dev/null >>> +++ b/dump.h >>> @@ -0,0 +1,10 @@ >> >> License header missing. > > There is no license in other header files. But those are preexisting files, no ne

Re: [Qemu-devel] [PATCH 1/2] slirp: remove duplicate definition

2012-02-15 Thread Jan Kiszka
On 2012-02-15 10:38, Michael S. Tsirkin wrote: > On Wed, Feb 15, 2012 at 09:30:23AM +0100, Jan Kiszka wrote: >> On 2012-02-15 09:12, zwu.ker...@gmail.com wrote: >>> From: Zhi Yong Wu >>> >>> Signed-off-by: Zhi Yong Wu >>> --- >>> slirp/if.c |2 -- >>> 1 files changed, 0 insertions(+), 2 dele

Re: [Qemu-devel] [RFC][PATCH 07/16 v6] target-i386: Add API to add extra memory mapping

2012-02-15 Thread Wen Congyang
At 02/15/2012 05:21 PM, Jan Kiszka Wrote: > On 2012-02-15 06:19, Wen Congyang wrote: >> At 02/15/2012 01:35 AM, Jan Kiszka Wrote: >>> On 2012-02-09 04:24, Wen Congyang wrote: Crash needs extra memory mapping to determine phys_base. Signed-off-by: Wen Congyang --- cpu-all.

Re: [Qemu-devel] [PULL 00/15] Block patches

2012-02-15 Thread Kevin Wolf
Am 10.02.2012 13:47, schrieb Kevin Wolf: > The following changes since commit 57c83dacfe179bf061b8fa79d9553ebabe4d2ff4: > > make: Remove duplicate use of GLIB_CFLAGS (2012-02-09 20:44:38 +0400) > > are available in the git repository at: > git://repo.or.cz/qemu/kevin.git for-anthony > > Alex

Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background

2012-02-15 Thread Jan Kiszka
On 2012-02-15 10:35, Wen Congyang wrote: > At 02/15/2012 05:21 PM, Jan Kiszka Wrote: >> On 2012-02-15 10:22, Wen Congyang wrote: >>> At 02/15/2012 05:07 PM, Jan Kiszka Wrote: On 2012-02-15 04:47, Wen Congyang wrote: > At 02/15/2012 02:27 AM, Jan Kiszka Wrote: >> On 2012-02-14 19:05, Ja

Re: [Qemu-devel] [RFC][PATCH 05/16 v6] Add API to get memory mapping

2012-02-15 Thread Jan Kiszka
On 2012-02-15 10:47, HATAYAMA Daisuke wrote: > From: Wen Congyang > Subject: Re: [RFC][PATCH 05/16 v6] Add API to get memory mapping > Date: Wed, 15 Feb 2012 17:41:15 +0800 > >> At 02/15/2012 05:17 PM, Jan Kiszka Wrote: >>> On 2012-02-15 05:07, Wen Congyang wrote: At 02/15/2012 01:21 AM, Jan

Re: [Qemu-devel] [RFC][PATCH 07/16 v6] target-i386: Add API to add extra memory mapping

2012-02-15 Thread Jan Kiszka
On 2012-02-15 10:44, Wen Congyang wrote: > At 02/15/2012 05:21 PM, Jan Kiszka Wrote: >> On 2012-02-15 06:19, Wen Congyang wrote: >>> At 02/15/2012 01:35 AM, Jan Kiszka Wrote: On 2012-02-09 04:24, Wen Congyang wrote: > Crash needs extra memory mapping to determine phys_base. > > Sig

[Qemu-devel] [PATCH v5 11/12] suspend: make acpi timer wakeup the guest.

2012-02-15 Thread Gerd Hoffmann
Make the acpi timer wake up the guest. Guests can enable/disable this via acpi too. Signed-off-by: Gerd Hoffmann --- hw/acpi.c |8 sysemu.h |1 + 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/hw/acpi.c b/hw/acpi.c index c05dde6..5d521e5 100644 --- a/hw/acpi.c +

[Qemu-devel] [PATCH v5 03/12] acpi: don't pass overflow_time to acpi_pm1_evt_get_sts

2012-02-15 Thread Gerd Hoffmann
Pretty pointless, can easily be reached via ACPIREGS now. Signed-off-by: Gerd Hoffmann --- hw/acpi.c |6 +++--- hw/acpi.h |2 +- hw/acpi_piix4.c |4 ++-- hw/vt82c686.c |4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/acpi.c b/hw/acpi.c inde

[Qemu-devel] [PATCH v5 01/12] acpi: move around structs

2012-02-15 Thread Gerd Hoffmann
Group all structs at the top of hw/acpi.h. Just moving around lines, no code changes. Signed-off-by: Gerd Hoffmann --- hw/acpi.h | 48 +++- 1 files changed, 23 insertions(+), 25 deletions(-) diff --git a/hw/acpi.h b/hw/acpi.h index c141e65..5c43b7d

[Qemu-devel] [PATCH v5 04/12] acpi: add acpi_pm1_evt_write_en

2012-02-15 Thread Gerd Hoffmann
Do APCIREGS->pm1.evt.en updates using the new acpi_pm1_evt_write_en function, so the acpi code will see those updates. Signed-off-by: Gerd Hoffmann --- hw/acpi.c |5 + hw/acpi.h |1 + hw/acpi_piix4.c |2 +- hw/vt82c686.c |2 +- 4 files changed, 8 insertions(+),

[Qemu-devel] [PATCH v5 05/12] suspend: add infrastructure

2012-02-15 Thread Gerd Hoffmann
This patch adds some infrastructure to handle suspend and resume to qemu. First there are two functions to switch state and second there is a suspend notifier: * qemu_system_suspend_request is supposed to be called when the guest asks for being be suspended, for example via ACPI. * qemu_sys

Re: [Qemu-devel] [PATCH v15 00/10] ARM: Samsung Exynos4210-based boards support.

2012-02-15 Thread Peter Maydell
On 10 February 2012 05:36, Evgeny Voevodin wrote: > This set of patches adds support for Samsung Exynos4210-based boards NURI and > SMDKC210. Whole series: Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [PATCH v5 10/12] suspend: make rtc alarm wakeup the guest.

2012-02-15 Thread Gerd Hoffmann
Make the rtc wake up the guest when the alarm fires. Add acpi windup to property support RTC_EN, so guests can enable and disable this. Signed-off-by: Gerd Hoffmann --- hw/acpi.c|7 +++ hw/mc146818rtc.c |1 + sysemu.h |1 + 3 files changed, 9 insertions(+), 0 dele

[Qemu-devel] [PATCH] ide: fail I/O to empty disk

2012-02-15 Thread Paolo Bonzini
Requesting a read or a write operation on an empty disk can lead to QEMU dumping core. Also fix a few braces here and there. Signed-off-by: Paolo Bonzini --- hw/ide/core.c | 24 1 files changed, 20 insertions(+), 4 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/cor

[Qemu-devel] [PATCH v5 08/12] suspend: make ps/2 devices wakeup the guest

2012-02-15 Thread Gerd Hoffmann
This patch adds wakeup support to ps/2 emulation. Any key press on the ps/2 keyboard will wakeup the guest. Likewise any mouse button press will wakeup the guest. Mouse moves are ignored, so the guest will not wakeup in case your mouse crosses the vnc window of a suspended guest by accident. Si

[Qemu-devel] [PATCH v5 12/12] suspend: add qmp events

2012-02-15 Thread Gerd Hoffmann
Send qmp events on suspend and wakeup so libvirt has a chance to track the vm state. Signed-off-by: Gerd Hoffmann --- monitor.c |6 ++ monitor.h |2 ++ vl.c | 15 +++ 3 files changed, 23 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index aadbdc

[Qemu-devel] [PATCH v5 00/12] initial suspend support

2012-02-15 Thread Gerd Hoffmann
Hi, Next and hopefully final suspend support patch series. It makes s3 support alot more useful by leaving guests actually suspended and allowing them to be woken up by certain events, with ps/2 keyboard input (wakeup-by-tap-enter) and real time clock (see 'man rtcwake') being the most useful o

[Qemu-devel] [PATCH v5 07/12] suspend: add system_wakeup monitor command

2012-02-15 Thread Gerd Hoffmann
This patch adds the system_wakeup monitor command which will simply wake up suspended guests. Signed-off-by: Gerd Hoffmann --- hmp-commands.hx | 14 ++ hmp.c|5 + hmp.h|1 + qapi-schema.json | 11 +++ qmp-commands.hx | 21 ++

[Qemu-devel] [PATCH v5 09/12] suspend: make serial ports wakeup the guest.

2012-02-15 Thread Gerd Hoffmann
Add a 'wakeup' property to the serial port. It is off by default. When enabled any incoming character on the serial line will wake up the guest. Useful for guests which have a serial console configured. Signed-off-by: Gerd Hoffmann --- hw/serial.c |6 ++ 1 files changed, 6 insertions(

[Qemu-devel] [PATCH v5 02/12] acpi: add ACPIREGS

2012-02-15 Thread Gerd Hoffmann
All those acpi structs are not independent from each other. Various acpi functions expecting multiple acpi structs passed in are a clean indicator for that ;) So this patch bundles all acpi structs in the new ACPIREGS struct, then use it everythere pass around acpi state. Signed-off-by: Gerd Hoff

[Qemu-devel] [PATCH v5 06/12] suspend: switch acpi s3 to new infrastructure.

2012-02-15 Thread Gerd Hoffmann
This patch switches pc s3 suspend over to the new infrastructure. The cmos_s3 qemu_irq is killed, the new notifier is used instead. The xen hack goes away with that too, the hypercall can simply be done in a notifier function now. This patch also makes the guest actually stay suspended instead of

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-15 Thread Avi Kivity
On 02/07/2012 04:39 PM, Alexander Graf wrote: > > > > Syscalls are orthogonal to that - they're to avoid the fget_light() and to > > tighten the vcpu/thread and vm/process relationship. > > How about keeping the ioctl interface but moving vcpu_run to a syscall then? I dislike half-and-half inter

Re: [Qemu-devel] [PATCH] hw/pl031: Actually raise interrupt on timer expiry

2012-02-15 Thread Andreas Färber
Am 14.02.2012 18:40, schrieb Peter Maydell: > Fix a typo in pl031_interrupt() which meant we were setting a bit > in the interrupt mask rather than the interrupt status register > and thus not actually raising an interrupt. This fix allows the > rtctest program from the kernel's Documentation/rtc.t

Re: [Qemu-devel] Block IO throttling: contractor wanted

2012-02-15 Thread Stefan Hajnoczi
On Tue, Feb 14, 2012 at 2:30 PM, Chris Webb wrote: > However, there are (known) run-time > assertion failures with throttled IDE devices[1], which show up in qemu-kvm > 1.0 and apparently also in qemu HEAD. We have also sometimes seen throttled > VMs spinning unresponsively with 100% CPU on start-

Re: [Qemu-devel] [PATCH] hw/pl031: Actually raise interrupt on timer expiry

2012-02-15 Thread Peter Maydell
On 15 February 2012 11:23, Andreas Färber wrote: > Am 14.02.2012 18:40, schrieb Peter Maydell: >> Fix a typo in pl031_interrupt() which meant we were setting a bit >> in the interrupt mask rather than the interrupt status register >> and thus not actually raising an interrupt. This fix allows the

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-15 Thread Alexander Graf
On 15.02.2012, at 12:18, Avi Kivity wrote: > On 02/07/2012 04:39 PM, Alexander Graf wrote: >>> >>> Syscalls are orthogonal to that - they're to avoid the fget_light() and to >>> tighten the vcpu/thread and vm/process relationship. >> >> How about keeping the ioctl interface but moving vcpu_run

[Qemu-devel] Slow booting with large Initrd

2012-02-15 Thread Dyweni - Qemu-Devel
Hi List, This morning I ran across a thread on this list from Oct'11 about slow booting with large initrd images. Reading through that thread, I didn't really see any sort of definitive resolution to the problem. Also, this morning, I upgraded Qemu-KVM to latest git master (9d636ae7488edfa9c7f03

Re: [Qemu-devel] [PATCH 0/6] qapi: Convert migrate

2012-02-15 Thread Luiz Capitulino
On Wed, 15 Feb 2012 09:59:07 +0100 Jan Kiszka wrote: > On 2012-02-10 20:31, Luiz Capitulino wrote: > > This is a rebase of Anthony's conversion, from his glib branch; and this is > > also the beginning of the conversion of complex commands to the qapi. > > > > There are two important changes tha

Re: [Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything to do with monitors

2012-02-15 Thread Luiz Capitulino
On Wed, 15 Feb 2012 10:02:54 +0100 Jan Kiszka wrote: > On 2012-02-10 20:31, Luiz Capitulino wrote: > > The Monitor object is passed back and forth within the migration/savevm > > code so that it can print errors and progress to the user. > > > > However, that approach assumes a HMP monitor, bein

Re: [Qemu-devel] [TRIVIAL v2] Bad zero comparison for sas_ss_flags on powerpc

2012-02-15 Thread Alex Barcelo
On Wed, Feb 15, 2012 at 09:35, Alexander Graf wrote: > On 15.02.2012, at 07:55, Alex Barcelo wrote: >> ping? is this ok? Or it is not trivial at all, and better do a normal patch? >> And write it better? > > The patch is fine, but it's not trivial. It's a ppc patch, hence it should've > gotten C

Re: [Qemu-devel] [RFC][PATCH 01/16 v6] monitor: introduce qemu_suspend_monitor()/qemu_resume_monitor()

2012-02-15 Thread Luiz Capitulino
On Wed, 15 Feb 2012 09:51:04 +0100 Jan Kiszka wrote: > On 2012-02-15 03:54, Wen Congyang wrote: > > At 02/15/2012 12:19 AM, Jan Kiszka Wrote: > >> On 2012-02-09 04:19, Wen Congyang wrote: > >>> Sync command needs these two APIs to suspend/resume monitor. > >>> > >>> Signed-off-by: Wen Congyang >

Re: [Qemu-devel] Slow booting with large Initrd

2012-02-15 Thread Michael Tokarev
On 15.02.2012 16:35, Dyweni - Qemu-Devel wrote: Hi List, This morning I ran across a thread on this list from Oct'11 about slow booting with large initrd images. Reading through that thread, I didn't really see any sort of definitive resolution to the problem. There's been several mentions of

Re: [Qemu-devel] [PATCH 4/6] Error: Introduce error_copy()

2012-02-15 Thread Luiz Capitulino
On Wed, 15 Feb 2012 10:04:50 +0100 Paolo Bonzini wrote: > On 02/10/2012 08:31 PM, Luiz Capitulino wrote: > > +err_new = g_malloc0(sizeof(*err)); > > +err_new->obj = qdict_copy(err->obj); > > +err_new->msg = g_strdup(err->msg); > > +err_new->fmt = err->fmt; > > + > > +return er

Re: [Qemu-devel] [PATCH 6/6] qapi: Convert migrate

2012-02-15 Thread Luiz Capitulino
On Wed, 15 Feb 2012 17:07:16 +0800 Wen Congyang wrote: > At 02/11/2012 03:31 AM, Luiz Capitulino Wrote: > > The migrate command is one of those commands where HMP and QMP completely > > mix up together. This made the conversion to the QAPI (which separates the > > command into QMP and HMP parts)

Re: [Qemu-devel] [PATCH 3/6] QDict: Introduce qdict_copy()

2012-02-15 Thread Juan Quintela
Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > /** > + * qdict_copy(): Build a new dictionary from an existing one. > + */ > +QDict *qdict_copy(const QDict *from) > +{ > +const QDictEntry *ent; > +QDict *new; > + > +new = qdict_new(); > + > +for (ent = qdict_first(fr

Re: [Qemu-devel] [PATCH 1/6] QError: Introduce new errors for the migration command

2012-02-15 Thread Juan Quintela
Luiz Capitulino wrote: > The new errors are QERR_MIGRATION_ACTIVE and QERR_MIGRATION_NOT_SUPPORTED, > which are going to be used by the QAPI converted migration command. > > Signed-off-by: Luiz Capitulino Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH 2/6] monitor: Introduce qemu_get_fd()

2012-02-15 Thread Juan Quintela
Luiz Capitulino wrote: > Get the file-descriptor from 'cur_mon', will be used by the QAPI > converted migration command. > > Signed-off-by: Anthony Liguori > Signed-off-by: Luiz Capitulino Reviewed-by: Juan Quintela

[Qemu-devel] [PATCH] qxl: don't render stuff when the vm is stopped.

2012-02-15 Thread Gerd Hoffmann
This patch fixes the local qxl renderer to not kick spice-server in case the vm is stopped. First it is pointless because we render evevything when the vm is stopped. Thus there is nothing to render anyway because a stopped guest can hardly queue more commands. Second we avoid triggering an asse

Re: [Qemu-devel] [PATCH v2 1/2] qxl: set only off-screen surfaces dirty instead of the whole vram

2012-02-15 Thread Gerd Hoffmann
On 02/15/12 10:22, Yonit Halperin wrote: > We used to assure the guest surfaces were saved before migration by > setting the whole vram dirty. This patch sets dirty only the areas > that are actually used in the vram. Great. Added both patches to the spice patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything to do with monitors

2012-02-15 Thread Juan Quintela
Luiz Capitulino wrote: > The Monitor object is passed back and forth within the migration/savevm > code so that it can print errors and progress to the user. > > However, that approach assumes a HMP monitor, being completely invalid > in QMP. > > This commit drops almost every single usage of the

Re: [Qemu-devel] [PATCH 4/6] Error: Introduce error_copy()

2012-02-15 Thread Paolo Bonzini
On 02/15/2012 02:05 PM, Luiz Capitulino wrote: >> > QDicts should be constant once they've >> > been built. > I think you meant QErrors? I meant QDicts included in Errors. > > (Also, I would refcount Errors rather than copy them, but > > that's a personal preference and I do not really object t

Re: [Qemu-devel] [PATCH] qxl: don't render stuff when the vm is stopped.

2012-02-15 Thread Yonit Halperin
Hi, On 02/15/2012 03:11 PM, Gerd Hoffmann wrote: This patch fixes the local qxl renderer to not kick spice-server in case the vm is stopped. First it is pointless because we render evevything when the vm is stopped. Thus there is nothing to render anyway because a stopped guest can hardly queue

Re: [Qemu-devel] [PATCH v3] Add SPICE support to add_client monitor command

2012-02-15 Thread Gerd Hoffmann
On 02/13/12 14:43, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > With the acceptance of some new APIs to libspice-server.so it > is possible to add support for SPICE to the 'add_client' > monitor command, bringing parity with VNC. Since SPICE can > use TLS or plain connections, the c

Re: [Qemu-devel] [PATCH 6/6] qapi: Convert migrate

2012-02-15 Thread Juan Quintela
Luiz Capitulino wrote: > The migrate command is one of those commands where HMP and QMP completely > mix up together. This made the conversion to the QAPI (which separates the > command into QMP and HMP parts) a bit difficult. > > The first important change to be noticed is that this commit comple

Re: [Qemu-devel] [PATCH 4/6] Error: Introduce error_copy()

2012-02-15 Thread Juan Quintela
Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino Didn't care if we copy/incref the dictionaries as Paolo suggests. Both work for me. Later, Juan.

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-15 Thread Avi Kivity
On 02/15/2012 01:57 PM, Alexander Graf wrote: > > > > Is an extra syscall for copying TLB entries to user space prohibitively > > expensive? > > The copying can be very expensive, yes. We want to have the possibility of > exposing a very large TLB to the guest, in the order of multiple kentries.

Re: [Qemu-devel] [PATCH 6/6] qapi: Convert migrate

2012-02-15 Thread Jan Kiszka
On 2012-02-10 20:31, Luiz Capitulino wrote: > The migrate command is one of those commands where HMP and QMP completely > mix up together. This made the conversion to the QAPI (which separates the > command into QMP and HMP parts) a bit difficult. > > The first important change to be noticed is th

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-15 Thread Avi Kivity
On 02/12/2012 09:10 AM, Takuya Yoshikawa wrote: > Avi Kivity wrote: > > > > > Slot searching is quite fast since there's a small number of slots, > > > > and we sort the larger ones to be in the front, so positive lookups are > > > > fast. We cache negative lookups in the shadow page tables (a

Re: [Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything to do with monitors

2012-02-15 Thread Jan Kiszka
On 2012-02-15 13:53, Luiz Capitulino wrote: > On Wed, 15 Feb 2012 10:02:54 +0100 > Jan Kiszka wrote: > >> On 2012-02-10 20:31, Luiz Capitulino wrote: >>> The Monitor object is passed back and forth within the migration/savevm >>> code so that it can print errors and progress to the user. >>> >>>

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-15 Thread Avi Kivity
On 02/07/2012 05:23 PM, Anthony Liguori wrote: > On 02/07/2012 07:40 AM, Alexander Graf wrote: >> >> Why? For the HPET timer register for example, we could have a simple >> MMIO hook that says >> >>on_read: >> return read_current_time() - shared_page.offset; >>on_write: >> handle_

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-02-15 Thread Markus Armbruster
Anthony Liguori writes: > On 02/14/2012 11:24 AM, Markus Armbruster wrote: >> Markus Armbruster writes: >> >>> Anthony Liguori writes: >> [Anthony asking for error_set() instead of error_report()...] Basically, same thing here and the remaining functions. Let's not introduce addition

Re: [Qemu-devel] [PATCH 0/6] qapi: Convert migrate

2012-02-15 Thread Jan Kiszka
On 2012-02-15 13:49, Luiz Capitulino wrote: > On Wed, 15 Feb 2012 09:59:07 +0100 > Jan Kiszka wrote: > >> On 2012-02-10 20:31, Luiz Capitulino wrote: >>> This is a rebase of Anthony's conversion, from his glib branch; and this is >>> also the beginning of the conversion of complex commands to the

Re: [Qemu-devel] [PATCH v2 7/9] hw/vexpress.c: Instantiate the motherboard CLCD

2012-02-15 Thread Peter Maydell
On 10 February 2012 02:51, Paul Brook wrote: >> I do hope we find a solution to deal with n displays in the future. I >> consider that a post-QOM topic and maybe Anthony's planned DisplayState >> refactoring helps with that. > > It used to work.  Not particularly pretty or user friendly, but defin

Re: [Qemu-devel] [PATCH] qxl: don't render stuff when the vm is stopped.

2012-02-15 Thread Gerd Hoffmann
On 02/15/12 14:22, Yonit Halperin wrote: > Hi, > On 02/15/2012 03:11 PM, Gerd Hoffmann wrote: >> This patch fixes the local qxl renderer to not kick spice-server in case >> the vm is stopped. First it is pointless because we render evevything >> when the vm is stopped. Thus there is nothing to re

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-15 Thread Alexander Graf
On 15.02.2012, at 14:29, Avi Kivity wrote: > On 02/15/2012 01:57 PM, Alexander Graf wrote: >>> >>> Is an extra syscall for copying TLB entries to user space prohibitively >>> expensive? >> >> The copying can be very expensive, yes. We want to have the possibility of >> exposing a very large TL

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-15 Thread Avi Kivity
On 02/07/2012 08:12 PM, Rusty Russell wrote: > > I would really love to have this, but the problem is that we'd need a > > general purpose bytecode VM with binding to some kernel APIs. The > > bytecode VM, if made general enough to host more complicated devices, > > would likely be much larger tha

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-15 Thread Avi Kivity
On 02/07/2012 06:29 PM, Jan Kiszka wrote: > >>> > >> > >> Isn't there another level in between just scheduling and full syscall > >> return if the user return notifier has some real work to do? > > > > Depends on whether you're scheduling a kthread or a userspace process, no? > > If > > Kthread

Re: [Qemu-devel] [PATCH 6/6] qapi: Convert migrate

2012-02-15 Thread Jan Kiszka
On 2012-02-15 14:31, Jan Kiszka wrote: > On 2012-02-10 20:31, Luiz Capitulino wrote: >> The migrate command is one of those commands where HMP and QMP completely >> mix up together. This made the conversion to the QAPI (which separates the >> command into QMP and HMP parts) a bit difficult. >> >> T

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-15 Thread Avi Kivity
On 02/07/2012 06:19 PM, Anthony Liguori wrote: >> Ah. But then ioeventfd has that as well, unless the other end is in >> the kernel too. > > > Yes, that was my point exactly :-) > > ioeventfd/mmio-over-socketpair to adifferent thread is not faster than > a synchronous KVM_RUN + writing to an eventf

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-15 Thread Avi Kivity
On 02/15/2012 03:37 PM, Alexander Graf wrote: > On 15.02.2012, at 14:29, Avi Kivity wrote: > > > On 02/15/2012 01:57 PM, Alexander Graf wrote: > >>> > >>> Is an extra syscall for copying TLB entries to user space prohibitively > >>> expensive? > >> > >> The copying can be very expensive, yes. We

Re: [Qemu-devel] [PATCH] qxl: don't render stuff when the vm is stopped.

2012-02-15 Thread Yonit Halperin
On 02/15/2012 03:36 PM, Gerd Hoffmann wrote: On 02/15/12 14:22, Yonit Halperin wrote: Hi, On 02/15/2012 03:11 PM, Gerd Hoffmann wrote: This patch fixes the local qxl renderer to not kick spice-server in case the vm is stopped. First it is pointless because we render evevything when the vm is s

Re: [Qemu-devel] [PATCH] qxl: don't render stuff when the vm is stopped.

2012-02-15 Thread Alon Levy
On Wed, Feb 15, 2012 at 02:11:06PM +0100, Gerd Hoffmann wrote: > This patch fixes the local qxl renderer to not kick spice-server in case > the vm is stopped. First it is pointless because we render evevything *everything > when the vm is stopped. Thus there is nothing to render anyway because >

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-15 Thread Alexander Graf
On 15.02.2012, at 14:57, Avi Kivity wrote: > On 02/15/2012 03:37 PM, Alexander Graf wrote: >> On 15.02.2012, at 14:29, Avi Kivity wrote: >> >>> On 02/15/2012 01:57 PM, Alexander Graf wrote: > > Is an extra syscall for copying TLB entries to user space prohibitively > expensive?

[Qemu-devel] [PATCH v5 6/7] arm_boot: Pass base address of GIC CPU interface, not whole GIC

2012-02-15 Thread Peter Maydell
The arm_boot secondary boot loader code needs the address of the GIC CPU interface. Obtaining this from the base address of the private peripheral region was possible for A9 and 11MPcore, but the A15 puts the GIC CPU interface in a different place. So make boards pass in the GIC CPU interface addre

[Qemu-devel] [PATCH v5 4/7] hw/vexpress.c: Factor out daughterboard-specific initialization

2012-02-15 Thread Peter Maydell
Factor out daughterboard specifics into a data structure and daughterboard initialization function, in preparation for adding vexpress-a15 support. Signed-off-by: Peter Maydell --- hw/vexpress.c | 118 - 1 files changed, 83 insertions(+),

[Qemu-devel] [PATCH v5 1/7] hw/a15mpcore.c: Add Cortex-A15 private peripheral model

2012-02-15 Thread Peter Maydell
Add a model of the Cortex-A15 memory mapped private peripheral space. This is fairly simple because the only memory mapped bit of the A15 is the GIC. Note that we don't currently model a VGIC and therefore don't map the VGIC related bits of the GIC. Signed-off-by: Peter Maydell --- Makefile.tar

[Qemu-devel] [PATCH v5 7/7] hw/vexpress.c: Add vexpress-a15 machine

2012-02-15 Thread Peter Maydell
Add the vexpress-a15 machine, and the A-Series memory map it uses. Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber --- hw/vexpress.c | 141 + 1 files changed, 141 insertions(+), 0 deletions(-) diff --git a/hw/vexpress.c b/hw/vex

[Qemu-devel] [PATCH v5 0/7] Add support for vexpress-a15

2012-02-15 Thread Peter Maydell
This patchset adds support for the Versatile Express A15 daughterboard. The resulting model is capable of booting a Linux kernel which has been configured for Cortex-A15 with the Versatile Express "extended memory map" and without support for LPAE. Since there were no major changes between v4 and

  1   2   3   >