On 02/10/2012 08:31 PM, Luiz Capitulino wrote: > + err_new = g_malloc0(sizeof(*err)); > + err_new->obj = qdict_copy(err->obj); > + err_new->msg = g_strdup(err->msg); > + err_new->fmt = err->fmt; > + > + return err_new; > +}
Why isn't an incref sufficient? QDicts should be constant once they've been built. (Also, I would refcount Errors rather than copy them, but that's a personal preference and I do not really object to error_copy). Paolo
