Re: [Qemu-devel] [PATCH v2 11/33] scsi-disk: support DVD profile in GET CONFIGURATION

2012-01-26 Thread Paolo Bonzini
On 01/25/2012 09:13 PM, Artyom Tarasenko wrote: On 1/25/12, Paolo Bonzini wrote: On 01/25/2012 05:34 PM, Artyom Tarasenko wrote: This patch produces the following error when booting Solaris/SPARC: WARNING: /iommu@0,1000/sbus@0,10001000/espdma@5,840/esp@5,880 (esp0): data

Re: [Qemu-devel] [PATCH v2 11/33] scsi-disk: support DVD profile in GET CONFIGURATION

2012-01-26 Thread ronnie sahlberg
Hi Paolo, List, I see you are very active in the MMC emulation for qemu. I have written several MMC emulators, the third of which (in STGT) is open source. I did the MMC emulation in STGT, (see README.mmc for how to use it as "blank burnable media") Do you have DVD+/-R + morhping implemented y

Re: [Qemu-devel] [PATCH] hw/vmmouse.c: Disable vmmouse after reboot

2012-01-26 Thread Andreas Färber
Am 25.01.2012 21:04, schrieb Gerhard Wiesinger: > Bugfix after reboot when vmmouse was enabled and another OS which uses > e.g. PS/2 > mouse. > > Details: > When a guest activated the vmmouse followed by a reboot the vmmouse was > still > enabled and the PS/2 mouse was therefore unsusable. When an

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-26 Thread Markus Armbruster
Gerhard Wiesinger writes: > Option ROM for network interface cards (NICs) can now explicitly disabled > with romfile=disabled (or romfile=no or romfile=none) parameter. > With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work. > This patch disables Option ROMs for iPXE for al

Re: [Qemu-devel] [PATCH v2 11/33] scsi-disk: support DVD profile in GET CONFIGURATION

2012-01-26 Thread Paolo Bonzini
On 01/26/2012 09:23 AM, ronnie sahlberg wrote: I see you are very active in the MMC emulation for qemu. Not really, beyond fixing bugs. I have written several MMC emulators, the third of which (in STGT) is open source. I did the MMC emulation in STGT, (see README.mmc for how to use it as "b

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-26 Thread Kevin Wolf
Am 25.01.2012 16:57, schrieb Eric Blake: > On 01/24/2012 11:47 PM, ronnie sahlberg wrote: >> Read from an arbitrary filedescriptor inherited from the parent process : >> 9> vnc=127.0.0.1:0 -drive file=iscsi://127.0.0.1/iqn.ronnie.test/1 >> -readconfig /proc/self/fd/9 > > That requires the existenc

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-26 Thread Michael S. Tsirkin
On Wed, Jan 25, 2012 at 06:46:03PM +1300, Alexey Korolev wrote: > Hi, > In this post > http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg03171.html I've > mentioned about the issues when 64Bit PCI BAR is present and 32bit > address range is selected for it. > The issue affects all recent qem

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-26 Thread ronnie sahlberg
Kevin, Collissions are bad, but what about IF ! STRNCMP (filename, "/proc/self/fd/", 14) THEN fopen(filename, "r") ELSE fdopen(atoi(filename+14), "r") FI modulo better validation for the atio() arguments. Probability of anyone using "/proc/self/fd/" as a prefix for normal fil

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-26 Thread Kevin Wolf
Am 26.01.2012 10:18, schrieb ronnie sahlberg: > Kevin, > > Collissions are bad, but what about > > IF ! STRNCMP (filename, "/proc/self/fd/", 14) THEN > fopen(filename, "r") > ELSE > fdopen(atoi(filename+14), "r") > FI > > modulo better validation for the atio() arguments. > >

[Qemu-devel] [PATCH] memory: fix return value on unassigned reads

2012-01-26 Thread Avi Kivity
The memory API returns -1 on unassigned reads, different from the original in exec.c, which returned zero. This breaks grlib_uart; apparently some users depend on it. Fix by returning zero; however if reading from the uart is legal, then it should be modified to accept reads. Signed-off-by: Avi

Re: [Qemu-devel] [libvirt] libvirt doesn't work with qemu 1.0

2012-01-26 Thread Paolo Bonzini
On 01/26/2012 04:55 AM, Eric Blake wrote: $ /usr/libexec/qemu-kvm -qmp stdio -S -display none qemu-kvm: -display: invalid option $ /usr/libexec/qemu-kvm -qmp stdio -S -nographic chardev: opening backend "stdio" failed qemu: could not open serial device 'stdio': Argument list too long Have you

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-26 Thread Michael Tokarev
On 26.01.2012 13:08, Kevin Wolf wrote: [] >> -readconfig fd:9 > Magic prefixes like this have one big problem: What if someone has a > config file called "fd:9"? We have the very same problem with protocols -readconfig ./fd:9 does the trick. > in the block layer and while in the general case it

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-26 Thread ronnie sahlberg
Ok so what about this You use a filename starting with "/proc/self/fd/" and you dont have a proc filesystem mounted? you are on your own! regards ronnie sahlberg On Thu, Jan 26, 2012 at 8:27 PM, Kevin Wolf wrote: > Am 26.01.2012 10:18, schrieb ronnie sahlberg: >> Kevin, >> >> Collissions

Re: [Qemu-devel] commit 67feec6ed854b3618b37ccf050b90192cbb96e0f breaks compilation of hw/pci.c

2012-01-26 Thread Andreas Färber
Am 26.01.2012 07:38, schrieb Gleb Natapov: > On Wed, Jan 25, 2012 at 10:07:14PM +0100, Erik Rull wrote: >> Is it possible that you provide this patch? Or was it already >> applied somewhere? >> > No patch needed. Just do "rm x86_64-softmmu/qmp-commands.h". Or for earlier versions "rm qmp-commands.

Re: [Qemu-devel] commit 67feec6ed854b3618b37ccf050b90192cbb96e0f breaks compilation of hw/pci.c

2012-01-26 Thread Jan Kiszka
On 2012-01-26 11:00, Andreas Färber wrote: > Am 26.01.2012 07:38, schrieb Gleb Natapov: >> On Wed, Jan 25, 2012 at 10:07:14PM +0100, Erik Rull wrote: >>> Is it possible that you provide this patch? Or was it already >>> applied somewhere? >>> >> No patch needed. Just do "rm x86_64-softmmu/qmp-comma

Re: [Qemu-devel] [PATCH] scsi: Guard against buflen exceeding req->cmd.xfer in scsi_disk_emulate_command

2012-01-26 Thread Kevin Wolf
Am 26.01.2012 08:50, schrieb Paolo Bonzini: > On 01/24/2012 06:19 PM, Thomas Higdon wrote: >> I agree that it's better to get this into a more general place. However, >> I wasn't willing to pull the MIN statement up into scsi_send_command >> because I don't understand the interplay between 'len' in

Re: [Qemu-devel] commit 67feec6ed854b3618b37ccf050b90192cbb96e0f breaks compilation of hw/pci.c

2012-01-26 Thread Andreas Färber
Am 26.01.2012 11:32, schrieb Jan Kiszka: > On 2012-01-26 11:00, Andreas Färber wrote: >> Am 26.01.2012 07:38, schrieb Gleb Natapov: >>> On Wed, Jan 25, 2012 at 10:07:14PM +0100, Erik Rull wrote: Is it possible that you provide this patch? Or was it already applied somewhere? >>> No p

Re: [Qemu-devel] [PATCH] READCONFIG: Allow reading the configuration from a pre-existing filedescriptor

2012-01-26 Thread Daniel P. Berrange
On Thu, Jan 26, 2012 at 08:40:02AM +0100, Markus Armbruster wrote: > Eric Blake writes: > > On 01/25/2012 03:23 PM, Ronnie Sahlberg wrote: > >> diff --git a/qemu-config.c b/qemu-config.c > >> index b030205..c12c5eb 100644 > >> --- a/qemu-config.c > >> +++ b/qemu-config.c > >> @@ -770,8 +770,19 @@

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-26 Thread Gerd Hoffmann
On 01/26/12 08:45, Markus Armbruster wrote: > Gerhard Wiesinger writes: > >> Option ROM for network interface cards (NICs) can now explicitly disabled >> with romfile=disabled (or romfile=no or romfile=none) parameter. >> With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work

Re: [Qemu-devel] [PATCH v2 3/4] uq/master: Add CPU eject handling for acpi_piix4

2012-01-26 Thread Avi Kivity
On 01/24/2012 04:56 PM, Vasilis Liaskovitis wrote: > On Tue, Jan 24, 2012 at 11:28:41AM +0100, Jan Kiszka wrote: > > On 2012-01-24 11:10, Vasilis Liaskovitis wrote: > > > Add stub functions for CPU eject callback. Define cpu_acpi_eject property > > > and > > > enable eject callback only for pc-1.1

Re: [Qemu-devel] [PATCH] scsi: Guard against buflen exceeding req->cmd.xfer in scsi_disk_emulate_command

2012-01-26 Thread Paolo Bonzini
On 01/26/2012 11:41 AM, Kevin Wolf wrote: > Kevin, shall I take this patch in the virtio-scsi series? I'll have to > resubmit anyway due to the QOM changes. I have picked it up for the block branch. If it conflicts with your changes, you can just rebase on top of that. No, it doesn't. Than

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-26 Thread Kevin Wolf
Am 25.01.2012 23:39, schrieb Ronnie Sahlberg: > This patch adds configuration variables for iSCSI to set > initiator-name to use when logging in to the target, > which type of header-digest to negotiate with the target > and username and password for CHAP authentication. > > This allows specifying

Re: [Qemu-devel] [libvirt] libvirt doesn't work with qemu 1.0

2012-01-26 Thread Markus Armbruster
Paolo Bonzini writes: > On 01/26/2012 04:55 AM, Eric Blake wrote: >> >> $ /usr/libexec/qemu-kvm -qmp stdio -S -display none >> qemu-kvm: -display: invalid option >> $ /usr/libexec/qemu-kvm -qmp stdio -S -nographic >> chardev: opening backend "stdio" failed >> qemu: could not open serial device 's

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-26 Thread Markus Armbruster
Gerd Hoffmann writes: > On 01/26/12 08:45, Markus Armbruster wrote: >> Gerhard Wiesinger writes: >> >>> Option ROM for network interface cards (NICs) can now explicitly disabled >>> with romfile=disabled (or romfile=no or romfile=none) parameter. >>> With hotplugable NICs (currently NE2000, PCN

[Qemu-devel] [PATCH v10 2/9] ARM: Samsung exynos4210-based boards emulation

2012-01-26 Thread Mitsyanko Igor
From: Evgeny Voevodin Add initial support of NURI and SMDKC210 boards Signed-off-by: Evgeny Voevodin --- Makefile.target |3 +- hw/exynos4210.c | 193 +++ hw/exynos4210.h | 40 +++ hw/exynos4_boards.c | 143 +++

[Qemu-devel] [PATCH v10 3/9] ARM: exynos4210: UART support

2012-01-26 Thread Mitsyanko Igor
From: Maksim Kozlov Add basic support of exynos4210 UART Signed-off-by: Maksim Kozlov --- Makefile.target |2 +- hw/exynos4210.c | 29 +++ hw/exynos4210.h |9 + hw/exynos4210_uart.c | 661 ++ 4 files changed, 700 inserti

[Qemu-devel] [PATCH v10 5/9] ARM: exynos4210: basic Power Management Unit implementation

2012-01-26 Thread Mitsyanko Igor
From: Maksim Kozlov Patch adds basic model for Exynos4210 SoC PMU. This model implements PMU registers just as a bulk of memory. Currently, the only reason this device exists is that secondary CPU boot loader uses PMU INFORM5 register as a holding pen. Signed-off-by: Maksim Kozlov --- Makefile

[Qemu-devel] [PATCH v10 8/9] hw/exynos4210.c: Add LAN support for SMDKC210.

2012-01-26 Thread Mitsyanko Igor
From: Evgeny Voevodin SMDKC210 uses lan9215 chip, but lan9118 in 16-bit mode seems to be enough. Signed-off-by: Evgeny Voevodin Reviewed-by: Peter Maydell --- hw/exynos4_boards.c | 27 +-- 1 files changed, 25 insertions(+), 2 deletions(-) diff --git a/hw/exynos4_boa

[Qemu-devel] [PATCH v10 6/9] ARM: exynos4210: MCT support.

2012-01-26 Thread Mitsyanko Igor
From: Evgeny Voevodin Signed-off-by: Evgeny Voevodin Reviewed-by: Peter Maydell --- Makefile.target |2 +- hw/exynos4210.c | 19 + hw/exynos4210_mct.c | 1479 +++ 3 files changed, 1499 insertions(+), 1 deletions(-) create mode 1006

[Qemu-devel] [PATCH v10 1/9] ARM: exynos4210: IRQ subsystem support.

2012-01-26 Thread Mitsyanko Igor
From: Evgeny Voevodin Signed-off-by: Evgeny Voevodin --- Makefile.target |1 + hw/exynos4210.h | 82 hw/exynos4210_combiner.c | 472 ++ hw/exynos4210_gic.c | 436 ++ 4 fil

Re: [Qemu-devel] [PATCH v10 5/9] ARM: exynos4210: basic Power Management Unit implementation

2012-01-26 Thread Mitsyanko Igor
On 01/26/2012 03:42 PM, Mitsyanko Igor wrote: Re: [PATCH v10 5/9] ARM: exynos4210: basic Power Management Unit implementation Please ignore this patch, it's wrong, I'm sending correct version of this patch right away as a reply to original patch. Sorry about that. -- Mitsyanko Igor ASWG, M

[Qemu-devel] [PATCH v10 5/9] ARM: exynos4210: basic Power Management Unit implementation

2012-01-26 Thread Mitsyanko Igor
From: Maksim Kozlov Patch adds basic model for Exynos4210 SoC PMU. This model implements PMU registers just as a bulk of memory. Currently, the only reason this device exists is that secondary CPU boot loader uses PMU INFORM5 register as a holding pen. Signed-off-by: Maksim Kozlov --- Makefile

[Qemu-devel] [PATCH v10 0/9] ARM: Samsung Exynos4210-based boards support

2012-01-26 Thread Mitsyanko Igor
This set of patches adds support for Samsung Exynos4210-based boards NURI and SMDKC210. Tested on Linux kernel v3.x series. Usage: "-smp 2" option is mandatory for now. Linux kernel v3.x configured with exynos4_defconfig can be used for boards models testing with rootfs on initrd. To enable sup

Re: [Qemu-devel] [PATCH] memory: fix return value on unassigned reads

2012-01-26 Thread Avi Kivity
On 01/26/2012 01:31 PM, Fabien Chouteau wrote: > On 26/01/2012 10:33, Avi Kivity wrote: > > The memory API returns -1 on unassigned reads, different from the original > > in exec.c, which returned zero. > > Isn't this return value platform specific? Maybe (and I think ~0 is the common one); the pa

[Qemu-devel] [PATCH v10 7/9] hw/lan9118: Add basic 16-bit mode support.

2012-01-26 Thread Mitsyanko Igor
From: Evgeny Voevodin Signed-off-by: Evgeny Voevodin --- hw/lan9118.c | 124 +++--- 1 files changed, 118 insertions(+), 6 deletions(-) diff --git a/hw/lan9118.c b/hw/lan9118.c index 9b199d0..bb790a3 100644 --- a/hw/lan9118.c +++ b/hw/lan9118

[Qemu-devel] [PATCH v10 4/9] ARM: exynos4210: PWM support.

2012-01-26 Thread Mitsyanko Igor
From: Evgeny Voevodin Signed-off-by: Evgeny Voevodin Reviewed-by: Peter Maydell --- Makefile.target |2 +- hw/exynos4210.c | 12 ++ hw/exynos4210_pwm.c | 413 +++ 3 files changed, 426 insertions(+), 1 deletions(-) create mode 1006

Re: [Qemu-devel] [PATCH] kvm: flush the dirty log when unregistering a slot

2012-01-26 Thread Avi Kivity
On 01/25/2012 10:15 PM, Gerhard Wiesinger wrote: > On Sun, 15 Jan 2012, Avi Kivity wrote: > >> On 01/15/2012 04:40 PM, Gerhard Wiesinger wrote: >>> On Sun, 15 Jan 2012, Jan Kiszka wrote: >>> On 2012-01-15 15:17, Avi Kivity wrote: > Otherwise, the dirty log information is lost in the kernel

Re: [Qemu-devel] [libvirt] libvirt doesn't work with qemu 1.0

2012-01-26 Thread Eric Blake
On 01/26/2012 02:41 AM, Paolo Bonzini wrote: > On 01/26/2012 04:55 AM, Eric Blake wrote: >> >> $ /usr/libexec/qemu-kvm -qmp stdio -S -display none >> qemu-kvm: -display: invalid option >> $ /usr/libexec/qemu-kvm -qmp stdio -S -nographic >> chardev: opening backend "stdio" failed >> qemu: could not

Re: [Qemu-devel] [libvirt] libvirt doesn't work with qemu 1.0

2012-01-26 Thread Paolo Bonzini
On 01/26/2012 01:46 PM, Eric Blake wrote: > On 01/26/2012 02:41 AM, Paolo Bonzini wrote: >> On 01/26/2012 04:55 AM, Eric Blake wrote: >>> >>> $ /usr/libexec/qemu-kvm -qmp stdio -S -display none >>> qemu-kvm: -display: invalid option >>> $ /usr/libexec/qemu-kvm -qmp stdio -S -nographic >>> chardev:

Re: [Qemu-devel] git bisect results

2012-01-26 Thread Erik Rull
Hi Jan,   here the results of the sdl printfs.   First of all the modified code:   #include #define NO_DEBUG_PATHS 3 int paths[NO_DEBUG_PATHS] = {0,0,0}; int last_sec = 0; struct timeval tv; static

[Qemu-devel] [Bug 922076] [NEW] doesn't clear screen on boot

2012-01-26 Thread Askar Safin
Public bug reported: When I start Linux in Qemu via "qemu -kernel /vmlinuz ...", opens Qemu window, it shows message "Starting Seabios (version 0.5.1-2010...)", and then Linux writes messages like "Loading, please wait..." on top of previous message! For example, I can see "Loading, please wait..

[Qemu-devel] [Bug 922076] Re: doesn't clear screen on boot

2012-01-26 Thread Askar Safin
** Attachment added: "kernel code. this kernel makes qemu bugs visible" https://bugs.launchpad.net/bugs/922076/+attachment/2694574/+files/kernel.tar -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/92

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-26 Thread Avi Kivity
On 01/26/2012 05:19 AM, Alexey Korolev wrote: > If you apply the following patch and add to qemu command: --device > ivshmem,size=32,shm="shm" > --- > diff --git a/hw/ivshmem.c b/hw/ivshmem.c > index 1aa9e3b..71f8c21 100644 > --- a/hw/ivshmem.c > +++ b/hw/ivshmem.c > @@ -341,7 +341,7 @@ static voi

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-26 Thread Avi Kivity
On 01/26/2012 11:14 AM, Michael S. Tsirkin wrote: > On Wed, Jan 25, 2012 at 06:46:03PM +1300, Alexey Korolev wrote: > > Hi, > > In this post > > http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg03171.html I've > > mentioned about the issues when 64Bit PCI BAR is present and 32bit > > addres

Re: [Qemu-devel] [PATCH] GRLIB UART: Add RX channel

2012-01-26 Thread Avi Kivity
On 01/26/2012 03:45 PM, Fabien Chouteau wrote: > @@ -141,18 +219,19 @@ grlib_apbuart_write(void *opaque, target_phys_addr_t > addr, > static bool grlib_apbuart_accepts(void *opaque, target_phys_addr_t addr, >unsigned size, bool is_write) > { > -return is_w

[Qemu-devel] [PATCH 3/5] arm: add secondary cpu boot callbacks to arm_boot.c

2012-01-26 Thread Peter Maydell
From: Mark Langsdorf Create two functions, write_secondary_boot() and secondary_cpu_reset_hook(), to allow platforms more control of how secondary CPUs are brought up. The new functions default to NULL and aren't called unless they are populated so there are no changes to existing platform models

[Qemu-devel] [PATCH 2/5] ahci: add support for non-PCI based controllers

2012-01-26 Thread Peter Maydell
From: Rob Herring Add support for ahci on sysbus. Signed-off-by: Rob Herring Signed-off-by: Mark Langsdorf Reviewed-by: Andreas Färber Signed-off-by: Peter Maydell --- hw/ide/ahci.c | 44 1 files changed, 44 insertions(+), 0 deletions(-) diff

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-26 Thread Michael S. Tsirkin
On Thu, Jan 26, 2012 at 03:51:06PM +0200, Avi Kivity wrote: > > Please look at HPET lines. HPET is mapped to 0xfed0. > > Size of ivshmem is 32MB. During pci enumeration ivshmem will corrupt the > > range from 0xfe00 - 0x. > > It overlaps HPET memory. When Linux does late_hpet init,

Re: [Qemu-devel] [PATCH] usb-redir: Add the posibility to filter out certain devices from redirecion

2012-01-26 Thread Gerd Hoffmann
On 01/25/12 09:50, Hans de Goede wrote: > This patch adds the posibility to filter out certain devices from redirecion. > To use this pass the filter property to -device usb-redir. The filter > property takes a string consisting of filter rules, the format for a rule is: > > Patch added to

[Qemu-devel] [PATCH] nic: zap obsolote romloading bits from ne2k + pcnet

2012-01-26 Thread Gerd Hoffmann
These days one just needs to specify the romfile in PCiDeviceInfo and everything magically works. It also allows to disable pxe rom loading via "romfile=" like it is possible for all other nics. Signed-off-by: Gerd Hoffmann --- hw/ne2000.c|9 + hw/pcnet-pci.c |9 + 2

[Qemu-devel] [PATCH] usb-uhci: implement bandwidth management

2012-01-26 Thread Gerd Hoffmann
The OS is allowed to make the UHCI Controller run in circles. That is usually done to serve multiple connected USB devices in a robin-round fashion, so the available USB bandwidth is evenly distributed between devices. The uhci emulation handles this in a very poor way though. When it figures it

[Qemu-devel] [PATCH v7 01/11] Add cache handling functions

2012-01-26 Thread Orit Wasserman
Add LRU page cache mechanism. The page are accessed by their address. Signed-off-by: Orit Wasserman --- arch_init.c | 174 +++ 1 files changed, 174 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index 2366511..bdc74a

[Qemu-devel] [PATCH v7 03/11] Add save_block_hdr function

2012-01-26 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 25 + 1 files changed, 13 insertions(+), 12 deletions(-) diff --git a/arch_init.c b/arch_init.c index bdc74a9..ac21bc0 100644 --- a/arch_init.c +++ b/arch_init.c @@ -300,6 +300,17 @@ static void cache_insert(unsigned long

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-26 Thread Avi Kivity
On 01/26/2012 04:05 PM, Michael S. Tsirkin wrote: > > > > Let me see if I get this right: during BAR sizing, the guest sets the > > BAR to ~1, which means 4GB-32MB -> 4GB, which overlaps the HPET. If so, > > that's expected behaviour. > > Yes BAR sizing temporarily sets the BAR to an invalid valu

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-26 Thread Michael S. Tsirkin
On Thu, Jan 26, 2012 at 03:52:27PM +0200, Avi Kivity wrote: > On 01/26/2012 11:14 AM, Michael S. Tsirkin wrote: > > On Wed, Jan 25, 2012 at 06:46:03PM +1300, Alexey Korolev wrote: > > > Hi, > > > In this post > > > http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg03171.html I've > > > menti

[Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-26 Thread Peter Maydell
From: Rob Herring Adds support for Calxeda's Highbank SoC. Signed-off-by: Rob Herring Signed-off-by: Mark Langsdorf Signed-off-by: Peter Maydell --- Makefile.target |1 + hw/highbank.c | 330 +++ 2 files changed, 331 insertions(+), 0

[Qemu-devel] [PATCH 4/5] arm_boot: support board IDs more than 16 bits wide

2012-01-26 Thread Peter Maydell
Support passing a board ID value to the kernel in r1 that is more than 16 bits wide. This is needed to pass the '-1 == invalid' value for boards which only support device tree booting. Signed-off-by: Peter Maydell Tested-by: Mark Langsdorf --- hw/arm_boot.c | 11 +-- 1 files changed,

[Qemu-devel] [PULL 0/5] arm-devs queue (to go after target-arm queue)

2012-01-26 Thread Peter Maydell
Hi; this is a pullreq for my arm-devs queue, which is basically the Highbank patches. There is a slight sequencing issue here: it would be better if this went in after the target-arm queue which I sent a pullreq for yesterday, because that includes a bugfix which Highbank depends on. It's not a di

[Qemu-devel] [PATCH v7 04/11] Add host_from_stream_offset_versioned function

2012-01-26 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 26 +++--- 1 files changed, 23 insertions(+), 3 deletions(-) diff --git a/arch_init.c b/arch_init.c index ac21bc0..0f6037e 100644 --- a/arch_init.c +++ b/arch_init.c @@ -550,6 +550,18 @@ static inline void *host_from_stream_o

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-26 Thread Michael Tokarev
26.01.2012 13:54, ronnie sahlberg wrote: Ok so what about this You use a filename starting with "/proc/self/fd/" and you dont have a proc filesystem mounted? you are on your own! No you're not: IF ! STRNCMP (filename, "/proc/self/fd/", 14) THEN fopen(filename, "r") ELSE

[Qemu-devel] [PATCH v7 11/11] Add XBZRLE statstics information

2012-01-26 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 60 ++ migration.c | 10 + migration.h |9 qapi-schema.json | 20 - 4 files changed, 97 insertions(+), 2 deletions(-) diff --git a/arch_i

Re: [Qemu-devel] commit 67feec6ed854b3618b37ccf050b90192cbb96e0f breaks compilation of hw/pci.c

2012-01-26 Thread Erik Rull
Andreas Färber wrote: Am 26.01.2012 11:32, schrieb Jan Kiszka: On 2012-01-26 11:00, Andreas Färber wrote: Am 26.01.2012 07:38, schrieb Gleb Natapov: On Wed, Jan 25, 2012 at 10:07:14PM +0100, Erik Rull wrote: Is it possible that you provide this patch? Or was it already applied somewhere? No

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-26 Thread Daniel P. Berrange
On Thu, Jan 26, 2012 at 08:54:11PM +1100, ronnie sahlberg wrote: > Ok so what about this > > You use a filename starting with "/proc/self/fd/" and you dont have a > proc filesystem mounted? you are on your own! IMHO that would be bad - turning what could easily be a platform neutral feature in

Re: [Qemu-devel] [PATCH v6] qdev: Add support for property type bool

2012-01-26 Thread Andreas Färber
Am 24.01.2012 18:17, schrieb Andreas Färber: > From: Andreas Färber > > VMState supports the type bool but qdev instead supports bit, backed by > uint32_t. Therefore let's add DEFINE_PROP_BOOL() and qdev_prop_set_bool(). Actually qdev_prop_set_bool() got lost in a merge conflict... Re-adding. A

[Qemu-devel] [PATCH v7 02/11] Add uleb encoding/decoding functions

2012-01-26 Thread Orit Wasserman
Implement Unsigned Little Endian Base 128. Signed-off-by: Orit Wasserman --- migration.h |4 savevm.c| 28 2 files changed, 32 insertions(+), 0 deletions(-) diff --git a/migration.h b/migration.h index 372b066..50dec18 100644 --- a/migration.h +++ b/m

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-26 Thread Avi Kivity
On 01/26/2012 04:36 PM, Michael S. Tsirkin wrote: > On Thu, Jan 26, 2012 at 03:52:27PM +0200, Avi Kivity wrote: > > On 01/26/2012 11:14 AM, Michael S. Tsirkin wrote: > > > On Wed, Jan 25, 2012 at 06:46:03PM +1300, Alexey Korolev wrote: > > > > Hi, > > > > In this post > > > > http://lists.gnu.org/

[Qemu-devel] Merging kvm-apic into qemu-kvm

2012-01-26 Thread Avi Kivity
The changes to kvm-apic are so drastic, that merging them into qemu-kvm in the normal way won't work. I can consider just dropping the existing implementation and switching to the new one, but the comment at the end Make the basic in-kernel irqchip support selectable via -machine ...,kern

[Qemu-devel] [PATCH v7 06/11] Add MigrationParams structure

2012-01-26 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- block-migration.c |8 migration.c | 16 +--- migration.h |9 +++-- qemu-common.h |1 + savevm.c | 12 sysemu.h |4 ++-- vmstate.h |2 +- 7 files changed, 32 i

[Qemu-devel] [PATCH v7 08/11] Add migration capabilties

2012-01-26 Thread Orit Wasserman
Add migration capabiltes that can be queried by the management. The managment can query to source and the destination in order to verify both support some maigration capability (currently only XBZRLE). Signed-off-by: Orit Wasserman --- hmp.c| 18 ++ hmp.h

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-26 Thread Eric Blake
[adding qemu-devel] On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: >> One thing, that you'll probably notice is this >> 'set-support-level' command. Basically, it tells GA what qemu version >> is it running on. Ideally, this should be done as soon as >> GA starts up. However, that cannot be det

[Qemu-devel] [PATCH v7 10/11] Add XBZRLE option to migrate command

2012-01-26 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- hmp-commands.hx | 21 + qmp-commands.hx | 18 +++--- 2 files changed, 24 insertions(+), 15 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 3b7255d..daa8aae 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx

[Qemu-devel] [PATCH v7 09/11] Add set_cachesize command

2012-01-26 Thread Orit Wasserman
Change XBZRLE cache size in MB (the size should be a power of 2). Signed-off-by: Orit Wasserman --- hmp-commands.hx | 15 +++ hmp.c| 13 + hmp.h|1 + migration.c | 22 +- migration.h |2 ++ qapi-schema.j

Re: [Qemu-devel] Merging kvm-apic into qemu-kvm

2012-01-26 Thread Jan Kiszka
On 2012-01-26 16:15, Avi Kivity wrote: > The changes to kvm-apic are so drastic, that merging them into qemu-kvm > in the normal way won't work. I can consider just dropping the existing > implementation and switching to the new one, but the comment at the end > > Make the basic in-kernel irq

[Qemu-devel] [Bug 922131] [NEW] QEMU v1.0-788-g3316364 crashes in win32 native environment

2012-01-26 Thread Roy Tam
Public bug reported: Host: lubuntu 10.04 LTS x86 (32bit) Build: i586-mingw32msvc-gcc 4.4.2 Libs: mingw32-runtime-3.15.2-0ubuntu1, wine1.3, zlib-1.2.5 (from source), glib-2.28.1 (from http://ftp.gnome.org/pub/gnome/binaries/win32/glib/2.28/glib*_2.28.1-1_win32.zip), gettext-0.18.1.1 (from source

[Qemu-devel] [PATCH v7 00/11] XBRLE delta for live migration of large memory app

2012-01-26 Thread Orit Wasserman
Changes from v6: 1) add assert checks to ULEB encoding/decoding 2) no need to send last zero run Changes from v5: 1) Add migration capabilities 2) Use ULEB to encode run length 3) Do not send unmodified (dirty) page 3) Fix other patch comments Using GCache or GHashTable requires allocat

[Qemu-devel] [PATCH v7 07/11] Add XBZRLE parameters to MigrationState

2012-01-26 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c |5 + migration.c |8 migration.h |4 savevm.c|9 ++--- 4 files changed, 23 insertions(+), 3 deletions(-) diff --git a/arch_init.c b/arch_init.c index 4ebf080..f864585 100644 --- a/arch_init.c +++ b/arch_ini

[Qemu-devel] [PATCH v7] qdev: Add support for property type bool

2012-01-26 Thread Andreas Färber
From: Andreas Färber VMState supports the type bool but qdev instead supports bit, backed by uint32_t. Therefore let's add PROP_TYPE_BOOL and qdev_prop_set_bool(). With non-programmers in mind, instead of universal true/false provide two different property types: * on/off for DEFINE_PROP_SWITCH(

Re: [Qemu-devel] Merging kvm-apic into qemu-kvm

2012-01-26 Thread Jan Kiszka
On 2012-01-26 16:25, Jan Kiszka wrote: > On 2012-01-26 16:15, Avi Kivity wrote: >> The changes to kvm-apic are so drastic, that merging them into qemu-kvm >> in the normal way won't work. I can consider just dropping the existing >> implementation and switching to the new one, but the comment at t

[Qemu-devel] [PATCH v7 05/11] Add XBZRLE to ram_save_block and ram_save_live

2012-01-26 Thread Orit Wasserman
Add migration state to store XBRLE params (enablement and cache size). In the outgoing migration check to see if the page is cached and changed than send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is set and decompress the page (

Re: [Qemu-devel] [PATCH v7] qdev: Add support for property type bool

2012-01-26 Thread Andreas Färber
Am 26.01.2012 16:27, schrieb Andreas Färber: > From: Andreas Färber > > VMState supports the type bool but qdev instead supports bit, backed by > uint32_t. Therefore let's add PROP_TYPE_BOOL and qdev_prop_set_bool(). > > With non-programmers in mind, instead of universal true/false provide > two

[Qemu-devel] [PATCH 1/5] Add xgmac ethernet model

2012-01-26 Thread Peter Maydell
From: Rob Herring This adds very basic support for the xgmac ethernet core. Missing things include: - statistics counters - WoL support - rx checksum offload - chained descriptors (only linear descriptor ring) - broadcast and multicast handling Signed-off-by: Rob Herring Signed-off-by: Mark La

Re: [Qemu-devel] Merging kvm-apic into qemu-kvm

2012-01-26 Thread Avi Kivity
On 01/26/2012 05:32 PM, Jan Kiszka wrote: > On 2012-01-26 16:25, Jan Kiszka wrote: > > On 2012-01-26 16:15, Avi Kivity wrote: > >> The changes to kvm-apic are so drastic, that merging them into qemu-kvm > >> in the normal way won't work. I can consider just dropping the existing > >> implementatio

Re: [Qemu-devel] Merging kvm-apic into qemu-kvm

2012-01-26 Thread Jan Kiszka
On 2012-01-26 16:39, Avi Kivity wrote: > On 01/26/2012 05:32 PM, Jan Kiszka wrote: >> On 2012-01-26 16:25, Jan Kiszka wrote: >>> On 2012-01-26 16:15, Avi Kivity wrote: The changes to kvm-apic are so drastic, that merging them into qemu-kvm in the normal way won't work. I can consider jus

Re: [Qemu-devel] Merging kvm-apic into qemu-kvm

2012-01-26 Thread Avi Kivity
On 01/26/2012 05:45 PM, Jan Kiszka wrote: > > > >> I merged the upstream patches one by one, resolving the mechanical and > >> logical conflicts in each step. Was done for that backend/frontend > >> concept, but the adjustments should basically be the same now. Want me > >> to prepare a branch or

[Qemu-devel] [PATCH v8] qdev: Add support for property type bool

2012-01-26 Thread Andreas Färber
From: Andreas Färber VMState supports the type bool but qdev instead supports bit, backed by uint32_t. Therefore let's add PROP_TYPE_BOOL and qdev_prop_set_bool(). With non-programmers in mind, instead of universal true/false provide two different property types: * on/off for DEFINE_PROP_SWITCH(

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-26 Thread Michael Tokarev
26.01.2012 18:55, Michael Tokarev wrote: 26.01.2012 13:54, ronnie sahlberg wrote: Ok so what about this You use a filename starting with "/proc/self/fd/" and you dont have a proc filesystem mounted? you are on your own! BTW, usual idiom (which was implemented in gawk for example) is to use /d

Re: [Qemu-devel] git bisect results

2012-01-26 Thread Jan Kiszka
On 2012-01-26 14:10, Erik Rull wrote: > Hi Jan, > > > > here the results of the sdl printfs. > > > > First of all the modified code: > > > > #include > > #define NO_DEBUG_PATHS 3 > int paths[NO_DEBUG_PATHS] = {0,0,0}; > int last_sec = 0; > struct timeval tv; > > static void handle_mouse

[Qemu-devel] [PATCH 14/22] block: add bdrv_find_backing_image

2012-01-26 Thread Kevin Wolf
From: Marcelo Tosatti Add bdrv_find_backing_image: given a BlockDriverState pointer, and an id, traverse the backing image chain to locate the id. Signed-off-by: Marcelo Tosatti Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c | 18 ++ block.h |2 ++

[Qemu-devel] [PATCH 06/22] block: add BlockJob interface for long-running operations

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c | 48 block_int.h | 40 2 files changed, 88 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c

[Qemu-devel] [PATCH 18/22] virtio-blk: add virtio_blk_handle_read trace event

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi There already exists a virtio_blk_handle_write trace event as well as completion events. Add the virtio_blk_handle_read event so it's easy to trace virtio-blk requests for both read and write operations. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- hw/vi

[Qemu-devel] [PATCH 08/22] block: rate-limit streaming operations

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi This patch implements rate-limiting for image streaming. If we've exceeded the bandwidth quota for a 100 ms time slice we sleep the coroutine until the next slice begins. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/stream.c | 65

[Qemu-devel] [PATCH 04/22] block: check bdrv_in_use() before blockdev operations

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi Long-running block operations like block migration and image streaming must have continual access to their block device. It is not safe to perform operations like hotplug, eject, change, resize, commit, or external snapshot while a long-running operation is in progress. Th

[Qemu-devel] [PATCH 20/22] qcow: Return real error code in qcow_open

2012-01-26 Thread Kevin Wolf
From: Li Zhi Hui Signed-off-by: Li Zhi Hui Signed-off-by: Kevin Wolf --- block/qcow.c | 56 +--- 1 files changed, 37 insertions(+), 19 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index b16955d..e0d0b88 100644 --- a/block/qcow.c +

[Qemu-devel] [PATCH 03/22] coroutine: add co_sleep_ns() coroutine sleep function

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- Makefile.objs |1 + qemu-coroutine-sleep.c | 38 ++ qemu-coroutine.h |9 + 3 files changed, 48 insertions(+), 0 deletions(-) create mode 1006

[Qemu-devel] [PATCH v2 00/18] Support mismatched host and guest logical block sizes

2012-01-26 Thread Paolo Bonzini
As in v1, the series is logically split in two parts. The first six patches ensure that BDRV_O_NO_CACHE is set for all non-file protocols. This makes sure that large sectors are handled correctly for the libiscsi backend. The next patches add support for arbitrary combinations of host/guest logi

[Qemu-devel] [PATCH v2 01/18] block: do not rely on open_flags for bdrv_is_snapshot

2012-01-26 Thread Paolo Bonzini
The BDRV_O_SNAPSHOT flag is stored in open_flags but not passed to bdrv_open. This makes the usage of bs->open_flags wrong in bdrv_snapshot_goto. (Instead, bdrv_commit uses the backing file's open_flags and those flags never include any of BDRV_O_SNAPSHOT, BDRV_O_NO_BACKING or BDRV_O_RDWR). We w

[Qemu-devel] [PATCH v2 05/18] block: remove enable_write_cache

2012-01-26 Thread Paolo Bonzini
This duplicates a bit in open_flags, we do not need it. Signed-off-by: Paolo Bonzini --- block.c |3 +-- block_int.h |3 --- 2 files changed, 1 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index 5055975..afc327e 100644 --- a/block.c +++ b/block.c @@ -607,7 +607,6 @@

[Qemu-devel] [PATCH v2 02/18] block: store actual flags in bs->open_flags

2012-01-26 Thread Paolo Bonzini
The passed flags are changed slightly before passing them to bdrv_open. Store the same flags in bs->open_flags, so that they are used correctly in bdrv. In addition, this way we will be able to query them and get back consistent values. Signed-off-by: Paolo Bonzini --- block.c | 38 +

[Qemu-devel] [PATCH v2 10/18] raw: probe host_block_size

2012-01-26 Thread Paolo Bonzini
Use ioctls if possible, else see what alignment it takes for O_DIRECT to succeed. Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 72 block/raw-win32.c | 42 +++ 2 files changed, 97 insertions(+), 17 deleti

[Qemu-devel] [PATCH v2 14/18] block: protect against "torn reads" for guest_block_size > host_block_size

2012-01-26 Thread Paolo Bonzini
When the guest sees a higher alignment than the host, writes may be done in multiple steps. So, reads have to be serialized against overlapping writes, so that the writes look atomic to the guest. This is true even when O_DIRECT is not in use. Signed-off-by: Paolo Bonzini --- block.c | 22 +++

  1   2   3   >