On 01/26/2012 01:31 PM, Fabien Chouteau wrote: > On 26/01/2012 10:33, Avi Kivity wrote: > > The memory API returns -1 on unassigned reads, different from the original > > in exec.c, which returned zero. > > Isn't this return value platform specific?
Maybe (and I think ~0 is the common one); the patch just restores the previous behaviour. > > > This breaks grlib_uart; apparently some users depend on it. > > > > Fix by returning zero; however if reading from the uart is legal, then > > it should be modified to accept reads. > > > > That's right, grlib_uart depends on it because I took the easy (lazy?) > way. I will send a patch to handle reads to UART's registers. Definitely that's the best way to fix the problem. -- error compiling committee.c: too many arguments to function
