[Qemu-devel] Insane virtio-serial semantics (was: [PATCH v2 4/5] backdoor: [softmmu] Add QEMU-side proxy to "libbackdoor.a")

2011-12-07 Thread Markus Armbruster
Anthony Liguori writes: > On 12/06/2011 04:30 PM, Lluís Vilanova wrote: >> Anthony Liguori writes: >> >>> I really worry about us introducing so many of these one-off paravirtual >>> devices. >>> I would much prefer that you look at doing this as an extension to the >>> ivshmem >>> device as it

Re: [Qemu-devel] winXP "Standard PC" HAL and qemu-kvm >= 0.15

2011-12-07 Thread Kevin Wolf
Am 06.12.2011 19:21, schrieb Jan Kiszka: > On 2011-12-06 19:13, Michael Tokarev wrote: >> On 06.12.2011 20:57, Michael Tokarev wrote: >>> On 06.12.2011 20:38, Jan Kiszka wrote: On 2011-12-06 17:29, Michael Tokarev wrote: >>> [] > It appears there are two issues here, one is fixed by >

Re: [Qemu-devel] [libvirt] Guest Agent Summaries

2011-12-07 Thread Alon Levy
On Mon, Dec 05, 2011 at 03:36:59PM -0600, Michael Roth wrote: > On 12/05/2011 01:21 PM, Chris Wright wrote: > >* Chris Wright (chr...@redhat.com) wrote: > >>* Anthony Liguori (aligu...@us.ibm.com) wrote: > >>>1. A short introduction to each of the guest agents, what guests they > >>>support, and wh

[Qemu-devel] [PATCH] block/qcow2.c : call qcow2_free_snapshots in the function of qcow2_close

2011-12-07 Thread Li Zhi Hui
Signed-off-by: Li Zhi Hui --- block/qcow2.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 37cd442..aa32e8d 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -635,6 +635,7 @@ static void qcow2_close(BlockDriverState *bs) g_free(s-

Re: [Qemu-devel] winXP "Standard PC" HAL and qemu-kvm >= 0.15

2011-12-07 Thread Michael Tokarev
On 07.12.2011 13:02, Kevin Wolf wrote: > Am 06.12.2011 19:21, schrieb Jan Kiszka: [] >>> For the 0.15 .. 1.0 change, the first commit which restores the (broken >>> in 0.15) functionality is this one: >>> >>> commit 86fbf97ceb4a9c46a609dd4ae053ba4262b68fe8 >>> Author: Jan Kiszka >>> Date: Fri Oc

[Qemu-devel] [PATCH] use PCI MACRO in virtio-pci

2011-12-07 Thread hkran
Signed-off-by: hkran --- hw/virtio-pci.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index c665f5c..f8ee772 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -627,9 +627,9 @@ void virtio_init_pci(VirtIOPCIProxy *proxy, Virt

Re: [Qemu-devel] [PATCH v4 2/3] Extract code to nbd_setup function to be used for many purposes

2011-12-07 Thread Paolo Bonzini
On 12/07/2011 05:23 AM, Chunyan Liu wrote: Add -f option to qemu-nbd. New implementation. Do not need nbd_setup. Tested and worked. Signed-off-by: Chunyan Liu mailto:cy...@suse.com>> --- qemu-nbd.c | 71 +-- 1 files changed, 49 inserti

[Qemu-devel] [PATCH 00/14] ARM: Samsung S5PC210-based boards support.

2011-12-07 Thread Evgeny Voevodin
This set of patches adds support for Samsung S5PC210-based boards NURI and SMDKC210. Tested on Linux kernel v3.x series. Usage of "-smp 2" option is reuired for now. Evgeny Voevodin (10): hw/sysbus.h: Increase maximum number of device IRQs. ARM: s5pc210: IRQ subsystem support. ARM: s5pc210:

[Qemu-devel] [PATCH 02/14] hw/sysbus.h: Increase maximum number of device IRQs.

2011-12-07 Thread Evgeny Voevodin
Samsung s5pc210 Interrupt Combiner needs 512 IRQ sources. Signed-off-by: Evgeny Voevodin --- hw/sysbus.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/sysbus.h b/hw/sysbus.h index 9bac582..4ef0c3c 100644 --- a/hw/sysbus.h +++ b/hw/sysbus.h @@ -8,7 +8,7 @@ #defin

[Qemu-devel] [PATCH 05/14] hw/arm_boot.c: Add new secondary CPU bootloader.

2011-12-07 Thread Evgeny Voevodin
Secondary CPU bootloader enables interrupt and issues wfi until start address is written to system controller. The position where to find this start address is hardcoded to 0x1030. This commit adds new bootloader for secondary CPU which allows a target board to cpecify a position where to find

[Qemu-devel] [PATCH 06/14] hw/arm_gic.c: lower IRQ only on changing of enable bit.

2011-12-07 Thread Evgeny Voevodin
In previous version IRQ was lowered every time if enable bits were not set. If platform has splitted IRQ source to pass IRQ to two identical GICs simultaneously in first of which IRQ passing is enabled but in second is disabled, handling IRQ by second GIC would lower IRQ previously raised by first

Re: [Qemu-devel] [PATCH 09/14] hw/lan9118.c: Basic byte/word/long access support.

2011-12-07 Thread Peter Maydell
On 7 December 2011 09:47, Evgeny Voevodin wrote: > We included this chip into s5pc210 platform because SMDK board holds > lan9215 chip. Difference is that 9215 access is 16-bit wide and some > registers differ. By addition basic 16-bit access to 9118 emulation we > achieved ethernet controller sup

[Qemu-devel] [PATCH 04/14] ARM: s5pc210: PWM support.

2011-12-07 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- Makefile.target |2 +- hw/s5pc210.c | 12 ++ hw/s5pc210_pwm.c | 433 ++ 3 files changed, 446 insertions(+), 1 deletions(-) create mode 100644 hw/s5pc210_pwm.c diff --git a/Makefile.target b/Makef

Re: [Qemu-devel] [PATCH] block/qcow2.c : call qcow2_free_snapshots in the function of qcow2_close

2011-12-07 Thread Stefan Hajnoczi
On Wed, Dec 7, 2011 at 9:25 AM, Li Zhi Hui wrote: > Signed-off-by: Li Zhi Hui > --- >  block/qcow2.c |    1 + >  1 files changed, 1 insertions(+), 0 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] block/qcow2.c : call qcow2_free_snapshots in the function of qcow2_close

2011-12-07 Thread Kevin Wolf
Am 07.12.2011 10:25, schrieb Li Zhi Hui: > Signed-off-by: Li Zhi Hui > --- > block/qcow2.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] use PCI MACRO in virtio-pci

2011-12-07 Thread Stefan Hajnoczi
On Wed, Dec 7, 2011 at 9:39 AM, hkran wrote: > Signed-off-by: hkran > --- >  hw/virtio-pci.c |    6 +++--- >  1 files changed, 3 insertions(+), 3 deletions(-) This patch is line-wrapped and git-am refuses to apply it. Are you using git-send-email(1)? It normally sends patches correctly so I re

[Qemu-devel] [PATCH 12/14] SD card: add query function to check wether SD card currently ready to recieve data Before executing data transfer to card, we must check that previously issued command wasn

2011-12-07 Thread Evgeny Voevodin
From: Mitsyanko Igor Signed-off-by: Evgeny Voevodin --- hw/sd.c |5 + hw/sd.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/sd.c b/hw/sd.c index 10e26ad..ddb9d39 100644 --- a/hw/sd.c +++ b/hw/sd.c @@ -1670,3 +1670,8 @@ void sd_enable(SDState *sd, int enabl

Re: [Qemu-devel] [PATCH] rbd: always set out parameter in qemu_rbd_snap_list

2011-12-07 Thread Kevin Wolf
Am 07.12.2011 02:05, schrieb Josh Durgin: > The caller expects psn_tab to be NULL when there are no snapshots or > an error occurs. This results in calling g_free on an invalid address. > > Reported-by: Oliver Francke > Signed-off-by: Josh Durgin Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-12-07 Thread Avi Kivity
On 10/17/2011 06:00 PM, Lai Jiangshan wrote: > From: Lai Jiangshan > > Currently, NMI interrupt is blindly sent to all the vCPUs when NMI > button event happens. This doesn't properly emulate real hardware on > which NMI button event triggers LINT1. Because of this, NMI is sent to > the processor

[Qemu-devel] [PATCH 07/14] ARM: s5pc210: MCT support.

2011-12-07 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- Makefile.target |2 +- hw/s5pc210.c | 19 + hw/s5pc210_mct.c | 1483 ++ 3 files changed, 1503 insertions(+), 1 deletions(-) create mode 100644 hw/s5pc210_mct.c diff --git a/Makefile.target b/Makef

Re: [Qemu-devel] [PATCH 00/14] ARM: Samsung S5PC210-based boards support.

2011-12-07 Thread Peter Maydell
On 7 December 2011 09:46, Evgeny Voevodin wrote: > This set of patches adds support for Samsung S5PC210-based boards NURI and > SMDKC210. > Tested on Linux kernel v3.x series. I'm a bit confused by the naming here -- which Linux kernel mach-* directory does this correspond to? I can see a mach-s

[Qemu-devel] [PATCH 14/14] s5pc210: Switch to sysbus_init_mmio.

2011-12-07 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- hw/s5pc210_cmu.c |2 +- hw/s5pc210_combiner.c |2 +- hw/s5pc210_fimd.c |2 +- hw/s5pc210_gic.c |4 ++-- hw/s5pc210_mct.c |2 +- hw/s5pc210_pwm.c |2 +- hw/s5pc210_sdhc.c |2 +- hw/s5pc210_uart.c |2

[Qemu-devel] SEO Proposal For High Ranking

2011-12-07 Thread Priyanka
Hi, I am Priyanka, SEO Consultant. Advertising in the online world is one of the most inexpensive and highly effective methods of promoting a business. We are a Leading Indian Based SEO & Web Development Company and one of the very few companies whi

Re: [Qemu-devel] [PATCH 1/2] guest agent: add RPC blacklist command-line option

2011-12-07 Thread Dor Laor
On 12/07/2011 06:03 AM, Michael Roth wrote: This adds a command-line option, -b/--blacklist, that accepts a comma-seperated list of RPCs to disable, or prints a list of available RPCs if passed "?". In consequence this also adds general blacklisting and RPC listing facilities to the new QMP disp

[Qemu-devel] [PATCH 09/14] hw/lan9118.c: Basic byte/word/long access support.

2011-12-07 Thread Evgeny Voevodin
We included this chip into s5pc210 platform because SMDK board holds lan9215 chip. Difference is that 9215 access is 16-bit wide and some registers differ. By addition basic 16-bit access to 9118 emulation we achieved ethernet controller support by Linux lernel on SMDK boards. Signed-off-by: Evgen

[Qemu-devel] [PATCH 08/14] ARM: s5pc210: Boot secondary CPU.

2011-12-07 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- hw/s5pc210.c | 26 +- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a/hw/s5pc210.c b/hw/s5pc210.c index eabe3b1..90858e9 100644 --- a/hw/s5pc210.c +++ b/hw/s5pc210.c @@ -97,6 +97,12 @@ #define S5PC210_BASE_BOOT_ADDR

Re: [Qemu-devel] [PATCH 14/14] s5pc210: Switch to sysbus_init_mmio.

2011-12-07 Thread Peter Maydell
On 7 December 2011 09:47, Evgeny Voevodin wrote: > > Signed-off-by: Evgeny Voevodin > --- >  hw/s5pc210_cmu.c      |    2 +- >  hw/s5pc210_combiner.c |    2 +- >  hw/s5pc210_fimd.c     |    2 +- >  hw/s5pc210_gic.c      |    4 ++-- >  hw/s5pc210_mct.c      |    2 +- >  hw/s5pc210_pwm.c      |    

Re: [Qemu-devel] [PATCH 00/14] ARM: Samsung S5PC210-based boards support.

2011-12-07 Thread Dmitry Solodkiy
Dear Peter, Orion, s5pc210 and Exynos4210 are aliases for the same hardware chip. We decided that s5pc210 is more informative than exynos4 (there are many hardware models started with Exynos4...) or Orion(obsolete one). Thanks, Dmitry Solodkiy, Mobile SW PL, Advanced Software Group

[Qemu-devel] [PATCH 03/14] ARM: s5pc210: IRQ subsystem support.

2011-12-07 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- Makefile.target |3 +- hw/s5pc210.c | 163 +++- hw/s5pc210.h | 39 + hw/s5pc210_combiner.c | 381 + hw/s5pc210_gic.c | 411

[Qemu-devel] [PATCH 10/14] hw/s5pc210.c: Add lan9118 support to SMDK board.

2011-12-07 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- hw/s5pc210.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/hw/s5pc210.c b/hw/s5pc210.c index 90858e9..8678b97 100644 --- a/hw/s5pc210.c +++ b/hw/s5pc210.c @@ -29,6 +29,8 @@ #include "sysemu.h" #include "sysbus.h"

Re: [Qemu-devel] [PATCH 1/2] guest agent: add RPC blacklist command-line option

2011-12-07 Thread Daniel P. Berrange
On Wed, Dec 07, 2011 at 12:34:01PM +0200, Dor Laor wrote: > On 12/07/2011 06:03 AM, Michael Roth wrote: > >This adds a command-line option, -b/--blacklist, that accepts a > >comma-seperated list of RPCs to disable, or prints a list of > >available RPCs if passed "?". > > > >In consequence this also

Re: [Qemu-devel] [PATCH 09/14] hw/lan9118.c: Basic byte/word/long access support.

2011-12-07 Thread Evgeny Voevodin
On 12/07/2011 02:09 PM, Peter Maydell wrote: On 7 December 2011 09:47, Evgeny Voevodin wrote: We included this chip into s5pc210 platform because SMDK board holds lan9215 chip. Difference is that 9215 access is 16-bit wide and some registers differ. By addition basic 16-bit access to 9118 emula

Re: [Qemu-devel] [PATCH 01/14] ARM: s5pc210: Basic support of s5pc210 boards

2011-12-07 Thread Peter Maydell
If you split this patch up so it is: 1 cmu 2 uart 3 initial basic board this will be easier to review than a 2000 line patch. > +DeviceState *s5pc210_uart_create(target_phys_addr_t addr, > +                                 int fifo_size, > +                                 int channel, > +    

Re: [Qemu-devel] [Bug 899140] Re: Problem with Linux Kernel Traffic Control

2011-12-07 Thread Vincent Autefage
Well I've compiled the ubuntu package. When I've launched qemu, I've got this : * *$ *qemu-system-x86_64 -hda debian.img -m 512 qemu: could not load PC BIOS 'bios.bin' ** *I've checked the content of the *pc-bios* directory and no bios are generated but I've got strange file like : **.bin *.d

Re: [Qemu-devel] [PATCH 09/14] hw/lan9118.c: Basic byte/word/long access support.

2011-12-07 Thread Peter Maydell
On 7 December 2011 10:58, Evgeny Voevodin wrote: > On 12/07/2011 02:09 PM, Peter Maydell wrote: >> >> On 7 December 2011 09:47, Evgeny Voevodin  wrote: >>> >>> We included this chip into s5pc210 platform because SMDK board holds >>> lan9215 chip. Difference is that 9215 access is 16-bit wide and s

Re: [Qemu-devel] [PATCH 12/14] SD card: add query function to check wether SD card currently ready to recieve data Before executing data transfer to card, we must check that previously issued command

2011-12-07 Thread Peter Maydell
On 7 December 2011 09:47, Evgeny Voevodin wrote: > From: Mitsyanko Igor Shouldn't we have a Signed-off-by: from this person as well? There's a missing blank line in the commit message which has put all of it into the Subject. > Signed-off-by: Evgeny Voevodin > --- >  hw/sd.c |    5 + >  h

[Qemu-devel] [PATCH] qemu-img rebase: Fix for undersized backing files

2011-12-07 Thread Kevin Wolf
Backing files may be smaller than the corresponding COW file. When reading directly from the backing file, qemu-img rebase must consider this and assume zero sectors after the end of backing files. Signed-off-by: Kevin Wolf --- qemu-img.c | 42 +- 1 file

Re: [Qemu-devel] [PATCH 4/4] ccid: make threads joinable

2011-12-07 Thread Alon Levy
On Tue, Dec 06, 2011 at 06:05:55PM +0100, Paolo Bonzini wrote: > Destroying a mutex that another thread might have just unlocked > is racy. It usually works, but you cannot do that in general and > can lead to deadlocks or segfaults. Change ccid to use joinable > threads instead. > Looks good t

Re: [Qemu-devel] [PATCH] qemu-img rebase: Fix for undersized backing files

2011-12-07 Thread Stefan Hajnoczi
On Wed, Dec 7, 2011 at 11:45 AM, Kevin Wolf wrote: > Backing files may be smaller than the corresponding COW file. When > reading directly from the backing file, qemu-img rebase must consider > this and assume zero sectors after the end of backing files. > > Signed-off-by: Kevin Wolf > --- >  qem

Re: [Qemu-devel] [PATCH] qemu-img rebase: Fix for undersized backing files

2011-12-07 Thread Kevin Wolf
Am 07.12.2011 12:50, schrieb Stefan Hajnoczi: > On Wed, Dec 7, 2011 at 11:45 AM, Kevin Wolf wrote: >> Backing files may be smaller than the corresponding COW file. When >> reading directly from the backing file, qemu-img rebase must consider >> this and assume zero sectors after the end of backing

Re: [Qemu-devel] [PATCH] qemu-img rebase: Fix for undersized backing files

2011-12-07 Thread Stefan Hajnoczi
On Wed, Dec 7, 2011 at 12:02 PM, Kevin Wolf wrote: > Am 07.12.2011 12:50, schrieb Stefan Hajnoczi: >> On Wed, Dec 7, 2011 at 11:45 AM, Kevin Wolf wrote: >>> Backing files may be smaller than the corresponding COW file. When >>> reading directly from the backing file, qemu-img rebase must consider

[Qemu-devel] [PATCH v2 0/3] block: zero write detection

2011-12-07 Thread Stefan Hajnoczi
This series adds an interface for optimized writes when data contains all zeros. If zero detection is enabled a block driver can take extra steps to represent zero regions efficiently. The details of optimized zero representations depend on the image format but the main block layer change is a fi

[Qemu-devel] [PATCH v2 3/3] qemu-io: add zero write detection option

2011-12-07 Thread Stefan Hajnoczi
Add a -z option to qemu-io and the 'open' command to enable zero write detection. This is used by the qemu-iotests 029 test case and allows scripts to exercise zero write detection. Signed-off-by: Stefan Hajnoczi --- qemu-io.c | 29 ++--- 1 files changed, 22 insertions

[Qemu-devel] [PATCH v2 2/3] qed: add zero write detection support

2011-12-07 Thread Stefan Hajnoczi
The QED image format is able to efficiently represent clusters containing zeroes with a magic offset value. This patch implements zero write detection for allocating writes so that image streaming can copy over zero clusters from a backing file without expanding the image file unnecessarily. This

[Qemu-devel] [PATCH v2 1/3] block: add zero write detection interface

2011-12-07 Thread Stefan Hajnoczi
Some image formats can represent zero regions efficiently even when a backing file is present. In order to use this feature they need to detect zero writes and handle them specially. Since zero write detection consumes CPU cycles it is disabled by default and must be explicitly enabled. This pat

Re: [Qemu-devel] [PATCH 1/2] guest agent: add RPC blacklist command-line option

2011-12-07 Thread Dor Laor
On 12/07/2011 12:52 PM, Daniel P. Berrange wrote: On Wed, Dec 07, 2011 at 12:34:01PM +0200, Dor Laor wrote: On 12/07/2011 06:03 AM, Michael Roth wrote: This adds a command-line option, -b/--blacklist, that accepts a comma-seperated list of RPCs to disable, or prints a list of available RPCs if

Re: [Qemu-devel] [PATCH] qemu-img rebase: Fix for undersized backing files

2011-12-07 Thread Kevin Wolf
Am 07.12.2011 13:06, schrieb Stefan Hajnoczi: > On Wed, Dec 7, 2011 at 12:02 PM, Kevin Wolf wrote: >> Am 07.12.2011 12:50, schrieb Stefan Hajnoczi: >>> On Wed, Dec 7, 2011 at 11:45 AM, Kevin Wolf wrote: Backing files may be smaller than the corresponding COW file. When reading directly

Re: [Qemu-devel] [PATCH] Convert keymap file to UTF-8 encoding

2011-12-07 Thread Zhi Yong Wu
On Sat, Dec 3, 2011 at 5:45 PM, Stefan Weil wrote: > Most QEMU files either are pure ASCII or use UTF-8. > Convert this keymap file which still used ISO-8859-1 to UTF-8. > > Signed-off-by: Stefan Weil > --- >  pc-bios/keymaps/is |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > di

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Lluís Vilanova
Anthony Liguori writes: > On 12/05/2011 04:22 PM, Lluís Vilanova wrote: >> Provides the ability for the guest to communicate with user-provided code >> inside >> QEMU itself, using a lightweight mechanism. >> >> See first commit for a full description. >> >> Signed-off-by: Lluís Vilanova > Thi

Re: [Qemu-devel] [PATCH] Convert keymap file to UTF-8 encoding

2011-12-07 Thread Peter Maydell
On 7 December 2011 12:13, Zhi Yong Wu wrote: > Can you let me know how you see that it is ISO-8859-1 coding, not > UTF-8? They look same to me. This gets a bit confusing because mail clients and web browsers tend to try to fix up what they think are wrongly labelled encodings, so for example in m

Re: [Qemu-devel] [PATCH] Convert keymap file to UTF-8 encoding

2011-12-07 Thread Zhi Yong Wu
On Wed, Dec 7, 2011 at 8:31 PM, Peter Maydell wrote: > On 7 December 2011 12:13, Zhi Yong Wu wrote: >> Can you let me know how you see that it is ISO-8859-1 coding, not >> UTF-8? They look same to me. > > This gets a bit confusing because mail clients and > web browsers tend to try to fix up what

[Qemu-devel] [PATCH] Documentation: Add qemu-img -t parameter in man page

2011-12-07 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- qemu-img-cmds.hx |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index 4be00a5..49dce7c 100644 --- a/qemu-img-cmds.hx +++ b/qemu-img-cmds.hx @@ -24,13 +24,13 @@ ETEXI DEF("commit", img_commit, "c

Re: [Qemu-devel] Insane virtio-serial semantics

2011-12-07 Thread Anthony Liguori
On 12/07/2011 02:21 AM, Markus Armbruster wrote: Anthony Liguori writes: On 12/06/2011 04:30 PM, Lluís Vilanova wrote: Anthony Liguori writes: I really worry about us introducing so many of these one-off paravirtual devices. I would much prefer that you look at doing this as an extension t

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Anthony Liguori
On 12/07/2011 06:21 AM, Lluís Vilanova wrote: Anthony Liguori writes: On 12/05/2011 04:22 PM, Lluís Vilanova wrote: Provides the ability for the guest to communicate with user-provided code inside QEMU itself, using a lightweight mechanism. See first commit for a full description. Signed-off

Re: [Qemu-devel] [PATCH] Documentation: Add qemu-img -t parameter in man page

2011-12-07 Thread Stefan Hajnoczi
On Wed, Dec 7, 2011 at 12:58 PM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- >  qemu-img-cmds.hx |    6 +++--- >  1 files changed, 3 insertions(+), 3 deletions(-) Please also document '-t' under "Command parameters:". So far this patch just lists -t but doesn't explain what it does or t

[Qemu-devel] ezmlm warning

2011-12-07 Thread 02hdec-help
Bonjour ! Je suis le programme ezmlm. Je m'occupe de la liste de diffusion 02h...@huiledecrete.com. Un certain nombre de messages provenant de la liste de diffusion <#l> n'ont pas pu vous etre remis correctement. En attachement, vous trouverez une copie du premier message de retour a l'envoyeur q

[Qemu-devel] [PATCH 0/2] net: clean up net/socket.c

2011-12-07 Thread Stefan Hajnoczi
There is no consistent policy on closing the socket file descriptor when net/socket.c initialization fails. This has been on my TODO list for a while and I had a few minutes to fix it now. Stefan Hajnoczi (2): net: expand tabs in net/socket.c net: take ownership of fd in socket init functions

[Qemu-devel] [PATCH 1/2] net: expand tabs in net/socket.c

2011-12-07 Thread Stefan Hajnoczi
In order to make later patches sane, expand the tab characters and conform to QEMU coding style now. Signed-off-by: Stefan Hajnoczi --- net/socket.c | 79 ++ 1 files changed, 41 insertions(+), 38 deletions(-) diff --git a/net/socket.c b/

[Qemu-devel] [PATCH 2/2] net: take ownership of fd in socket init functions

2011-12-07 Thread Stefan Hajnoczi
Today net/socket.c has no consistent policy for closing the socket file descriptor when initialization fails. This means we leak the file descriptor in some cases or we could also try to close it twice. Make error paths consistent by taking ownership of the file descriptor and closing it on error

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Lluís Vilanova
Anthony Liguori writes: [...] >>> If you want to extend QEMU, then send proper patches. Adding random C >>> files to >>> the build is unacceptable. >> >> What do you mean by proper patches? > If you want to add "custom functionality" to QEMU, send a patch to upstream > QEMU. See below. >> T

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Anthony Liguori
On 12/07/2011 09:23 AM, Lluís Vilanova wrote: Anthony Liguori writes: [...] If you want to extend QEMU, then send proper patches. Adding random C files to the build is unacceptable. What do you mean by proper patches? If you want to add "custom functionality" to QEMU, send a patch to upstr

Re: [Qemu-devel] [PATCH v2 0/6] Memory API mutators

2011-12-07 Thread Anthony Liguori
On 12/04/2011 12:09 PM, Avi Kivity wrote: This patchset introduces memory_region_set_enabled() and memory_region_set_address() to avoid the requirement on memory routers to track the internal state of the memory API (so they know whether they need to add or remove a region). Instead, they can si

[Qemu-devel] vfio / iommu domain attributes

2011-12-07 Thread Stuart Yoder
In the vfio RFC thread there seemed to be convergence that some new iommu_ops API is needed to set some platform specific aspects of an iommu domain. On Wed, Nov 30, 2011 at 10:58 AM, Alex Williamson wrote: [cut] > In that case, you should definitely be following what Alexey is thinking > about w

Re: [Qemu-devel] [PATCH v2 0/6] Memory API mutators

2011-12-07 Thread Avi Kivity
On 12/07/2011 05:52 PM, Anthony Liguori wrote: > On 12/04/2011 12:09 PM, Avi Kivity wrote: >> This patchset introduces memory_region_set_enabled() and >> memory_region_set_address() to avoid the requirement on memory >> routers to track the internal state of the memory API (so they know >> whether

Re: [Qemu-devel] [PATCH v2 0/6] Memory API mutators

2011-12-07 Thread Anthony Liguori
On 12/07/2011 09:54 AM, Avi Kivity wrote: On 12/07/2011 05:52 PM, Anthony Liguori wrote: On 12/04/2011 12:09 PM, Avi Kivity wrote: This patchset introduces memory_region_set_enabled() and memory_region_set_address() to avoid the requirement on memory routers to track the internal state of the m

Re: [Qemu-devel] [PATCH v2 0/6] Memory API mutators

2011-12-07 Thread Peter Maydell
On 7 December 2011 15:56, Anthony Liguori wrote: > Ok, let's add a docs/vmstate.txt and add a section that says "If you use the > following functions, you probably need to call them again in post_load" and > put these functions on the list. We've already got docs/migration.txt which talks about

[Qemu-devel] Error while booting

2011-12-07 Thread sparsh mittal
I use version 0.15 of qemu with marss cycle-accurate simulator. After making checkpoints in an image, I get this error, while trying to boot it (i.e. not using loadvm to run checkpoint, but just starting the image). This kernel requires an x86-64 CPU, but only detected an i686 CPU. Unable to boot

[Qemu-devel] [PATCH] build: Cleanup qga make output

2011-12-07 Thread Adam Litke
Currently the make variable qapi-dir refers to the qapi-generated directory in absolute terms. This causes the harmless but ugly make output below. By changing this variable to the relative path the output conforms to the norm and the build works fine. Before patch: CC/home/aglitke/src/qem

Re: [Qemu-devel] [PATCH 1/2] guest agent: add RPC blacklist command-line option

2011-12-07 Thread Michael Roth
On 12/07/2011 06:12 AM, Dor Laor wrote: On 12/07/2011 12:52 PM, Daniel P. Berrange wrote: On Wed, Dec 07, 2011 at 12:34:01PM +0200, Dor Laor wrote: On 12/07/2011 06:03 AM, Michael Roth wrote: This adds a command-line option, -b/--blacklist, that accepts a comma-seperated list of RPCs to disabl

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Lluís Vilanova
Anthony Liguori writes: >> Well, both backdoor and trace instrumentation are implemented using the same >> approach (a static library selected at compile-time). The user sets which >> events >> to instrument in the "trace-events" file. This has the effect that the >> tracetool >> script will not

Re: [Qemu-devel] vfio / iommu domain attributes

2011-12-07 Thread Joerg Roedel
On Wed, Dec 07, 2011 at 09:54:39AM -0600, Stuart Yoder wrote: > Alex, Alexey I'm wondering if you've had any new thoughts on this over > the last week. > > For Freescale, our iommu domain attributes would look something like: > -domain iova base address > -domain iova window size I agree

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Anthony Liguori
On 12/07/2011 10:59 AM, Lluís Vilanova wrote: Anthony Liguori writes: Well, both backdoor and trace instrumentation are implemented using the same approach (a static library selected at compile-time). The user sets which events to instrument in the "trace-events" file. This has the effect that t

Re: [Qemu-devel] ncurses 5.3 conflicts with latest qemu

2011-12-07 Thread andrzej zaborowski
On 5 December 2011 22:44, Stefan Weil wrote: > Am 05.12.2011 20:13, schrieb andrzej zaborowski: > >> Hi, >> >> On 17 November 2011 10:06, Caraman Mihai Claudiu-B02008 >> wrote: >>> >>> A recent patch in qemu conflicts with old ncurses libraries (version >>> 5.3). You will see this error cause by

[Qemu-devel] [RFC] Device sandboxing

2011-12-07 Thread Corey Bryant
A group of us are starting to work on sandboxing QEMU device emulation code. We're just getting started investigating various approaches, and want to engage the community to gather input. Following are the design points that we are currently considering: * Decompose QEMU into multiple processes

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Lluís Vilanova
Anthony Liguori writes: [...] > Why should this analyzer live outside of QEMU in the first place? I fail to > see > the rationale for that other than not wanting to do the work of making it > suitable for upstream consumption. For the same reason that SystemTap lets you add user-provided code in

[Qemu-devel] [PULL 00/35] VMState port of all cpus

2011-12-07 Thread Juan Quintela
The following changes since commit 217bfb445b54db618a30f3a39170bebd9fd9dbf2: hw/arm_gic.c: Ignore attempts to complete nonexistent IRQs (2011-12-05 21:38:56 +0100) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu/quintela.git vmstate-cpus-v4-for-anthony [v4] - change co

[Qemu-devel] [PATCH] configure: don't try to compile against known broken curses.

2011-12-07 Thread Andrzej Zaborowski
This should resolve a problem noted by Caraman Mihai Claudiu. Signed-off-by: Andrzej Zaborowski --- configure |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 61c43b9..678b982 100755 --- a/configure +++ b/configure @@ -1846,6 +1846,11 @@ if

[Qemu-devel] [PATCH 1/2] configure: don't check for Cocoa when detecting SDL.

2011-12-07 Thread Andrzej Zaborowski
The SDL check is supposed to set $sdl to "yes" or "no", but with that check it leaves $sdl unset on darwin, unless --enable-cocoa was specified (which is not needed to enable cocoa anyway). Signed-off-by: Andrzej Zaborowski --- configure |4 +--- 1 files changed, 1 insertions(+), 3 deletions

[Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa.

2011-12-07 Thread Andrzej Zaborowski
Cocoa can only be enabled on Darwin, and is enabled by default too, making --enable-cocoa redundant, with no way to disable Cocoa. It also interfered with SDL support in a way that was dependent on the order of commandline switches. Signed-off-by: Andrzej Zaborowski --- Cocoa support seems to be

Re: [Qemu-devel] [RFC] Device sandboxing

2011-12-07 Thread Anthony Liguori
On 12/07/2011 12:25 PM, Corey Bryant wrote: A group of us are starting to work on sandboxing QEMU device emulation code. We're just getting started investigating various approaches, and want to engage the community to gather input. Following are the design points that we are currently considerin

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Peter Maydell
2011/12/7 Lluís Vilanova : > Anthony Liguori writes: > [...] >> Why should this analyzer live outside of QEMU in the first place?  I fail to >> see >> the rationale for that other than not wanting to do the work of making it >> suitable for upstream consumption. > > For the same reason that System

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Anthony Liguori
On 12/07/2011 12:51 PM, Peter Maydell wrote: 2011/12/7 Lluís Vilanova: Anthony Liguori writes: [...] Why should this analyzer live outside of QEMU in the first place? I fail to see the rationale for that other than not wanting to do the work of making it suitable for upstream consumption. Fo

Re: [Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa.

2011-12-07 Thread Peter Maydell
On 7 December 2011 07:47, Andrzej Zaborowski wrote: > Cocoa can only be enabled on Darwin, and is enabled by default too, > making --enable-cocoa redundant, with no way to disable Cocoa.  It > also interfered with SDL support in a way that was dependent on > the order of commandline switches. For

Re: [Qemu-devel] [PATCH] configure: don't try to compile against known broken curses.

2011-12-07 Thread Stefan Weil
Am 07.12.2011 08:47, schrieb Andrzej Zaborowski: This should resolve a problem noted by Caraman Mihai Claudiu. Signed-off-by: Andrzej Zaborowski --- configure | 5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 61c43b9..678b982 100755 --- a/confi

Re: [Qemu-devel] [PATCH] configure: don't try to compile against known broken curses.

2011-12-07 Thread andrzej zaborowski
On 7 December 2011 19:57, Stefan Weil wrote: > Am 07.12.2011 08:47, schrieb Andrzej Zaborowski: >> +#ifdef NCURSES_VERSION >> +# if NCURSES_VERSION_PATCH < 20040117 >> +# error Old ncurses contain dangerous typedefs, break qemu build (and are >> old) >> +# endif >> +#endif >> int main(void) { resi

Re: [Qemu-devel] vfio / iommu domain attributes

2011-12-07 Thread Stuart Yoder
On Wed, Dec 7, 2011 at 10:38 AM, Joerg Roedel wrote: > On Wed, Dec 07, 2011 at 09:54:39AM -0600, Stuart Yoder wrote: >> Alex, Alexey I'm wondering if you've had any new thoughts on this over >> the last week. >> >> For Freescale, our iommu domain attributes would look something like: >>     -domai

Re: [Qemu-devel] [RFC] Device sandboxing

2011-12-07 Thread Corey Bryant
On 12/07/2011 01:48 PM, Anthony Liguori wrote: On 12/07/2011 12:25 PM, Corey Bryant wrote: A group of us are starting to work on sandboxing QEMU device emulation code. We're just getting started investigating various approaches, and want to engage the community to gather input. Following are

Re: [Qemu-devel] [RFC] Device sandboxing

2011-12-07 Thread Anthony Liguori
On 12/07/2011 01:32 PM, Corey Bryant wrote: Agreed. * The untrusted thread would be restricted by seccomp mode 1 and would contain the device emulation code. I think the best strategy would allow for a device to run either in the untrusted thread or the trusted thread. This makes performance

Re: [Qemu-devel] [PATCH v5 0/4] -net bridge: rootless bridge support for qemu

2011-12-07 Thread Corey Bryant
On 11/13/2011 10:45 PM, Corey Bryant wrote: With qemu it is possible to run a guest from an unprivileged user but if we wanted to communicate with the outside world we had to switch to root. We address this problem by introducing a new network backend and a new network option for -net tap. Thi

Re: [Qemu-devel] Insane virtio-serial semantics

2011-12-07 Thread Michael Roth
On 12/07/2011 07:49 AM, Anthony Liguori wrote: On 12/07/2011 02:21 AM, Markus Armbruster wrote: Anthony Liguori writes: On 12/06/2011 04:30 PM, Lluís Vilanova wrote: Anthony Liguori writes: I really worry about us introducing so many of these one-off paravirtual devices. I would much prefer

Re: [Qemu-devel] [RFC] Device sandboxing

2011-12-07 Thread Michael Halcrow
On Wed, Dec 7, 2011 at 11:43 AM, Anthony Liguori wrote: > I'd like to see what the whitelist would need to be for something like > QEMU in mode 2. My biggest concern is that the whitelist would need to be > so large that the practical security what's all that much improved. > Based on some proto

Re: [Qemu-devel] [PATCH] configure: don't try to compile against known broken curses.

2011-12-07 Thread Stefan Weil
Am 07.12.2011 20:06, schrieb andrzej zaborowski: On 7 December 2011 19:57, Stefan Weil wrote: Am 07.12.2011 08:47, schrieb Andrzej Zaborowski: +#ifdef NCURSES_VERSION +# if NCURSES_VERSION_PATCH < 20040117 +# error Old ncurses contain dangerous typedefs, break qemu build (and are old) +# end

Re: [Qemu-devel] Insane virtio-serial semantics

2011-12-07 Thread Anthony Liguori
On 12/07/2011 01:44 PM, Michael Roth wrote: On 12/07/2011 07:49 AM, Anthony Liguori wrote: On 12/07/2011 02:21 AM, Markus Armbruster wrote: Anthony Liguori writes: On 12/06/2011 04:30 PM, Lluís Vilanova wrote: Anthony Liguori writes: I really worry about us introducing so many of these one

Re: [Qemu-devel] [RFC] Device sandboxing

2011-12-07 Thread Corey Bryant
On 12/07/2011 02:43 PM, Anthony Liguori wrote: On 12/07/2011 01:32 PM, Corey Bryant wrote: Agreed. * The untrusted thread would be restricted by seccomp mode 1 and would contain the device emulation code. I think the best strategy would allow for a device to run either in the untrusted th

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Lluís Vilanova
Anthony Liguori writes: > On 12/07/2011 12:51 PM, Peter Maydell wrote: >> 2011/12/7 Lluís Vilanova: >>> Anthony Liguori writes: >>> [...] Why should this analyzer live outside of QEMU in the first place? I fail to see the rationale for that other than not wanting to do the work of

Re: [Qemu-devel] [RFC] Device sandboxing

2011-12-07 Thread Eric Paris
On Wed, 2011-12-07 at 13:43 -0600, Anthony Liguori wrote: > On 12/07/2011 01:32 PM, Corey Bryant wrote: > > That would seem like the logical approach. I think there may be new mode 2 > > patches coming soon so we can see how they go over. > > I'd like to see what the whitelist would need to be fo

[Qemu-devel] [RFC][PATCH RFC 0/4] trace-instrument: Let the user wrap/override specific event tracing routines

2011-12-07 Thread Lluís Vilanova
XXX: Must be applied on top of the "backdoor" patch series and the patch "trace: Provide a per-event status define for conditional compilation", but is independent otherwise. Adds the "instrument" event property. When specified, this event property lets the user provide her own implement

[Qemu-devel] [PATCH RFC 1/4] trace: [tracetool] Add 'get_api_name' to construct the name of tracing routines

2011-12-07 Thread Lluís Vilanova
All backends now use 'get_api_name' to build the name of the routines that are used by QEMU code when invoking trace points. This is built based on the values of 'get_api_name_fmt' and 'get_api_name_fmt_default'. The old 'get_name' is still available to refer to the name of an event. This allows

[Qemu-devel] [PATCH RFC 2/4] trace-instrument: Add documentation

2011-12-07 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- docs/instrumentation.txt | 142 ++ docs/tracing.txt |9 +++ 2 files changed, 151 insertions(+), 0 deletions(-) create mode 100644 docs/instrumentation.txt diff --git a/docs/instrumentation.txt b/docs/inst

[Qemu-devel] [PATCH RFC 3/4] trace-instrument: Add support for user-provided code on a per-event basis

2011-12-07 Thread Lluís Vilanova
Adds support for the 'instrument' propery into the "trace-events" file. Events with this property will generate tracing routines named '${api_name}_backend' (instead of '${api_name}'), and expect the user to provide its own implementation for the '${api_name}' routines. Signed-off-by: Lluís Vilan

  1   2   >