On 12/07/2011 05:52 PM, Anthony Liguori wrote: > On 12/04/2011 12:09 PM, Avi Kivity wrote: >> This patchset introduces memory_region_set_enabled() and >> memory_region_set_address() to avoid the requirement on memory >> routers to track the internal state of the memory API (so they know >> whether they need to add or remove a region). Instead, they can >> simply copy the state of the region from the guest-exposed register >> to the memory core, via the new mutator functions. > > Based on previous discussions, any time these functions are used, the > caller more than likely needs to call them again in a post_load hook > during restore, correct? > > It would be good to document this very clearly in the header docs for > each function.
It's a layering violation, but I'll add something. -- error compiling committee.c: too many arguments to function
