[Qemu-devel] pseries machine updates

2011-08-04 Thread David Gibson
Hi Alex, Here's another batch of assorted updates for the pseries machine.

[Qemu-devel] [PATCH 4/6] pseries: Add a phandle to the xicp interrupt controller device tree node

2011-08-04 Thread David Gibson
Future devices we will be adding to the pseries machine (e.g. PCI) will need nodes in the device tree which explicitly reference the top-level interrupt controller via interrupt-parent or interrupt-map properties. In order to do this, the interrupt controller node needs an assigned phandle. This

[Qemu-devel] [PATCH 5/6] pseries: interrupt controller should not have a 'reg' property

2011-08-04 Thread David Gibson
The interrupt controller presented in the device tree for the pseries machine is manipulated by the guest only through hypervisor calls. It has no real or emulated registers for the guest to access. However, it currently has a bogus 'reg' property advertising a register window. Moreover, this pr

[Qemu-devel] [PATCH 6/6] pseries: More complete WIMG validation in H_ENTER code

2011-08-04 Thread David Gibson
Currently our implementation of the H_ENTER hypercall, which inserts a mapping in the hash page table assumes that only ordinary memory is ever mapped, and only permits mapping attribute bits accordingly (WIMG==0010). However, we intend to start adding emulated IO to the pseries platform (and real

Re: [Qemu-devel] [PATCH][uq/master] kvmclock: Fix feature detection

2011-08-04 Thread Jan Kiszka
On 2011-07-04 20:37, Marcelo Tosatti wrote: > On Thu, Jun 23, 2011 at 10:23:10AM +0200, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Bit-wise or the feature flags and drop the obsolete #ifdef. >> >> Signed-off-by: Jan Kiszka >> --- >> hw/kvmclock.c |7 ++- >> 1 files changed, 2 insertions

Re: [Qemu-devel] [PATCH] migration: remove subsections in fdc and rtl8139 and bump versions

2011-08-04 Thread Paolo Bonzini
On 08/03/2011 07:44 PM, Anthony Liguori wrote: Not really true, with my series you can migrate new to old if you use pc-0.xx as the machine on the source too. But that is dangerous, no? It suffers from the same problem with subsections. Not in the common case where the source does not pu

Re: [Qemu-devel] [PATCH] migration: remove subsections in fdc and rtl8139 and bump versions

2011-08-04 Thread Paolo Bonzini
On 08/03/2011 11:42 PM, Juan Quintela wrote: > I can certainly limit the change to IDE if we think machine, floppy, > and rtl8139 are safe. Ok, only IDE is broken, something done if we are not reverting the others. Floppy is broken too, and has the problem that the subsection is sent almost

Re: [Qemu-devel] [PATCH v2 16/45] scsi-disk: Track tray locked state

2011-08-04 Thread Markus Armbruster
Hannes Reinecke writes: > On 08/04/2011 08:39 AM, Markus Armbruster wrote: >> Hannes Reinecke writes: >> >>> On 08/03/2011 03:07 PM, Markus Armbruster wrote: We already track it in BlockDriverState. Just like tray open/close state, we should track it in the device models instead, beca

[Qemu-devel] [PATCH 3/6] pseries: Add real mode debugging hcalls

2011-08-04 Thread David Gibson
From: Ben Herrenschmidt PAPR systems support several hypercalls intended for use in real mode debugging tools. These implement reads and writes to arbitrary guest physical addresses. This is useful for real mode software because it allows access to IO addresses and memory outside the RMA withou

Re: [Qemu-devel] [PATCH v2 16/45] scsi-disk: Track tray locked state

2011-08-04 Thread Hannes Reinecke
On 08/04/2011 09:25 AM, Markus Armbruster wrote: Hannes Reinecke writes: On 08/04/2011 08:39 AM, Markus Armbruster wrote: Hannes Reinecke writes: On 08/03/2011 03:07 PM, Markus Armbruster wrote: We already track it in BlockDriverState. Just like tray open/close state, we should track it

[Qemu-devel] [PATCH 1/6] pseries: Bugfixes for interrupt numbering in XICS code

2011-08-04 Thread David Gibson
The implementation of the XICS interrupt controller contains several (difficult to trigger) bugs due to the fact that we were not 100% consistent with which irq numbering we used. In most places, global numbers were used as handled by the presentation layer, however a few functions took "local" nu

[Qemu-devel] [PATCH 2/6] Implement POWER7's CFAR in TCG

2011-08-04 Thread David Gibson
This patch implements support for the CFAR SPR on POWER7 (Come From Address Register), which snapshots the PC value at the time of a branch or an rfid. The latest powerpc-next kernel also catches it and can show it in xmon or in the signal frames. This works well enough to let recent kernels boot

[Qemu-devel] [PATCH] scsi-bus: use DO_UPCAST.

2011-08-04 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu --- hw/scsi-bus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index ad6a730..f6c416e 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@ -712,7 +712,7 @@ void scsi_device_purge_requests(SCSIDevice *sdev) stati

Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify "drive is suitable for microdrive" test

2011-08-04 Thread Kevin Wolf
Am 03.08.2011 22:20, schrieb andrzej zaborowski: > On 3 August 2011 20:24, Markus Armbruster wrote: >> andrzej zaborowski writes: >>> On 3 August 2011 18:38, Markus Armbruster wrote: andrzej zaborowski writes: > 2. if the > under

Re: [Qemu-devel] [PATCH v2 0/5]: QMP: Proper thin provisioning support

2011-08-04 Thread Kevin Wolf
Am 03.08.2011 20:08, schrieb Luiz Capitulino: > On Wed, 03 Aug 2011 17:39:04 +0200 > Kevin Wolf wrote: > >> Am 03.08.2011 17:19, schrieb Luiz Capitulino: >>> Roughly speaking, thin provisioning is a feature where the VM is started >>> with >>> a small disk and space is allocated on demand. >>> >

Re: [Qemu-devel] [libvirt] speeding up qemu core dumps

2011-08-04 Thread Daniel P. Berrange
On Wed, Aug 03, 2011 at 09:42:23PM -0600, Jim Fehlig wrote: > Eric Blake wrote: > > On 08/03/2011 08:37 AM, Jim Fehlig wrote: > >> http://lists.nongnu.org/archive/html/qemu-devel/2011-02/msg01156.html > >> > >> I thought there were more discussions on the topic but can only find the > >> above thre

Re: [Qemu-devel] [PATCH] scsi-bus: use DO_UPCAST.

2011-08-04 Thread Markus Armbruster
Zhi Yong Wu writes: > Signed-off-by: Zhi Yong Wu > --- > hw/scsi-bus.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c > index ad6a730..f6c416e 100644 > --- a/hw/scsi-bus.c > +++ b/hw/scsi-bus.c > @@ -712,7 +712,7 @@ void scsi_device_

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-08-04 Thread Supriya Kannery
On 08/01/2011 09:14 PM, Anthony Liguori wrote: On 08/01/2011 10:44 AM, Kevin Wolf wrote: Am 01.08.2011 17:28, schrieb Anthony Liguori: 2. Top-level command for each parameter (e.g. block_set_hostcache). Supported parameters are easily discoverable via query-commands. If individual block devices

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-08-04 Thread Stefan Hajnoczi
On Thu, Aug 4, 2011 at 9:32 AM, Supriya Kannery wrote: > On 08/01/2011 09:14 PM, Anthony Liguori wrote: >> >> On 08/01/2011 10:44 AM, Kevin Wolf wrote: >>> >>> Am 01.08.2011 17:28, schrieb Anthony Liguori: > > 2. Top-level command for each parameter (e.g. block_set_hostcache). > Suppor

[Qemu-devel] [Bug 816370] Re: compile error in QEMU 0.15.0-rc0 and 0.15.0-rc1

2011-08-04 Thread Marcel Hnilka
Well, I tried to build it with your configuration. It ended with the same result as I posted, but I found that building was successfull with option --disable-spice. Sould you try to build it with --disable-spice option? I'll also try to build and install newest devel version of spice server and c

Re: [Qemu-devel] [PATCH 6/7] Monitor: Don't allow cont on bad VM state

2011-08-04 Thread Jan Kiszka
On 2011-08-03 19:32, Luiz Capitulino wrote: > On Wed, 03 Aug 2011 17:32:03 +0200 > Jan Kiszka wrote: > >> On 2011-08-03 17:17, Luiz Capitulino wrote: >>> We have two states where issuing cont before system_reset can be >>> catastrophic: QSTATE_SHUTDOWN (when -no-shutdown is used) and >>> QSTATE_I

[Qemu-devel] [PATCH v2 2/2] block: add cache=directsync parameter to -drive

2011-08-04 Thread Stefan Hajnoczi
This patch adds -drive cache=directsync for O_DIRECT | O_SYNC host file I/O with no disk write cache presented to the guest. This mode is useful when guests may not be sending flushes when appropriate and therefore leave data at risk in case of power failure. When cache=directsync is used, write o

[Qemu-devel] [PATCH v2 1/2] block: set cache mode flags in a single place

2011-08-04 Thread Stefan Hajnoczi
This patch introduces bdrv_set_cache_flags() which sets open flags given a cache mode. Previously this was duplicated in blockdev.c and qemu-img.c. Signed-off-by: Stefan Hajnoczi --- block.c| 25 + block.h|1 + blockdev.c | 15 +++ qemu-img.c

Re: [Qemu-devel] [Bug 816370] Re: compile error in QEMU 0.15.0-rc0 and 0.15.0-rc1

2011-08-04 Thread Alon Levy
On Thu, Aug 04, 2011 at 08:33:21AM -, Marcel Hnilka wrote: > Well, I tried to build it with your configuration. It ended with the > same result as I posted, but I found that building was successfull with > option --disable-spice. > > Sould you try to build it with --disable-spice option? > >

Re: [Qemu-devel] [PATCH] Correctly assign PCI domain numbers

2011-08-04 Thread David Gibson
On Wed, Aug 03, 2011 at 04:28:33PM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 02, 2011 at 12:15:22AM +1000, David Gibson wrote: > > On Mon, Aug 01, 2011 at 05:03:18PM +0300, Michael S. Tsirkin wrote: > > > On Mon, Aug 01, 2011 at 11:33:37PM +1000, David Gibson wrote: > > > > On Mon, Aug 01, 201

Re: [Qemu-devel] [PATCH 3/7] QemuState: Add additional states

2011-08-04 Thread Markus Armbruster
Luiz Capitulino writes: > Currently, only vm_start() and vm_stop() change the VM state. That's, > the state is only changed when starting or stopping the VM. > > This commit adds the qemu_state_set() function, making it possible > to also do state transitions when qemu is stopped or running. > >

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-08-04 Thread Supriya Kannery
On 08/04/2011 02:02 PM, Supriya Kannery wrote: On 08/01/2011 09:14 PM, Anthony Liguori wrote: On 08/01/2011 10:44 AM, Kevin Wolf wrote: Am 01.08.2011 17:28, schrieb Anthony Liguori: 2. Top-level command for each parameter (e.g. block_set_hostcache). Supported parameters are easily discoverable

Re: [Qemu-devel] [PATCH 0/7]: Introduce the QemuState type

2011-08-04 Thread Markus Armbruster
Luiz Capitulino writes: > It replaces the VMSTOP macros and allows us to drop some global variables. > > Also, the problem with issuing 'cont' when the VM is in bad state is > addressed, > and we make the current state available in QMP. Looks pretty good to me.

Re: [Qemu-devel] [Qemu-trivial] [PATCH] scsi-bus: use DO_UPCAST.

2011-08-04 Thread Stefan Hajnoczi
On Thu, Aug 04, 2011 at 03:40:35PM +0800, Zhi Yong Wu wrote: > Signed-off-by: Zhi Yong Wu > --- > hw/scsi-bus.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches-nex

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/qdev: Don't crash if qdev_create(NULL, ...) fails

2011-08-04 Thread Stefan Hajnoczi
On Wed, Aug 03, 2011 at 11:49:04PM +0100, Peter Maydell wrote: > If an attempt to create a qdev device on the default sysbus (by passing > NULL as the bus to qdev_create) fails, print a useful error message > rather than crashing trying to dereference a NULL pointer. > > Signed-off-by: Peter Mayde

Re: [Qemu-devel] [PATCH v2 0/5]: QMP: Proper thin provisioning support

2011-08-04 Thread Markus Armbruster
Kevin Wolf writes: > Am 03.08.2011 20:08, schrieb Luiz Capitulino: >> On Wed, 03 Aug 2011 17:39:04 +0200 >> Kevin Wolf wrote: >> >>> Am 03.08.2011 17:19, schrieb Luiz Capitulino: Roughly speaking, thin provisioning is a feature where the VM is started with a small disk and space

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-08-04 Thread Supriya Kannery
On 08/04/2011 02:01 PM, Stefan Hajnoczi wrote: On Thu, Aug 4, 2011 at 9:32 AM, Supriya Kannery wrote: On 08/01/2011 09:14 PM, Anthony Liguori wrote: On 08/01/2011 10:44 AM, Kevin Wolf wrote: Am 01.08.2011 17:28, schrieb Anthony Liguori: 2. Top-level command for each parameter (e.g. block_se

Re: [Qemu-devel] ethlite mac on virtex board

2011-08-04 Thread Lê Đức Tài
On Aug 08, 2011 15:13, "Lê Đức Tài" wrote: > Hi Edgar, > I have a problem with Ethernet Lite on Virtex board as following. > Could you help me? > Thank you! Hi, I have just successful configured the Ethernet Lite :). Th

Re: [Qemu-devel] [PATCH v3] XBZRLE delta for live migration of large memory apps

2011-08-04 Thread Shribman, Aidan
> From: Anthony Liguori [mailto:anth...@codemonkey.ws] > Sent: Tuesday, August 02, 2011 6:01 PM > To: Alexander Graf > Cc: Shribman, Aidan; Kevin Wolf; Stefan Hajnoczi; qemu-devel > Developers > Subject: Re: [Qemu-devel] [PATCH v3] XBZRLE delta for live > migration of large memory apps > > On 0

Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify "drive is suitable for microdrive" test

2011-08-04 Thread Markus Armbruster
andrzej zaborowski writes: > On 3 August 2011 20:24, Markus Armbruster wrote: >> andrzej zaborowski writes: >>> On 3 August 2011 18:38, Markus Armbruster wrote: andrzej zaborowski writes: >                                                      2. if the > underlaying storage can d

Re: [Qemu-devel] [PATCH v2 27/45] scsi-disk: Preserve tray state on migration

2011-08-04 Thread Kevin Wolf
Am 04.08.2011 08:23, schrieb Hannes Reinecke: > On 08/03/2011 03:08 PM, Markus Armbruster wrote: >> Breaks migration of qdevs "scsi-cd" and legacy "scsi-disk" to older >> versions. We normally use subsections to avoid that. Not possible >> here, because we don't have a section to begin with. Too

Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type

2011-08-04 Thread Avi Kivity
On 08/03/2011 06:17 PM, Luiz Capitulino wrote: @@ -9,6 +9,20 @@ #include "notify.h" /* vl.c */ + +typedef enum { +QSTATE_DEBUG, /* qemu is running under gdb */ +QSTATE_INTERROR, /* paused due to an internal error */ +QSTATE_IOERROR, /* paused due to an I/O erro

[Qemu-devel] [PATCH 0/2] Support for i_generation / st_gen in 9p server

2011-08-04 Thread Harsh Prateek Bora
This patch series provide support for i_generation / st_gen in 9p server. First patch provide support for local fs type, second patch adds support for handle based fs driver. Harsh Prateek Bora (2): i_generation / st_gen support for local fs type i_generation / st_gen support for handle based

[Qemu-devel] [PATCH 2/2] i_generation / st_gen support for handle based fs driver

2011-08-04 Thread Harsh Prateek Bora
This patch provides support for st_gen for handle based fs type server. Currently the support is provided for ext4, btrfs, reiserfs and xfs. Signed-off-by: Harsh Prateek Bora --- hw/9pfs/virtio-9p-handle.c | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 1/2] i_generation / st_gen support for local fs type

2011-08-04 Thread Harsh Prateek Bora
This patch provides support for st_gen for local fs type server. Currently the support is provided for ext4, btrfs, reiserfs and xfs. Signed-off-by: Harsh Prateek Bora --- fsdev/file-op-9p.h |7 +++ hw/9pfs/cofile.c | 22 ++ hw/9pfs/virtio-9p-coth.

Re: [Qemu-devel] [PATCH 2/3] target-mips:Adding Octeon cpu definitions

2011-08-04 Thread Peter Maydell
I'm not a MIPS expert, but some attempt at review anyway... On 5 July 2011 10:19, wrote: > diff --git a/target-mips/mips-defs.h b/target-mips/mips-defs.h > index bf094a3..6fec935 100644 > --- a/target-mips/mips-defs.h > +++ b/target-mips/mips-defs.h > @@ -44,6 +44,7 @@ >  #define                

Re: [Qemu-devel] [PATCH 1/2] i_generation / st_gen support for local fs type

2011-08-04 Thread Stefan Hajnoczi
On Thu, Aug 4, 2011 at 11:06 AM, Harsh Prateek Bora wrote: > +static int local_ioc_getversion(FsContext *ctx, V9fsPath *path, uint64_t > *st_gen) > +{ > +    int mode = 0600; > +    int fd; > + > +    fd = local_open(ctx, path, mode); > +    if(fd < 0) { > +        return fd; > +    } > +    retu

Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type

2011-08-04 Thread Jan Kiszka
On 2011-08-04 11:55, Avi Kivity wrote: > On 08/03/2011 06:17 PM, Luiz Capitulino wrote: >> @@ -9,6 +9,20 @@ >> #include "notify.h" >> >> /* vl.c */ >> + >> +typedef enum { >> +QSTATE_DEBUG, /* qemu is running under gdb */ >> +QSTATE_INTERROR, /* paused due to an internal er

Re: [Qemu-devel] [PATCH 2/2] i_generation / st_gen support for handle based fs driver

2011-08-04 Thread Stefan Hajnoczi
On Thu, Aug 4, 2011 at 11:06 AM, Harsh Prateek Bora wrote: > This patch provides support for st_gen for handle based fs type server. > Currently the support is provided for ext4, btrfs, reiserfs and xfs. > > Signed-off-by: Harsh Prateek Bora > --- >  hw/9pfs/virtio-9p-handle.c |   30

Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type

2011-08-04 Thread Jan Kiszka
On 2011-08-04 12:17, Jan Kiszka wrote: > On 2011-08-04 11:55, Avi Kivity wrote: >> On 08/03/2011 06:17 PM, Luiz Capitulino wrote: >>> @@ -9,6 +9,20 @@ >>> #include "notify.h" >>> >>> /* vl.c */ >>> + >>> +typedef enum { >>> +QSTATE_DEBUG, /* qemu is running under gdb */ >>> +QST

Re: [Qemu-devel] [PATCH v2 2/6] VMDK: add twoGbMaxExtentSparse support

2011-08-04 Thread Stefan Hajnoczi
On Thu, Aug 4, 2011 at 4:09 AM, Fam Zheng wrote: > +static void vmdk_free_last_extent(BlockDriverState *bs) > +{ > +    BDRVVmdkState *s = bs->opaque; > + > +    if (s->num_extents == 0) { > +        return; > +    } > +    s->num_extents--; > +    s->extents = qemu_realloc(s->extents, s->num_exte

Re: [Qemu-devel] [PATCH] PPC: Fix sync instructions problem in SMP

2011-08-04 Thread Elie Richa
bump. Anybody have opinions on this? I can provide a more thorough explanation of the problem if needed. I wrote the test case in Ada for an MPC8641D processor (2 e600 cores) on a board that is not yet submitted to the list, therefore I cannot provide a ready to run binary. I can submit my boa

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-04 Thread Joerg Roedel
On Sat, Jul 30, 2011 at 12:20:08PM -0600, Alex Williamson wrote: > On Sat, 2011-07-30 at 09:58 +1000, Benjamin Herrenschmidt wrote: > > - The -minimum- granularity of pass-through is not always a single > > device and not always under SW control > > But IMHO, we need to preserve the granularity of

Re: [Qemu-devel] [PATCH 2/6] VMDK: add twoGbMaxExtentSparse support

2011-08-04 Thread Stefan Hajnoczi
On Thu, Aug 4, 2011 at 3:35 AM, Fam Zheng wrote: > On Tue, Aug 2, 2011 at 6:32 PM, Stefan Hajnoczi wrote: >> On Wed, Jul 27, 2011 at 10:27 AM, Fam Zheng wrote: >>> Add twoGbMaxExtentSparse support. Only opening code is changed. >>> >>> Signed-off-by: Fam Zheng >>> --- >>>  block/vmdk.c |  124

Re: [Qemu-devel] [PATCH v2 2/6] VMDK: add twoGbMaxExtentSparse support

2011-08-04 Thread Fam Zheng
On Thu, Aug 4, 2011 at 6:34 PM, Stefan Hajnoczi wrote: > On Thu, Aug 4, 2011 at 4:09 AM, Fam Zheng wrote: >> +static void vmdk_free_last_extent(BlockDriverState *bs) >> +{ >> +    BDRVVmdkState *s = bs->opaque; >> + >> +    if (s->num_extents == 0) { >> +        return; >> +    } >> +    s->num_e

Re: [Qemu-devel] [PATCH v2 1/2] block: set cache mode flags in a single place

2011-08-04 Thread Christoph Hellwig
On Thu, Aug 04, 2011 at 09:46:33AM +0100, Stefan Hajnoczi wrote: > +/** > + * Set open flags for a given cache mode > + * > + * Return 0 on success, -1 if the cache mode was invalid. > + */ > +int bdrv_set_cache_flags(const char *mode, int *flags) I would call this bdrv_parse_cache_flags.

Re: [Qemu-devel] [PATCH v2 2/6] VMDK: add twoGbMaxExtentSparse support

2011-08-04 Thread Stefan Hajnoczi
On Thu, Aug 4, 2011 at 11:38 AM, Fam Zheng wrote: > On Thu, Aug 4, 2011 at 6:34 PM, Stefan Hajnoczi wrote: >> On Thu, Aug 4, 2011 at 4:09 AM, Fam Zheng wrote: >>> +static void vmdk_free_last_extent(BlockDriverState *bs) >>> +{ >>> +    BDRVVmdkState *s = bs->opaque; >>> + >>> +    if (s->num_ext

Re: [Qemu-devel] [PATCH 2/2] i_generation / st_gen support for handle based fs driver

2011-08-04 Thread Aneesh Kumar K.V
On Thu, 4 Aug 2011 11:21:05 +0100, Stefan Hajnoczi wrote: > On Thu, Aug 4, 2011 at 11:06 AM, Harsh Prateek Bora > wrote: > > This patch provides support for st_gen for handle based fs type server. > > Currently the support is provided for ext4, btrfs, reiserfs and xfs. > > > > Signed-off-by: Hars

Re: [Qemu-devel] [PATCH 3/3] target-mips:Support for Cavium specific instructions

2011-08-04 Thread Peter Maydell
On 5 July 2011 10:19, wrote: > --- >  host-utils.c            |    1 + >  target-mips/cpu.h       |    7 + >  target-mips/helper.h    |    5 + >  target-mips/op_helper.c |   67 +++ >  target-mips/translate.c |  443 > ++- >  5 files changed, 514 ins

[Qemu-devel] [PATCH v3 2/2] block: add cache=directsync parameter to -drive

2011-08-04 Thread Stefan Hajnoczi
This patch adds -drive cache=directsync for O_DIRECT | O_SYNC host file I/O with no disk write cache presented to the guest. This mode is useful when guests may not be sending flushes when appropriate and therefore leave data at risk in case of power failure. When cache=directsync is used, write o

[Qemu-devel] [PATCH v3 1/2] block: parse cache mode flags in a single place

2011-08-04 Thread Stefan Hajnoczi
This patch introduces bdrv_parse_cache_flags() which sets open flags given a cache mode. Previously this was duplicated in blockdev.c and qemu-img.c. Signed-off-by: Stefan Hajnoczi --- v3: * Renamed bdrv_set_cache_flags() to bdrv_parse_cache_flags() [Christoph Hellwig] block.c| 25

Re: [Qemu-devel] [PATCH v2 1/2] block: set cache mode flags in a single place

2011-08-04 Thread Stefan Hajnoczi
On Thu, Aug 4, 2011 at 12:14 PM, Christoph Hellwig wrote: > On Thu, Aug 04, 2011 at 09:46:33AM +0100, Stefan Hajnoczi wrote: >> +/** >> + * Set open flags for a given cache mode >> + * >> + * Return 0 on success, -1 if the cache mode was invalid. >> + */ >> +int bdrv_set_cache_flags(const char *mo

Re: [Qemu-devel] [PATCH 2/2] i_generation / st_gen support for handle based fs driver

2011-08-04 Thread Stefan Hajnoczi
On Thu, Aug 4, 2011 at 12:20 PM, Aneesh Kumar K.V wrote: > On Thu, 4 Aug 2011 11:21:05 +0100, Stefan Hajnoczi wrote: >> On Thu, Aug 4, 2011 at 11:06 AM, Harsh Prateek Bora >> wrote: >> > This patch provides support for st_gen for handle based fs type server. >> > Currently the support is provide

Re: [Qemu-devel] [Bug 816370] Re: compile error in QEMU 0.15.0-rc0 and 0.15.0-rc1

2011-08-04 Thread Gerd Hoffmann
On 08/04/11 10:54, Alon Levy wrote: On Thu, Aug 04, 2011 at 08:33:21AM -, Marcel Hnilka wrote: Well, I tried to build it with your configuration. It ended with the same result as I posted, but I found that building was successfull with option --disable-spice. Sould you try to build it with

Re: [Qemu-devel] [PATCH 2/2] i_generation / st_gen support for handle based fs driver

2011-08-04 Thread Aneesh Kumar K.V
On Thu, 4 Aug 2011 12:47:42 +0100, Stefan Hajnoczi wrote: > On Thu, Aug 4, 2011 at 12:20 PM, Aneesh Kumar K.V > wrote: > > On Thu, 4 Aug 2011 11:21:05 +0100, Stefan Hajnoczi > > wrote: > >> On Thu, Aug 4, 2011 at 11:06 AM, Harsh Prateek Bora > >> wrote: > >> > This patch provides support for s

Re: [Qemu-devel] [PATCH 3/7] QemuState: Add additional states

2011-08-04 Thread Kevin Wolf
Am 04.08.2011 11:02, schrieb Markus Armbruster: > Luiz Capitulino writes: > >> Currently, only vm_start() and vm_stop() change the VM state. That's, >> the state is only changed when starting or stopping the VM. >> >> This commit adds the qemu_state_set() function, making it possible >> to also d

Re: [Qemu-devel] [PATCH] migration: remove subsections in fdc and rtl8139 and bump versions

2011-08-04 Thread Kevin Wolf
Am 03.08.2011 23:42, schrieb Juan Quintela: > Anthony Liguori wrote: >> On 08/03/2011 04:00 AM, Juan Quintela wrote: > >> I don't have a problem with Paolo's new protocol. In fact, I'm strong >> in favor of applying it to master. But I don't like the idea of >> adding a new migration protocol w

[Qemu-devel] [PATCH v3 02/39] pci: add API to get a BAR's mapped address

2011-08-04 Thread Avi Kivity
This is a hack, for devices that have a back-channel to read this address back outside the normal configuration mechanisms, such as VMware svga. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/pci.c |5 + hw/pci.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-

[Qemu-devel] [PATCH v3 24/39] ppc: convert to memory API

2011-08-04 Thread Avi Kivity
Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/cuda.c |6 ++- hw/escc.c | 42 +-- hw/escc.h |2 +- hw/heathrow_pic.c | 29 -- hw/ide.h |2 +- hw/ide/macio.c| 36 ---

[Qemu-devel] [PATCH v3 12/39] pci: allow I/O BARs to be registered with pci_register_bar_region()

2011-08-04 Thread Avi Kivity
Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/pci.c | 43 +++ hw/pci.h |1 + hw/pci_internals.h |3 ++- 3 files changed, 26 insertions(+), 21 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 2659d96..9808

[Qemu-devel] [PATCH v3 17/39] es1370: convert to memory API

2011-08-04 Thread Avi Kivity
Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/es1370.c | 43 +-- 1 files changed, 25 insertions(+), 18 deletions(-) diff --git a/hw/es1370.c b/hw/es1370.c index 1ed62b7..6a01797 100644 --- a/hw/es1370.c +++ b/hw/es1370.c @@ -268,6 +268

[Qemu-devel] [PATCH v3 34/39] pci: remove pci_register_bar_simple()

2011-08-04 Thread Avi Kivity
Reviewed-by: Richard Henderson Superceded by pci_register_bar_region(). --- hw/pci.c | 17 - hw/pci.h |3 --- 2 files changed, 0 insertions(+), 20 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 980840f..6aca1af 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -903,7 +903,6 @@ v

[Qemu-devel] [PATCH v3 04/39] vga: convert vga and its derivatives to the memory API

2011-08-04 Thread Avi Kivity
Convert all vga memory to the memory API. Note we need to fall back to get_system_memory(), since the various buses don't pass the vga window as a memory region. We no longer need to sync the dirty bitmap of the cirrus mapped memory banks, since the memory API takes care of that for us. [jan: fi

[Qemu-devel] [PATCH v3 18/39] ide: convert to memory API

2011-08-04 Thread Avi Kivity
Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/ide/cmd646.c | 208 +++ hw/ide/pci.c| 25 --- hw/ide/pci.h| 19 - hw/ide/piix.c | 64 + hw/ide/via.c| 65 + 5 files c

Re: [Qemu-devel] [PATCH] migration: remove subsections in fdc and rtl8139 and bump versions

2011-08-04 Thread Anthony Liguori
On 08/04/2011 07:59 AM, Kevin Wolf wrote: Am 03.08.2011 23:42, schrieb Juan Quintela: Anthony Liguori wrote: On 08/03/2011 04:00 AM, Juan Quintela wrote: I don't have a problem with Paolo's new protocol. In fact, I'm strong in favor of applying it to master. But I don't like the idea of a

Re: [Qemu-devel] [PATCH 00/12][RFC] char: add flow control and fix guest_[open|close]

2011-08-04 Thread Anthony Liguori
On 08/04/2011 01:45 AM, Amit Shah wrote: On (Mon) 01 Aug 2011 [09:22:58], Anthony Liguori wrote: The char layer has been growing some nasty warts for some time now as we ask it to do things it was never intended on doing. It's been long over due for an overhaul and its become evident to me that

Re: [Qemu-devel] [PATCH] migration: remove subsections in fdc and rtl8139 and bump versions

2011-08-04 Thread Anthony Liguori
On 08/04/2011 02:22 AM, Paolo Bonzini wrote: On 08/03/2011 11:42 PM, Juan Quintela wrote: > I can certainly limit the change to IDE if we think machine, floppy, > and rtl8139 are safe. Ok, only IDE is broken, something done if we are not reverting the others. Floppy is broken too, and has the

Re: [Qemu-devel] [PATCH 3/7] QemuState: Add additional states

2011-08-04 Thread Anthony Liguori
On 08/04/2011 07:32 AM, Kevin Wolf wrote: Am 04.08.2011 11:02, schrieb Markus Armbruster: Luiz Capitulino writes: Currently, only vm_start() and vm_stop() change the VM state. That's, the state is only changed when starting or stopping the VM. This commit adds the qemu_state_set() function,

[Qemu-devel] [PATCH v3 00/39] Memory API, batch 2: PCI devices

2011-08-04 Thread Avi Kivity
This is a mostly mindless conversion of all QEMU PCI devices to the memory API. After this patchset is applied, it is no longer possible to create a PCI device using the old API. An immediate benefit is that PCI BARs that overlap each other are now handled correctly: currently, the sequence map

Re: [Qemu-devel] [PATCH] xen-mapcache: Fix rlimit set size.

2011-08-04 Thread Anthony PERARD
On Tue, Aug 2, 2011 at 15:50, Alexander Graf wrote: > On 08/01/2011 09:26 PM, Anthony PERARD wrote: >> >> Previously, the address space soft limit was set mcache_max_size. So, >> before the mcache_max_size was reached by the mapcache, QEMU was killed >> for overuse of the virtual address space. >>

[Qemu-devel] [PATCH v3 35/39] pci: convert pci rom to memory API

2011-08-04 Thread Avi Kivity
Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/pci.c | 20 +++- hw/pci.h |3 ++- 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 6aca1af..481eb7e 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -1857,11 +1857,6 @@ static ui

Re: [Qemu-devel] [PATCH 01/16] scsi-disk: no need to call scsi_req_data on a short read

2011-08-04 Thread Stefan Hajnoczi
On Wed, Aug 3, 2011 at 9:49 AM, Paolo Bonzini wrote: > In fact, if the HBA's transfer_data callback goes on with scsi_req_continue > the request will be completed successfully instead of showing a failure. > It can even cause a segmentation fault. > > An easy way to trigger it is "eject -f cd" dur

[Qemu-devel] [PATCH v3 37/39] pci: fold BAR mapping function into its caller

2011-08-04 Thread Avi Kivity
There is only one function, so no need for a function pointer. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/pci.c | 25 + hw/pci.h |1 - 2 files changed, 9 insertions(+), 17 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index e9e4874..e6a759a 10

[Qemu-devel] [PATCH v3 27/39] i6300esb: convert to memory API

2011-08-04 Thread Avi Kivity
Also add missing destructor. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/wdt_i6300esb.c | 43 +-- 1 files changed, 29 insertions(+), 14 deletions(-) diff --git a/hw/wdt_i6300esb.c b/hw/wdt_i6300esb.c index 53786ce..abc2e17 100644 --

Re: [Qemu-devel] [PATCH v2 0/5]: QMP: Proper thin provisioning support

2011-08-04 Thread Luiz Capitulino
On Thu, 04 Aug 2011 11:19:31 +0200 Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 03.08.2011 20:08, schrieb Luiz Capitulino: > >> On Wed, 03 Aug 2011 17:39:04 +0200 > >> Kevin Wolf wrote: > >> > >>> Am 03.08.2011 17:19, schrieb Luiz Capitulino: > Roughly speaking, thin provisioni

[Qemu-devel] [PATCH v3 31/39] uhci: convert to memory API

2011-08-04 Thread Avi Kivity
Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/usb-uhci.c | 42 -- 1 files changed, 28 insertions(+), 14 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index da74c57..96a17bd 100644 --- a/hw/usb-uhci.c +++ b/hw/usb-uhci.c @@ -1

[Qemu-devel] Device Configuration

2011-08-04 Thread Nilay Vaish
Hello Is it possible to configure the set of devices that are emulated when a virtual machine is spawned? In particular, I am looking whether is it possible to create only one DMA controller. The code in file hw/dma.c is creates two DMA controllers. One way would be to just re-write that code

Re: [Qemu-devel] [PATCH 01/16] scsi-disk: no need to call scsi_req_data on a short read

2011-08-04 Thread Kevin Wolf
Am 04.08.2011 15:35, schrieb Stefan Hajnoczi: > On Wed, Aug 3, 2011 at 9:49 AM, Paolo Bonzini wrote: >> In fact, if the HBA's transfer_data callback goes on with scsi_req_continue >> the request will be completed successfully instead of showing a failure. >> It can even cause a segmentation fault.

[Qemu-devel] [PATCH v3 09/39] cirrus: simplify linear framebuffer access functions

2011-08-04 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 74 ++- 1 files changed, 8 insertions(+), 66 deletions(-)

[Qemu-devel] [PATCH v3 11/39] pci: pass I/O address space to new PCI bus

2011-08-04 Thread Avi Kivity
This lets us register BARs in the I/O address space. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/apb_pci.c |1 + hw/bonito.c|1 + hw/grackle_pci.c |8 ++-- hw/gt64xxx.c |4 +++- hw/pc.h|4 +++- hw/pc_piix.c |

Re: [Qemu-devel] [PATCH 3/7] QemuState: Add additional states

2011-08-04 Thread Luiz Capitulino
On Thu, 04 Aug 2011 11:02:06 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Currently, only vm_start() and vm_stop() change the VM state. That's, > > the state is only changed when starting or stopping the VM. > > > > This commit adds the qemu_state_set() function, making it pos

[Qemu-devel] [PATCH v3 03/39] vmsvga: don't remember pci BAR address in callback any more

2011-08-04 Thread Avi Kivity
We're going to remove the callback, so we can't use it to save the address. Use the pci API instead. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/vmware_vga.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.

Re: [Qemu-devel] [PATCH v1] qmp/hmp: add block_set_io_throttle and enhance query_block

2011-08-04 Thread Stefan Hajnoczi
On Thu, Aug 4, 2011 at 5:34 AM, Zhi Yong Wu wrote: > @@ -1387,6 +1422,11 @@ void bdrv_set_io_limits(BlockDriverState *bs, >  { >     memset(&bs->io_limits, 0, sizeof(BlockIOLimit)); >     bs->io_limits = *io_limits; > +    if (bdrv_io_limits_enabled(bs)) { > +        bs->io_limits_enabled = true;

Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type

2011-08-04 Thread Luiz Capitulino
On Thu, 04 Aug 2011 12:17:55 +0200 Jan Kiszka wrote: > On 2011-08-04 11:55, Avi Kivity wrote: > > On 08/03/2011 06:17 PM, Luiz Capitulino wrote: > >> @@ -9,6 +9,20 @@ > >> #include "notify.h" > >> > >> /* vl.c */ > >> + > >> +typedef enum { > >> +QSTATE_DEBUG, /* qemu is running u

Re: [Qemu-devel] [PATCH] migration: remove subsections in fdc and rtl8139 and bump versions

2011-08-04 Thread Kevin Wolf
Am 04.08.2011 15:20, schrieb Anthony Liguori: > On 08/04/2011 02:22 AM, Paolo Bonzini wrote: >> On 08/03/2011 11:42 PM, Juan Quintela wrote: I can certainly limit the change to IDE if we think machine, floppy, and rtl8139 are safe. >>> >>> Ok, only IDE is broken, something done if we are

[Qemu-devel] [PATCH v3 30/39] ehci: convert to memory API

2011-08-04 Thread Avi Kivity
Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/usb-ehci.c | 36 +--- 1 files changed, 9 insertions(+), 27 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index 8b0dcc3..025ed1f 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -368,8 +3

[Qemu-devel] [PATCH v3 06/39] cirrus: simplify bitblt BAR access functions

2011-08-04 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 81 +-- 1 files changed, 13 insertions(+), 68 deletions(-)

[Qemu-devel] [PATCH v3 08/39] vga: simplify vga window mmio access functions

2011-08-04 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. We have to keep vga_mem_{read,write}b() since they're used by cirrus. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/cirrus_vga.c |4 +- hw/vga.c| 56 +++---

[Qemu-devel] [BUG] Qcow2 corruption on snapshot revert

2011-08-04 Thread Philipp Hahn
Hello, it seems like I have discovered a bug in qemu-0.14.1 which corrupts Qcow2 image files when using internal snapshots. I tied this both on an amd64 host running our Debian bases UCS distribution (using pure qemu-kvm_0.14 and pure qemu-kvm_0.14.1) and also on a pure Debian i386 sid installa

[Qemu-devel] [PATCH v3 29/39] sun4u: convert to memory API

2011-08-04 Thread Avi Kivity
fixes memory leak on repeated BAR map/unmap Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/sun4u.c | 55 +-- 1 files changed, 25 insertions(+), 30 deletions(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index d7dcaf0..74a06a8 100

[Qemu-devel] [PATCH v3 15/39] e1000: convert to memory API

2011-08-04 Thread Avi Kivity
Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/e1000.c | 114 +-- 1 files changed, 48 insertions(+), 66 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index 96d84f9..dfc082b 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@

[Qemu-devel] [PATCH v3 32/39] xen-platform: convert to memory API

2011-08-04 Thread Avi Kivity
Since this device bypasses PCI and registers I/O ports directly with the system bus, it needs further attention. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/xen_platform.c | 84 - 1 files changed, 51 insertions(+), 33 del

[Qemu-devel] [PATCH v3 33/39] msix: convert to memory API

2011-08-04 Thread Avi Kivity
The msix table is defined as a subregion, to allow for a BAR that mixes device specific regions with the msix table. Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/ivshmem.c| 11 + hw/msix.c | 64 +++ hw/

[Qemu-devel] [PATCH v3 20/39] virtio-pci: convert to memory API

2011-08-04 Thread Avi Kivity
except msix. [jan: fix build] Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/virtio-pci.c | 71 +++--- hw/virtio-pci.h |2 +- 2 files changed, 31 insertions(+), 42 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.

Re: [Qemu-devel] [PATCH] migration: remove subsections in fdc and rtl8139 and bump versions

2011-08-04 Thread Anthony Liguori
On 08/04/2011 09:09 AM, Kevin Wolf wrote: Am 04.08.2011 15:20, schrieb Anthony Liguori: On 08/04/2011 02:22 AM, Paolo Bonzini wrote: On 08/03/2011 11:42 PM, Juan Quintela wrote: I can certainly limit the change to IDE if we think machine, floppy, and rtl8139 are safe. Ok, only IDE is broken,

  1   2   3   >