On Thu, Aug 4, 2011 at 12:20 PM, Aneesh Kumar K.V <aneesh.ku...@linux.vnet.ibm.com> wrote: > On Thu, 4 Aug 2011 11:21:05 +0100, Stefan Hajnoczi <stefa...@gmail.com> wrote: >> On Thu, Aug 4, 2011 at 11:06 AM, Harsh Prateek Bora >> <ha...@linux.vnet.ibm.com> wrote: >> > This patch provides support for st_gen for handle based fs type server. >> > Currently the support is provided for ext4, btrfs, reiserfs and xfs. >> > >> > Signed-off-by: Harsh Prateek Bora <ha...@linux.vnet.ibm.com> >> > --- >> > hw/9pfs/virtio-9p-handle.c | 30 ++++++++++++++++++++++++++++++ >> > 1 files changed, 30 insertions(+), 0 deletions(-) >> >> Does handle-based file I/O really need to duplicate all this code? Is >> it possible to use either regular open or handle-based open from a >> single local fs codebase? > > The only details common between handle based and local based getversion > callback is the ioctl. Moving that into a helper may not really help in > this case ?.
Aneesh, do you have a public virtfs tree that I can look at? In qemu.git we don't have virtio-9p-handle.c yet, so I can't give any specific feedback. Stefan
