Hello, colleagues,
On 4/29/11, Dmitry Eremin-Solenikov wrote:
> Hello,
>
> Any chance to get any response for this patches serie?
Still no response at all. Is there anything wrong with my approach? Is there
any problem with patch format? Am I just being ignored?
> On 4/25/11, Dmitry Eremin-Sole
Hi, all
I have built cross toolchain for arm , but I cannot cross compile QEMU
qemu version: qemu-0.14.0
cross-compiler: arm-2007q3 (arm-none-linux-gnueabi)
The cross compiler I used is downloaded from:
http://www.codesourcery.com/
The following are my steps:
1. bel
Am Dienstag, 3. Mai 2011, 11:13:35 schrieb 李柏舉:
> arm-2007q3
Try a newer cross-compiler please and then report back.
Best,
Jan-Simon
Gleb Natapov wrote:
> On Thu, Apr 07, 2011 at 04:39:58PM -0500, Anthony Liguori wrote:
> > On 04/07/2011 01:51 PM, Gleb Natapov wrote:
> > >NMI does not have to generate crash dump on every guest we support.
> > >Actually even for windows guest it does not generate one without
> > >tweaking registr
Blue Swirl wrote:
> On Fri, Apr 8, 2011 at 9:04 AM, Gleb Natapov wrote:
> > On Thu, Apr 07, 2011 at 04:41:03PM -0500, Anthony Liguori wrote:
> >> On 04/07/2011 02:17 PM, Gleb Natapov wrote:
> >> >On Thu, Apr 07, 2011 at 10:04:00PM +0300, Blue Swirl wrote:
> >> >>On Thu, Apr 7, 2011 at 9:51 PM, Gle
On 02.05.2011, at 20:00, Jan Kiszka wrote:
> msi_init may fail, so we need to check on uninit if the cap was
> actually installed. This also avoids that the users need to check.
>
> Signed-off-by: Jan Kiszka
Looks good to me.
Acked-by: Alexander Graf
Alex
On 01.05.2011, at 18:31, Andreas Färber wrote:
> Someone on Linux should check if a similar patch is necessary for roms/SLOF/:
Mind to just send a patch I can try out with some instruction on how to trigger
this? :)
Alex
Please send in any agenda items you are interested in covering.
Later, Juan.
On 11.04.2011, at 18:15, Scott Wood wrote:
> On Sat, 9 Apr 2011 02:18:34 +0200
> Alexander Graf wrote:
>
>>> -int kvm_arch_init_vcpu(CPUState *cenv)
>>> +static int kvm_arch_sync_sregs(CPUState *cenv)
>>
>> huh? So what about the previous caller of this?
>
> It's a new function. kvm_arch_ini
On 30.04.2011, at 00:10, Scott Wood wrote:
> Read them via KVM_GET_SREGS in kvm_arch_get_registers(),
> and display them in "info registers".
>
> Also get CR and PID from the existing KVM_GET_REGS.
>
> Signed-off-by: Scott Wood
Nice patch :)
Alex
On 30.04.2011, at 00:10, Scott Wood wrote:
> Read them via KVM_GET_SREGS in kvm_arch_get_registers(),
> and display them in "info registers".
>
> Also get CR and PID from the existing KVM_GET_REGS.
>
> Signed-off-by: Scott Wood
cc1: warnings being treated as errors
/home/agraf/release/qemu/ta
On Thu, Apr 28, 2011 at 4:20 PM, wrote:
> From: Nick Thomas
>
> Signed-off-by: Nick Thomas
> ---
> block/nbd.c | 4
> 1 files changed, 4 insertions(+), 0 deletions(-)
Reviewed-by: Stefan Hajnoczi
---
target-i386/kvm.c |4 ++--
tcg/tcg.c |4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index a13599d..e9e8d54 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -950,7 +950,7 @@ static int kvm_get_xsave(CPUState
On 30.04.2011, at 00:10, Scott Wood wrote:
> Read them via KVM_GET_SREGS in kvm_arch_get_registers(),
> and display them in "info registers".
>
> Also get CR and PID from the existing KVM_GET_REGS.
>
> Signed-off-by: Scott Wood
> ---
> v2: fix a couple style oversights, and cache kvm caps as r
From: Amit Shah
Move misplaced comment for media_is_dvd()
Signed-off-by: Amit Shah
Signed-off-by: Kevin Wolf
---
hw/ide/atapi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
index 690a0ab..86b18d8 100644
--- a/hw/ide/atapi.c
+++ b/hw
For shrinking images, you're supposed to use a negative size. However, the
leading minus makes getopt think that it's an option and so you get the help
text if you don't use -- like in 'qemu-img resize test.img -- -1G'.
This patch handles the size first and removes it from the argument list so tha
The following changes since commit 57aa265d462a64a06268be26d49020729cff56c1:
lm32: add Milkymist Minimac2 support (2011-05-03 10:48:40 +0200)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git for-anthony
Alon Levy (1):
ide/atapi: fix set but unused
Amit Shah (2):
From: Jes Sorensen
Change the signal handling to indicate a signal is pending, rather
then printing directly from the signal handler.
In addition make the signal prints go to stderr, rather than stdout.
Signed-off-by: Jes Sorensen
Signed-off-by: Kevin Wolf
---
qemu-progress.c |7 ++-
From: Alon Levy
Signed-off-by: Alon Levy
Acked-by: Stefan Weil
Signed-off-by: Kevin Wolf
---
hw/ide/atapi.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
index 58febc0..fe2fb0b 100644
--- a/hw/ide/atapi.c
+++ b/hw/ide/atapi.c
@@ -1
From: Amit Shah
After the re-org of the atapi code, it might not be intuitive for a
reader of the code to understand why we're inserting a 'media not
present' state between cd changes.
Signed-off-by: Amit Shah
Signed-off-by: Kevin Wolf
---
hw/ide/atapi.c |8 +++-
1 files changed, 7 in
From: Nick Thomas
Signed-off-by: Nick Thomas
Signed-off-by: Kevin Wolf
---
block/nbd.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index 1d6b225..7a52f62 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -239,6 +239,10 @@ static int nbd_wri
On Fri, Apr 29, 2011 at 10:06 AM, Kevin Wolf wrote:
> For shrinking images, you're supposed to use a negative size. However, the
> leading minus makes getopt think that it's an option and so you get the help
> text if you don't use -- like in 'qemu-img resize test.img -- -1G'.
>
> This patch handl
Hi,
When enabling the -device usb-host option support for adding
automatically USB devices from the host to the guest, only one device
gets detected.
Yes. -device usb-host creates a *single* virtual usb device instance.
When a matching device on the host is found the virtual device is
plu
I have made following changes
addr = env->lladdr;
addr &= qemu_host_page_mask;
page_addr = addr & TARGET_PAGE_MASK;
start_exclusive();
mmap_lock();
flags = page_get_flags(page_addr);
now return to elfload.c
I have a simple hello world mips64 binary for which I have two loadable
segments
so fol
On 04/29/11 15:45, Anthony Liguori wrote:
> On 04/29/2011 08:38 AM, Jes Sorensen wrote:
>> It is exactly the same for the management tool:
>> - Creation of the new image either succeeds or fails
>> - Switchover either succeeds or fails
>
> Creating an image can be treated as an atomic operation.
When compiling Qemu with older kernel headers, the PVR setting
mechanism isn't available yet. Unfortunately, back then I didn't add
a capability we could check against, so all we can do is add a configure
test to see if we support PVR setting. For BookE, we don't care yet.
This fixes compilation e
On PPC, the default PAGE_SIZE is 64kb. Unfortunately, the hardware
alignments don't match here: There are RAM and MMIO regions within
a single page when it's 64kb in size.
So the only way out for now is to tell the user that he should use 4k
PAGE_SIZE.
This patch gives the user a hint on that, te
This patchset resurrects my older patches to add TRIM support. The
old approach to pass an action handler through the IDE subsystem doesn't
work any more after the refactoring for the AHCI driver, so not we simple
switch on the type of command passed in.
Make dma_bdrv_io available for drivers, and pass an explicit I/O function
instead of hardcoding bdrv_aio_readv/bdrv_aio_writev. This is required
to implement non-READ/WRITE dma commands in the ide driver, e.g. the
upcoming TRIM support.
Signed-off-by: Christoph Hellwig
Index: qemu/dma-helpers.c
Replace the is_read flag with a dma_cmd flag to allow the dma and
restart logic to handler other commands like TRIM.
Signed-off-by: Christoph Hellwig
Index: qemu/hw/ide/core.c
===
--- qemu.orig/hw/ide/core.c 2011-05-03 11:32:14.
Add support for TRIM sub function of the data set management command,
and wire it up to the qemu discard infrastructure.
Signed-off-by: Christoph Hellwig
Index: qemu/hw/ide/core.c
===
--- qemu.orig/hw/ide/core.c 2011-05-03 11:35
On 04/05/2011 04:00 PM, Kevin Wolf wrote:
I have a hard time each time I try to understand this SCSI stuff without
reading a lot of code and specs. What I would have expected is this:
if (len == 0) {
scsi_command_complete(r, 0);
} else {
r->req.bus->complete(r->req.bus, SCSI_REASON_DAT
On 2011-05-03 13:54, Alexander Graf wrote:
> When compiling Qemu with older kernel headers, the PVR setting
> mechanism isn't available yet. Unfortunately, back then I didn't add
> a capability we could check against, so all we can do is add a configure
> test to see if we support PVR setting. For
On 03.05.2011, at 14:14, Jan Kiszka wrote:
> On 2011-05-03 13:54, Alexander Graf wrote:
>> When compiling Qemu with older kernel headers, the PVR setting
>> mechanism isn't available yet. Unfortunately, back then I didn't add
>> a capability we could check against, so all we can do is add a confi
On 2011-05-03 14:28, Alexander Graf wrote:
>
> On 03.05.2011, at 14:14, Jan Kiszka wrote:
>
>> On 2011-05-03 13:54, Alexander Graf wrote:
>>> When compiling Qemu with older kernel headers, the PVR setting
>>> mechanism isn't available yet. Unfortunately, back then I didn't add
>>> a capability we
On 03.05.2011, at 14:31, Jan Kiszka wrote:
> On 2011-05-03 14:28, Alexander Graf wrote:
>>
>> On 03.05.2011, at 14:14, Jan Kiszka wrote:
>>
>>> On 2011-05-03 13:54, Alexander Graf wrote:
When compiling Qemu with older kernel headers, the PVR setting
mechanism isn't available yet. Unfo
On 05/03/2011 06:08 AM, Kevin Wolf wrote:
The following changes since commit 57aa265d462a64a06268be26d49020729cff56c1:
lm32: add Milkymist Minimac2 support (2011-05-03 10:48:40 +0200)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git for-anthony
Pulled. Thanks.
R
On 04/21/11 15:55, Michael Roth wrote:
>> Did you do anything with the fsfreeze patches, or were they dropped in
>> the migration to qapi?
>
> They were pending some changes required on the agent side that weren't
> really addressed/doable until this patchset, namely:
>
> 1) server-side timeout m
> I'm not sure what source tree you're looking at. Code for ARM core
> as a target is in target-arm/.
Exactly that.
> We don't support Jazelle. We don't implement the TCMs (in the same
> way we don't implement caches). We probably don't get all the
> device-specific cp15 registers right. (None
Hi, Anton.
Your proposal is also interesting :-)
It is well-documented hardware?
IT
Da: Антон Кочков
A: Peter Maydell
Cc: Alessandro ; qemu-devel@nongnu.org
Inviato: Mar 3 maggio 2011, 00:04:13
Oggetto: Re: [Qemu-devel] implementing ARM926EJ-S support
Aless
On 2011-05-03 14:33, Alexander Graf wrote:
>
> On 03.05.2011, at 14:31, Jan Kiszka wrote:
>
>> On 2011-05-03 14:28, Alexander Graf wrote:
>>>
>>> On 03.05.2011, at 14:14, Jan Kiszka wrote:
>>>
On 2011-05-03 13:54, Alexander Graf wrote:
> When compiling Qemu with older kernel headers, the
On 2011-05-03 12:21, Juan Quintela wrote:
>
> Please send in any agenda items you are interested in covering.
>
Provided there will be more topics:
- import kvm headers into qemu, drop #ifdef maze
Otherwise, we can also discuss this based on the patch I'm preparing ATM.
Jan
--
Siemens AG, C
On 05/03/2011 08:04 AM, Jan Kiszka wrote:
On 2011-05-03 12:21, Juan Quintela wrote:
Please send in any agenda items you are interested in covering.
Provided there will be more topics:
- import kvm headers into qemu, drop #ifdef maze
This has come up a few times in the past.
The oppositi
On 05/03/2011 02:06 PM, Christoph Hellwig wrote:
+case IDE_DMA_TRIM:
+m->aiocb = dma_bdrv_io(s->bs,&s->sg, sector_num,
+ ide_issue_trim,, pmac_ide_transfer_cb, s, 1);
+break;
Not compile-tested?
Paolo
Alex Williamson writes:
> When we're trying to get a newly registered phys memory client updated
> with the current page mappings, we end up passing the region offset
> (a ram_addr_t) as the start address rather than the actual guest
> physical memory address (target_phys_addr_t). If your guest
On Thu, 2011-04-28 at 16:20 +0100, n...@bytemark.co.uk wrote:
[...]
> +static void nbd_unregister_write_request_handler(BDRVNBDState *s)
> +{
> +int sock = s->sock;
> +if (s->sock == -1) {
> +logout("Unregister write request handler tried when socket
closed\n");
> +return
A thread should only be counted as idle when it really is waiting for new
requests. Without this patch, sometimes too few threads are started as busy
threads are counted as idle.
Not sure if it makes a difference in practice outside some artificial
qemu-io/qemu-img tests, but I think the change ma
Include the list of available targets in the --help output
for the --target-list= option.
Signed-off-by: Peter Maydell
---
v2: As suggested by Stefan Weil, put the target list in --help
rather than using '--target-list=?'. This patch includes using
fold(1) in configure -- this should be OK becaus
On 05/03/2011 07:51 AM, Jes Sorensen wrote:
On 04/21/11 15:55, Michael Roth wrote:
Did you do anything with the fsfreeze patches, or were they dropped in
the migration to qapi?
They were pending some changes required on the agent side that weren't
really addressed/doable until this patchset, n
On 05/03/11 15:04, Jan Kiszka wrote:
> On 2011-05-03 12:21, Juan Quintela wrote:
>>
>> Please send in any agenda items you are interested in covering.
>>
>
> Provided there will be more topics:
> - import kvm headers into qemu, drop #ifdef maze
>
> Otherwise, we can also discuss this based on th
This helps reducing our build-time checks for feature support in the
available Linux kernel headers. And it helps users that do not have
sufficiently recent headers installed on their build machine.
Header upstate is triggered via 'make update-linux-headers', optionally
specifying a kernel directo
On 2011-05-03 15:07, Anthony Liguori wrote:
> On 05/03/2011 08:04 AM, Jan Kiszka wrote:
>> On 2011-05-03 12:21, Juan Quintela wrote:
>>>
>>> Please send in any agenda items you are interested in covering.
>>>
>>
>> Provided there will be more topics:
>> - import kvm headers into qemu, drop #ifdef
On 05/03/11 15:53, Michael Roth wrote:
>>
>> IMHO it is better to disable the commands rather than just logging, but
>> either way should allow it to drop in.
>
> Kinda agree, but logging seems to be the real dependency. With the
> server-side timeouts now in place even doing stuff like fopen/fwri
On 18.04.2011, at 20:34, Aurelien Jarno wrote:
> On Fri, Apr 15, 2011 at 05:32:46PM +0200, Alexander Graf wrote:
>> We have a generic stub architecture for kvm calls, but some architectures
>> are different from others. So we do want to be able to have stubs for
>> architecture specific functiona
On Tue, 2011-05-03 at 15:15 +0200, Markus Armbruster wrote:
> Alex Williamson writes:
>
> > When we're trying to get a newly registered phys memory client updated
> > with the current page mappings, we end up passing the region offset
> > (a ram_addr_t) as the start address rather than the actual
On 05/03/2011 09:12 AM, Jes Sorensen wrote:
On 05/03/11 15:53, Michael Roth wrote:
IMHO it is better to disable the commands rather than just logging, but
either way should allow it to drop in.
Kinda agree, but logging seems to be the real dependency. With the
server-side timeouts now in plac
On 2011-05-03 16:17, Alexander Graf wrote:
>
> On 18.04.2011, at 20:34, Aurelien Jarno wrote:
>
>> On Fri, Apr 15, 2011 at 05:32:46PM +0200, Alexander Graf wrote:
>>> We have a generic stub architecture for kvm calls, but some architectures
>>> are different from others. So we do want to be able
On 3 May 2011 15:17, Alexander Graf wrote:
> Maybe there's some Makefile magic to only compile the stub if the file
> exists? I certainly don't know of any.
obj-$(CONFIG_NO_KVM) += kvm-stub.o
ifneq ($(wildcard $(TARGET_PATH)/kvm-arch-stub.c),)
obj-$(CONFIG_NO_KVM) += kvm-arch-stub.o
endif
? (not
Hi,
This is the current spice patch queue ready for pull. Patches have been
posted a few days ago for review. A minor issue (leftover debug bit,
spotten by Alon) has been fixed and the patch queue has been rebased to
latest master, otherwise it is unmodified.
Please pull.
cheers,
Gerd
The
We don't use qemu internals from spice server context any more.
Thus we don't also need to grab the iothread mutex from spice
server context. And we don't have to temporarely release the
lock to avoid deadlocks. Drop all the calls.
Signed-off-by: Gerd Hoffmann
---
hw/qxl.c |8 ---
From: Jes Sorensen
qemu_spice_set_passwd() and qemu_spice_set_pw_expire() dummy functions
needs to be inline, in order to handle the case where they are called
without checking the return value.
Signed-off-by: Jes Sorensen
Signed-off-by: Gerd Hoffmann
---
ui/qemu-spice.h | 12 ++--
This patch moves the displaystate callback calls for setting the cursor
and the mouse pointer from spice server to qemu (iothread) context.
This allows us to simplify locking.
Signed-off-by: Gerd Hoffmann
---
hw/qxl-render.c| 25 -
hw/qxl.c |2 ++
ui/s
This patch moves the creation of spice screen updates from the spice
server context to qemu iothread context (display refresh timer to be
exact). This way we avoid accessing qemu internals (display surface)
from spice thread context which in turn allows us to simplify locking.
Signed-off-by: Gerd
On Tue, May 03, 2011 at 04:05:37PM +0200, Jan Kiszka wrote:
> This helps reducing our build-time checks for feature support in the
> available Linux kernel headers. And it helps users that do not have
> sufficiently recent headers installed on their build machine.
>
> Header upstate is triggered v
On Tue, May 03, 2011 at 03:08:43PM +0200, Paolo Bonzini wrote:
> On 05/03/2011 02:06 PM, Christoph Hellwig wrote:
>> +case IDE_DMA_TRIM:
>> +m->aiocb = dma_bdrv_io(s->bs,&s->sg, sector_num,
>> + ide_issue_trim,, pmac_ide_transfer_cb, s, 1);
>> +brea
On 2 May 2011 16:47, Venkateswararao Jujjuri wrote:
> On 04/28/2011 09:51 AM, Sassan Panahinejad wrote:
>
> This thread seems relevant:
> http://www.mail-archive.com/linux-fsdevel@vger.kernel.org/msg09159.html
> Unless things have changed, it looks like the problem is in the client
> kernel (alth
On Tue, 3 May 2011 13:02:40 +0200
Alexander Graf wrote:
>
> On 30.04.2011, at 00:10, Scott Wood wrote:
>
> > Read them via KVM_GET_SREGS in kvm_arch_get_registers(),
> > and display them in "info registers".
> >
> > Also get CR and PID from the existing KVM_GET_REGS.
> >
> > Signed-off-by: Sc
On 2011-05-03 17:12, Christoph Hellwig wrote:
> On Tue, May 03, 2011 at 04:05:37PM +0200, Jan Kiszka wrote:
>> This helps reducing our build-time checks for feature support in the
>> available Linux kernel headers. And it helps users that do not have
>> sufficiently recent headers installed on thei
> But there's a pretty good chance I'll get to it somewhere in the next
few months.
That would be amazing. I've got a Linkstation Live v2 and a Drobo FS
waiting eagerly for the possibility of running some x86 binaries.
--
You received this bug notification because you are a member of qemu-
devel
On 03.05.2011, at 17:28, Scott Wood wrote:
> On Tue, 3 May 2011 13:02:40 +0200
> Alexander Graf wrote:
>
>>
>> On 30.04.2011, at 00:10, Scott Wood wrote:
>>
>>> Read them via KVM_GET_SREGS in kvm_arch_get_registers(),
>>> and display them in "info registers".
>>>
>>> Also get CR and PID from
On Tuesday 03 May 2011, Jan Kiszka wrote:
> This helps reducing our build-time checks for feature support in the
> available Linux kernel headers. And it helps users that do not have
> sufficiently recent headers installed on their build machine.
>
> Header upstate is triggered via 'make update-li
On Tue, May 3, 2011 at 2:26 PM, Kevin Wolf wrote:
> A thread should only be counted as idle when it really is waiting for new
> requests. Without this patch, sometimes too few threads are started as busy
> threads are counted as idle.
>
> Not sure if it makes a difference in practice outside some
Paravirtualized devices (and also some real devices) can assume they
are going to access RAM. For this reason, provide a fast-path
function with the following properties:
1) it will never allocate a bounce buffer
2) it can be used for read-modify-write operations
3) unlike qemu_get_ram_ptr, it
This function performs all the work on the fast path, and returns
enough information for the slow path to pick up the work. This
will be used later by other functions that only do the fast path.
Signed-off-by: Paolo Bonzini
---
exec.c | 77 -
Signed-off-by: Paolo Bonzini
---
hw/vhost.c | 10 +-
hw/virtio.c |2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/vhost.c b/hw/vhost.c
index 14b571d..763ee4c 100644
--- a/hw/vhost.c
+++ b/hw/vhost.c
@@ -283,7 +283,7 @@ static int vhost_verify_ring_mappings(s
Paravirtualized devices (and also some real devices) can assume they
are going to access RAM. For this reason, provide a fast-path
function with the following properties:
1) it will never allocate a bounce buffer
2) it can be used for read-modify-write operations
3) unlike qemu_get_ram_ptr, it
This patch adds proper unmapping of the memory when the addresses
cross multiple memory blocks, and it also uses a single map_fast
operation for the RMW access to the destination frame buffer.
Cc: Michael Walle
Signed-off-by: Paolo Bonzini
---
Compile-tested only.
hw/milkymist-tmu2.c |
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c |6 ++
trace-events |6 ++
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index ceeb4ec..0fd85fc 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
@@ -4,6 +4,7 @@
#include "scsi-defs.h"
#
This series includes the following improvements to the SCSI subsystem:
1) introduction of SCSIBusOps that generalize the existing
command_complete callback;
2) widespread use of the SCSIRequest abstraction, with simpler memory
management (refcounting) and with various common idioms converted into
scsi-generic scsi_read_complete() should not -both- call the client
complete callback with SCSI_REASON_DATA -and- call
scsi_command_complete(). The former will cause the client to queue a
new read or write request, while the later will free the request data
structure, thus causing the new read or
Signed-off-by: Paolo Bonzini
---
hw/lsi53c895a.c | 63 +-
1 files changed, 38 insertions(+), 25 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index 56329c2..fc21158 100644
--- a/hw/lsi53c895a.c
+++ b/hw/lsi53c895a.c
@@ -652,38 +
The code for canceling requests upon reset is already the same. Clean
it up and move it to scsi-bus.c.
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c | 12
hw/scsi-disk.c| 18 ++
hw/scsi-generic.c | 18 ++
hw/scsi.h |1 +
4
There are more operations than a SCSI bus can handle, besides completing
commands. One example, which this series will introduce, is cleaning up
after a request is cancelled.
More long term, a "SCSI bus" can represent the LUNs attached to a
target; in this case, while all commands will ultimately
This abstracts calling the command_complete callback, reducing churn
in the following patches.
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c |6 ++
hw/scsi-disk.c|8
hw/scsi-generic.c |6 +++---
hw/scsi.h |1 +
trace-events |1 +
5 files cha
This covers the case of canceling a request's I/O and still
completing it.
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c|9 +
hw/scsi.h|1 +
hw/spapr_vscsi.c |8 ++--
3 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.
Signed-off-by: Paolo Bonzini
---
hw/esp.c |2 +-
hw/lsi53c895a.c |3 +--
hw/scsi-bus.c|5 +
hw/scsi.h|1 +
hw/spapr_vscsi.c |2 +-
hw/usb-msd.c |2 +-
6 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/hw/esp.c b/hw/esp.c
index 3a6
Signed-off-by: Paolo Bonzini
---
hw/scsi-generic.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index 5bfbb8a..e1f8a8a 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -288,7 +288,6 @@ static int32_t scsi_send_command(
With the next patch, a device may hold SCSIRequest for an indefinite
time. Split a rather big patch, and protect against access errors,
by reference counting them.
There is some ugliness in scsi_send_command implementation due to
the need to unref the request when it fails. This will go away
wit
The return value is unused anyway.
Signed-off-by: Paolo Bonzini
---
hw/scsi-disk.c|6 ++
hw/scsi-generic.c |7 ++-
hw/scsi.h |2 +-
3 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 65744c7..4c7a53e 100644
--- a/
Move the common part of scsi-disk.c and scsi-generic.c to the SCSI layer.
Signed-off-by: Paolo Bonzini
---
hw/esp.c |2 +-
hw/lsi53c895a.c |2 +-
hw/scsi-bus.c |3 ++-
hw/scsi-disk.c|1 -
hw/scsi-generic.c |1 -
hw/scsi.h |2 +-
hw/spapr_vscsi.c
From: Hannes Reinecke
The SCSI spec has a quite detailed list of sense codes available.
It even mandates the use of specific ones for some failure cases.
The current implementation just has one type of generic error
which is actually a violation of the spec in certain cases.
This patch introduces
From: Hannes Reinecke
Currently the SCSIRequest structure is abstracted away and cannot accessed
directly from the driver. This requires the handler to do a lookup on
an abstract 'tag' which identifies the SCSIRequest structure.
With this patch the SCSIRequest structure is exposed to the driver.
The sg driver currently has a hardcoded limit of commands it
can handle simultaneously. When this limit is reached the
driver will return -EDOM. So we need to capture this to
enable proper return values here.
Signed-off-by: Hannes Reinecke
Signed-off-by: Paolo Bonzini
---
hw/scsi-generic.c |
... and remove some SCSIDevice variables or fields that now become unused.
Signed-off-by: Paolo Bonzini
---
hw/esp.c |2 +-
hw/lsi53c895a.c |2 +-
hw/scsi-bus.c|5 +
hw/scsi.h|1 +
hw/spapr_vscsi.c |8 ++--
hw/usb-msd.c |2 +-
6 files chan
This is for when the request must be dropped in the void,
but still memory should be freed. To this end, the devices
register a second callback in SCSIBusOps.
Signed-off-by: Paolo Bonzini
---
hw/esp.c | 16 ++--
hw/lsi53c895a.c | 30 +-
hw/
Am 03.05.2011 17:56, schrieb Stefan Hajnoczi:
> On Tue, May 3, 2011 at 2:26 PM, Kevin Wolf wrote:
>> A thread should only be counted as idle when it really is waiting for new
>> requests. Without this patch, sometimes too few threads are started as busy
>> threads are counted as idle.
>>
>> Not su
From: Hannes Reinecke
The get_sense callback copies existing sense information into
the provided buffer. This is required if sense information
should be transferred together with the command response.
Signed-off-by: Hannes Reinecke
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c |9 +++
Signed-off-by: Paolo Bonzini
---
hw/esp.c | 26 ++
hw/lsi53c895a.c | 22 --
hw/scsi-bus.c| 10 ++
hw/scsi.h|1 +
hw/spapr_vscsi.c | 26 ++
hw/usb-msd.c | 15 ---
trace-ev
From: Hannes Reinecke
scsi_req_parse() already provides for a data direction setting,
so we should be using it to check for correct direction.
And we should return the sense code 'INVALID FIELD IN CDB'
in these cases.
Signed-off-by: Hannes Reinecke
Signed-off-by: Paolo Bonzini
---
hw/scsi-dis
On 05/03/2011 07:48 PM, Jan Kiszka wrote:
This helps reducing our build-time checks for feature support in the
available Linux kernel headers. And it helps users that do not have
sufficiently recent headers installed on their build machine.
Header upstate is triggered via
scripts/update-li
1 - 100 of 173 matches
Mail list logo
