[Qemu-devel] Re: [v1 PATCH 3/3]: Convert v9fs_stat to threaded model.

2011-03-17 Thread Stefan Hajnoczi
On Thu, Mar 17, 2011 at 4:26 AM, Venkateswararao Jujjuri (JV) wrote: > On 3/16/2011 10:10 AM, Stefan Hajnoczi wrote: >> On Wed, Mar 16, 2011 at 2:33 PM, Venkateswararao Jujjuri (JV) >> wrote: >>> On 3/16/2011 3:23 AM, Stefan Hajnoczi wrote: On Tue, Mar 15, 2011 at 10:39 AM, Arun R Bharadwaj

[Qemu-devel] Re: [PATCH 15/26] Virtual hash page table handling on pSeries machine'

2011-03-17 Thread Alexander Graf
On 17.03.2011, at 02:03, David Gibson wrote: > On Wed, Mar 16, 2011 at 04:03:47PM +0100, Alexander Graf wrote: >> On 03/16/2011 05:56 AM, David Gibson wrote: > [snip] >>> @@ -248,6 +261,16 @@ static void ppc_spapr_init(ram_addr_t ram_size, >>> ram_offset = qemu_ram_alloc(NULL, "ppc_spapr.ram

[Qemu-devel] Re: [PATCH 16/26] Implement hcall based RTAS for pSeries machines

2011-03-17 Thread Alexander Graf
On 17.03.2011, at 02:22, David Gibson wrote: > On Wed, Mar 16, 2011 at 04:08:30PM +0100, Alexander Graf wrote: >> On 03/16/2011 05:56 AM, David Gibson wrote: > [snip] >>> diff --git a/pc-bios/spapr-rtas.bin b/pc-bios/spapr-rtas.bin >>> new file mode 100644 >>> index >>> 0

[Qemu-devel] Re: [PATCH 18/26] Implement the PAPR (pSeries) virtualized interrupt controller (xics)

2011-03-17 Thread Alexander Graf
On 17.03.2011, at 02:29, David Gibson wrote: > On Wed, Mar 16, 2011 at 04:47:11PM +0100, Alexander Graf wrote: >> On 03/16/2011 05:56 AM, David Gibson wrote: > [snip] >>> +/* static void ics_resend(struct icp_server_state *ss) */ >>> +/* { */ >>> +/* int i; */ >>> + >>> +/* for (i = 0; i

[Qemu-devel] Re: [PATCH 19/26] Add PAPR H_VIO_SIGNAL hypercall and infrastructure for VIO interrupts

2011-03-17 Thread Alexander Graf
On 17.03.2011, at 02:38, David Gibson wrote: > On Wed, Mar 16, 2011 at 04:49:07PM +0100, Alexander Graf wrote: >> On 03/16/2011 05:56 AM, David Gibson wrote: > [snip] >>> +return H_PARAMETER;; >>> + >>> +dev->signal_state = mode; >> >> No need to notify the device? > > No, at the p

[Qemu-devel] Re: [PATCH 25/26] Add a PAPR TCE-bypass mechanism for the pSeries machine

2011-03-17 Thread Alexander Graf
On 17.03.2011, at 04:25, Benjamin Herrenschmidt wrote: > On Thu, 2011-03-17 at 13:21 +1100, David Gibson wrote: >>> Is this an official extension used by anyone or is it your own >>> invention that's not implemented in pHyp? >> >> The latter. > > The main reason is to avoid having to deal wit

[Qemu-devel] [PATCH +STABLE-0.14] exit if -drive specified is invalid instead of ignoring the "wrong" -drive

2011-03-17 Thread Michael Tokarev
Trivial patch. I've sent it yesterday but somehow it didn't reach the list. This fixes the problem when qemu continues even if -drive specification is somehow invalid, resulting in a mess. Applicable for both current master and for stable-0.14 (and 0.13 and 0.12 as well). The prob can actually

[Qemu-devel] Re: [PATCH 04/26] pci: add accessor function to get irq levels

2011-03-17 Thread Michael S. Tsirkin
On Thu, Mar 17, 2011 at 03:05:00PM +0900, Isaku Yamahata wrote: > On Thu, Mar 17, 2011 at 07:29:09AM +0200, Michael S. Tsirkin wrote: > > On Wed, Mar 16, 2011 at 06:29:15PM +0900, Isaku Yamahata wrote: > > > Introduce accessor function to know INTx levels. > > > It will be used later by q35. > > >

Re: [Qemu-devel] v2 revamp acpitable parsing and allow to specify complete (headerful) table

2011-03-17 Thread Michael Tokarev
17.03.2011 08:19, Isaku Yamahata wrote: > Ouch. You already clean it up. Please excuse me for this. My first try was just an RFC to show the "basic idea" - as if it's so much large idea :), it wasn't my intention to ask for comments about the code itself, I said "_something_ of this theme". And

[Qemu-devel] Re: [PATCH 25/26] Add a PAPR TCE-bypass mechanism for the pSeries machine

2011-03-17 Thread Benjamin Herrenschmidt
On Thu, 2011-03-17 at 08:44 +0100, Alexander Graf wrote: > On 17.03.2011, at 04:25, Benjamin Herrenschmidt > wrote: > > > On Thu, 2011-03-17 at 13:21 +1100, David Gibson wrote: > >>> Is this an official extension used by anyone or is it your own > >>> invention that's not implemented in pHyp? >

[Qemu-devel] Re: [PATCH 1/4] block: clarify the meaning of BDRV_O_NOCACHE

2011-03-17 Thread Kevin Wolf
Am 16.03.2011 18:00, schrieb Stefan Hajnoczi: > On Wed, Mar 16, 2011 at 2:08 PM, Christoph Hellwig wrote: >> On Wed, Mar 16, 2011 at 09:42:37AM +, Stefan Hajnoczi wrote: >>> -writethrough = ((flags & BDRV_O_CACHE_MASK) == 0); >>> +writethrough = ((flags & (BDRV_O_CACHE_WB | BDRV_O_NO_F

[Qemu-devel] Re: [PATCH] pcnet: Fix sign extension: make ipxe work with >2G RAM

2011-03-17 Thread Stefan Hajnoczi
On Tue, Mar 15, 2011 at 10:47:22AM -0600, Alex Williamson wrote: > From: Michael Brown > > The problem is with definitions in hw/pcnet.c such as: > > #define CSR_CRDA(S) ((S)->csr[28] | ((S)->csr[29] << 16)) > > "(S)->csr[29]" is a uint16_t, but "(S)->csr[29] << 16" gets promoted to > in

[Qemu-devel] Re: [PATCH 1/4] block: clarify the meaning of BDRV_O_NOCACHE

2011-03-17 Thread Stefan Hajnoczi
On Thu, Mar 17, 2011 at 9:07 AM, Kevin Wolf wrote: > Am 16.03.2011 18:00, schrieb Stefan Hajnoczi: >> On Wed, Mar 16, 2011 at 2:08 PM, Christoph Hellwig wrote: >>> On Wed, Mar 16, 2011 at 09:42:37AM +, Stefan Hajnoczi wrote: -    writethrough = ((flags & BDRV_O_CACHE_MASK) == 0); +

Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-17 Thread Alon Levy
On Wed, Mar 16, 2011 at 05:48:41PM +0100, Jes Sorensen wrote: > On 03/16/11 16:52, Alon Levy wrote: > > +void qxl_server_request_cursor_set(PCIQXLDevice *qxl, QEMUCursor *c, int > > x, int y) > > +{ > > +QXLServerCursorSetRequest req; > > +int r; > > + > > +req.req = QXL_SERVER_CURSOR_

[Qemu-devel] Re: [PATCH 25/26] Add a PAPR TCE-bypass mechanism for the pSeries machine

2011-03-17 Thread Alexander Graf
On 03/17/2011 09:44 AM, Benjamin Herrenschmidt wrote: On Thu, 2011-03-17 at 08:44 +0100, Alexander Graf wrote: On 17.03.2011, at 04:25, Benjamin Herrenschmidt wrote: On Thu, 2011-03-17 at 13:21 +1100, David Gibson wrote: Is this an official extension used by anyone or is it your own inventi

Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-17 Thread Jes Sorensen
On 03/17/11 10:32, Alon Levy wrote: > On Wed, Mar 16, 2011 at 05:48:41PM +0100, Jes Sorensen wrote: >> > On 03/16/11 16:52, Alon Levy wrote: >>> > > +void qxl_server_request_cursor_set(PCIQXLDevice *qxl, QEMUCursor *c, >>> > > int x, int y) >>> > > +{ >>> > > +QXLServerCursorSetRequest req; >>

Re: [Qemu-devel] Re: KVM call agenda for Jan 25

2011-03-17 Thread Kevin Wolf
Am 16.03.2011 18:47, schrieb Stefan Hajnoczi: > On Tue, Mar 15, 2011 at 10:27 AM, Kevin Wolf wrote: >> Am 14.03.2011 16:13, schrieb Dushyant Bansal: Nice that qemu-img convert isn't that far out by default on raw :). About Google Summer of Code, I have posted my take on applyin

[Qemu-devel] [PATCH] v3 revamp acpitable parsing and allow to specify complete (headerful) table

2011-03-17 Thread Michael Tokarev
This patch almost rewrites acpi_table_add() function (but still leaves it using old get_param_value() interface). The result is that it's now possible to specify whole table (together with a header) in an external file, instead of just data portion, with a new file= parameter, but at the same time

Re: [Qemu-devel] OSX build issues

2011-03-17 Thread François Revol
Hi, Le 16 mars 2011 à 08:57, Tristan Gingold a écrit : >> It should fix the build issue. >> But QEMU is unreliable on OSX even when it gets built. >> I tried to bisect but lost some time trying to find a revision that actually >> builds. I thought I updated more this month... >> >> 55f8d6ac3e03

Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-17 Thread Alon Levy
On Thu, Mar 17, 2011 at 10:48:43AM +0100, Jes Sorensen wrote: > On 03/17/11 10:32, Alon Levy wrote: > > On Wed, Mar 16, 2011 at 05:48:41PM +0100, Jes Sorensen wrote: > >> > On 03/16/11 16:52, Alon Levy wrote: > >>> > > +void qxl_server_request_cursor_set(PCIQXLDevice *qxl, QEMUCursor *c, > >>> > >

Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-17 Thread Jes Sorensen
On 03/17/11 11:27, Alon Levy wrote: > On Thu, Mar 17, 2011 at 10:48:43AM +0100, Jes Sorensen wrote: >>> Same for the asserts below, writes are from spice server thread, reads >>> are in iothread. >> >> But shouldn't this make it try to reconnect? Even if the reconnect >> fails, it shouldn't kill th

Re: [libvirt] [Qemu-devel] KVM call minutes for Mar 15

2011-03-17 Thread Daniel P. Berrange
On Tue, Mar 15, 2011 at 12:06:06PM -0700, Chris Wright wrote: > * Anthony Liguori (anth...@codemonkey.ws) wrote: > > On 03/15/2011 09:53 AM, Chris Wright wrote: > > > QAPI > > > >- c library implementation is critical to have unit tests and test > > > driven development > > > - thread safe? >

[Qemu-devel] setting OEM ID in BIOS from qemu?

2011-03-17 Thread Michael Tokarev
Hello. What's the possible way(s) to set OEM identification string in BIOS too, so that it provides ACPI tables with the given identification? It is needed to support running OEM version of windows vista and windows 7 (for example) from /dev/sda without voiding its activation - this needs a real

Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-17 Thread Alon Levy
On Thu, Mar 17, 2011 at 11:29:03AM +0100, Jes Sorensen wrote: > On 03/17/11 11:27, Alon Levy wrote: > > On Thu, Mar 17, 2011 at 10:48:43AM +0100, Jes Sorensen wrote: > >>> Same for the asserts below, writes are from spice server thread, reads > >>> are in iothread. > >> > >> But shouldn't this make

Re: [Qemu-devel] [PATCH 5/7] ccid: add ccid-card-emulated device

2011-03-17 Thread Alon Levy
On Mon, Mar 14, 2011 at 04:41:02PM +0100, Jes Sorensen wrote: > On 02/23/11 12:20, Alon Levy wrote: > > diff --git a/hw/ccid-card-emulated.c b/hw/ccid-card-emulated.c > > new file mode 100644 > > index 000..bd84d45 > > --- /dev/null > > +++ b/hw/ccid-card-emulated.c > > @@ -0,0 +1,599 @@ > > +/

Re: [Qemu-devel] [PATCH 5/7] ccid: add ccid-card-emulated device

2011-03-17 Thread Alon Levy
On Thu, Mar 17, 2011 at 12:54:16PM +0200, Alon Levy wrote: sorry for the double review of the review, nothing new here. > On Mon, Mar 14, 2011 at 04:41:02PM +0100, Jes Sorensen wrote: > > On 02/23/11 12:20, Alon Levy wrote: > > > diff --git a/hw/ccid-card-emulated.c b/hw/ccid-card-emulated.c > >

Re: [Qemu-devel] OSX build issues

2011-03-17 Thread Tristan Gingold
On Mar 17, 2011, at 11:28 AM, François Revol wrote: > Hi, > > Le 16 mars 2011 à 08:57, Tristan Gingold a écrit : > >>> It should fix the build issue. >>> But QEMU is unreliable on OSX even when it gets built. >>> I tried to bisect but lost some time trying to find a revision that >>> actually

Re: [Qemu-devel] OSX build issues

2011-03-17 Thread Juha.Riihimaki
On 17.03.11 13:09 , "ext Tristan Gingold" wrote: >On Mar 17, 2011, at 11:28 AM, François Revol wrote: > >>From the content of the functions called it's either one of the added >>fds which cause problem on select() (but why ?), or likely some signal >>masks which interfere with some internal thre

[Qemu-devel] Re: [PATCH, RFC] virtio_blk: add cache control support

2011-03-17 Thread Rusty Russell
On Wed, 16 Mar 2011 15:09:58 +0100, Christoph Hellwig wrote: > On Wed, Mar 16, 2011 at 02:39:39PM +1030, Rusty Russell wrote: > > > + if (strncmp(buf, "write through", sizeof("write through") - 1) == 0) { > > > + ; > > > + } else if (strncmp(buf, "write back", sizeof("write back") - 1) ==

Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v2)

2011-03-17 Thread Kevin Wolf
Am 16.03.2011 16:59, schrieb Anthony Liguori: > On 03/16/2011 09:34 AM, Luiz Capitulino wrote: >> On Fri, 11 Mar 2011 17:05:30 -0600 >> Anthony Liguori wrote: >> >>> For more information about the background of QAPI, see >>> http://wiki.qemu.org/Features/QAPI >>> >>> This series depends on 'QAPI R

Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v2)

2011-03-17 Thread Anthony Liguori
On 03/17/2011 07:21 AM, Kevin Wolf wrote: Another detail is that, event extension is more important than command extension, because it's probably going to happen. I think it would be very bad to add new events just because we wanted to add a new field. The way this is typically handled is that

Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v2)

2011-03-17 Thread Kevin Wolf
Am 17.03.2011 13:46, schrieb Anthony Liguori: > On 03/17/2011 07:21 AM, Kevin Wolf wrote: >>> Another detail is that, event extension is more important than command extension, because it's probably going to happen. I think it would be very bad to add new events just because we wanted

Re: [Qemu-devel] [PATCH 18/26] Implement the PAPR (pSeries) virtualized interrupt controller (xics)

2011-03-17 Thread Anthony Liguori
On 03/16/2011 08:34 PM, David Gibson wrote: +/* + * ICP: Presentation layer + */ + +struct icp_server_state { +uint32_t cppr :8; +uint32_t xisr :24; No real reason to use bitfields here. Well.. in the hardware xics implementation, CPPR and XISR are considered fields of the one 32-bit

Re: [Qemu-devel] [PATCH 03/26] Add a hook to allow hypercalls to be emulated on PowerPC

2011-03-17 Thread Anthony Liguori
On 03/16/2011 11:55 PM, David Gibson wrote: On Wed, Mar 16, 2011 at 03:44:49PM -0500, Anthony Liguori wrote: On 03/15/2011 11:56 PM, David Gibson wrote: From: David Gibson PowerPC and POWER chips since the POWER4 and 970 have a special hypervisor mode, and a corresponding form of the system ca

Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v2)

2011-03-17 Thread Anthony Liguori
On 03/17/2011 08:15 AM, Kevin Wolf wrote: Am 17.03.2011 13:46, schrieb Anthony Liguori: On 03/17/2011 07:21 AM, Kevin Wolf wrote: Another detail is that, event extension is more important than command extension, because it's probably going to happen. I think it would be very bad to add new even

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-17 Thread Alon Levy
On Mon, Mar 14, 2011 at 04:20:22PM +0100, Jes Sorensen wrote: > On 02/23/11 12:20, Alon Levy wrote: > > +/* private data for PKI applets */ > > +typedef struct CACPKIAppletDataStruct { > > +unsigned char *cert; > > +int cert_len; > > +unsigned char *cert_buffer; > > +int cert_buffer

[Qemu-devel] [PATCH 1/3] pci: add accessor function to get irq levels

2011-03-17 Thread Isaku Yamahata
Introduce accessor function to know INTx levels. It will be used later by q35. Although piix_pci tracks the intx line levels, it can be eliminated by this helper function. Cc: Michael S. Tsirkin Signed-off-by: Isaku Yamahata --- hw/pci.c |7 +++ hw/pci.h |1 + 2 files changed, 8 ins

[Qemu-devel] [PATCH 0/3] piix_pci: optimize irq data path

2011-03-17 Thread Isaku Yamahata
This patch series optimizes irq data path of piix_pci. So far piix3 tracks each pirq level and checks whether a given pic pins is asserted by seeing if each pirq is mapped into the pic pin. This is independent on irq routing, but data path is on slow path. Given that irq routing is rarely changed

[Qemu-devel] [PATCH 2/3] piix_pci: eliminate PIIX3State::pci_irq_levels

2011-03-17 Thread Isaku Yamahata
PIIX3State::pci_irq_levels are redundant which is already tracked by PCIBus layer. So eliminate them. Cc: Michael S. Tsirkin Signed-off-by: Isaku Yamahata --- hw/piix_pci.c | 31 +-- 1 files changed, 21 insertions(+), 10 deletions(-) diff --git a/hw/piix_pci.c b/h

[Qemu-devel] [PATCH 3/3] piix_pci: optimize set irq path

2011-03-17 Thread Isaku Yamahata
optimize irq routing in piix_pic.c which has been a TODO. Cc: Michael S. Tsirkin Signed-off-by: Isaku Yamahata --- hw/piix_pci.c | 103 +--- 1 files changed, 90 insertions(+), 13 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index

Re: [Qemu-devel] [PATCH +STABLE-0.14] exit if -drive specified is invalid instead of ignoring the "wrong" -drive

2011-03-17 Thread Markus Armbruster
Michael Tokarev writes: > Trivial patch. I've sent it yesterday but somehow it didn't > reach the list. > > This fixes the problem when qemu continues even if -drive specification > is somehow invalid, resulting in a mess. Applicable for both current > master and for stable-0.14 (and 0.13 and 0

Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v2)

2011-03-17 Thread Kevin Wolf
Am 17.03.2011 14:28, schrieb Anthony Liguori: > On 03/17/2011 08:15 AM, Kevin Wolf wrote: >> Am 17.03.2011 13:46, schrieb Anthony Liguori: >>> On 03/17/2011 07:21 AM, Kevin Wolf wrote: >> Another detail is that, event extension is more important than command >> extension, because it's proba

Re: [Qemu-devel] Re: [PATCH, RFC] virtio_blk: add cache control support

2011-03-17 Thread Christoph Hellwig
On Thu, Mar 17, 2011 at 03:36:08PM +1030, Rusty Russell wrote: > > I'm happ to switch strcmp. > > Of course, that's assuming buf is nul terminated. It's the string the user writes into it, which normally should be nul-terminated. > > No, it's intentional. config space writes can't return errors

Re: [Qemu-devel] [PATCH +STABLE-0.14] exit if -drive specified is invalid instead of ignoring the "wrong" -drive

2011-03-17 Thread Michael Tokarev
17.03.2011 16:51, Markus Armbruster wrote: > Michael Tokarev writes: > >> Trivial patch. I've sent it yesterday but somehow it didn't >> reach the list. >> >> This fixes the problem when qemu continues even if -drive specification >> is somehow invalid, resulting in a mess. Applicable for both

[Qemu-devel] Re: Clock skew after pausing guests

2011-03-17 Thread Timur Safin
Have you checked with Windows Time service enabled in the guest? net start w32time Best Regards, Timur 2011/3/17 Virtbie : > Hello all > I am seeing, perhaps unsurprisingly, a skewed system clock after pausing > and then resuming a qemu-kvm guest. The guest continues with its earlier > time. >

[Qemu-devel] Clock skew after pausing guests

2011-03-17 Thread Virtbie
Hello all I am seeing, perhaps unsurprisingly, a skewed system clock after pausing and then resuming a qemu-kvm guest. The guest continues with its earlier time. Since I'd like to use the pause technique for backups, which can take 1 hour, this is significant. This is with windows guests, and it d

Re: [Qemu-devel] [PATCH 5/7] ccid: add ccid-card-emulated device

2011-03-17 Thread Jes Sorensen
On 03/17/11 11:54, Alon Levy wrote: > On Mon, Mar 14, 2011 at 04:41:02PM +0100, Jes Sorensen wrote: >>> +static const char *emul_event_to_string(uint32_t emul_event) >>> +{ >>> +switch (emul_event) { >>> +case EMUL_READER_INSERT: return "EMUL_READER_INSERT"; >>> +case EMUL_READER_REMOVE

Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-17 Thread Jes Sorensen
On 03/17/11 11:45, Alon Levy wrote: > On Thu, Mar 17, 2011 at 11:29:03AM +0100, Jes Sorensen wrote: >> On 03/17/11 11:27, Alon Levy wrote: >>> On Thu, Mar 17, 2011 at 10:48:43AM +0100, Jes Sorensen wrote: > Same for the asserts below, writes are from spice server thread, reads > are in ioth

[Qemu-devel] Re: [PATCH 3/3] piix_pci: optimize set irq path

2011-03-17 Thread Michael S. Tsirkin
On Thu, Mar 17, 2011 at 10:49:53PM +0900, Isaku Yamahata wrote: > optimize irq routing in piix_pic.c which has been a TODO. > > Cc: Michael S. Tsirkin > Signed-off-by: Isaku Yamahata Some minor comments, and looks like load has a minor bug - probably an old one as we didn't use to have a post l

[Qemu-devel] Re: [PATCH 0/3] piix_pci: optimize irq data path

2011-03-17 Thread Michael S. Tsirkin
On Thu, Mar 17, 2011 at 10:49:50PM +0900, Isaku Yamahata wrote: > This patch series optimizes irq data path of piix_pci. > So far piix3 tracks each pirq level and checks whether a given pic pins is > asserted by seeing if each pirq is mapped into the pic pin. > This is independent on irq routing, b

[Qemu-devel] Re: [PATCH 03/26] pci: introduce pci_swizzle_map_irq_fn() for standardized interrupt pin swizzle

2011-03-17 Thread Michael S. Tsirkin
On Wed, Mar 16, 2011 at 06:29:14PM +0900, Isaku Yamahata wrote: > introduce pci_swizzle_map_irq_fn() for interrupt pin swizzle which is > standardized. PCI bridge swizzle is common logic, by introducing > this function duplicated swizzle logic will be avoided later. > > Cc: Michael S. Tsirkin > S

Re: [Qemu-devel] [PATCH 2/4] block: add a helper to change writeback mode on the fly

2011-03-17 Thread Daniel P. Berrange
On Tue, Mar 15, 2011 at 03:11:32PM +0100, Christoph Hellwig wrote: > Add a new bdrv_change_cache that can set/clear the writeback flag > at runtime by stopping all I/O and closing/reopening the image file. > > All code is based on a patch from Prerna Saxena > with minimal refactoring. > > Signed

[Qemu-devel] [PATCH v21 09/11] libcacard: add docs

2011-03-17 Thread Alon Levy
From: Robert Relyea --- docs/libcacard.txt | 483 1 files changed, 483 insertions(+), 0 deletions(-) create mode 100644 docs/libcacard.txt diff --git a/docs/libcacard.txt b/docs/libcacard.txt new file mode 100644 index 000..5dee6fa ---

[Qemu-devel] [PATCH v21 05/11] ccid: add passthru card device

2011-03-17 Thread Alon Levy
The passthru ccid card is a device sitting on the usb-ccid bus and using a chardevice to communicate with a remote device using the VSCard protocol defined in libcacard/vscard_common.h Usage docs available in following patch in docs/ccid.txt Signed-off-by: Alon Levy --- Changes from v20->v21:

[Qemu-devel] [PATCH v21 01/11] trace: move trace objects from Makefile to Makefile.objs

2011-03-17 Thread Alon Levy
--- Makefile | 32 Makefile.objs | 32 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/Makefile b/Makefile index eca4c76..5b35b9f 100644 --- a/Makefile +++ b/Makefile @@ -112,38 +112,6 @@ ui/vnc.o: QEMU_CFL

[Qemu-devel] [PATCH v21 04/11] introduce libcacard/vscard_common.h

2011-03-17 Thread Alon Levy
--- Signed-off-by: Alon Levy v20->v21 changes: (Jes Sorenson review) * license set to 2+ * long comment fixes, remove empty line at eof. * add reference to COPYING v19->v20 changes: * checkpatch.pl v15->v16 changes: Protocol change: * VSCMsgInit capabilities and magic * removed ReaderRe

[Qemu-devel] [PATCH v21 07/11] libcacard: add vscclient

2011-03-17 Thread Alon Levy
From: Robert Relyea client to talk to ccid-card-passthru and use smartcard on client to perform actual operations. --- libcacard/Makefile|7 +- libcacard/vscclient.c | 730 + 2 files changed, 736 insertions(+), 1 deletions(-) create mode

[Qemu-devel] [PATCH v21 03/11] usb-ccid: add CCID bus

2011-03-17 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_R

[Qemu-devel] [PATCH v21 02/11] qemu-thread.h: include inttypes.h

2011-03-17 Thread Alon Levy
qemu-thread.h relies on uint64_t being defined, but doesn't include inttypes.h explicitly. This makes it easier to use it from vscclient (part of libcacard). --- qemu-thread.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qemu-thread.h b/qemu-thread.h index acdb6b2..b14

[Qemu-devel] [PATCH v21 11/11] ccid: add docs

2011-03-17 Thread Alon Levy
Add documentation for the usb-ccid device and accompanying two card devices, ccid-card-emulated and ccid-card-passthru. Signed-off-by: Alon Levy --- docs/ccid.txt | 135 + 1 files changed, 135 insertions(+), 0 deletions(-) create mode 100

[Qemu-devel] [PATCH v21 00/11] usb-ccid

2011-03-17 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard with CAC card emulation, CAC is a type of

[Qemu-devel] [PATCH v21 10/11] ccid: add ccid-card-emulated device

2011-03-17 Thread Alon Levy
This devices uses libcacard (internal) to emulate a smartcard conforming to the CAC standard. It attaches to the usb-ccid bus. Usage instructions (example command lines) are in the following patch in docs/ccid.txt. It uses libcacard which uses nss, so it can work with both hw cards and certificates

Re: [Qemu-devel] [PATCH +STABLE-0.14] exit if -drive specified is invalid instead of ignoring the "wrong" -drive

2011-03-17 Thread Kevin Wolf
Am 17.03.2011 08:58, schrieb Michael Tokarev: > Trivial patch. I've sent it yesterday but somehow it didn't > reach the list. > > This fixes the problem when qemu continues even if -drive specification > is somehow invalid, resulting in a mess. Applicable for both current > master and for stable

[Qemu-devel] [PATCH v21 08/11] libcacard: add passthru

2011-03-17 Thread Alon Levy
From: Robert Relyea In this mode libcacard doesn't emulate a card, but just passes apdu's straight to the underlying card. Not to be confused with ccid-card-passthru, which doesn't use libcacard at all. So with this functionality in libcacard you can talk directly to the host accessible card, fo

Re: [Qemu-devel] [RFC] QCFG: a new mechanism to replace QemuOpts and option handling

2011-03-17 Thread Markus Armbruster
Anthony Liguori writes: > As I've been waiting for QAPI review, I've been working on the design > of a new mechanism to replace our current command line option handling > (QemuOpts) with something that reuses the QAPI infrastructure. I'm ignoring the connection to QAPI, because I'm still ignoran

Re: [Qemu-devel] Re: [PATCH 03/26] pci: introduce pci_swizzle_map_irq_fn() for standardized interrupt pin swizzle

2011-03-17 Thread Isaku Yamahata
On Thu, Mar 17, 2011 at 04:43:36PM +0200, Michael S. Tsirkin wrote: > On Wed, Mar 16, 2011 at 06:29:14PM +0900, Isaku Yamahata wrote: > > introduce pci_swizzle_map_irq_fn() for interrupt pin swizzle which is > > standardized. PCI bridge swizzle is common logic, by introducing > > this function dupl

Re: [Qemu-devel] Re: [RFC] QCFG: a new mechanism to replace QemuOpts and option handling

2011-03-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 15.03.2011 14:37, schrieb Anthony Liguori: >> On 03/15/2011 06:21 AM, Kevin Wolf wrote: >>> Am 14.03.2011 18:48, schrieb Anthony Liguori: I've got a spec written up at http://wiki.qemu.org/Features/QCFG. Initial code is in my QAPI tree. >>> One question about a s

Re: [Qemu-devel] [PATCH] vhost: force vhost off for non-MSI guests

2011-03-17 Thread rukhsana ansari
Alex, Michael, Thank you for the clarification. On Tue, Mar 15, 2011 at 1:01 AM, Alex Williamson wrote: > On Mon, 2011-03-14 at 21:00 +0200, Michael S. Tsirkin wrote: > > On Mon, Mar 14, 2011 at 10:35:08PM +0530, rukhsana ansari wrote: > > > Seeking clarification to the original question I post

Re: [Qemu-devel] [PATCH 2/4] block: add a helper to change writeback mode on the fly

2011-03-17 Thread Kevin Wolf
Am 17.03.2011 15:44, schrieb Daniel P. Berrange: > On Tue, Mar 15, 2011 at 03:11:32PM +0100, Christoph Hellwig wrote: >> Add a new bdrv_change_cache that can set/clear the writeback flag >> at runtime by stopping all I/O and closing/reopening the image file. >> >> All code is based on a patch from

Re: [Qemu-devel] qemu.org unreachable ?

2011-03-17 Thread Anthony Liguori
On 03/17/2011 10:19 AM, François Revol wrote: At least from france, confirmed by several people. François. traceroute to qemu.org (64.62.173.86), 64 hops max, 52 byte packets 1 172.28.0.1 (172.28.0.1) 1.145 ms 0.960 ms 0.859 ms 2 172.30.1.1 (172.30.1.1) 0.702 ms 0.786 ms 0.631 ms

Re: [Qemu-devel] [PATCH v21 01/11] trace: move trace objects from Makefile to Makefile.objs

2011-03-17 Thread Alon Levy
On Thu, Mar 17, 2011 at 04:49:26PM +0200, Alon Levy wrote: > --- > Makefile | 32 > Makefile.objs | 32 > 2 files changed, 32 insertions(+), 32 deletions(-) The commit message can be a little more verbose :( It will be:

Re: [Qemu-devel] qemu.org unreachable ?

2011-03-17 Thread Антон Кочков
Looks like. >From Russia also Best regards, Anton Kochkov. On Thu, Mar 17, 2011 at 18:19, François Revol wrote: > At least from france, confirmed by several people. > > François. > > traceroute to qemu.org (64.62.173.86), 64 hops max, 52 byte packets >  1  172.28.0.1 (172.28.0.1)  1.145 ms  0

Re: [Qemu-devel] [PATCH +STABLE-0.14] exit if -drive specified is invalid instead of ignoring the "wrong" -drive

2011-03-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 17.03.2011 08:58, schrieb Michael Tokarev: >> Trivial patch. I've sent it yesterday but somehow it didn't >> reach the list. >> >> This fixes the problem when qemu continues even if -drive specification >> is somehow invalid, resulting in a mess. Applicable for both cur

Re: [Qemu-devel] [PATCH +STABLE-0.14] exit if -drive specified is invalid instead of ignoring the "wrong" -drive

2011-03-17 Thread Michael Tokarev
17.03.2011 18:04, Kevin Wolf wrote: > Am 17.03.2011 08:58, schrieb Michael Tokarev: [] >> --- a/vl.c >> +++ b/vl.c >> @@ -2098,7 +2098,8 @@ int main(int argc, char **argv, char **envp) >>HD_OPTS); >> break; >> case QEMU_OPTION_drive: >> -

[Qemu-devel] qemu.org unreachable ?

2011-03-17 Thread François Revol
At least from france, confirmed by several people. François. traceroute to qemu.org (64.62.173.86), 64 hops max, 52 byte packets 1 172.28.0.1 (172.28.0.1) 1.145 ms 0.960 ms 0.859 ms 2 172.30.1.1 (172.30.1.1) 0.702 ms 0.786 ms 0.631 ms 3 routeur-iut.iut-valence.fr (193.51.172.1) 1.207

Re: [Qemu-devel] [PATCH +STABLE-0.14] exit if -drive specified is invalid instead of ignoring the "wrong" -drive

2011-03-17 Thread Kevin Wolf
Am 17.03.2011 16:49, schrieb Michael Tokarev: > 17.03.2011 18:04, Kevin Wolf wrote: >> Am 17.03.2011 08:58, schrieb Michael Tokarev: > [] >>> --- a/vl.c >>> +++ b/vl.c >>> @@ -2098,7 +2098,8 @@ int main(int argc, char **argv, char **envp) >>>HD_OPTS); >>>

Re: [Qemu-devel] qemu.org unreachable ?

2011-03-17 Thread Anthony Liguori
On 03/17/2011 11:10 AM, Антон Кочков wrote: Looks like. From Russia also The server is down. The VM was having what appeared to be memory issues (random processes SEGV'ing) over the past week. I can't say for sure whether it's an issue with the guest or whether it's an issue with the phys

[Qemu-devel] FVD Paper Accepted to USENIX ATC'11

2011-03-17 Thread Chunqiang Tang
I am pleased to report that a short of version of the FVD-cow paper I previously posted here was just accepted to USENIX Annual Technical Conference (USENIX ATC'11), which is a prestigious and highly competitive research conference in the systems field. This shows from another angle (in additio

Re: [Qemu-devel] [PATCH v21 01/11] trace: move trace objects from Makefile to Makefile.objs

2011-03-17 Thread Stefan Hajnoczi
On Thu, Mar 17, 2011 at 3:00 PM, Alon Levy wrote: > On Thu, Mar 17, 2011 at 04:49:26PM +0200, Alon Levy wrote: >> --- >>  Makefile      |   32 >>  Makefile.objs |   32 >>  2 files changed, 32 insertions(+), 32 deletions(-) > > The c

Re: [Qemu-devel] [PATCH +STABLE-0.14] exit if -drive specified is invalid instead of ignoring the "wrong" -drive

2011-03-17 Thread Kevin Wolf
Am 17.03.2011 16:33, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 17.03.2011 08:58, schrieb Michael Tokarev: >>> Trivial patch. I've sent it yesterday but somehow it didn't >>> reach the list. >>> >>> This fixes the problem when qemu continues even if -drive specification >>> is someh

Re: [Qemu-devel] [PATCH v21 01/11] trace: move trace objects from Makefile to Makefile.objs

2011-03-17 Thread Alon Levy
On Thu, Mar 17, 2011 at 04:45:15PM +, Stefan Hajnoczi wrote: > On Thu, Mar 17, 2011 at 3:00 PM, Alon Levy wrote: > > On Thu, Mar 17, 2011 at 04:49:26PM +0200, Alon Levy wrote: > >> --- > >>  Makefile      |   32 > >>  Makefile.objs |   32 ++

Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-17 Thread Alon Levy
On Thu, Mar 17, 2011 at 03:19:28PM +0100, Jes Sorensen wrote: > On 03/17/11 11:45, Alon Levy wrote: > > On Thu, Mar 17, 2011 at 11:29:03AM +0100, Jes Sorensen wrote: > >> On 03/17/11 11:27, Alon Levy wrote: > >>> On Thu, Mar 17, 2011 at 10:48:43AM +0100, Jes Sorensen wrote: > > Same for the ass

Re: [Qemu-devel] [PATCH +STABLE-0.14] exit if -drive specified is invalid instead of ignoring the "wrong" -drive

2011-03-17 Thread Markus Armbruster
Michael Tokarev writes: > 17.03.2011 16:51, Markus Armbruster wrote: >> Michael Tokarev writes: >> >>> Trivial patch. I've sent it yesterday but somehow it didn't >>> reach the list. >>> >>> This fixes the problem when qemu continues even if -drive specification >>> is somehow invalid, resulti

Re: [Qemu-devel] Re: [PATCH 00/15] QAPI Round 1 (core code generator) (v2)

2011-03-17 Thread Anthony Liguori
On 03/17/2011 09:04 AM, Kevin Wolf wrote: No, the problem with the old events is that they aren't registered/maskable. So even if you don't care about BLOCK_IO_ERROR, you're getting the notification. Plus, we'd like to add the ability to add a tag to events when we register them. What's the

Re: [Qemu-devel] [PATCH 2/4] block: add a helper to change writeback mode on the fly

2011-03-17 Thread Stefan Hajnoczi
On Thu, Mar 17, 2011 at 3:11 PM, Kevin Wolf wrote: > Am 17.03.2011 15:44, schrieb Daniel P. Berrange: >> On Tue, Mar 15, 2011 at 03:11:32PM +0100, Christoph Hellwig wrote: >>> Add a new bdrv_change_cache that can set/clear the writeback flag >>> at runtime by stopping all I/O and closing/reopening

Re: [Qemu-devel] [RFC] QCFG: a new mechanism to replace QemuOpts and option handling

2011-03-17 Thread Anthony Liguori
On 03/17/2011 10:22 AM, Markus Armbruster wrote: void qcfg_handle_vnc(VncConfig *option, Error **errp) { } And that's it. You can squirrel away the option such that they all can be processed later, you can perform additional validation and return an error, or you can implement the appropriate

[Qemu-devel] QEMU e1000 driver loopback mode supported?

2011-03-17 Thread amy chen
Hi, I have experienced the loopback mode failed on the interfaces. Just wondering is loopback mode is supported on the QEMU e1000 driver? Thanks, Amy

[Qemu-devel] [PATCH 1/3] use kernel-provided para_features instead of statically coming up with new capabilities

2011-03-17 Thread Glauber Costa
According to Avi's comments over my last submission, I decided to take a different, and more correct direction - we hope. This patch is now using the features provided by KVM_GET_SUPPORTED_CPUID directly to mask out features from guest-visible cpuid. The old get_para_features() mechanism is kept

[Qemu-devel] [PATCH 0/3] enable newer msr set for kvm

2011-03-17 Thread Glauber Costa
This patch is a follow up to an earlier one that aims to enable kvmclock newer msr set. This time I'm doing it through a more sane mechanism of consulting the kernel about the supported msr set. Glauber Costa (3): use kernel-provided para_features instead of statically coming up with new cap

[Qemu-devel] [PATCH 3/3] don't create kvmclock when one of the flags are present.

2011-03-17 Thread Glauber Costa
kvmclock presence can be signalled by two different flags. So for device creation, we have to test for both. Signed-off-by: Glauber Costa --- hw/kvmclock.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/hw/kvmclock.c b/hw/kvmclock.c index b6ceddf..004c4ad 100644 --

[Qemu-devel] [PATCH 2/3] add kvmclock to its second bit

2011-03-17 Thread Glauber Costa
We have two bits that can represent kvmclock in cpuid. They signal the guest which msr set to use. When we tweak flags involving this value - specially when we use "-", we have to act on both. Besides adding it to the kvm features list, we also have to "break" the assumption represented by the bre

[Qemu-devel] [PATCH v2 0/3] piix_pci: optimize irq data path

2011-03-17 Thread Isaku Yamahata
This patch series optimizes irq data path of piix_pci. So far piix3 tracks each pirq level and checks whether a given pic pins is asserted by seeing if each pirq is mapped into the pic pin. This is independent on irq routing, but data path is on slow path. Given that irq routing is rarely changed

[Qemu-devel] [PATCH v2 3/3] piix_pci: optimize set irq path

2011-03-17 Thread Isaku Yamahata
optimize irq routing in piix_pic.c which has been a TODO. So far piix3 tracks each pirq level and checks whether a given pic pins is asserted by seeing if each pirq is mapped into the pic pin. This is independent on irq routing, but data path is on slow path. Given that irq routing is rarely chang

[Qemu-devel] [PATCH v2 2/3] piix_pci: eliminate PIIX3State::pci_irq_levels

2011-03-17 Thread Isaku Yamahata
PIIX3State::pci_irq_levels are redundant which is already tracked by PCIBus layer. So eliminate them. Cc: Michael S. Tsirkin Signed-off-by: Isaku Yamahata --- hw/piix_pci.c | 31 +-- 1 files changed, 21 insertions(+), 10 deletions(-) diff --git a/hw/piix_pci.c b/h

[Qemu-devel] Re: [PATCH 3/3] piix_pci: optimize set irq path

2011-03-17 Thread Isaku Yamahata
On Thu, Mar 17, 2011 at 04:41:08PM +0200, Michael S. Tsirkin wrote: > > +static int piix3_post_load(void *opaque, int version_id) > > +{ > > +PIIX3State *piix3 = opaque; > > +piix3_rebuild_irq_levels(piix3); > > Don't we need to set_irq_pic here as well? > And in that case, just make the

[Qemu-devel] [PATCH v2 1/3] pci: add accessor function to get irq levels

2011-03-17 Thread Isaku Yamahata
Introduce accessor function to know INTx levels. It will be used later by q35. Although piix_pci tracks the intx line levels, it can be eliminated by this helper function. Cc: Michael S. Tsirkin Signed-off-by: Isaku Yamahata --- hw/pci.c |7 +++ hw/pci.h |1 + 2 files changed, 8 ins

[Qemu-devel] Re: [PATCH] v3 revamp acpitable parsing and allow to specify complete (headerful) table

2011-03-17 Thread Isaku Yamahata
It looks good, except the unnecessary black line after return 0; Reviewed-by: Isaku Yamahata On Thu, Mar 17, 2011 at 01:00:54PM +0300, Michael Tokarev wrote: > This patch almost rewrites acpi_table_add() function > (but still leaves it using old get_param_value() interface). > The result is that

Re: [Qemu-devel] [PATCH 21/26] Implement TCE translation for sPAPR VIO

2011-03-17 Thread David Gibson
On Wed, Mar 16, 2011 at 05:20:53PM -0500, Anthony Liguori wrote: > On 03/15/2011 11:56 PM, David Gibson wrote: > >From: Ben Herrenschmidt [snip] > >+static target_ulong h_put_tce(CPUState *env, sPAPREnvironment *spapr, > >+ target_ulong opcode, target_ulong *args) > >+{

[Qemu-devel] [V9 PATCH 00/13] virtio-9p: Use chroot to safely access files in passthrough security model

2011-03-17 Thread M. Mohan Kumar
In passthrough security model, following symbolic links in the server side could result in TOCTTOU vulnerabilities. This patchset resolves this issue by creating a dedicated process which chroots into the share path and all file object access is done in the chroot environment. This patchset imple

[Qemu-devel] [V9 PATCH 10/13] virtio-9p: Move file post creation changes to none security model

2011-03-17 Thread M. Mohan Kumar
After creating a file object, its permission and ownership details are updated as per 9p client's request for both passthrough and none security model. But with chrooted environment its not required for passthrough security model. Move all post file creation changes to none security model. Signed-

  1   2   >