[Qemu-devel] Re: [PATCH 16/26] Implement hcall based RTAS for pSeries machines

[Alexander Graf]

On 17.03.2011, at 02:22, David Gibson <da...@gibson.dropbear.id.au> wrote:

> On Wed, Mar 16, 2011 at 04:08:30PM +0100, Alexander Graf wrote:
>> On 03/16/2011 05:56 AM, David Gibson wrote:
> [snip]
>>> diff --git a/pc-bios/spapr-rtas.bin b/pc-bios/spapr-rtas.bin
>>> new file mode 100644
>>> index 
>>> 0000000000000000000000000000000000000000..eade9c0e8ff0fd3071e3a6638a11c1a2e9a47152
>>> GIT binary patch
>>> literal 20
>>> bcmb<Pk*=^wC@M)vPAqm|U{LaFU{C-6M#cr<
>>> 
>>> literal 0
>>> HcmV?d00001
>> 
>> Despite being very simple, this is missing source code. There needs
>> to at least be a reference on where to find it in some text file in
>> pc-bios.
> 
> Good point.  Can I just include the source here?  Having an external
> reference to a 5-line asm file seems crazy...

Sure - we already have the source code in-tree for some x86 option roms.

Alex

>