[Qemu-devel] [V3 PATCH 7/8] virtio-9p: Move file post creation changes to none security model

2011-01-18 Thread M. Mohan Kumar
After creating a file object, its permission and ownership details are updated as per client's request for both passthrough and none security model. But with chrooted environment its not required for passthrough security model. Move all post file creation changes to none security model Signed-off-

Re: [Qemu-devel] [PATCH] linux-user: Fix possible realloc memory leak

2011-01-18 Thread Markus Armbruster
Stefan Weil writes: > Extract from "man realloc": > "If realloc() fails the original block is left untouched; > it is not freed or moved." > > Fix a possible memory leak (reported by cppcheck). > > Cc: Riku Voipio > Signed-off-by: Stefan Weil Sidestep the problem via qemu_realloc() instead?

[Qemu-devel] Re: Errors on MMIO read access on VM suspend / resume operations

2011-01-18 Thread Jan Kiszka
On 2011-01-18 04:03, Stefan Berger wrote: > On 01/16/2011 09:43 AM, Avi Kivity wrote: >> On 01/14/2011 09:27 PM, Stefan Berger wrote: >>> Can you sprinkle some printfs() arount kvm_run (in qemu-kvm.c) to verify this? >>> Here's what I did: >>> >>> >>> interrupt exit requested >>

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-18 Thread Gerd Hoffmann
Hi, Worse might also be that unknown issue that force you to inject an IRQ here. We don't know. That's probably worst. Well, IIRC the issue was that usually a level high interrupt line would simply retrigger an interrupt after enabling the interrupt line in the APIC again. edge triggered i

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Jes Sorensen
On 01/18/11 10:20, Markus Armbruster wrote: >> diff --git a/cutils.c b/cutils.c >> index 328738c..f2c8bbd 100644 >> --- a/cutils.c >> +++ b/cutils.c >> @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char **end, >> const char default_suffix) >> } >> } >> switch (t

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Markus Armbruster
jes.soren...@redhat.com writes: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- > cutils.c | 10 +- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/cutils.c b/cutils.c > index 328738c..f2c8bbd 100644 > --- a/cutils.c > +++ b/cutils.c > @@ -324,26 +324,26

[Qemu-devel] Changing the content of target cpu registers

2011-01-18 Thread Stefano Bonifazi
Hi all! I am working on qemu-user (qemu-ppc). I'd like to edit the values of target registers during the execution. Can I do that by simply changing the content of env->gpr[] or do these only contain a copy of the values of the registers? In this last case, where are the real values of the targ

[Qemu-devel] Re: MIPS, io-thread, icount and wfi

2011-01-18 Thread Jan Kiszka
On 2011-01-18 01:19, Edgar E. Iglesias wrote: > On Mon, Jan 17, 2011 at 11:03:08AM +0100, Edgar E. Iglesias wrote: >> Hi, >> >> I'm running an io-thread enabled qemu-system-mipsel with icount. >> When the guest (linux) goes to sleep through the wait insn (waiting >> to be woken up by future timer i

[Qemu-devel] [PATCH v2 1/3] scsi-disk: Allow overriding SCSI INQUIRY removable bit

2011-01-18 Thread Stefan Hajnoczi
Provide the "removable" qdev property bit to override the SCSI INQUIRY removable (RMB) bit for non-CDROM devices. This will be used by USB Mass Storage Devices, which sometimes have this guest-visible bit set and sometimes do not. They therefore requires a means for user configuration. Signed-of

[Qemu-devel] [PATCH v2 2/3] scsi: Allow SCSI devices to override the removable bit

2011-01-18 Thread Stefan Hajnoczi
Some SCSI devices may wish to override the removable bit. Add support for a qdev property on the SCSI device. Signed-off-by: Stefan Hajnoczi --- hw/pci-hotplug.c |2 +- hw/scsi-bus.c|8 ++-- hw/scsi.h|3 ++- hw/usb-msd.c |2 +- 4 files changed, 10 insertions(

[Qemu-devel] [PATCH v2 0/3] usb-msd: Add usb-storage, removable=on|off property

2011-01-18 Thread Stefan Hajnoczi
Allow overriding the SCSI INQUIRY removable (RMB) bit for scsi-disk and usb-msd devices. In particular this addresses the problem that some usb-msd devices have the bit set while other do not have it set. Now the user can choose and get desired guest behavior. qemu -usb -drive if=none,file=

[Qemu-devel] Re: MIPS, io-thread, icount and wfi

2011-01-18 Thread Jan Kiszka
On 2011-01-18 11:00, Jan Kiszka wrote: > On 2011-01-18 01:19, Edgar E. Iglesias wrote: >> On Mon, Jan 17, 2011 at 11:03:08AM +0100, Edgar E. Iglesias wrote: >>> Hi, >>> >>> I'm running an io-thread enabled qemu-system-mipsel with icount. >>> When the guest (linux) goes to sleep through the wait ins

[Qemu-devel] Re: [PATCH v2 3/3] checkpatch: adjust to QEMUisms

2011-01-18 Thread Paolo Bonzini
On 01/17/2011 08:37 PM, Blue Swirl wrote: On Mon, Jan 17, 2011 at 7:40 AM, Paolo Bonzini wrote: On 01/15/2011 06:45 PM, Blue Swirl wrote: + if ($level == 0&& !$block =~ /^\s*\{/&& !$allowed) { I'm not a Perl expert at all, but I think you need parentheses for the argu

Re: [Qemu-devel] [PATCH 1/3] mips: Break TBs after mfc0_count

2011-01-18 Thread Aurelien Jarno
On Tue, Jan 18, 2011 at 12:29:40AM +0100, edgar.igles...@gmail.com wrote: > From: Edgar E. Iglesias > > Break the TB after reading the count register. This makes it > possible to take timer interrupts immediately after a read of > a possibly expired timer. > > Signed-off-by: Edgar E. Iglesias >

[Qemu-devel] Re: [PATCH 2/3] mips: Break out cpu_mips_timer_expire

2011-01-18 Thread Aurelien Jarno
On Tue, Jan 18, 2011 at 12:29:41AM +0100, edgar.igles...@gmail.com wrote: > From: Edgar E. Iglesias > > Reorganize for future patches, no functional change. > > Signed-off-by: Edgar E. Iglesias > --- > hw/mips_timer.c | 36 ++-- > 1 files changed, 22 insertion

Re: [Qemu-devel] Re: [PATCH 3/3] mips: Expire late timers when reading cp0_count

2011-01-18 Thread Aurelien Jarno
On Tue, Jan 18, 2011 at 01:33:00AM +0100, Edgar E. Iglesias wrote: > On Tue, Jan 18, 2011 at 12:29:42AM +0100, edgar.igles...@gmail.com wrote: > > From: Edgar E. Iglesias > > > > When reading cp0_count from a timer with a late trigger that should > > already have expired, expire it and raise the

Re: [Qemu-devel] Re: [PATCH 3/3] mips: Expire late timers when reading cp0_count

2011-01-18 Thread Edgar E. Iglesias
On Tue, Jan 18, 2011 at 11:36:25AM +0100, Aurelien Jarno wrote: > On Tue, Jan 18, 2011 at 01:33:00AM +0100, Edgar E. Iglesias wrote: > > On Tue, Jan 18, 2011 at 12:29:42AM +0100, edgar.igles...@gmail.com wrote: > > > From: Edgar E. Iglesias > > > > > > When reading cp0_count from a timer with a l

Re: [Qemu-devel] [PATCH 1/3] mips: Break TBs after mfc0_count

2011-01-18 Thread Edgar E. Iglesias
On Tue, Jan 18, 2011 at 11:34:28AM +0100, Aurelien Jarno wrote: > On Tue, Jan 18, 2011 at 12:29:40AM +0100, edgar.igles...@gmail.com wrote: > > From: Edgar E. Iglesias > > > > Break the TB after reading the count register. This makes it > > possible to take timer interrupts immediately after a re

Re: [Qemu-devel] Re: [PATCH 3/3] mips: Expire late timers when reading cp0_count

2011-01-18 Thread Aurelien Jarno
On Tue, Jan 18, 2011 at 11:41:54AM +0100, Edgar E. Iglesias wrote: > On Tue, Jan 18, 2011 at 11:36:25AM +0100, Aurelien Jarno wrote: > > On Tue, Jan 18, 2011 at 01:33:00AM +0100, Edgar E. Iglesias wrote: > > > On Tue, Jan 18, 2011 at 12:29:42AM +0100, edgar.igles...@gmail.com wrote: > > > > From: E

[Qemu-devel] [PATCH 3/3] qdev-properties: add PROP_TYPE_ENUM

2011-01-18 Thread Alon Levy
Example usage: EnumTable foo_enum_table[] = { {"bar", 1}, {"buz", 2}, {NULL, 0}, }; DEFINE_PROP_ENUM("foo", State, foo, 1, foo_enum_table) When using qemu -device foodev,? it will appear as: foodev.foo=bar/buz --- hw/qdev-properties.c | 60

[Qemu-devel] [PATCH 0/3] add PROP_TYPE_ENUM and print_options callback

2011-01-18 Thread Alon Levy
This patchset allows a new property type called PROP_TYPE_ENUM, I want to use it for the backend property in the ccid patches (will send the patchset that uses it after this), libvirt is the ultimate user. The first patch adds a print_options callback that works with this property type to print th

[Qemu-devel] [PATCH 2/3] qdev: add data pointer to Property

2011-01-18 Thread Alon Levy
For later use by PROP_TYPE_ENUM, will store enumeration name/value table there. --- hw/qdev.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/qdev.h b/hw/qdev.h index 530fc5d..f6d5279 100644 --- a/hw/qdev.h +++ b/hw/qdev.h @@ -83,6 +83,7 @@ struct Property { int

[Qemu-devel] [PATCH 1/3] qdev: add print_options callback

2011-01-18 Thread Alon Levy
another callback added to PropertyInfo, for later use by PROP_TYPE_ENUM. Allows printing of runtime computed options when doing: qemu -device foo,? --- hw/qdev.c | 10 +- hw/qdev.h |1 + 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 5b8d

Re: [Qemu-devel] [PATCH v2 1/3] scsi-disk: Allow overriding SCSI INQUIRY removable bit

2011-01-18 Thread Kevin Wolf
Am 18.01.2011 11:10, schrieb Stefan Hajnoczi: > Provide the "removable" qdev property bit to override the SCSI INQUIRY > removable (RMB) bit for non-CDROM devices. This will be used by USB > Mass Storage Devices, which sometimes have this guest-visible bit set > and sometimes do not. They therefo

[Qemu-devel] Re: Fwd: Re: port-sparc/44389: awk failure during m4 installation with pkgsrc

2011-01-18 Thread Mateusz Loskot
Blue Swirl gmail.com> writes: > Mateusz Loskot loskot.net> wrote: > > Hi, > > > > I emulate SPARC with NetBSD 5.0 installed and I've experienced a problem > > with pkgsrc installing one of packages. > > I submitted bug report to NetBSD team and received short response > > suggesting it is likely

Re: [Qemu-devel] [PATCH 1/3] mips: Break TBs after mfc0_count

2011-01-18 Thread Edgar E. Iglesias
On Tue, Jan 18, 2011 at 11:34:28AM +0100, Aurelien Jarno wrote: > On Tue, Jan 18, 2011 at 12:29:40AM +0100, edgar.igles...@gmail.com wrote: > > From: Edgar E. Iglesias > > > > Break the TB after reading the count register. This makes it > > possible to take timer interrupts immediately after a re

[Qemu-devel] Re: [PATCH v2 0/5] iohandlers: Add support for enabling/disabling individual handlers

2011-01-18 Thread Amit Shah
On (Mon) Jan 17 2011 [08:57:16], Anthony Liguori wrote: > >Also -- this patchset was prompted by a bug in qemu chardevs that > >freezes guests if they write faster than the chardevs can consume. > >What should the strategy on fixing that bug be? > > Fix the loop API such that we're not just fixing

[Qemu-devel] [PATCH v3 0/3] qcow2 metadata cache

2011-01-18 Thread Kevin Wolf
block-queue turned out to be too big effort to be useful for quickly fixing the performance problems that qcow2 got since we introduced the metadata flushes. While I still think the idea is right, it needs more time and qcow2 doesn't have more time. Let's come back to block-queue later when the mos

[Qemu-devel] [PATCH v3 1/3] qcow2: Add QcowCache

2011-01-18 Thread Kevin Wolf
This adds some new cache functions to qcow2 which can be used for caching refcount blocks and L2 tables. When used with cache=writethrough they work like the old caching code which is spread all over qcow2, so for this case we have merely a cleanup. The interesting case is with writeback caching (

[Qemu-devel] [PATCH v3 3/3] qcow2: Batch flushes for COW

2011-01-18 Thread Kevin Wolf
qcow2 calls bdrv_flush() after performing COW in order to ensure that the L2 table change is never written before the copy is safe on disk. Now that the L2 table is cached, we can wait with flushing until we write out the next L2 table. Signed-off-by: Kevin Wolf --- block/qcow2-cache.c | 20

[Qemu-devel] [PATCH v3 2/3] qcow2: Use QcowCache

2011-01-18 Thread Kevin Wolf
Use the new functions of qcow2-cache.c for everything that works on refcount block and L2 tables. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 206 ++-- block/qcow2-refcount.c | 249 +++- block/qcow2.c

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-18 Thread Alexander Graf
On 18.01.2011, at 10:08, Gerd Hoffmann wrote: > Hi, > >>> Worse might also be that unknown issue that force you to inject an IRQ >>> here. We don't know. That's probably worst. >> >> Well, IIRC the issue was that usually a level high interrupt line would >> simply retrigger an interrupt after

Re: [Qemu-devel] [PATCH v2 1/3] scsi-disk: Allow overriding SCSI INQUIRY removable bit

2011-01-18 Thread Stefan Hajnoczi
On Tue, Jan 18, 2011 at 11:39 AM, Kevin Wolf wrote: > Am 18.01.2011 11:10, schrieb Stefan Hajnoczi: >> Provide the "removable" qdev property bit to override the SCSI INQUIRY >> removable (RMB) bit for non-CDROM devices.  This will be used by USB >> Mass Storage Devices, which sometimes have this g

[Qemu-devel] Re: [PATCH 2/8] ahci: split ICH and AHCI even more

2011-01-18 Thread Kevin Wolf
Am 20.12.2010 22:13, schrieb Alexander Graf: > Sebastian's patch already did a pretty good job at splitting up ICH-9 > AHCI code and the AHCI core. We need some more though. Copyright was missing, > the lspci dump belongs to ICH-9, we don't need the AHCI core to have its > own qdev device duplicate

[Qemu-devel] Re: [PATCH 3/8] ahci: send init d2h fis on fis enable

2011-01-18 Thread Kevin Wolf
Am 20.12.2010 22:13, schrieb Alexander Graf: > The drive sends a d2h init fis on initialization. Usually, the guest doesn't > receive fises yet at that point though, so the delivery is deferred. > > Let's reflect that by sending the init fis on fis receive enablement. > > Signed-off-by: Alexander

[Qemu-devel] Re: [PATCH V2 1/3] Introduce log_start/log_stop in CPUPhysMemoryClient

2011-01-18 Thread anthony . perard
From: Anthony PERARD In order to use log_start/log_stop with Xen as well in the vga code, this two operations have been put in CPUPhysMemoryClient. The two new functions cpu_physical_log_start,cpu_physical_log_stop are used in hw/vga.c and replace the kvm_log_start/stop. With this, vga does no l

Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command

2011-01-18 Thread Christoph Hellwig
On Mon, Jan 17, 2011 at 06:36:15PM +0100, Kevin Wolf wrote: > size should be 'o' instead of 'l'. The latter may be too small on 32 bit > hosts and doesn't support convenient suffixes: Fixed. > Hm, is there a real reason except that CD-ROMs are read-only? The code > below seems to take read-only d

[Qemu-devel] Re: [PATCH 4/8] ahci: use qiov instead of dma helpers

2011-01-18 Thread Kevin Wolf
Am 20.12.2010 22:13, schrieb Alexander Graf: > The DMA helpers incur additional overhead on data transfers. I'm not > sure we need the additional complexity provided by them. So let's just > use qiovs directly when running in the fast path (ncq). > > Signed-off-by: Alexander Graf > --- > hw/ide/

Re: [Qemu-devel] [PATCH 0/3] allow online resizing of block devices

2011-01-18 Thread Luiz Capitulino
On Fri, 14 Jan 2011 17:20:44 +0100 Christoph Hellwig wrote: > This patchset adds support for online resizing of block devices. > > The first patch adds a new resize monitor command which call into > the existing image resize code. This is the meat of the series > and probably needs quite a bit

[Qemu-devel] Re: [PATCH 6/8] ahci: make number of ports runtime determined

2011-01-18 Thread Kevin Wolf
Am 20.12.2010 22:13, schrieb Alexander Graf: > Different AHCI controllers have a different number of ports, so the core > shouldn't care about the amount of ports available. > > This patch makes the number of ports available to the AHCI core runtime > configurable, allowing us to have multiple dif

[Qemu-devel] Re: [PATCH 7/8] ahci: free dynamically allocated iovs

2011-01-18 Thread Kevin Wolf
Am 20.12.2010 22:13, schrieb Alexander Graf: > We allocate iovs on the fly now, but also need to free them on uninit. > This patch does that. > > Signed-off-by: Alexander Graf Isn't this a fix for patch 4? If so, please merge it there. Kevin

[Qemu-devel] Re: [PATCH 3/8] ahci: send init d2h fis on fis enable

2011-01-18 Thread Alexander Graf
On 18.01.2011, at 13:25, Kevin Wolf wrote: > Am 20.12.2010 22:13, schrieb Alexander Graf: >> The drive sends a d2h init fis on initialization. Usually, the guest doesn't >> receive fises yet at that point though, so the delivery is deferred. >> >> Let's reflect that by sending the init fis on fi

[Qemu-devel] Re: [PATCH 4/8] ahci: use qiov instead of dma helpers

2011-01-18 Thread Alexander Graf
On 18.01.2011, at 13:35, Kevin Wolf wrote: > Am 20.12.2010 22:13, schrieb Alexander Graf: >> The DMA helpers incur additional overhead on data transfers. I'm not >> sure we need the additional complexity provided by them. So let's just >> use qiovs directly when running in the fast path (ncq). >>

[Qemu-devel] Re: [PATCH 6/8] ahci: make number of ports runtime determined

2011-01-18 Thread Alexander Graf
On 18.01.2011, at 13:40, Kevin Wolf wrote: > Am 20.12.2010 22:13, schrieb Alexander Graf: >> Different AHCI controllers have a different number of ports, so the core >> shouldn't care about the amount of ports available. >> >> This patch makes the number of ports available to the AHCI core runti

Re: [Qemu-devel] [PATCH 0/3] allow online resizing of block devices

2011-01-18 Thread Christoph Hellwig
On Tue, Jan 18, 2011 at 10:35:39AM -0200, Luiz Capitulino wrote: > Well, what happens is this: we screwed up with that interface and we > should replace it soon. > > I see you're not adding the new command in QMP (only in the human monitor), > is that intentional? (qmp commands are added to the qm

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-18 Thread Jan Kiszka
On 2011-01-18 13:05, Alexander Graf wrote: > > On 18.01.2011, at 10:08, Gerd Hoffmann wrote: > >> Hi, >> Worse might also be that unknown issue that force you to inject an IRQ here. We don't know. That's probably worst. >>> >>> Well, IIRC the issue was that usually a level high interru

Re: [Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-18 Thread Gerd Hoffmann
Hi, edge triggered interrupts wouldn't though. The code change doesn't change anything for edge triggered interrupts - they work fine. Only !msi (== level) ones are broken. apic irqs can be both edge and level triggered too ... That re-trigger smells like you are not clearing the interru

[Qemu-devel] [PATCH] target-arm: Log instruction start in TCG code

2011-01-18 Thread Peter Maydell
Add support for logging the start of instructions in TCG code debug dumps for ARM targets. Signed-off-by: Peter Maydell --- target-arm/translate.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 907d73a..c60cd18 10

Re: [Qemu-devel] Re: [PATCH 6/8] ahci: make number of ports runtime determined

2011-01-18 Thread Gerd Hoffmann
Hi, diff --git a/hw/ide/ich.c b/hw/ide/ich.c index 70cb766..f242d7a 100644 --- a/hw/ide/ich.c +++ b/hw/ide/ich.c @@ -100,7 +100,7 @@ static int pci_ich9_ahci_init(PCIDevice *dev) msi_init(dev, 0x50, 1, true, false); -ahci_init(&d->ahci,&dev->qdev); +ahci_init(&d->ahci,&dev->qde

[Qemu-devel] Re: [PATCH 4/8] ahci: use qiov instead of dma helpers

2011-01-18 Thread Stefan Hajnoczi
On Tue, Jan 18, 2011 at 01:45:40PM +0100, Alexander Graf wrote: > > On 18.01.2011, at 13:35, Kevin Wolf wrote: > > > Am 20.12.2010 22:13, schrieb Alexander Graf: > >> The DMA helpers incur additional overhead on data transfers. I'm not > >> sure we need the additional complexity provided by them.

Re: [Qemu-devel] [PATCH 0/3] allow online resizing of block devices

2011-01-18 Thread Luiz Capitulino
On Tue, 18 Jan 2011 13:48:06 +0100 Christoph Hellwig wrote: > On Tue, Jan 18, 2011 at 10:35:39AM -0200, Luiz Capitulino wrote: > > Well, what happens is this: we screwed up with that interface and we > > should replace it soon. > > > > I see you're not adding the new command in QMP (only in the

[Qemu-devel] [PATCH v2 3/3] usb-msd: Propagate removable bit to SCSI device

2011-01-18 Thread Stefan Hajnoczi
USB Mass Storage Devices sometimes have the RMB (removable) bit set in the SCSI INQUIRY response. Thumbdrives tend to have the bit set whereas hard disks do not. Operating systems differentiate between removable devices and fixed devices. Under Linux, the anaconda installer looks for removable d

[Qemu-devel] Re: [PATCH 4/8] ahci: use qiov instead of dma helpers

2011-01-18 Thread Kevin Wolf
Am 18.01.2011 14:14, schrieb Stefan Hajnoczi: > On Tue, Jan 18, 2011 at 01:45:40PM +0100, Alexander Graf wrote: >> >> On 18.01.2011, at 13:35, Kevin Wolf wrote: >> >>> Am 20.12.2010 22:13, schrieb Alexander Graf: The DMA helpers incur additional overhead on data transfers. I'm not sure we

[Qemu-devel] Re: [PATCH 6/8] ahci: make number of ports runtime determined

2011-01-18 Thread Kevin Wolf
Am 18.01.2011 13:46, schrieb Alexander Graf: > > On 18.01.2011, at 13:40, Kevin Wolf wrote: > >> Am 20.12.2010 22:13, schrieb Alexander Graf: >>> Different AHCI controllers have a different number of ports, so the core >>> shouldn't care about the amount of ports available. >>> >>> This patch mak

Re: [Qemu-devel] paravirtual tablet v3

2011-01-18 Thread Gerd Hoffmann
Hi, Sure, someone needs to map multitouch to non-multitouch. I'd leave that job to the guest driver tough. Why do you think doing it in the host is better? My assumptions are 1) the host is capable of doing the mapping just as easily as the guest Probably. 2) the host can do something us

Re: [Qemu-devel] [RFC][PATCH v6 00/23] virtagent: host/guest RPC communication agent

2011-01-18 Thread Gerd Hoffmann
On 01/17/11 15:53, Michael Roth wrote: On 01/17/2011 07:53 AM, Gerd Hoffmann wrote: What is your plan to handle system-level queries+actions (such as reboot) vs. per-user stuff (such as cut+paste)? This is an area that hasn't been well-defined yet and is definitely open for suggestions. One

Re: [Qemu-devel] [RFC][PATCH v6 00/23] virtagent: host/guest RPC communication agent

2011-01-18 Thread Anthony Liguori
On 01/18/2011 08:02 AM, Gerd Hoffmann wrote: On 01/17/11 15:53, Michael Roth wrote: On 01/17/2011 07:53 AM, Gerd Hoffmann wrote: What is your plan to handle system-level queries+actions (such as reboot) vs. per-user stuff (such as cut+paste)? This is an area that hasn't been well-defined yet

[Qemu-devel] Re: [PATCH v2 0/5] iohandlers: Add support for enabling/disabling individual handlers

2011-01-18 Thread Anthony Liguori
On 01/18/2011 05:56 AM, Amit Shah wrote: On (Mon) Jan 17 2011 [08:57:16], Anthony Liguori wrote: Also -- this patchset was prompted by a bug in qemu chardevs that freezes guests if they write faster than the chardevs can consume. What should the strategy on fixing that bug be? Fix t

Re: [Qemu-devel] [PATCH] target-arm: Log instruction start in TCG code

2011-01-18 Thread Edgar E. Iglesias
On Tue, Jan 18, 2011 at 01:08:40PM +, Peter Maydell wrote: > Add support for logging the start of instructions in TCG > code debug dumps for ARM targets. > > Signed-off-by: Peter Maydell Applied, thanks. > --- > target-arm/translate.c |4 > 1 files changed, 4 insertions(+), 0 del

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-12 11:31, Jan Kiszka wrote: > Am 12.01.2011 11:22, Avi Kivity wrote: >> On 01/11/2011 03:54 PM, Anthony Liguori wrote: >>> >>> Right, we should introduce a KVMBus that KVM devices are created on. >>> The devices can get at KVMState through the BusState. >> >> There is no kvm bus in a PC

[Qemu-devel] Re: KVM call agenda for Jan 18

2011-01-18 Thread Chris Wright
* Chris Wright (chr...@redhat.com) wrote: > Please send in any agenda items you are interested in covering. No agenda, this week's call is cancelled. thanks, -chris

[Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-18 Thread Christophe Lyon
Fix garbage collection of temporaries in Neon emulation. Signed-off-by: Christophe Lyon --- target-arm/translate.c | 22 +- 1 files changed, 17 insertions(+), 5 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 57664bc..363351e 100644 --- a/t

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 08:28 AM, Jan Kiszka wrote: On 2011-01-12 11:31, Jan Kiszka wrote: Am 12.01.2011 11:22, Avi Kivity wrote: On 01/11/2011 03:54 PM, Anthony Liguori wrote: Right, we should introduce a KVMBus that KVM devices are created on. The devices can get at KVMState through

Re: [Qemu-devel] paravirtual tablet v3

2011-01-18 Thread Anthony Liguori
On 01/18/2011 07:46 AM, Gerd Hoffmann wrote: Hi, Sure, someone needs to map multitouch to non-multitouch. I'd leave that job to the guest driver tough. Why do you think doing it in the host is better? My assumptions are 1) the host is capable of doing the mapping just as easily as the guest

[Qemu-devel] [sparc] Floating point exception issue

2011-01-18 Thread Mateusz Loskot
Hi, Recently, I have reported mysterious issues on NetBSD 5.1 emulated on SPARC. The whole first thread is here: http://lists.gnu.org/archive/html/qemu-devel/2011-01/msg01509.html I decided to investigate the problem deeper and with great help from NetBSD folks, I managed to find reproducible t

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Alex Williamson
On Tue, 2011-01-18 at 10:20 +0100, Markus Armbruster wrote: > jes.soren...@redhat.com writes: > > > From: Jes Sorensen > > > > Signed-off-by: Jes Sorensen > > --- > > cutils.c | 10 +- > > 1 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/cutils.c b/cutils.c > > in

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-18 Thread Peter Maydell
On 18 January 2011 14:34, Christophe Lyon wrote: > + > +    /* gen_helper_neon_mull_[su]{8|16} do not free their parameters. > +       Don't forget to clean them now.  */ > +    switch ((size << 1) | u) { > +    case 0: > +    case 1: > +    case 2: > +    case 3: > +      dead_tmp(a); > +      de

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-18 Thread Peter Maydell
Incidentally there are some correctness fixes for the multiply-by-scalar neon insns from the qemu-meego tree which are on my list to push upstream. So you probably aren't getting the right results even if you've managed to shut up qemu's warnings :-) -- PMM

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-18 16:04, Anthony Liguori wrote: > On 01/18/2011 08:28 AM, Jan Kiszka wrote: >> On 2011-01-12 11:31, Jan Kiszka wrote: >> >>> Am 12.01.2011 11:22, Avi Kivity wrote: >>> On 01/11/2011 03:54 PM, Anthony Liguori wrote: > Right, we should introduce a KVMBus th

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 09:43 AM, Jan Kiszka wrote: On 2011-01-18 16:04, Anthony Liguori wrote: On 01/18/2011 08:28 AM, Jan Kiszka wrote: On 2011-01-12 11:31, Jan Kiszka wrote: Am 12.01.2011 11:22, Avi Kivity wrote: On 01/11/2011 03:54 PM, Anthony Liguori wrote:

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 09:43 AM, Jan Kiszka wrote: On 2011-01-18 16:04, Anthony Liguori wrote: On 01/18/2011 08:28 AM, Jan Kiszka wrote: On 2011-01-12 11:31, Jan Kiszka wrote: Am 12.01.2011 11:22, Avi Kivity wrote: On 01/11/2011 03:54 PM, Anthony Liguori wrote:

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-18 16:48, Anthony Liguori wrote: > On 01/18/2011 09:43 AM, Jan Kiszka wrote: >> On 2011-01-18 16:04, Anthony Liguori wrote: >> >>> On 01/18/2011 08:28 AM, Jan Kiszka wrote: >>> On 2011-01-12 11:31, Jan Kiszka wrote: > Am 12.01.2011 11:22, Avi Kivity w

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-18 16:50, Anthony Liguori wrote: > On 01/18/2011 09:43 AM, Jan Kiszka wrote: >> On 2011-01-18 16:04, Anthony Liguori wrote: >> >>> On 01/18/2011 08:28 AM, Jan Kiszka wrote: >>> On 2011-01-12 11:31, Jan Kiszka wrote: > Am 12.01.2011 11:22, Avi Kivity w

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 10:01 AM, Jan Kiszka wrote: On 2011-01-18 16:50, Anthony Liguori wrote: On 01/18/2011 09:43 AM, Jan Kiszka wrote: On 2011-01-18 16:04, Anthony Liguori wrote: On 01/18/2011 08:28 AM, Jan Kiszka wrote: On 2011-01-12 11:31, Jan Kiszka wrote:

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-18 17:04, Anthony Liguori wrote: > A KVM device should sit on a KVM specific bus that hangs off of > sysbus. > It can get to kvm_state through that bus. > > That bus doesn't get instantiated through qdev so requiring a pointer > argument should not be an issue. >>

[Qemu-devel] [PATCH] pxa2xx_lcd: restore updating of display

2011-01-18 Thread Dmitry Eremin-Solenikov
Recently PXA2xx lcd have stopped to be updated incrementally (picture frozen). This patch fixes that by passing non min/max x/y, but rather (correctly) x/y and w/h. Signed-off-by: Dmitry Eremin-Solenikov --- hw/pxa2xx_lcd.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 10:17 AM, Jan Kiszka wrote: On 2011-01-18 17:04, Anthony Liguori wrote: A KVM device should sit on a KVM specific bus that hangs off of sysbus. It can get to kvm_state through that bus. That bus doesn't get instantiated through qdev so requiring a pointer argument should not b

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Anthony Liguori
On 01/18/2011 03:20 AM, Markus Armbruster wrote: jes.soren...@redhat.com writes: From: Jes Sorensen Signed-off-by: Jes Sorensen --- cutils.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cutils.c b/cutils.c index 328738c..f2c8bbd 100644 --- a/cutils.c

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Jes Sorensen
On 01/18/11 17:50, Anthony Liguori wrote: > On 01/18/2011 03:20 AM, Markus Armbruster wrote: >> jes.soren...@redhat.com writes: >> >> >>> From: Jes Sorensen >>> >>> Signed-off-by: Jes Sorensen >>> --- >>> cutils.c | 10 +- >>> 1 files changed, 5 insertions(+), 5 deletions(-) >>> >>>

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Eric Blake
On 01/18/2011 09:50 AM, Anthony Liguori wrote: >>> @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char >>> **end, const char default_suffix) >>> } >>> } >>> switch (toupper(d)) { > BTW, a useful change would be to accept both upper and lower case letters. And

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-18 17:37, Anthony Liguori wrote: > On 01/18/2011 10:17 AM, Jan Kiszka wrote: >> On 2011-01-18 17:04, Anthony Liguori wrote: >> >>> A KVM device should sit on a KVM specific bus that hangs off of >>> sysbus. >>> It can get to kvm_state through that bus. >>> >>> Tha

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Alex Williamson
On Tue, 2011-01-18 at 16:54 +0100, Jan Kiszka wrote: > On 2011-01-18 16:48, Anthony Liguori wrote: > > On 01/18/2011 09:43 AM, Jan Kiszka wrote: > >> On 2011-01-18 16:04, Anthony Liguori wrote: > >> > >>> On 01/18/2011 08:28 AM, Jan Kiszka wrote: > >>> > On 2011-01-12 11:31, Jan Kisz

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-18 Thread Christophe Lyon
On 18.01.2011 16:26, Peter Maydell wrote: > On 18 January 2011 14:34, Christophe Lyon wrote: >> + >> +/* gen_helper_neon_mull_[su]{8|16} do not free their parameters. >> + Don't forget to clean them now. */ >> +switch ((size << 1) | u) { >> +case 0: >> +case 1: >> +case

Re: [Qemu-devel] [V3 PATCH 2/8] virtio-9p: Provide chroot environment server side interfaces

2011-01-18 Thread Blue Swirl
On Tue, Jan 18, 2011 at 6:25 AM, M. Mohan Kumar wrote: > Implement chroot server side interfaces like sending the file > descriptor to qemu process, reading the object request from socket etc. > Also add chroot main function and other helper routines. > > Signed-off-by: M. Mohan Kumar > --- >  Ma

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-18 18:02, Alex Williamson wrote: > On Tue, 2011-01-18 at 16:54 +0100, Jan Kiszka wrote: >> On 2011-01-18 16:48, Anthony Liguori wrote: >>> On 01/18/2011 09:43 AM, Jan Kiszka wrote: On 2011-01-18 16:04, Anthony Liguori wrote: > On 01/18/2011 08:28 AM, Jan Kiszka wrote: >

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 10:56 AM, Jan Kiszka wrote: The device model topology is 100% a hidden architectural detail. This is true for the sysbus, it is obviously not the case for PCI and similarly discoverable buses. There we have a guest-explorable topology that is currently equivalent to the the

Re: [Qemu-devel] [V3 PATCH 5/8] virtio-9p: Create support in chroot environment

2011-01-18 Thread Blue Swirl
On Tue, Jan 18, 2011 at 6:25 AM, M. Mohan Kumar wrote: > Add both server & client side interfaces to create regular files in > chroot environment > > Signed-off-by: M. Mohan Kumar > --- >  hw/9pfs/virtio-9p-chroot.c |   42 ++ >  hw/9pfs/virtio-9p-local.c  |

Re: [Qemu-devel] [V3 PATCH 6/8] virtio-9p: Support for creating special files

2011-01-18 Thread Blue Swirl
On Tue, Jan 18, 2011 at 6:26 AM, M. Mohan Kumar wrote: > Add both server and client side interfaces to create special files > (directory, device nodes, links and symbolic links) > > Signed-off-by: M. Mohan Kumar > --- >  hw/9pfs/virtio-9p-chroot.c |   84 ++- >  hw/9pfs/vir

Re: [Qemu-devel] [PATCH] linux-user: Fix possible realloc memory leak

2011-01-18 Thread Stefan Weil
Am 18.01.2011 09:26, schrieb Markus Armbruster: Stefan Weil writes: Extract from "man realloc": "If realloc() fails the original block is left untouched; it is not freed or moved." Fix a possible memory leak (reported by cppcheck). Cc: Riku Voipio Signed-off-by: Stefan Weil Sidestep the

Re: [Qemu-devel] Changing the content of target cpu registers

2011-01-18 Thread Blue Swirl
On Tue, Jan 18, 2011 at 9:29 AM, Stefano Bonifazi wrote: > Hi all! >  I am working on qemu-user (qemu-ppc). > I'd like to edit the values of target registers during the execution. Can I > do that by simply changing the content of env->gpr[] or do these only > contain a copy of the values of the re

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-18 18:09, Anthony Liguori wrote: > On 01/18/2011 10:56 AM, Jan Kiszka wrote: >> >>> The device model topology is 100% a hidden architectural detail. >>> >> This is true for the sysbus, it is obviously not the case for PCI and >> similarly discoverable buses. There we have a guest-e

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-18 Thread Peter Maydell
On 18 January 2011 17:00, Christophe Lyon wrote: > On 18.01.2011 16:36, Peter Maydell wrote: >> Incidentally there are some correctness fixes for the multiply-by-scalar >> neon insns from the qemu-meego tree which are on my list to push >> upstream. So you probably aren't getting the right results

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-18 Thread Christophe Lyon
On 18.01.2011 16:36, Peter Maydell wrote: > Incidentally there are some correctness fixes for the multiply-by-scalar > neon insns from the qemu-meego tree which are on my list to push > upstream. So you probably aren't getting the right results even if > you've managed to shut up qemu's warnings :-

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 11:20 AM, Jan Kiszka wrote: Which only works as along as we expose a single bus. You don't need to be an oracle to predict that this is not a stable interface. Today we only have a very low level factory interface--device creation and deletion. I think we should move to hi

Re: [Qemu-devel] [sparc] Floating point exception issue

2011-01-18 Thread Blue Swirl
On Tue, Jan 18, 2011 at 3:27 PM, Mateusz Loskot wrote: > Hi, > > Recently, I have reported mysterious issues on NetBSD 5.1 > emulated on SPARC. The whole first thread is here: > > http://lists.gnu.org/archive/html/qemu-devel/2011-01/msg01509.html > > I decided to investigate the problem deeper and

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Alex Williamson
On Tue, 2011-01-18 at 18:08 +0100, Jan Kiszka wrote: > On 2011-01-18 18:02, Alex Williamson wrote: > > On Tue, 2011-01-18 at 16:54 +0100, Jan Kiszka wrote: > >> On 2011-01-18 16:48, Anthony Liguori wrote: > >>> On 01/18/2011 09:43 AM, Jan Kiszka wrote: > On 2011-01-18 16:04, Anthony Liguori wr

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-18 18:31, Anthony Liguori wrote: >>> It's automatically created as part of the CPUs or as part of the >>> chipset. How to enable/disable kvm assistance is a property of the CPU >>> and/or chipset. >>> >> If we exclude creation via command line / config files, we could also >> pass

Re: [Qemu-devel] [PATCH] linux-user: Fix possible realloc memory leak

2011-01-18 Thread Markus Armbruster
Stefan Weil writes: > Am 18.01.2011 09:26, schrieb Markus Armbruster: >> Stefan Weil writes: >> >>> Extract from "man realloc": >>> "If realloc() fails the original block is left untouched; >>> it is not freed or moved." >>> >>> Fix a possible memory leak (reported by cppcheck). >>> >>> Cc: Riku

Re: [Qemu-devel] Re: Fwd: Re: port-sparc/44389: awk failure during m4 installation with pkgsrc

2011-01-18 Thread Blue Swirl
On Tue, Jan 18, 2011 at 11:40 AM, Mateusz Loskot wrote: > Blue Swirl gmail.com> writes: >> Mateusz Loskot loskot.net> wrote: >> > Hi, >> > >> > I emulate SPARC with NetBSD 5.0 installed and I've experienced a problem >> > with pkgsrc installing one of packages. >> > I submitted bug report to Net

Re: [Qemu-devel] [sparc] Floating point exception issue

2011-01-18 Thread Mateusz Loskot
On 18/01/11 17:36, Blue Swirl wrote: On Tue, Jan 18, 2011 at 3:27 PM, Mateusz Loskot wrote: Hi, Recently, I have reported mysterious issues on NetBSD 5.1 emulated on SPARC. The whole first thread is here: http://lists.gnu.org/archive/html/qemu-devel/2011-01/msg01509.html I decided to investi

  1   2   >