On 18.01.2011, at 13:25, Kevin Wolf wrote: > Am 20.12.2010 22:13, schrieb Alexander Graf: >> The drive sends a d2h init fis on initialization. Usually, the guest doesn't >> receive fises yet at that point though, so the delivery is deferred. >> >> Let's reflect that by sending the init fis on fis receive enablement. >> >> Signed-off-by: Alexander Graf <ag...@suse.de> > > Hm... If I read the spec right, the real solution wouldn't be an > init_d2h_sent flag, but implementing a queue for FISes that are received > when the guest hasn't set FRE yet. > > I'm not against taking a hack like this, but maybe leave a comment > somewhere at least.
Yes, they'd get queued. In practice it doesn't really matter that much, which is why the hack works :). But you're right - a comment would be nice. Alex
