Re: [Qemu-devel] [PATCH 02/10] qdev: export qdev_reset() for later use.

2010-06-17 Thread Markus Armbruster
Isaku Yamahata writes: > export qdev_reset() for later use. > > Signed-off-by: Isaku Yamahata > --- > hw/qdev.c | 13 + > hw/qdev.h |1 + > 2 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/hw/qdev.c b/hw/qdev.c > index 61f999c..378f842 100644 > --- a/hw/qdev.

[Qemu-devel] Re: [PATCH] SeaBIOS: Fix bvprintf() to respect padding for hex printing.

2010-06-17 Thread Jes Sorensen
On 06/17/10 04:42, Kevin O'Connor wrote: > On Mon, Jun 14, 2010 at 02:04:31PM +0200, jes.soren...@redhat.com wrote: >> From: Jes Sorensen >> >> Fix bvprintf to respect space padding when printing hex numbers >> and the caller specifies alignment without zero padding, eg. %2x >> as opposed to %02x

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-17 Thread Jan Kiszka
Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 06:00:56PM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Wed, Jun 16, 2010 at 12:35:16PM +0300, Gleb Natapov wrote: On Wed, Jun 16, 2010 at 11:33:13AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: >> On Wed, Jun 16, 2010 at 09:57:

[Qemu-devel] [PATCH 2/4] qemu: Enable XSAVE related CPUID

2010-06-17 Thread Sheng Yang
We can support it in KVM now. The 0xd leaf is queried from KVM. Signed-off-by: Sheng Yang --- target-i386/cpuid.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c index 99d1f44..ab6536b 100644 --- a/target-i38

[Qemu-devel] [PATCH 3/4] qemu: kvm: Enable XSAVE live migration support

2010-06-17 Thread Sheng Yang
Signed-off-by: Sheng Yang --- target-i386/cpu.h |5 ++ target-i386/kvm.c | 134 + target-i386/machine.c | 20 +++ 3 files changed, 159 insertions(+), 0 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 548ab8

[Qemu-devel] [PATCH 1/4] qemu: kvm: Extend kvm_arch_get_supported_cpuid() to support index

2010-06-17 Thread Sheng Yang
Would use it later for XSAVE related CPUID. Signed-off-by: Sheng Yang --- kvm.h |2 +- target-i386/kvm.c | 19 +++ 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/kvm.h b/kvm.h index a28e7aa..7975e87 100644 --- a/kvm.h +++ b/kvm.h @@ -145,7 +145,

[Qemu-devel] [PATCH v4 0/4] XSAVE enabling in QEmu

2010-06-17 Thread Sheng Yang
Notice the first three patches applied to uq/master branch of qemu-kvm, the last one applied to qemu-kvm master branch. And the last one would only apply after the first three merged in master branch.

[Qemu-devel] [PATCH 4/4] qemu-kvm: Enable XSAVE live migration support

2010-06-17 Thread Sheng Yang
Based on upstream xsave related fields. Signed-off-by: Sheng Yang --- qemu-kvm-x86.c | 95 +++- qemu-kvm.c | 24 ++ qemu-kvm.h | 28 3 files changed, 146 insertions(+), 1 deletions(-) diff --git a/qem

[Qemu-devel] Re: [PATCH v3] qemu: kvm: Enable XSAVE live migration support

2010-06-17 Thread Jan Kiszka
Sheng Yang wrote: > On Thursday 17 June 2010 00:05:44 Marcelo Tosatti wrote: >> On Wed, Jun 16, 2010 at 05:48:46PM +0200, Jan Kiszka wrote: >>> Marcelo Tosatti wrote: On Fri, Jun 11, 2010 at 12:36:49PM +0800, Sheng Yang wrote: > Signed-off-by: Sheng Yang > --- > > qemu-kvm-x8

[Qemu-devel] Re: [PATCH 3/4] qemu: kvm: Enable XSAVE live migration support

2010-06-17 Thread Jan Kiszka
Sheng Yang wrote: > Signed-off-by: Sheng Yang > --- > target-i386/cpu.h |5 ++ > target-i386/kvm.c | 134 > + > target-i386/machine.c | 20 +++ > 3 files changed, 159 insertions(+), 0 deletions(-) > > diff --git a/target-i386/cp

[Qemu-devel] Re: [PATCH 4/4] qemu-kvm: Enable XSAVE live migration support

2010-06-17 Thread Jan Kiszka
Sheng Yang wrote: > Based on upstream xsave related fields. > > Signed-off-by: Sheng Yang > --- > qemu-kvm-x86.c | 95 > +++- > qemu-kvm.c | 24 ++ > qemu-kvm.h | 28 > 3 files changed, 146 insertions

Re: [Qemu-devel] Q35 qemu repository?

2010-06-17 Thread Isaku Yamahata
Thanks for the patch. Does vista boot with the patch eventually? On Wed, Jun 16, 2010 at 06:33:15PM +0100, Matthew Garrett wrote: > On Wed, Jun 16, 2010 at 04:42:10PM +0100, Matthew Garrett wrote: > > > Thanks for this - however, Vista gives me an ACPI error on boot (stop > > 0x00a5, 0x0

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-17 Thread Gleb Natapov
On Thu, Jun 17, 2010 at 09:17:51AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Jun 16, 2010 at 06:00:56PM +0200, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Wed, Jun 16, 2010 at 12:35:16PM +0300, Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 11:33:13AM +0200, Jan Kiszka

Re: [Qemu-devel] Re: [PATCH 1/2] qemu-io: retry fgets() when errno is EINTR

2010-06-17 Thread Kevin Wolf
Am 16.06.2010 18:52, schrieb MORITA Kazutaka: > At Wed, 16 Jun 2010 13:04:47 +0200, > Kevin Wolf wrote: >> >> Am 15.06.2010 19:53, schrieb MORITA Kazutaka: >>> posix-aio-compat sends a signal in aio operations, so we should >>> consider that fgets() could be interrupted here. >>> >>> Signed-off-by:

[Qemu-devel] [PATCH 3/4] qemu: kvm: Enable XSAVE live migration support

2010-06-17 Thread Sheng Yang
Signed-off-by: Sheng Yang --- target-i386/cpu.h |7 ++- target-i386/kvm.c | 139 - target-i386/machine.c | 20 +++ 3 files changed, 163 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 548ab

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-17 Thread Jan Kiszka
Gleb Natapov wrote: > On Thu, Jun 17, 2010 at 09:17:51AM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Wed, Jun 16, 2010 at 06:00:56PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 12:35:16PM +0300, Gleb Natapov wrote: >> On Wed, Jun 16, 2010 at 11:33:

Re: [Qemu-devel] Re: RFC v2: blockdev_add & friends, brief rationale, QMP docs

2010-06-17 Thread Kevin Wolf
Am 16.06.2010 20:07, schrieb Anthony Liguori: >> But it requires that >> everything that -blockdev provides is accessible with -drive, too (or >> that we're okay with users hating us). >> > > I'm happy for -drive to die. I think we should support -hda and > -blockdev. -hda is not suffici

[Qemu-devel] Re: [PATCH 4/4] qemu-kvm: Enable XSAVE live migration support

2010-06-17 Thread Sheng Yang
On Thursday 17 June 2010 15:41:43 Jan Kiszka wrote: > Sheng Yang wrote: > > Based on upstream xsave related fields. > > > > Signed-off-by: Sheng Yang > > --- > > > > qemu-kvm-x86.c | 95 > > +++- qemu-kvm.c > > | 24 ++ > >

Re: [Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices

2010-06-17 Thread Kevin Wolf
Am 16.06.2010 17:57, schrieb Chris Lalancette: > On 06/16/10 - 05:32:58PM, Kevin Wolf wrote: >> Am 16.06.2010 17:22, schrieb Chris Lalancette: >>> On 06/16/10 - 03:15:11PM, Kevin Wolf wrote: Am 16.06.2010 14:59, schrieb Miguel Di Ciurcio Filho: > On Wed, Jun 16, 2010 at 9:40 AM, Kevin Wolf

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-17 Thread Gleb Natapov
On Thu, Jun 17, 2010 at 10:30:15AM +0200, Jan Kiszka wrote: > > Sorry, I lost you here. What "works for IO-based fw-cfg, but not for > > MMIO-based". > > Undefined IO ports return -1, undefined (/wrt read access) MMIO 0. So > you need to select a key that is different from both. > But can we rely

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-17 Thread Jan Kiszka
Gleb Natapov wrote: > On Thu, Jun 17, 2010 at 10:30:15AM +0200, Jan Kiszka wrote: >>> Sorry, I lost you here. What "works for IO-based fw-cfg, but not for >>> MMIO-based". >> Undefined IO ports return -1, undefined (/wrt read access) MMIO 0. So >> you need to select a key that is different from bot

[Qemu-devel] Re: [PATCH 4/4] qemu-kvm: Enable XSAVE live migration support

2010-06-17 Thread Jan Kiszka
Sheng Yang wrote: > On Thursday 17 June 2010 15:41:43 Jan Kiszka wrote: >> Sheng Yang wrote: >>> Based on upstream xsave related fields. >>> >>> Signed-off-by: Sheng Yang >>> --- >>> >>> qemu-kvm-x86.c | 95 >>> +++- qemu-kvm.c >>> | 24

[Qemu-devel] Re: [PATCH V4 2/3] qemu: Generic task offloading framework: threadlets

2010-06-17 Thread Gautham R Shenoy
On Wed, Jun 16, 2010 at 02:34:16PM +0200, Paolo Bonzini wrote: >> +block-obj-y += qemu-thread.o >> +block-obj-y += async-work.o > > These should be (at least for now) block-obj-$(CONFIG_POSIX). Right. Will fix that. > >> +while (QTAILQ_EMPTY(&(queue->request_list))&& >> + (re

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-17 Thread Gleb Natapov
On Wed, Jun 16, 2010 at 09:22:09PM -0400, Kevin O'Connor wrote: > On Tue, Jun 15, 2010 at 09:37:07AM +0300, Gleb Natapov wrote: > > On Mon, Jun 14, 2010 at 04:12:32PM -0400, Kevin O'Connor wrote: > > > But.. in order to move to a newer ACPI spec, there would be qemu > > > changes anyway. (If nothi

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-17 Thread Gleb Natapov
On Thu, Jun 17, 2010 at 10:42:34AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Thu, Jun 17, 2010 at 10:30:15AM +0200, Jan Kiszka wrote: > >>> Sorry, I lost you here. What "works for IO-based fw-cfg, but not for > >>> MMIO-based". > >> Undefined IO ports return -1, undefined (/wrt read acc

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-17 Thread Jan Kiszka
Gleb Natapov wrote: > On Thu, Jun 17, 2010 at 10:42:34AM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Thu, Jun 17, 2010 at 10:30:15AM +0200, Jan Kiszka wrote: > Sorry, I lost you here. What "works for IO-based fw-cfg, but not for > MMIO-based". Undefined IO ports return -1, u

[Qemu-devel] Re: [PATCH 3/4] qemu: kvm: Enable XSAVE live migration support

2010-06-17 Thread Jan Kiszka
Sheng Yang wrote: > Signed-off-by: Sheng Yang > --- > target-i386/cpu.h |7 ++- > target-i386/kvm.c | 139 > - > target-i386/machine.c | 20 +++ > 3 files changed, 163 insertions(+), 3 deletions(-) > > diff --git a/target-i386/c

Re: [Qemu-devel] Re: [PATCH V4 2/3] qemu: Generic task offloading framework: threadlets

2010-06-17 Thread Gautham R Shenoy
On Wed, Jun 16, 2010 at 10:20:36AM -0500, Anthony Liguori wrote: > On 06/16/2010 09:52 AM, Paolo Bonzini wrote: >> BTW it's obviously okay with signaling the condition when a threadlet is >> submitted. But when something affects all queue's workers >> (flush_threadlet_queue) you want a broadcast

Re: [Qemu-devel] Re: [PATCH V4 2/3] qemu: Generic task offloading framework: threadlets

2010-06-17 Thread Gautham R Shenoy
On Wed, Jun 16, 2010 at 06:06:35PM +0200, Corentin Chary wrote: > On Wed, Jun 16, 2010 at 5:52 PM, Anthony Liguori > wrote: > > On 06/16/2010 10:47 AM, Corentin Chary wrote: > >> > >> I would need something like flush_threadlet_queue for the vnc server. > >> I need it in > >> vnc_disconnect(), vnc

Re: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-17 Thread Gleb Natapov
On Thu, Jun 17, 2010 at 10:59:01AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Thu, Jun 17, 2010 at 10:42:34AM +0200, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Thu, Jun 17, 2010 at 10:30:15AM +0200, Jan Kiszka wrote: > > Sorry, I lost you here. What "works for IO-based fw-cf

[Qemu-devel] Re: [PATCH 09/10] pci: set PCI multi-function bit appropriately.

2010-06-17 Thread Michael S. Tsirkin
On Thu, Jun 17, 2010 at 03:15:51PM +0900, Isaku Yamahata wrote: > set PCI multi-function bit appropriately. > > Signed-off-by: Isaku Yamahata > > --- > changes v1 -> v2: > don't set header type register in configuration space. > --- > hw/pci.c | 25 + > 1 files changed

[Qemu-devel] Re: [PATCH 10/10] pci: don't overwrite multi functio bit in pci header type.

2010-06-17 Thread Michael S. Tsirkin
On Thu, Jun 17, 2010 at 03:15:52PM +0900, Isaku Yamahata wrote: > Don't overwrite pci header type. > Otherwise, multi function bit which pci_init_header_type() sets > appropriately is lost. > Anyway PCI_HEADER_TYPE_NORMAL is zero, so it is unnecessary to zero > which is already zero cleared. > > S

[Qemu-devel] [PATCH 3/4] qemu: kvm: Enable XSAVE live migration support

2010-06-17 Thread Sheng Yang
Signed-off-by: Sheng Yang --- kvm-all.c | 21 +++ kvm.h |2 + target-i386/cpu.h |7 ++- target-i386/kvm.c | 139 - target-i386/machine.c | 20 +++ 5 files changed, 186 insertions(+), 3 deleti

[Qemu-devel] Re: [PATCH 04/10] pci_bridge: introduce pci bridge layer.

2010-06-17 Thread Michael S. Tsirkin
On Thu, Jun 17, 2010 at 03:15:46PM +0900, Isaku Yamahata wrote: > introduce pci bridge layer. > export pci_bridge_write_config() for generic use. > support device reset and bus reset of bridge control. > convert apb bridge and dec p2p bridge to use new pci bridge layer. > save/restore is supported

[Qemu-devel] [PATCH] qemu-kvm: Replace kvm_set/get_fpu() with upstream version.

2010-06-17 Thread Sheng Yang
Signed-off-by: Sheng Yang --- Would send out XSAVE patch after the upstream ones have been merged, since the patch would be affected by the merge. qemu-kvm-x86.c| 23 ++- qemu-kvm.c| 10 -- qemu-kvm.h| 30 -- tar

[Qemu-devel] Re: [PATCH 00/10] pci: pci to pci bridge clean up and enhancement

2010-06-17 Thread Michael S. Tsirkin
On Thu, Jun 17, 2010 at 03:15:42PM +0900, Isaku Yamahata wrote: > This patch series cleans up pci to pci bridge layer by introducing > pci bridge layer. and some bug fixes. > Although pci bridge implementation would belong to pci.c, > I split it out into pci_bridge.c because pci.c is already big en

[Qemu-devel] Re: [PATCH V4 2/3] qemu: Generic task offloading framework: threadlets

2010-06-17 Thread Paolo Bonzini
+while (QTAILQ_EMPTY(&(queue->request_list))&& + (ret != ETIMEDOUT)) { +ret = qemu_cond_timedwait(&(queue->cond), + &(queue->lock), 10*10); +} Using qemu_cond_timedwait is a hack for not properly broadcasting the

[Qemu-devel] Re: [PATCH 02/10] qdev: export qdev_reset() for later use.

2010-06-17 Thread Michael S. Tsirkin
On Thu, Jun 17, 2010 at 03:15:44PM +0900, Isaku Yamahata wrote: > export qdev_reset() for later use. > > Signed-off-by: Isaku Yamahata > --- > hw/qdev.c | 13 + > hw/qdev.h |1 + > 2 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/hw/qdev.c b/hw/qdev.c > index

[Qemu-devel] Re: [PATCH 05/10] pci bridge: add helper function for ssvid capability.

2010-06-17 Thread Michael S. Tsirkin
On Thu, Jun 17, 2010 at 03:15:47PM +0900, Isaku Yamahata wrote: > helper function to add ssvid capability. > > Signed-off-by: Isaku Yamahata But .. this is unused? > --- > hw/pci_bridge.c | 20 > hw/pci_bridge.h |3 +++ > 2 files changed, 23 insertions(+), 0 deletion

Re: [Qemu-devel] RFC v3: blockdev_add & friends, brief rationale, QMP docs

2010-06-17 Thread Stefan Hajnoczi
On Wed, Jun 16, 2010 at 6:27 PM, Markus Armbruster wrote: > blockdev_add > > > Add host block device. > > Arguments: > > - "id": the host block device's ID, must be unique (json-string) > - "format": image format (json-string, optional) >    - Possible values: "raw", "qcow2", ... Wha

[Qemu-devel] Re: [PATCH 5/5] linux fbdev display driver.

2010-06-17 Thread Gerd Hoffmann
Hi, +static void fbdev_free_displaysurface(DisplaySurface *surface) +{ +if (surface == NULL) +return; + +if (surface->flags& QEMU_ALLOCATED_FLAG) { +qemu_free(surface->data); +} + +surface->data = NULL; This is pretty pointless ... +qemu_free(surface);

[Qemu-devel] [Bug 595438] Re: KVM segmentation fault, using SCSI+writeback and linux 2.4 guest

2010-06-17 Thread Коренберг Марк
** Summary changed: - segmentation scsi writeback + KVM segmentation fault, using SCSI+writeback and linux 2.4 guest -- KVM segmentation fault, using SCSI+writeback and linux 2.4 guest https://bugs.launchpad.net/bugs/595438 You received this bug notification because you are a member of qemu- de

[Qemu-devel] [Bug 595438] Re: segmentation scsi writeback

2010-06-17 Thread Коренберг Марк
Bug 100% reproductible (on this, and on other machine with different processor) core dump (bzip2) attached ** Attachment added: "core dump" http://launchpadlibrarian.net/50482028/core.bz2 -- segmentation scsi writeback https://bugs.launchpad.net/bugs/595438 You received this bug notificati

[Qemu-devel] [Bug 595438] [NEW] segmentation scsi writeback

2010-06-17 Thread Коренберг Марк
Public bug reported: I Use Ubuntu 32 bit 10.04 with standerd kvm. I have E7600 @ 3.06GHz processor with VMX In this system I Run: LC_ALL=C PATH=/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/sbin:/sbin:/bin QEMU_AUDIO_DRV=none /usr/bin/kvm -M pc-0.12 -enable-kvm -m 256 -smp 1 -name spamsender -u

[Qemu-devel] [Bug 595438] Re: segmentation scsi writeback

2010-06-17 Thread Коренберг Марк
do not fuck me about 'spamsender' machine name. I never send spam. it's just our mail server :) -- segmentation scsi writeback https://bugs.launchpad.net/bugs/595438 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New

[Qemu-devel] [PATCH 0/8] seabios: pci: multi pci bus support

2010-06-17 Thread Isaku Yamahata
This patch set allows seabios to initialize multi pci bus and 64bit BAR. Currently seabios is able to initialize only pci root bus. However multi pci bus support is wanted because - more pci bus is wanted in qemu for many slots - pci express support is commin in qemu which requires multi pci b

[Qemu-devel] [PATCH 7/8] seabios: pciinit: pci bridge bus initialization.

2010-06-17 Thread Isaku Yamahata
pci bridge bus initialization. Signed-off-by: Isaku Yamahata --- src/pciinit.c | 70 + 1 files changed, 70 insertions(+), 0 deletions(-) diff --git a/src/pciinit.c b/src/pciinit.c index 1c2c8c6..fe6848a 100644 --- a/src/pciinit.c +++ b/s

[Qemu-devel] [PATCH 2/8] seabios: pciinit: factor out pci bar region allocation logic.

2010-06-17 Thread Isaku Yamahata
factor out pci bar region allocation logic. Signed-off-by: Isaku Yamahata --- src/pciinit.c | 84 - 1 files changed, 47 insertions(+), 37 deletions(-) diff --git a/src/pciinit.c b/src/pciinit.c index 0556ee2..488c77b 100644 --- a/src/pci

[Qemu-devel] Re: [PATCH 03/10] pci: fix pci_bus_reset() with 64bit BAR and several clean ups.

2010-06-17 Thread Michael S. Tsirkin
On Thu, Jun 17, 2010 at 03:15:45PM +0900, Isaku Yamahata wrote: > fix pci_device_reset() with 64bit BAR. > export pci_bus_reset(), pci_device_reset() and two helper functions > for later use. And several clean ups. > > Signed-off-by: Isaku Yamahata > --- > hw/pci.c | 44 +++

[Qemu-devel] [PATCH 1/8] seabios: pci: introduce foreachpci_in_bus() helper macro.

2010-06-17 Thread Isaku Yamahata
This patch introduces foreachpci_in_bus() helper macro for depth first recursion. foreachpci() is for width first recursion. The macro will be used later to initialize pci bridge that requires depth first recursion. Signed-off-by: Isaku Yamahata --- src/pci.c | 30 +

[Qemu-devel] [PATCH 4/8] seabios: pciinit: make pci bar assigner preferchable memory aware.

2010-06-17 Thread Isaku Yamahata
Make pci bar assigner preferchable memory aware. This is needed for PCI bridge support because memory space and prefetchable memory space is filtered independently based on memory base/limit and prefetchable memory base/limit of pci bridge. On bus 0, such a distinction isn't necessary so keep exist

[Qemu-devel] [PATCH 5/8] seabios: pciinit: factor out bar offset calculation.

2010-06-17 Thread Isaku Yamahata
This patch factors out bar offset calculation. Later the calculation logic will be enhanced. Signed-off-by: Isaku Yamahata --- src/pciinit.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/pciinit.c b/src/pciinit.c index b6ab157..6ba51f2 100644 -

[Qemu-devel] [PATCH 8/8] seabios: pciinit: initialize pci bridge filtering registers.

2010-06-17 Thread Isaku Yamahata
initialize pci bridge filtering registers. Signed-off-by: Isaku Yamahata --- src/pciinit.c | 117 +++- 1 files changed, 114 insertions(+), 3 deletions(-) diff --git a/src/pciinit.c b/src/pciinit.c index fe6848a..f68a690 100644 --- a/src/pciin

[Qemu-devel] [PATCH 6/8] seabios: pciinit: make bar offset calculation pci bridge aware.

2010-06-17 Thread Isaku Yamahata
This patch makes pci bar offset calculation pci bridge aware. The offset of pci bridge rom is different from normal device. Signed-off-by: Isaku Yamahata --- src/pciinit.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/pciinit.c b/src/pciinit.c index 6ba51f2..1

[Qemu-devel] [PATCH 3/8] seabios: pciinit: make pci memory space assignment 64bit aware.

2010-06-17 Thread Isaku Yamahata
make pci memory space assignment 64bit aware. If 64bit memory space is found while assigning pci memory space, clear higher bit and skip to next bar. This patch is preparation for q35 chipset initialization which has 64bit bar. Signed-off-by: Isaku Yamahata --- src/pciinit.c | 19

[Qemu-devel] [PATCH] vmware_vga: fix reset value for command register

2010-06-17 Thread Michael S. Tsirkin
Make init value for this register match the spec. BAR address is 0 at init, so enabling it only works by chance. Signed-off-by: Michael S. Tsirkin --- This patch is untested. Could someone who has vmware guests please look at it? Thanks! hw/vmware_vga.c |3 --- 1 files changed, 0 insertion

[Qemu-devel] [PATCH] pcnet: address TODOs

2010-06-17 Thread Michael S. Tsirkin
pcnet enables memory/io on init, which does not make sense as BAR values are wrong. Fix this, disabling BARs according to PCI spec. Address other minor TODOs. Signed-off-by: Michael S. Tsirkin --- The following untested patch brings pcnet in compliance with the spec. Could someone who's interest

[Qemu-devel] Re: [PATCH 0/8] seabios: pci: multi pci bus support

2010-06-17 Thread Michael S. Tsirkin
On Thu, Jun 17, 2010 at 08:03:08PM +0900, Isaku Yamahata wrote: > This patch set allows seabios to initialize multi pci bus and 64bit BAR. > > Currently seabios is able to initialize only pci root bus. > However multi pci bus support is wanted because > - more pci bus is wanted in qemu for many

[Qemu-devel] Re: [PATCH 00/10] pci: pci to pci bridge clean up and enhancement

2010-06-17 Thread Michael S. Tsirkin
On Thu, Jun 17, 2010 at 01:02:43PM +0300, Michael S. Tsirkin wrote: > For example, forcing all devices to call pci_reset_default > in their reset routines does not look like a good cleanup: > the less boilerplate, the better IMO. One thing that we need to address, is devices which need to enable m

[Qemu-devel] [RFC][PATCH 0/2] block: Add flush after metadata writes

2010-06-17 Thread Kevin Wolf
This addresses the data integrity problems described at http://wiki.qemu.org/Features/Qcow2DataIntegrity#Metadata_update_ordering.2C_Part_2 These problems are the same for all image formats (except raw, which doesn't have any metadata), so I'm going to add more patches for the other formats for th

[Qemu-devel] [RFC][PATCH 1/2] block: Add bdrv_(p)write_sync

2010-06-17 Thread Kevin Wolf
Add new functions that write and flush the written data to disk immediately. This is what needs to be used for image format metadata to maintain integrity for cache=... modes that don't use O_DSYNC. (Actually, we only need barriers, and therefore the functions are defined as such, but flushes is wh

[Qemu-devel] [RFC][PATCH 2/2] qcow2: Use bdrv_(p)write_sync for metadata writes

2010-06-17 Thread Kevin Wolf
Use bdrv_(p)write_sync to ensure metadata integrity in case of a crash. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 16 block/qcow2-refcount.c | 18 +- block/qcow2-snapshot.c | 14 +++--- block/qcow2.c | 10 +- 4 files

Re: [Qemu-devel] RFC v3: blockdev_add & friends, brief rationale, QMP docs

2010-06-17 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Wed, Jun 16, 2010 at 6:27 PM, Markus Armbruster wrote: >> blockdev_add >> >> >> Add host block device. >> >> Arguments: >> >> - "id": the host block device's ID, must be unique (json-string) >> - "format": image format (json-string, optional) >>    - Pos

[Qemu-devel] Re: [Bug 595117] Re: qemu-nbd slow and missing "writeback" cache option

2010-06-17 Thread Stephane Chazelas
2010-06-16 20:36:00 -, Dustin Kirkland: [...] > Could you please send that patch to the qemu-devel@ mailing list? > Thanks! [...] Hi Dustin, it looks like qemu-devel is subscribed to bugs in there, so the bug report is on the list already. Note that I still consider it as a bug because: - s

[Qemu-devel] [PATCH v2] monitor: Really show snapshot information about all devices

2010-06-17 Thread Miguel Di Ciurcio Filho
The 'info snapshots' monitor command does not show snapshot information from all available block devices. Usage example: $ qemu -hda disk1.qcow2 -hdb disk2.qcow2 (qemu) info snapshots Snapshot devices: ide0-hd0 Snapshot list (from ide0-hd0): IDTAG VM SIZEDA

Re: [Qemu-devel] Re: RFC v2: blockdev_add & friends, brief rationale, QMP docs

2010-06-17 Thread Anthony Liguori
On 06/17/2010 03:20 AM, Kevin Wolf wrote: Am 16.06.2010 20:07, schrieb Anthony Liguori: But it requires that everything that -blockdev provides is accessible with -drive, too (or that we're okay with users hating us). I'm happy for -drive to die. I think we should support -hda

[Qemu-devel] Re: [PATCH] pcnet: address TODOs

2010-06-17 Thread Jan Kiszka
Michael S. Tsirkin wrote: > pcnet enables memory/io on init, which > does not make sense as BAR values are wrong. > Fix this, disabling BARs according to PCI spec. > Address other minor TODOs. > > Signed-off-by: Michael S. Tsirkin > --- > > The following untested patch brings pcnet in > complian

[Qemu-devel] Re: [PATCH 3/4] qemu: kvm: Enable XSAVE live migration support

2010-06-17 Thread Jan Kiszka
Sheng Yang wrote: > Signed-off-by: Sheng Yang > --- > kvm-all.c | 21 +++ > kvm.h |2 + > target-i386/cpu.h |7 ++- > target-i386/kvm.c | 139 > - > target-i386/machine.c | 20 +++ > 5 files

[Qemu-devel] Re: [PATCH] qemu-kvm: Replace kvm_set/get_fpu() with upstream version.

2010-06-17 Thread Jan Kiszka
Sheng Yang wrote: > Signed-off-by: Sheng Yang > --- > > Would send out XSAVE patch after the upstream ones have been merged, since the > patch would be affected by the merge. > > qemu-kvm-x86.c| 23 ++- > qemu-kvm.c| 10 -- > qemu-kvm.h| 30

Re: [Qemu-devel] Q35 qemu repository?

2010-06-17 Thread Matthew Garrett
On Thu, Jun 17, 2010 at 04:48:09PM +0900, Isaku Yamahata wrote: > Thanks for the patch. > Does vista boot with the patch eventually? Vista boots, but is unable to allocate resources for the pcie root ports. I'm looking into that. -- Matthew Garrett | mj...@srcf.ucam.org

Re: [Qemu-devel] Re: RFC v2: blockdev_add & friends, brief rationale, QMP docs

2010-06-17 Thread Kevin Wolf
Am 17.06.2010 15:01, schrieb Anthony Liguori: > On 06/17/2010 03:20 AM, Kevin Wolf wrote: >> Am 16.06.2010 20:07, schrieb Anthony Liguori: >> But it requires that everything that -blockdev provides is accessible with -drive, too (or that we're okay with users hating us).

[Qemu-devel] Re: [RFC][PATCH 2/2] qcow2: Use bdrv_(p)write_sync for metadata writes

2010-06-17 Thread Stefan Hajnoczi
On Thu, Jun 17, 2010 at 1:03 PM, Kevin Wolf wrote: > Use bdrv_(p)write_sync to ensure metadata integrity in case of a crash. Any performance numbers? This change is necessary for correctness but I wonder what the performance impact is for users. Stefan

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-17 Thread Luiz Capitulino
On Wed, 16 Jun 2010 21:10:04 +0200 Juan Quintela wrote: > Luiz Capitulino wrote: > > On Tue, 15 Jun 2010 17:24:59 +0200 > > Juan Quintela wrote: > > >> > > >> > I still don't see the need for MIGRATION_STARTED, it could be useful in > >> > the target but I'd like to understand the use case in

[Qemu-devel] Re: [PATCH 5/5] linux fbdev display driver.

2010-06-17 Thread Julian Pidancet
On 06/17/2010 11:43 AM, Gerd Hoffmann wrote: >Hi, > > You register the display allocator, but don't unregister in > fbdev_display_uninit(). > > You are just lucky that fbdev_cleanup() forgets to unmap the framebuffer. > > Apply the attached fix, start qemu with vnc, then do "change fbdev on

[Qemu-devel] Re: [PATCH v2] monitor: Really show snapshot information about all devices

2010-06-17 Thread Luiz Capitulino
On Thu, 17 Jun 2010 09:58:37 -0300 Miguel Di Ciurcio Filho wrote: > The 'info snapshots' monitor command does not show snapshot information from > all > available block devices. > > Usage example: > $ qemu -hda disk1.qcow2 -hdb disk2.qcow2 > > (qemu) info snapshots > Snapshot devices: ide0-hd0

[Qemu-devel] Re: [RFC][PATCH 2/2] qcow2: Use bdrv_(p)write_sync for metadata writes

2010-06-17 Thread Kevin Wolf
Am 17.06.2010 16:19, schrieb Stefan Hajnoczi: > On Thu, Jun 17, 2010 at 1:03 PM, Kevin Wolf wrote: >> Use bdrv_(p)write_sync to ensure metadata integrity in case of a crash. > > Any performance numbers? This change is necessary for correctness but > I wonder what the performance impact is for us

[Qemu-devel] Re: [CFR 0/10] QMP specification review

2010-06-17 Thread Luiz Capitulino
On Tue, 15 Jun 2010 11:30:20 -0500 Anthony Liguori wrote: > This is the first set of commands as part of the QMP specification review. > Please comment on the individual commands specifications and Stefan and I will > try to fold the comments back into the command documentation. Very nice! A

[Qemu-devel] Re: [PATCH 2/3] Monitor command 'info trace'

2010-06-17 Thread Stefan Hajnoczi
On Wed, Jun 16, 2010 at 06:12:06PM +0530, Prerna Saxena wrote: > diff --git a/simpletrace.c b/simpletrace.c > index 2fec4d3..239ae3f 100644 > --- a/simpletrace.c > +++ b/simpletrace.c > @@ -62,3 +62,16 @@ void trace4(TraceEvent event, unsigned long x1, unsigned > long x2, unsigned long > void tra

RE: [Qemu-devel] VLIW?

2010-06-17 Thread Gibbons, Scott
Yes, as a guest. Thanks for the helpful suggestions. We have a closed pipeline and code errors are caught by the assembler. Delaying writeback is most likely what I'll be doing. Another question I have is how to handle this multithreaded architecture. This seems to be extraordinarily diffic

[Qemu-devel] [PATCH] virtio-pci: fix bus master bug setting on load

2010-06-17 Thread Alex Williamson
The comment suggests we're checking for the driver in the ready state and bus master disabled, but the code is checking that it's not in the ready state. Signed-off-by: Alex Williamson Found-by: Amit Shah --- hw/virtio-pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --g

[Qemu-devel] Re: [PATCH] virtio-pci: fix bus master bug setting on load

2010-06-17 Thread Michael S. Tsirkin
On Thu, Jun 17, 2010 at 09:15:02AM -0600, Alex Williamson wrote: > The comment suggests we're checking for the driver in the ready > state and bus master disabled, but the code is checking that it's > not in the ready state. > > Signed-off-by: Alex Williamson > Found-by: Amit Shah Acked-by: Mic

[Qemu-devel] Re: [PATCH] virtio-pci: fix bus master bug setting on load

2010-06-17 Thread Amit Shah
On (Thu) Jun 17 2010 [09:15:02], Alex Williamson wrote: > The comment suggests we're checking for the driver in the ready > state and bus master disabled, but the code is checking that it's > not in the ready state. > > Signed-off-by: Alex Williamson > Found-by: Amit Shah > --- Acked-by: Amit S

Re: [Qemu-devel] VLIW?

2010-06-17 Thread Richard Henderson
On 06/17/2010 08:12 AM, Gibbons, Scott wrote: > Another question I have is how to handle this multithreaded > architecture. This seems to be extraordinarily difficult as a > dynamic translation problem and I'll probably defer it to later. > But, if anyone has any suggestions, I'd be glad to hear t

[Qemu-devel] Re: [PATCH] virtio-pci: fix bus master bug setting on load

2010-06-17 Thread Alexander Graf
Alex Williamson wrote: > The comment suggests we're checking for the driver in the ready > state and bus master disabled, but the code is checking that it's > not in the ready state. > > Signed-off-by: Alex Williamson > Found-by: Amit Shah > --- > > hw/virtio-pci.c |2 +- > 1 files changed,

[Qemu-devel] Re: [Bug 595117] Re: qemu-nbd slow and missing "writeback" cache option

2010-06-17 Thread Dustin Kirkland
Stephane- I understand your plight. However, according to the rules and policies of the QEMU project, you must submit the patch on the qemu-devel@ mailing list, in addition to (or instead of) in the bug tracker. It's not my project, not my policy. I'm just trying to make sure you get your patch

[Qemu-devel] Re: [PATCH 3/3] Toggle tracepoint state

2010-06-17 Thread Stefan Hajnoczi
On Wed, Jun 16, 2010 at 06:14:35PM +0530, Prerna Saxena wrote: > This patch adds support for dynamically enabling/disabling of tracepoints. > This is done by internally maintaining each tracepoint's state, and > permitting logging of data from a tracepoint only if it is in an > 'active' state. >

Re: [Qemu-devel] Re: [PATCH 5/5] linux fbdev display driver.

2010-06-17 Thread Julian Pidancet
On 06/17/2010 03:29 PM, Julian Pidancet wrote: > > Hi, > > Thanks for spotting these errors. Here is a respin of my patch to address you > concerns. > (The munmap call is included). > > Cheers, > > Julian > Oh, I actually tested the last patch only with the -nographic switch. There's still

[Qemu-devel] [Bug 595117] Re: qemu-nbd slow and missing "writeback" cache option

2010-06-17 Thread Brian Murray
** Tags added: patch -- qemu-nbd slow and missing "writeback" cache option https://bugs.launchpad.net/bugs/595117 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: Invalid Status in “qemu-kvm” package in Ubuntu: Incomplete

[Qemu-devel] Re: [PATCH] virtio-pci: fix bus master bug setting on load

2010-06-17 Thread Juan Quintela
Alex Williamson wrote: > The comment suggests we're checking for the driver in the ready > state and bus master disabled, but the code is checking that it's > not in the ready state. > > Signed-off-by: Alex Williamson > Found-by: Amit Shah Acked-by: Juan Quintela > --- > > hw/virtio-pci.c |

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-17 Thread Luiz Capitulino
On Thu, 17 Jun 2010 18:34:00 +0200 Juan Quintela wrote: > Luiz Capitulino wrote: > > On Wed, 16 Jun 2010 21:10:04 +0200 > > Juan Quintela wrote: > > > >> Luiz Capitulino wrote: > >> > On Tue, 15 Jun 2010 17:24:59 +0200 > >> > Juan Quintela wrote: > >> > >> >> > > >> >> > I still don't see t

Re: [Qemu-devel] Re: [PATCH 1/2] qemu-io: retry fgets() when errno is EINTRg

2010-06-17 Thread Jamie Lokier
Kevin Wolf wrote: > Am 16.06.2010 18:52, schrieb MORITA Kazutaka: > > At Wed, 16 Jun 2010 13:04:47 +0200, > > Kevin Wolf wrote: > >> > >> Am 15.06.2010 19:53, schrieb MORITA Kazutaka: > >>> posix-aio-compat sends a signal in aio operations, so we should > >>> consider that fgets() could be interrup

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-17 Thread Juan Quintela
Luiz Capitulino wrote: > On Wed, 16 Jun 2010 21:10:04 +0200 > Juan Quintela wrote: > >> Luiz Capitulino wrote: >> > On Tue, 15 Jun 2010 17:24:59 +0200 >> > Juan Quintela wrote: >> >> >> > >> >> > I still don't see the need for MIGRATION_STARTED, it could be useful in >> >> > the target but I'

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-17 Thread Anthony Liguori
On 06/17/2010 11:45 AM, Luiz Capitulino wrote: On Thu, 17 Jun 2010 18:34:00 +0200 Juan Quintela wrote: Luiz Capitulino wrote: On Wed, 16 Jun 2010 21:10:04 +0200 Juan Quintela wrote: Luiz Capitulino wrote: On Tue, 15 Jun 2010 17:24:59 +0200 Juan Quintela wrot

Re: [Qemu-devel] Re: [PATCH V4 2/3] qemu: Generic task offloading framework: threadlets

2010-06-17 Thread Anthony Liguori
On 06/17/2010 05:09 AM, Paolo Bonzini wrote: +while (QTAILQ_EMPTY(&(queue->request_list))&& + (ret != ETIMEDOUT)) { +ret = qemu_cond_timedwait(&(queue->cond), + &(queue->lock), 10*10); +} Using qemu_cond_timedwait is a hack for not properly broadcas

RE: [Qemu-devel] VLIW?

2010-06-17 Thread Gibbons, Scott
My architecture is an Interleaved Multithreading VLIW architecture. One bundle (packet) executes per processor cycle, rotating between threads (i.e., thread 0 executes at time 0, thread 1 executes at time 1, then thread 0 executes at time 2, etc.). Each thread has its own context (including a

Re: [Qemu-devel] VLIW?

2010-06-17 Thread Richard Henderson
On 06/17/2010 11:05 AM, Gibbons, Scott wrote: > My architecture is an Interleaved Multithreading VLIW architecture. > One bundle (packet) executes per processor cycle, rotating between > threads (i.e., thread 0 executes at time 0, thread 1 executes at time > 1, then thread 0 executes at time 2, etc

Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command

2010-06-17 Thread Luiz Capitulino
On Tue, 15 Jun 2010 11:03:13 +0200 Markus Armbruster wrote: > Anthony Liguori writes: > > > On 06/09/2010 09:27 AM, Gerd Hoffmann wrote: > >> Hi, > >> > >>> This make sense when you mistakenly add a pci device on a -s -S > >>> scenario, like the scenario described on the following bug: > >>>

Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command

2010-06-17 Thread Anthony Liguori
On 06/17/2010 01:15 PM, Luiz Capitulino wrote: This is a general question for all commands that can take way too long or never return. For QMP the question is whether we should handle this in QEMU or in the client. Ie, if the guest doesn't respond the client could detect that and cancel the

Re: [Qemu-devel] VLIW?

2010-06-17 Thread Jamie Lokier
Gibbons, Scott wrote: > My architecture is an Interleaved Multithreading VLIW architecture. One > bundle (packet) executes per processor cycle, rotating between threads (i.e., > thread 0 executes at time 0, thread 1 executes at time 1, then thread 0 > executes at time 2, etc.). Each thread has

[Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v3)

2010-06-17 Thread Christian Brunner
Hi Simone, sorry for the late reply. I've been on vacation for a week. Thanks for sending the patch. At first sight your patch looks good. I'll do some testing by the weekend. Kevin also sent me a note about the missing aio support, but I didn't have the time to implement it yet. Now it seems, t

  1   2   >