Re: [Qemu-devel] Re: KVM call minutes for June 15

2010-06-16 Thread Markus Armbruster
Anthony Liguori writes: > On 06/15/2010 10:41 AM, Christoph Hellwig wrote: >> On Tue, Jun 15, 2010 at 08:18:12AM -0700, Chris Wright wrote: >> >>> KVM/qemu patches >>> - patch rate is high, documentation is low, review is low >>> - patches need to include better descriptions and documentation

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Jan Kiszka
Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 12:40:28AM +0200, Jan Kiszka wrote: >> From: Jan Kiszka >> >> There is no need starting with the special value for hpet_cfg.count. >> Either Seabios is aware of the new firmware interface and properly >> interprets the counter or it simply ignores it a

[Qemu-devel] [Bug 581353] Re: qemu doesn't stop execution upon hitting a breakpoint

2010-06-16 Thread Alfredo Mungo
Same thing happens to me, same versions as above.. I must turn to another app to accomplish my work while awaiting for a bug-fix, the code is perfectly executed but while gdb hits the breakpoints qemu goes on.. -- qemu doesn't stop execution upon hitting a breakpoint https://bugs.launchpad.net/bu

Re: [Qemu-devel] [Bug 581353] Re: qemu doesn't stop execution upon hitting a breakpoint

2010-06-16 Thread Jun Koi
On Wed, Jun 16, 2010 at 4:07 PM, Alfredo Mungo wrote: > Same thing happens to me, same versions as above.. I must turn to > another app to accomplish my work while awaiting for a bug-fix, the code > is perfectly executed but while gdb hits the breakpoints qemu goes on.. > > -- > qemu doesn't stop

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Gleb Natapov
On Wed, Jun 16, 2010 at 09:03:01AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Jun 16, 2010 at 12:40:28AM +0200, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> There is no need starting with the special value for hpet_cfg.count. > >> Either Seabios is aware of the new firmware in

[Qemu-devel] Re: [Bug 581353] Re: qemu doesn't stop execution upon hitting a breakpoint

2010-06-16 Thread Jan Kiszka
Jun Koi wrote: > On Wed, Jun 16, 2010 at 4:07 PM, Alfredo Mungo wrote: >> Same thing happens to me, same versions as above.. I must turn to >> another app to accomplish my work while awaiting for a bug-fix, the code >> is perfectly executed but while gdb hits the breakpoints qemu goes on.. >> >> -

[Qemu-devel] Re: [Bug 581353] Re: qemu doesn't stop execution upon hitting a breakpoint

2010-06-16 Thread Jun Koi
On Wed, Jun 16, 2010 at 4:40 PM, Jan Kiszka wrote: > Jun Koi wrote: >> On Wed, Jun 16, 2010 at 4:07 PM, Alfredo Mungo >> wrote: >>> Same thing happens to me, same versions as above.. I must turn to >>> another app to accomplish my work while awaiting for a bug-fix, the code >>> is perfectly exec

Re: [Qemu-devel] [PATCH 1/4] savevm: refactor qemu_loadvm_state().

2010-06-16 Thread Yoshiaki Tamura
Anthony Liguori wrote: On 06/14/2010 09:01 PM, Yoshiaki Tamura wrote: Anthony Liguori wrote: On 06/03/2010 02:22 AM, Yoshiaki Tamura wrote: Split qemu_loadvm_state(), and introduce qemu_loadvm_state_{begin,iterate,complete,async}. qemu_loadvm_state_async() is a function to handle a single inco

[Qemu-devel] Re: [Bug 581353] Re: qemu doesn't stop execution upon hitting a breakpoint

2010-06-16 Thread Jan Kiszka
Jun Koi wrote: > On Wed, Jun 16, 2010 at 4:40 PM, Jan Kiszka wrote: >> Jun Koi wrote: >>> On Wed, Jun 16, 2010 at 4:07 PM, Alfredo Mungo >>> wrote: Same thing happens to me, same versions as above.. I must turn to another app to accomplish my work while awaiting for a bug-fix, the code

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Jan Kiszka
Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 09:03:01AM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Wed, Jun 16, 2010 at 12:40:28AM +0200, Jan Kiszka wrote: From: Jan Kiszka There is no need starting with the special value for hpet_cfg.count. Either Seabios is aware

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Gleb Natapov
On Wed, Jun 16, 2010 at 09:51:14AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Jun 16, 2010 at 09:03:01AM +0200, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Wed, Jun 16, 2010 at 12:40:28AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > There is no need starti

[Qemu-devel] Re: [Bug 581353] Re: qemu doesn't stop execution upon hitting a breakpoint

2010-06-16 Thread Jan Kiszka
[Please keep the list in CC] chimerane...@gmail.com wrote: > I never thought about this, since I always used qemu + gdb without > having this kind of trouble.. I just finished compiling version 0.12.4, > and I will surely try what you are suggesting, I really appreciate your > help. The restricti

[Qemu-devel] Re: [Bug 581353] Re: qemu doesn't stop execution upon hitting a breakpoint

2010-06-16 Thread Jun Koi
On Wed, Jun 16, 2010 at 4:49 PM, Jan Kiszka wrote: > Jun Koi wrote: >> On Wed, Jun 16, 2010 at 4:40 PM, Jan Kiszka wrote: >>> Jun Koi wrote: On Wed, Jun 16, 2010 at 4:07 PM, Alfredo Mungo wrote: > Same thing happens to me, same versions as above.. I must turn to > another app

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Jan Kiszka
Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 09:51:14AM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Wed, Jun 16, 2010 at 09:03:01AM +0200, Jan Kiszka wrote: Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 12:40:28AM +0200, Jan Kiszka wrote: >> From: Jan Kiszka >> >>

[Qemu-devel] Re: [Bug 581353] Re: qemu doesn't stop execution upon hitting a breakpoint

2010-06-16 Thread Jan Kiszka
Jun Koi wrote: > On Wed, Jun 16, 2010 at 4:49 PM, Jan Kiszka wrote: >> Jun Koi wrote: >>> On Wed, Jun 16, 2010 at 4:40 PM, Jan Kiszka wrote: Jun Koi wrote: > On Wed, Jun 16, 2010 at 4:07 PM, Alfredo Mungo > wrote: >> Same thing happens to me, same versions as above.. I must tur

[Qemu-devel] Re: Re: [Bug 581353] Re: qemu doesn't stop execution upon hitting a breakpoint

2010-06-16 Thread chimeranet89
Ok this is it: I've just compiled and tried qemu 0.12.4, this bug has been fixed and it works perfectly again, I'm adding a report to launchpad within the next few seconds.. Thank you for the support.

[Qemu-devel] [PATCH v6 3/4] Use cpu_physical_memory_set_dirty_range() to update dirty bitmap.

2010-06-16 Thread Yoshiaki Tamura
Modifies kvm_physical_sync_dirty_bitmap to use cpu_physical_memory_set_dirty_range() to update the row of the bit-based dirty bitmap at once. Signed-off-by: OHMURA Kei Signed-off-by: Yoshiaki Tamura --- kvm-all.c | 24 +--- 1 files changed, 9 insertions(+), 15 deletions(-)

[Qemu-devel] [PATCH v6 0/4] Introduce bit-based dirty bitmap, and bit-based dirty page checker.

2010-06-16 Thread Yoshiaki Tamura
Updated the series to conform to newly introduced RAMList struct. The dirty and non-dirty pages are checked one by one. When most of the memory is not dirty, checking the dirty and non-dirty pages by multiple page size should be much faster than checking them one by one. We introduced bit-based

[Qemu-devel] [PATCH v6 1/4] Modify DIRTY_FLAG value and introduce DIRTY_IDX to use as indexes of bit-based dirty bitmap.

2010-06-16 Thread Yoshiaki Tamura
Replaces byte-based dirty bitmap with four (MASTER, VGA, CODE, MIGRATION) bit-based dirty bitmap. On allocation, it sets all bits in the bitmap. It uses ffs() to convert DIRTY_FLAG to DIRTY_IDX. Modifies wrapper functions for byte-based dirty bitmap to bit-based dirty bitmap. MASTER works as a

[Qemu-devel] [PATCH v6 4/4] Use cpu_physical_memory_get_dirty_range() to check multiple dirty pages.

2010-06-16 Thread Yoshiaki Tamura
Modifies ram_save_block() and ram_save_remaining() to use cpu_physical_memory_get_dirty_range() to check multiple dirty and non-dirty pages at once. Signed-off-by: Yoshiaki Tamura Signed-off-by: OHMURA Kei --- arch_init.c | 58 -- 1 file

[Qemu-devel] [PATCH v6 2/4] Introduce cpu_physical_memory_get_dirty_range().

2010-06-16 Thread Yoshiaki Tamura
It checks the first row and puts dirty addr in the array. If the first row is empty, it skips to the first non-dirty row or the end addr, and put the length in the first entry of the array. Signed-off-by: Yoshiaki Tamura Signed-off-by: OHMURA Kei --- cpu-all.h |4 +++ exec.c| 67

[Qemu-devel] [Bug 581353] Re: qemu doesn't stop execution upon hitting a breakpoint

2010-06-16 Thread Alfredo Mungo
Ok this issue has been fixed in qemu 0.12.4. Just type 'qemu --version' to see what version you have, it is probably outdated. -- qemu doesn't stop execution upon hitting a breakpoint https://bugs.launchpad.net/bugs/581353 You received this bug notification because you are a member of qemu- deve

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-16 Thread Markus Armbruster
Alex Williamson writes: > On Tue, 2010-06-15 at 12:28 +0100, Paul Brook wrote: >> > > Alex proposed to disambiguate by adding "identified properties of the >> > > immediate parent bus and device" to the path component. For PCI, these >> > > are dev.fn. Likewise for any other bus where devices h

Re: [Qemu-devel] Re: [RFC PATCH 0/5] Introduce canonical device hierarchy string

2010-06-16 Thread Markus Armbruster
Markus Armbruster writes: > Alex Williamson writes: > >> On Tue, 2010-06-15 at 10:53 +0200, Markus Armbruster wrote: >>> Alex Williamson writes: [...] >>> > virtio-serial doesn't seem to make a DeviceState per port, so I think it >>> > can be skipped. >>> >>> Really? >>> >>> Anyway, its port

Re: [Qemu-devel] Re: [RFC PATCH 0/5] Introduce canonical device hierarchy string

2010-06-16 Thread Markus Armbruster
Alex Williamson writes: > On Tue, 2010-06-15 at 10:53 +0200, Markus Armbruster wrote: >> Alex Williamson writes: >> >> > On Mon, 2010-06-14 at 09:02 +0200, Gerd Hoffmann wrote: >> >> Hi, >> >> >> >> > My premise with this attempt is that we walk the hierarchy and use the >> >> > names to creat

Re: [Qemu-devel] [PATCH 2/2] Return usb device to host on exit

2010-06-16 Thread Gerd Hoffmann
+static void usb_host_cleanup(struct Notifier* n) +{ +struct USBHostDevice *s; + +QTAILQ_FOREACH(s,&hostdevs, next) { +if (s->fd != -1) { +ioctl(s->fd, USBDEVFS_RESET); +} +} +} Well. The point of exit notifiers is that you don't need global variables fo

[Qemu-devel] Re: [PATCH 5/5] ide: fix migration in the middle of a bmdma transfer

2010-06-16 Thread Paolo Bonzini
On 06/15/2010 03:31 PM, Juan Quintela wrote: Signed-off-by: Juan Quintela Sorry if this has been discussed to death before (if so I must have missed it...). With subsections available, what about taking advantage of the new protocol extension and add to the subsection info about the size of

[Qemu-devel] Re: [PATCH 2/7] megasas: Update to 1.02

2010-06-16 Thread Nicholas A. Bellinger
On Tue, 2010-06-15 at 17:16 +0200, Hannes Reinecke wrote: > This patchset updates the megasas HBA emulation to v1.02. > Fixed issues; > - Fixup frame context handling > - Endianness fixes > - Implement reset function > - Improve DCMD bounds checking > - Improve dump_frame() output > - Sanitize I/O

[Qemu-devel] Re: [PATCH 1/7] scsi-generic: Handle queue full

2010-06-16 Thread Nicholas A. Bellinger
On Tue, 2010-06-15 at 17:16 +0200, Hannes Reinecke wrote: > The sg driver currently has a hardcoded limit of commands it > can handle simultaneously. When this limit is reached the > driver will return -EDOM. So we need to capture this to > enable proper return values here. > And we shouldn't forge

[Qemu-devel] Re: [PATCH 5/7] scsi-generic: Codingstyle fixes

2010-06-16 Thread Nicholas A. Bellinger
On Tue, 2010-06-15 at 17:16 +0200, Hannes Reinecke wrote: > Updated indentation to match CodingStyle. > > Signed-off-by: Hannes Reinecke > --- > hw/scsi-generic.c | 45 +++-- > 1 files changed, 23 insertions(+), 22 deletions(-) > Commited, thanks! --n

[Qemu-devel] Re: [PATCH 3/7] megasas: Codingstyle fixes

2010-06-16 Thread Nicholas A. Bellinger
On Tue, 2010-06-15 at 17:16 +0200, Hannes Reinecke wrote: > Fixup code to match Codingstyle as suggested by blueswirl. > > Signed-off-by: Hannes Reinecke > --- > hw/megasas.c | 1209 > +++--- > 1 files changed, 562 insertions(+), 647 deletions

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Gleb Natapov
On Wed, Jun 16, 2010 at 09:57:35AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Jun 16, 2010 at 09:51:14AM +0200, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Wed, Jun 16, 2010 at 09:03:01AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Jun 16, 2010 at 12:

[Qemu-devel] Re: [PATCH 6/7] scsi: Update sense handling

2010-06-16 Thread Nicholas A. Bellinger
On Tue, 2010-06-15 at 17:16 +0200, Hannes Reinecke wrote: > Each driver uses it's own means of storing the sense data, so the > sense code should be stored within the driver-specific structure. > And we should not allow a direct access to it but rather implement > an accessor 'scsi_req_sense' to co

Re: [Qemu-devel] Re: KVM call minutes for June 15

2010-06-16 Thread Yoshiaki Tamura
2010/6/16 Markus Armbruster : > Anthony Liguori writes: > >> On 06/15/2010 10:41 AM, Christoph Hellwig wrote: >>> On Tue, Jun 15, 2010 at 08:18:12AM -0700, Chris Wright wrote: >>> KVM/qemu patches - patch rate is high, documentation is low, review is low - patches need to include be

Re: [Qemu-devel] Re: [Bug 581353] Re: qemu doesn't stop execution upon hitting a breakpoint

2010-06-16 Thread malc
On Wed, 16 Jun 2010, Jan Kiszka wrote: > Jun Koi wrote: > > On Wed, Jun 16, 2010 at 4:49 PM, Jan Kiszka wrote: > >> Jun Koi wrote: > >>> On Wed, Jun 16, 2010 at 4:40 PM, Jan Kiszka wrote: > Jun Koi wrote: > > On Wed, Jun 16, 2010 at 4:07 PM, Alfredo Mungo > > wrote: > >> Same

[Qemu-devel] Re: [PATCH 4/7] scsi: Use SAM status codes

2010-06-16 Thread Nicholas A. Bellinger
On Tue, 2010-06-15 at 17:16 +0200, Hannes Reinecke wrote: > Any SCSI emulation is supposed to return status codes as defined > by SAM, not the linux ones which are shifted by one. > > Signed-off-by: Hannes Reinecke > --- > hw/megasas.c | 12 +++- > hw/scsi-bus.c |4 +++- >

[Qemu-devel] Re: KVM call minutes for June 15

2010-06-16 Thread Paolo Bonzini
On 06/15/2010 05:18 PM, Chris Wright wrote: - size for each section would be useful (breaks protocol) - while size is possibly useful, breaks protocol It is not necessary to break the protocol. If you're okay with only having the size information when the migration data has been saved to a

[Qemu-devel] Re: [PATCH 7/7] megasas: Update to 1.10

2010-06-16 Thread Nicholas A. Bellinger
On Tue, 2010-06-15 at 17:16 +0200, Hannes Reinecke wrote: > This patchset updates the megasas HBA emulation to version 1.10. > The main changes are: > - Range checking for IO vecs and frames > - Fixed frame address and frame count resolution > - Unmap existing frames on reset > - Round sge size to

[Qemu-devel] Re: [PATCH 2/2] pci: don't overwrite pci header type.

2010-06-16 Thread Michael S. Tsirkin
On Wed, Jun 16, 2010 at 11:20:02AM +0900, Isaku Yamahata wrote: > On Tue, Jun 15, 2010 at 12:12:07PM +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 15, 2010 at 02:06:46PM +0900, Isaku Yamahata wrote: > > > Don't overwrite pci header type. > > > Otherwise, multi function bit which pci_init_header_

[Qemu-devel] Re: [PATCH 1/2] tcg: Optionally sign-extend 32-bit arguments for 64-bit hosts.

2010-06-16 Thread Aurelien Jarno
On Mon, Jun 14, 2010 at 05:35:27PM -0700, Richard Henderson wrote: > Some hosts (amd64, ia64) have an ABI that ignores the high bits > of the 64-bit register when passing 32-bit arguments. Others > require the value to be properly sign-extended for the type. > I.e. "int32_t" must be sign-extended

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Jan Kiszka
Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 09:57:35AM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Wed, Jun 16, 2010 at 09:51:14AM +0200, Jan Kiszka wrote: Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 09:03:01AM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On W

Re: [Qemu-devel] Re: [Bug 581353] Re: qemu doesn't stop execution upon hitting a breakpoint

2010-06-16 Thread Jan Kiszka
malc wrote: > On Wed, 16 Jun 2010, Jan Kiszka wrote: > >> Jun Koi wrote: >>> On Wed, Jun 16, 2010 at 4:49 PM, Jan Kiszka wrote: Jun Koi wrote: > On Wed, Jun 16, 2010 at 4:40 PM, Jan Kiszka wrote: >> Jun Koi wrote: >>> On Wed, Jun 16, 2010 at 4:07 PM, Alfredo Mungo >>> wrot

Re: [Qemu-devel] Re: [Bug 581353] Re: qemu doesn't stop execution upon hitting a breakpoint

2010-06-16 Thread malc
On Wed, 16 Jun 2010, Jan Kiszka wrote: > malc wrote: > > On Wed, 16 Jun 2010, Jan Kiszka wrote: > > > >> Jun Koi wrote: > >>> On Wed, Jun 16, 2010 at 4:49 PM, Jan Kiszka wrote: > Jun Koi wrote: > > On Wed, Jun 16, 2010 at 4:40 PM, Jan Kiszka wrote: > >> Jun Koi wrote: > >>> On

[Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter

2010-06-16 Thread Gleb Natapov
On Wed, Jun 16, 2010 at 11:33:13AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Jun 16, 2010 at 09:57:35AM +0200, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Wed, Jun 16, 2010 at 09:51:14AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Jun 16, 2010 at 09:

Re: [Qemu-devel] Re: [Bug 581353] Re: qemu doesn't stop execution upon hitting a breakpoint

2010-06-16 Thread malc
On Wed, 16 Jun 2010, malc wrote: > On Wed, 16 Jun 2010, Jan Kiszka wrote: > > > malc wrote: > > > On Wed, 16 Jun 2010, Jan Kiszka wrote: [..snip..] > > >> > > >> You need this for segmented addressing, either in real mode (linear > > >> address = segment * 16 + offset) or in segmented protected

RFC qdev path semantics (was: [Qemu-devel] [RFC PATCH 0/5] Introduce canonical device hierarchy string)

2010-06-16 Thread Markus Armbruster
A number of changes to qdev paths have been proposed in various threads. It's becoming harder to keep track of them, so let me sum them up in one place. Please correct me if I misrepresent your ideas. I'm going to describe the current state of things, and the proposed changes (marked with ###).

[Qemu-devel] Re: [PATCH 2/2] pci: don't overwrite pci header type.

2010-06-16 Thread Isaku Yamahata
On Wed, Jun 16, 2010 at 11:54:25AM +0300, Michael S. Tsirkin wrote: > On Wed, Jun 16, 2010 at 11:20:02AM +0900, Isaku Yamahata wrote: > > On Tue, Jun 15, 2010 at 12:12:07PM +0300, Michael S. Tsirkin wrote: > > > On Tue, Jun 15, 2010 at 02:06:46PM +0900, Isaku Yamahata wrote: > > > > Don't overwrite

Re: [Qemu-devel] RFC v2: blockdev_add & friends, brief rationale, QMP docs

2010-06-16 Thread Avi Kivity
On 06/15/2010 05:54 PM, Markus Armbruster wrote: Avi Kivity writes: On 06/15/2010 04:27 PM, Markus Armbruster wrote: I'm only talking about the interface, not the implementation. Internal design details shouldn't be exposed. For the implementation, I imagine you can create

Re: [Qemu-devel] Re: [Bug 581353] Re: qemu doesn't stop execution upon hitting a breakpoint

2010-06-16 Thread Gleb Natapov
On Wed, Jun 16, 2010 at 11:34:36AM +0200, Jan Kiszka wrote: > malc wrote: > > On Wed, 16 Jun 2010, Jan Kiszka wrote: > > > >> Jun Koi wrote: > >>> On Wed, Jun 16, 2010 at 4:49 PM, Jan Kiszka wrote: > Jun Koi wrote: > > On Wed, Jun 16, 2010 at 4:40 PM, Jan Kiszka wrote: > >> Jun Koi

Re: [Qemu-devel] [PATCH 2/2] Return usb device to host on exit

2010-06-16 Thread Shahar Havivi
On Wed, Jun 16, 2010 at 10:48:23AM +0200, Gerd Hoffmann wrote: > Date: Wed, 16 Jun 2010 10:48:23 +0200 > From: Gerd Hoffmann > To: Shahar Havivi > Cc: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH 2/2] Return usb device to host on exit > > >+static void usb_host_cleanup(struct Notifie

Re: RFC qdev path semantics (was: [Qemu-devel] [RFC PATCH 0/5] Introduce canonical device hierarchy string)

2010-06-16 Thread Paul Brook
> * Else, use TYPE.NUM, where TYPE is derived from the bus type, and NUM > is the bus number, as above. > > ### Paul proposes to either drop TYPE.NUM (and require drivers to > provide bus names), or make NUM count separately for each bus type. I revised this proposal: Drop the .NUM part, an

Re: [Qemu-devel] RFC v2: blockdev_add & friends, brief rationale, QMP docs

2010-06-16 Thread Markus Armbruster
Avi Kivity writes: > On 06/15/2010 05:54 PM, Markus Armbruster wrote: >> Avi Kivity writes: >> >> >>> On 06/15/2010 04:27 PM, Markus Armbruster wrote: >>> > I'm only talking about the interface, not the implementation. > Internal design details shouldn't be exposed

[Qemu-devel] Re: [PATCH 1/2] qemu-io: retry fgets() when errno is EINTR

2010-06-16 Thread Kevin Wolf
Am 15.06.2010 19:53, schrieb MORITA Kazutaka: > posix-aio-compat sends a signal in aio operations, so we should > consider that fgets() could be interrupted here. > > Signed-off-by: MORITA Kazutaka > --- > cmd.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/cmd

Re: [Qemu-devel] RFC v2: blockdev_add & friends, brief rationale, QMP docs

2010-06-16 Thread Avi Kivity
On 06/16/2010 02:02 PM, Markus Armbruster wrote: That is true. Maybe we should just ignore the duplication. It's fine to create empty blockdev, insert media, attach device model, even if the device model wants fixed media. Nevertheless, I think my convenience shortcuts make sense.

[Qemu-devel] Re: RFC v2: blockdev_add & friends, brief rationale, QMP docs

2010-06-16 Thread Kevin Wolf
Am 15.06.2010 15:44, schrieb Avi Kivity: > On 06/10/2010 08:45 PM, Markus Armbruster wrote: >> >> >> * Our config file format is in INI syntax. QemuOpts correspond to >> INI sections. Sections can't be nested, so recursive QemuOpts >> don't translate. >> > > git (and probably

[Qemu-devel] Re: [PATCH 2/2] pci: don't overwrite pci header type.

2010-06-16 Thread Michael S. Tsirkin
On Wed, Jun 16, 2010 at 06:43:53PM +0900, Isaku Yamahata wrote: > On Wed, Jun 16, 2010 at 11:54:25AM +0300, Michael S. Tsirkin wrote: > > On Wed, Jun 16, 2010 at 11:20:02AM +0900, Isaku Yamahata wrote: > > > On Tue, Jun 15, 2010 at 12:12:07PM +0300, Michael S. Tsirkin wrote: > > > > On Tue, Jun 15,

[Qemu-devel] Re: [PATCH 2/2] qemu-io: check registered fds in command_loop()

2010-06-16 Thread Kevin Wolf
Am 15.06.2010 19:53, schrieb MORITA Kazutaka: > Some block drivers use an aio handler and do I/O completion routines > in it. However, the handler is not invoked if we only do > aio_read/write, because registered fds are not checked at all. > > This patch registers a command processing function a

[Qemu-devel] Re: RFC qdev path semantics

2010-06-16 Thread Jan Kiszka
Markus Armbruster wrote: > A number of changes to qdev paths have been proposed in various threads. > It's becoming harder to keep track of them, so let me sum them up in one > place. Please correct me if I misrepresent your ideas. > > I'm going to describe the current state of things, and the pr

[Qemu-devel] Re: [PATCH 2/2] pci: don't overwrite pci header type.

2010-06-16 Thread Isaku Yamahata
On Wed, Jun 16, 2010 at 02:19:44PM +0300, Michael S. Tsirkin wrote: > > > > Apb host bridge specifies PCI_HEADER_TYPE_BRIDGE in PCIDeviceInfo, > > > > on the other hand pbc_pci_host_init() sets the register > > > > to PCI_HEADER_TYPE_NORMAL. > > > > To be honest I don't know why it does so, but tha

Antwort: Re: [Qemu-devel] [Bug 319014] Re: serial usb-device can't be passed-through to a guest

2010-06-16 Thread Nico Prenzel
Hi David, i've tried your suggestion and now it works.I'am sure, it didn't work last time i've tried that way. But now, I'am fine.  Thanks. NicoP.-"David S. Ahern" schrieb: -An: Nico Prenzel Von: "David S. Ahern" Datum: 03.06.2010 19:23Kopie: qemu-devel@nongnu.orgBetreff: Re: [Qemu-devel]

[Qemu-devel] Re: RFC qdev path semantics

2010-06-16 Thread Paul Brook
> Markus Armbruster wrote: > > A number of changes to qdev paths have been proposed in various threads. > > It's becoming harder to keep track of them, so let me sum them up in one > > place. Please correct me if I misrepresent your ideas. > > > > I'm going to describe the current state of things

Re: [Qemu-devel] Re: KVM call minutes for June 15

2010-06-16 Thread Arnd Bergmann
On Wednesday 16 June 2010, Markus Armbruster wrote: > Can't hurt reviewer motivation. Could it be automated? Find replies, > extract tags. If you want your acks to be picked up, you better make > sure your References header works, and your tags are formatted > correctly. I think pwclient (https

[Qemu-devel] [PATCH V4 1/3] qemu: Add qemu-barrier support to qemu-thread framework.

2010-06-16 Thread Gautham R Shenoy
Signed-off-by: Gautham R Shenoy --- qemu-thread.c | 23 +++ qemu-thread.h |9 + 2 files changed, 32 insertions(+), 0 deletions(-) diff --git a/qemu-thread.c b/qemu-thread.c index 3923db7..7c445b6 100644 --- a/qemu-thread.c +++ b/qemu-thread.c @@ -161,3 +161,26 @

[Qemu-devel] [PATCH V4 0/3] qemu: Threadlets: A generic task offloading framework

2010-06-16 Thread Gautham R Shenoy
Hi, This is the v4 of the patch-series to have a generic asynchronous task offloading framework (called threadlets) within qemu. V3 can be found here: http://lists.gnu.org/archive/html/qemu-devel/2010-06/index.html Changes from V3:

[Qemu-devel] [PATCH V4 2/3] qemu: Generic task offloading framework: threadlets

2010-06-16 Thread Gautham R Shenoy
From: Aneesh Kumar K.V This patch creates a generic asynchronous-task-offloading infrastructure named threadlets. The core idea has been borrowed from the threading framework that is being used by paio. The reason for creating this generic infrastructure is so that other subsystems, such as virt

[Qemu-devel] [PATCH V4 3/3] qemu: Convert AIO code to use threadlets.

2010-06-16 Thread Gautham R Shenoy
This patch makes the paio subsystem use the threadlet framework thereby decoupling asynchronous threading framework portion out of posix-aio-compat.c The patch has been tested with fstress. Signed-off-by: Gautham R Shenoy --- posix-aio-compat.c | 152 ---

[Qemu-devel] Re: RFC qdev path semantics

2010-06-16 Thread Jan Kiszka
Paul Brook wrote: >> Markus Armbruster wrote: >>> A number of changes to qdev paths have been proposed in various threads. >>> It's becoming harder to keep track of them, so let me sum them up in one >>> place. Please correct me if I misrepresent your ideas. >>> >>> I'm going to describe the curre

[Qemu-devel] [PATCH,APPLIED] Strace mprotect flags.

2010-06-16 Thread Paul Brook
Teach strace code about linux specific mprotect flags. Signed-off-by: Paul Brook --- linux-user/strace.c |3 +++ linux-user/syscall_defs.h |6 ++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index d77053b..bf9a0d9 1006

[Qemu-devel] [PATCH,APPLIED] GDB exit status for semihosting

2010-06-16 Thread Paul Brook
Report exit status to GDB when a semihosted application exits. Signed-off-by: Paul Brook --- arm-semi.c |1 + gdbstub.c | 34 -- gdbstub.h |2 +- m68k-semi.c |1 + 4 files changed, 23 insertions(+), 15 deletions(-) diff --git a/arm-semi.c b/arm

[Qemu-devel] [PATCH,APPLIED] Usermode exec-stack fix

2010-06-16 Thread Paul Brook
When loading a shared library that requires an executable stack, glibc uses the mprotext PROT_GROWSDOWN flag to achieve this. We don't support PROT_GROWSDOWN. Add a special case to handle changing the stack permissions in this way. Signed-off-by: Paul Brook --- linux-user/elfload.c |1 + li

[Qemu-devel] [PATCH 0/2 v5] Release usb devices on shutdown and usb_del

2010-06-16 Thread Shahar Havivi
v5: Fix to Gerd Hoffmann comments on v4. Shahar Havivi (2): Return usb device to host on usb_del command Return usb device to host on exit usb-linux.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-)

Re: [Qemu-devel] Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-16 Thread Kevin Wolf
Am 04.06.2010 16:06, schrieb Kevin Wolf: > Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: >> From: Nicholas Bellinger >> >> This patch updates hw/scsi-bus.c to add PERSISTENT_RESERVE_OUT and >> PERSISTENT_RESERVE_IN >> case in scsi_req_length() to extra the incoming buffer length into >> SC

[Qemu-devel] [PATCH 2/2] Return usb device to host on exit

2010-06-16 Thread Shahar Havivi
Signed-off-by: Shahar Havivi --- usb-linux.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 22a85e3..c3c38ec 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -33,6 +33,7 @@ #include "qemu-common.h" #include "qemu-timer.h" #i

Re: [Qemu-devel] Re: RFC qdev path semantics

2010-06-16 Thread Paul Brook
> > I think this would be better served by adding explicit aliases/IDs for > > those use-cases. i.e. define the global ID "pci.0" to be an alias for > > > > /i440FX-pcihost/pci > > Makes sense. We could attach this ID to the BusState (corresponding to > DeviceState:id) and manually set it during

[Qemu-devel] [PATCH 1/2] Return usb device to host on usb_del command

2010-06-16 Thread Shahar Havivi
Signed-off-by: Shahar Havivi --- usb-linux.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 88273ff..22a85e3 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -991,6 +991,7 @@ static int usb_host_close(USBHostDevice *dev) async_complete(

Re: [Qemu-devel] Re: [PATCH RFC] Mark a device as non-migratable

2010-06-16 Thread Anthony Liguori
On 06/16/2010 12:05 AM, Cam Macdonell wrote: On Tue, Jun 15, 2010 at 4:33 PM, Anthony Liguori wrote: On 06/15/2010 05:26 PM, Cam Macdonell wrote: On Tue, Jun 15, 2010 at 10:32 AM, Anthony Liguori wrote: On 06/15/2010 11:16 AM, Cam Macdonell wrote: How does thi

Re: [Qemu-devel] [PATCH] Fix comparison which always returned false

2010-06-16 Thread Anthony Liguori
On 06/15/2010 07:27 PM, Richard Henderson wrote: On 06/15/2010 02:28 PM, Anthony Liguori wrote: On 06/15/2010 04:03 PM, Stefan Weil wrote: Comparing an 8 bit value with ~0 does not work as expected. Replace ~0 by UINT8_MAX in comparison and also in assignment (and fix coding style, to

[Qemu-devel] [PATCH 0/3] Monitor support QEMU trace framework

2010-06-16 Thread Prerna Saxena
This is v3 of a set of patches to enable trace visualization & control via the QEMU monitor. It is based on trace infrastructure posted by Stefan : ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html ) This patchset adds monitor commands : - info trace : to view current content

[Qemu-devel] Re: [PATCH V4 2/3] qemu: Generic task offloading framework: threadlets

2010-06-16 Thread Paolo Bonzini
+block-obj-y += qemu-thread.o +block-obj-y += async-work.o These should be (at least for now) block-obj-$(CONFIG_POSIX). +while (QTAILQ_EMPTY(&(queue->request_list))&& + (ret != ETIMEDOUT)) { +ret = qemu_cond_timedwait(&(queue->cond), +

[Qemu-devel] Re: [PATCH 2/2] pci: don't overwrite pci header type.

2010-06-16 Thread Michael S. Tsirkin
On Wed, Jun 16, 2010 at 08:38:18PM +0900, Isaku Yamahata wrote: > On Wed, Jun 16, 2010 at 02:19:44PM +0300, Michael S. Tsirkin wrote: > > > > > Apb host bridge specifies PCI_HEADER_TYPE_BRIDGE in PCIDeviceInfo, > > > > > on the other hand pbc_pci_host_init() sets the register > > > > > to PCI_HEADE

[Qemu-devel] Re: [PATCH 5/5] linux fbdev display driver.

2010-06-16 Thread Stefano Stabellini
On Tue, 15 Jun 2010, Gerd Hoffmann wrote: > Display works, requires truecolor framebuffer with 16 or 32 bpp on the > host. 32bpp is recommended. The framebuffer is used as-is, qemu > doesn't try to switch modes. With LCD displays mode switching is pretty > pointless IMHO, also it wouldn't work a

[Qemu-devel] Re: RFC v2: blockdev_add & friends, brief rationale, QMP docs

2010-06-16 Thread Markus Armbruster
Kevin Wolf writes: > Am 15.06.2010 15:44, schrieb Avi Kivity: >> On 06/10/2010 08:45 PM, Markus Armbruster wrote: >>> >>> >>> * Our config file format is in INI syntax. QemuOpts correspond to >>> INI sections. Sections can't be nested, so recursive QemuOpts >>> don't translate.

[Qemu-devel] [PATCH 3/3] Toggle tracepoint state

2010-06-16 Thread Prerna Saxena
This patch adds support for dynamically enabling/disabling of tracepoints. This is done by internally maintaining each tracepoint's state, and permitting logging of data from a tracepoint only if it is in an 'active' state. Monitor commands added : 1) info tracepoints : to view all a

[Qemu-devel] [PATCH 2/3] Monitor command 'info trace'

2010-06-16 Thread Prerna Saxena
Monitor command 'info trace' to display contents of trace buffer Signed-off-by: Prerna Saxena --- configure |3 +++ monitor.c | 12 qemu-monitor.hx |4 simpletrace.c | 13 + tracetool |2 ++ 5 files changed, 34 insertions(+), 0 d

[Qemu-devel] [PATCH 1/3] Export hash function

2010-06-16 Thread Prerna Saxena
Rename tdb_hash() to qemu_hash(). Move definition from qdict.c to a new file qemu-misc.c for use by tracing infrastructure. Signed-off-by: Prerna Saxena --- Makefile.objs |2 +- qdict.c | 24 qemu-common.h |3 +++ qemu-misc.c | 24 +++

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-16 Thread Markus Armbruster
Jan Kiszka writes: > Markus Armbruster wrote: >> Jan Kiszka writes: [...] >>> The format I will propose is "global-ID|/absolute/path", no more >>> /path/global-ID as this comes with the risk of ambiguity (ID may shadow >>> bus-local name of a device). >> >> Doesn't this break existing usage? >

[Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices

2010-06-16 Thread Kevin Wolf
Am 16.06.2010 03:53, schrieb Miguel Di Ciurcio Filho: > The 'info snapshots' monitor command does not show snapshot information from > all > available block devices. > > Usage example: > $ qemu -hda disk1.qcow2 -hdb disk2.qcow2 > > (qemu) info snapshots > Snapshot devices: ide0-hd0 > Snapshot li

Re: [Qemu-devel] Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-16 Thread Nicholas A. Bellinger
On Wed, 2010-06-16 at 14:13 +0200, Kevin Wolf wrote: > Am 04.06.2010 16:06, schrieb Kevin Wolf: > > Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: > >> From: Nicholas Bellinger > >> > >> This patch updates hw/scsi-bus.c to add PERSISTENT_RESERVE_OUT and > >> PERSISTENT_RESERVE_IN > >> case i

Re: [Qemu-devel] Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-16 Thread Kevin Wolf
Am 16.06.2010 15:03, schrieb Nicholas A. Bellinger: > On Wed, 2010-06-16 at 14:13 +0200, Kevin Wolf wrote: >> Am 04.06.2010 16:06, schrieb Kevin Wolf: >>> Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger This patch updates hw/scsi-bus.c to add PERSISTENT_

[Qemu-devel] Re: [Bug 513273] Re: kvm with -vga std is broken since karmic

2010-06-16 Thread Claus Frein
Hi Dustin, behavior seems ok. No issues there. Just the error message. Anything you want me to try/test? Claus 2010/6/15 Dustin Kirkland : > @Claus- > > Other than the error message, are you seeing incorrect behavior?  If > so, what specifically? > > -- > kvm with -vga std is broken since karmi

[Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices

2010-06-16 Thread Miguel Di Ciurcio Filho
On Wed, Jun 16, 2010 at 9:40 AM, Kevin Wolf wrote: > > If the human monitor was exactly what its name says, I'd happily apply > this one (though I think it should be made clear from which image the VM > state would be loaded). However, it isn't and I'm not sure if this > wouldn't break libvirt. Da

[Qemu-devel] Re: RFC qdev path semantics

2010-06-16 Thread Markus Armbruster
Markus Armbruster writes: [...] > Bus names are chosen by the system as follows: > > * If the driver of the parent device model provides a name, use that. > > * Else, if the parent device has id ID, use ID.NUM, where NUM is the bus > number, counting from zero in creation order. > > * Else, use

Re: [Qemu-devel] [PATCH V4 0/3] qemu: Threadlets: A generic task offloading framework

2010-06-16 Thread Anthony Liguori
On 06/16/2010 06:56 AM, Gautham R Shenoy wrote: Hi, This is the v4 of the patch-series to have a generic asynchronous task offloading framework (called threadlets) within qemu. Semantically, a threadlet is identical to a QEMUBH except that a QEMUBH holds the qemu_mutex and a threadlet doe

[Qemu-devel] Re: [PATCH 5/5] ide: fix migration in the middle of a bmdma transfer

2010-06-16 Thread Juan Quintela
Paolo Bonzini wrote: > On 06/15/2010 03:31 PM, Juan Quintela wrote: >> Signed-off-by: Juan Quintela > > Sorry if this has been discussed to death before (if so I must have > missed it...). > > With subsections available, what about taking advantage of the new > protocol extension and add to the su

[Qemu-devel] Re: [CFR 6/10] cont command

2010-06-16 Thread Juan Quintela
Anthony Liguori wrote: > cont > > > Resume emulation. > > Arguments: None. > > Example: > > -> { "execute": "cont" } > <- { "return": {} } This is related to the commands, not QMP per se: Once that we are talking about "cont" command. There are two cases that we need to think of: - incomi

[Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices

2010-06-16 Thread Kevin Wolf
Am 16.06.2010 14:59, schrieb Miguel Di Ciurcio Filho: > On Wed, Jun 16, 2010 at 9:40 AM, Kevin Wolf wrote: >> >> If the human monitor was exactly what its name says, I'd happily apply >> this one (though I think it should be made clear from which image the VM >> state would be loaded). However, it

[Qemu-devel] Re: [PATCH 0/2 v5] Release usb devices on shutdown and usb_del

2010-06-16 Thread Gerd Hoffmann
On 06/16/10 14:15, Shahar Havivi wrote: v5: Fix to Gerd Hoffmann comments on v4. Shahar Havivi (2): Return usb device to host on usb_del command Return usb device to host on exit Looks fine to me now. Acked-by: Gerd Hoffmann cheers, Gerd

[Qemu-devel] Re: [PATCH 01/16] vnc: tight: add JPEG and gradient subencoding with smooth image detection

2010-06-16 Thread Juan Quintela
Corentin Chary wrote: > Add gradient filter and JPEG compression with an heuristic to detect how > lossy the comppression will be. This code has been adapted from > libvncserver/tight.c. > > JPEG support can be enabled/disabled at compile time with --enable-vnc-jpeg > and --disable-vnc-jpeg. > > S

Re: [Qemu-devel] Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-16 Thread Nicholas A. Bellinger
On Wed, 2010-06-16 at 06:03 -0700, Nicholas A. Bellinger wrote: > On Wed, 2010-06-16 at 14:13 +0200, Kevin Wolf wrote: > > Am 04.06.2010 16:06, schrieb Kevin Wolf: > > > Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: > > >> From: Nicholas Bellinger > > >> > > >> This patch updates hw/scsi-bus

Re: [Qemu-devel] Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-16 Thread Kevin Wolf
Am 16.06.2010 15:09, schrieb Nicholas A. Bellinger: > On Wed, 2010-06-16 at 06:03 -0700, Nicholas A. Bellinger wrote: >> On Wed, 2010-06-16 at 14:13 +0200, Kevin Wolf wrote: >>> Am 04.06.2010 16:06, schrieb Kevin Wolf: Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: > From: Nicholas Be

  1   2   3   >