Am 16.06.2010 03:53, schrieb Miguel Di Ciurcio Filho: > The 'info snapshots' monitor command does not show snapshot information from > all > available block devices. > > Usage example: > $ qemu -hda disk1.qcow2 -hdb disk2.qcow2 > > (qemu) info snapshots > Snapshot devices: ide0-hd0 > Snapshot list (from ide0-hd0): > ID TAG VM SIZE DATE VM CLOCK > 1 1.5M 2010-05-26 21:51:02 00:00:03.263 > 2 1.5M 2010-05-26 21:51:09 00:00:08.844 > 3 1.5M 2010-05-26 21:51:24 00:00:23.274 > 4 1.5M 2010-05-26 21:53:17 00:00:03.595 > > In the above case, disk2.qcow2 has snapshot information, but it is not being > shown. Only the first device is always shown. > > This patch updates the do_info_snapshots() function do correctly show snapshot > information about all available block devices. > > New output: > (qemu) info snapshots > Snapshot list from ide0-hd0: > ID TAG VM SIZE DATE VM CLOCK > 1 1.5M 2010-05-26 21:51:02 00:00:03.263 > 2 1.5M 2010-05-26 21:51:09 00:00:08.844 > 3 1.5M 2010-05-26 21:51:24 00:00:23.274 > 4 1.5M 2010-05-26 21:53:17 00:00:03.595 > > Snapshot list from ide0-hd1: > ID TAG VM SIZE DATE VM CLOCK > 1 0 2010-05-26 21:51:02 00:00:03.263 > 2 0 2010-05-26 21:51:09 00:00:08.844 > 3 0 2010-05-26 21:51:24 00:00:23.274 > 4 0 2010-05-26 21:53:17 00:00:03.595 > > Signed-off-by: Miguel Di Ciurcio Filho <miguel.fi...@gmail.com>
If the human monitor was exactly what its name says, I'd happily apply this one (though I think it should be made clear from which image the VM state would be loaded). However, it isn't and I'm not sure if this wouldn't break libvirt. Dan, can you help? If we can't change the info snapshots output, a possible alternative would be to introduce another info command for this. Kevin
