[Qemu-devel] [PATCH 0/2 v3] Release usb devices on shutdown and usb_del command

2010-06-12 Thread Shahar Havivi
v3: separate usb hot-unplug and host terminate handling remove empty methods from bsd and stub added usb-linux atexit method to reset usb devices on termination Shahar Havivi (2): Return usb device to host on usb_del command Return usb device to host on exit usb-linux.c | 13 +

[Qemu-devel] [PATCH 1/2] Return usb device to host on usb_del command

2010-06-12 Thread Shahar Havivi
Signed-off-by: Shahar Havivi --- usb-linux.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 88273ff..22a85e3 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -991,6 +991,7 @@ static int usb_host_close(USBHostDevice *dev) async_complete(

[Qemu-devel] [PATCH 2/2] Return usb device to host on exit

2010-06-12 Thread Shahar Havivi
Signed-off-by: Shahar Havivi --- usb-linux.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 22a85e3..2a595f0 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -286,6 +286,17 @@ static void async_cancel(USBPacket *unused, void *opa

[Qemu-devel] [PATCH v3 16/16] hpet: Add MSI support

2010-06-12 Thread Jan Kiszka
Paul Brook wrote: >> +} else if (timer_fsb_route(timer)) { >> +apic_send_msi(timer->fsb >> 32, timer->fsb & 0x); > > This should use a regular memory write, like the PCI MSI-X code does. > Indeed, here we go: --> From: Jan Kiszka This implements the HPET capabilit

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-12 Thread Juan Quintela
Luiz Capitulino wrote: > On Thu, 10 Jun 2010 12:44:55 +0200 > Juan Quintela wrote: > >> Luiz Capitulino wrote: >> > On Wed, 9 Jun 2010 14:10:53 +0200 >> > Juan Quintela wrote: >> > >> >> This is a resent with what we agreed on yesterday call. >> >> Migration events would be there for 0.13 unti

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-12 Thread Juan Quintela
Anthony Liguori wrote: > On 06/11/2010 09:30 AM, Luiz Capitulino wrote: >> On Thu, 10 Jun 2010 12:44:55 +0200 >> Juan Quintela wrote: > > I think we've more or less agreed that MIGRATION_CONNECTED is really > the event we want. This had the problem of migrating to a file/whatever. MIGRATION_CO

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-12 Thread Juan Quintela
Luiz Capitulino wrote: > On Fri, 11 Jun 2010 09:38:42 -0500 > Anthony Liguori wrote: > >> > 1. QMP only returns the response when the command is finished, eg: >> > >> > C: { "execute": "migrate", "id": "foo" ... } >> > /* nothing is returned, other commands are issued, after several

Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in create_config

2010-06-12 Thread Aurelien Jarno
On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > Only match on true dir variable assignments, avoid generating garbage > due to the "# Configured with: ..." line which may contain "*dir=" as > well. Wouldn't it be better to skip all lines starting with '#', as t

Re: [Qemu-devel] [PATCH 09/16] Enable message delivery via IRQs

2010-06-12 Thread Paul Brook
> This patch allows to optionally attach a message to an IRQ event. The > message can contain a payload reference and a callback that the IRQ > handler may invoke to report the delivery result. The former can be used > to model message signaling interrupts, the latter to cleanly implement > IRQ de-

Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in create_config

2010-06-12 Thread Jan Kiszka
Aurelien Jarno wrote: > On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Only match on true dir variable assignments, avoid generating garbage >> due to the "# Configured with: ..." line which may contain "*dir=" as >> well. > > Wouldn't it be better to skip a

Re: [Qemu-devel] [PATCH 15/35] tcg-s390: Query instruction extensions that are installed.

2010-06-12 Thread Aurelien Jarno
On Fri, Jun 11, 2010 at 06:07:52AM -0700, Richard Henderson wrote: > On 06/11/2010 01:06 AM, Aurelien Jarno wrote: > > What's the difference between FACILITY_ZARCH and FACILITY_ZARCH_ACTIVE, > > as both are actually flagged together. My guess is that > > FACILITY_ZARCH_ACTIVE is needed in 64-bit mo

Re: [Qemu-devel] [PATCH 09/16] Enable message delivery via IRQs

2010-06-12 Thread Jan Kiszka
Paul Brook wrote: >> This patch allows to optionally attach a message to an IRQ event. The >> message can contain a payload reference and a callback that the IRQ >> handler may invoke to report the delivery result. The former can be used >> to model message signaling interrupts, the latter to clean

Re: [Qemu-devel] [PATCH 09/16] Enable message delivery via IRQs

2010-06-12 Thread Blue Swirl
On Sat, Jun 12, 2010 at 12:21 PM, Paul Brook wrote: >> This patch allows to optionally attach a message to an IRQ event. The >> message can contain a payload reference and a callback that the IRQ >> handler may invoke to report the delivery result. The former can be used >> to model message signal

[Qemu-devel] [PATCH] win32: Add missing function ffs

2010-06-12 Thread Stefan Weil
mingw32 does not include function ffs. Commit c6d29ad6e24533cc3762e1d654275607e1d03058 added a declaration for ffs, but an implementation was missing. For compilations with optimization, the compiler creates inline code, so the implementation is not always needed. Without optimization, linking f

Re: [Qemu-devel] [PATCH 20/35] tcg-s390: Use LOAD COMPLIMENT for negate.

2010-06-12 Thread Aurelien Jarno
On Fri, Jun 04, 2010 at 12:14:28PM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/s390/tcg-target.c | 10 ++ > 1 files changed, 2 insertions(+), 8 deletions(-) This patch looks fine. > diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c > index f

Re: [Qemu-devel] [PATCH 18/35] tcg-s390: Implement bswap operations.

2010-06-12 Thread Aurelien Jarno
On Fri, Jun 04, 2010 at 12:14:26PM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/s390/tcg-target.c | 24 > tcg/s390/tcg-target.h | 10 +- > 2 files changed, 29 insertions(+), 5 deletions(-) This patch looks fine. > diff --git

Re: [Qemu-devel] [PATCH 09/16] Enable message delivery via IRQs

2010-06-12 Thread Paul Brook
> On Sat, Jun 12, 2010 at 12:21 PM, Paul Brook wrote: > >> This patch allows to optionally attach a message to an IRQ event. The > >> message can contain a payload reference and a callback that the IRQ > >> handler may invoke to report the delivery result. The former can be used > >> to model mess

[Qemu-devel] [Bug 538908] Re: qemu-system-cris crashes after a few seconds

2010-06-12 Thread Ken Sharp
** Changed in: qemu Status: New => Fix Committed -- qemu-system-cris crashes after a few seconds https://bugs.launchpad.net/bugs/538908 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: Fix Committed Status in “qemu

Re: [Qemu-devel] [PATCH 19/35] tcg-s390: Implement rotates.

2010-06-12 Thread Aurelien Jarno
On Fri, Jun 04, 2010 at 12:14:27PM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/s390/tcg-target.c | 46 ++ > tcg/s390/tcg-target.h |4 ++-- > 2 files changed, 48 insertions(+), 2 deletions(-) This patch looks fin

Re: [Qemu-devel] [PATCH 09/16] Enable message delivery via IRQs

2010-06-12 Thread Blue Swirl
On Sat, Jun 12, 2010 at 2:15 PM, Paul Brook wrote: >> On Sat, Jun 12, 2010 at 12:21 PM, Paul Brook wrote: >> >> This patch allows to optionally attach a message to an IRQ event. The >> >> message can contain a payload reference and a callback that the IRQ >> >> handler may invoke to report the de

Re: [Qemu-devel] [PATCH 17/35] tcg-s390: Implement sign and zero-extension operations.

2010-06-12 Thread Aurelien Jarno
On Fri, Jun 04, 2010 at 12:14:25PM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/s390/tcg-target.c | 164 > - > tcg/s390/tcg-target.h | 20 +++--- > 2 files changed, 158 insertions(+), 26 deletions(-) This patch

Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in create_config

2010-06-12 Thread Aurelien Jarno
On Sat, Jun 12, 2010 at 02:25:10PM +0200, Jan Kiszka wrote: > Aurelien Jarno wrote: > > On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> Only match on true dir variable assignments, avoid generating garbage > >> due to the "# Configured with: ..." line wh

[Qemu-devel] Re: [PATCH] win32: Add missing function ffs

2010-06-12 Thread Richard Henderson
On 06/12/2010 07:07 AM, Stefan Weil wrote: > v2: Use __builtin_ffs as suggested by Richard Henderson > > Cc: Richard Henderson > Signed-off-by: Stefan Weil Acked-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 09/16] Enable message delivery via IRQs

2010-06-12 Thread Paul Brook
> I think message passing interrupts > are only used in bus based systems, like PCI or UPA/JBUS etc. I don't > know how LAPIC/IOAPIC bus works, it could be similar. PCI Message Signalled Interrupts use a regular data write, and we model it exactly that way. Under normal circumstances you program

Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in create_config

2010-06-12 Thread Jan Kiszka
Aurelien Jarno wrote: > On Sat, Jun 12, 2010 at 02:25:10PM +0200, Jan Kiszka wrote: >> Aurelien Jarno wrote: >>> On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote: From: Jan Kiszka Only match on true dir variable assignments, avoid generating garbage due to the "# Conf

[Qemu-devel] Re: [PATCH] configure: Fix evaluation of config-host.mak in create_config

2010-06-12 Thread Paolo Bonzini
On 06/12/2010 06:44 PM, Jan Kiszka wrote: Yes, but only for this line. What I mean is something more generic like: "#"*) # comment continue ;; IMO, that would only paper over suboptimally expressed patterns for the other line evaluations. Agreed. I like Jan's patch more. Paolo

Re: [Qemu-devel] [PATCH 09/16] Enable message delivery via IRQs

2010-06-12 Thread Blue Swirl
On Sat, Jun 12, 2010 at 3:58 PM, Paul Brook wrote: >> I think message passing interrupts >> are only used in bus based systems, like PCI or UPA/JBUS etc. I don't >> know how LAPIC/IOAPIC bus works, it could be similar. > > PCI Message Signalled Interrupts use a regular data write, and we model it

Re: [Qemu-devel] [PATCH 09/16] Enable message delivery via IRQs

2010-06-12 Thread Paul Brook
> > [*] A simple unidirectional dma request line is suitable for qmu_irq. A > > DMA system that transfers data outside of memory read/write transactions > > is not. e.g. ISA effectively defines a regular memory bus plus 8 > > bidirectional data streams (aka DMA channels). These are multiplexed > >

Re: [Qemu-devel] [PATCH 09/16] Enable message delivery via IRQs

2010-06-12 Thread Blue Swirl
On Sat, Jun 12, 2010 at 7:33 PM, Blue Swirl wrote: > On Sat, Jun 12, 2010 at 3:58 PM, Paul Brook wrote: >>> I think message passing interrupts >>> are only used in bus based systems, like PCI or UPA/JBUS etc. I don't >>> know how LAPIC/IOAPIC bus works, it could be similar. >> >> PCI Message Sign

[Qemu-devel] [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-06-12 Thread Blue Swirl
Clean up APIC and IOAPIC. Convert both devices to qdev. v1->v2: Remove apic.h reorganization. Add IOAPIC and APIC qdev conversions. Use CPUState also in 5/7. However on 6/7 we have to again use void * because of VMState limitations. VMState gurus, please comment. Blue Swirl (7): ioapic: unexpor

[Qemu-devel] [PATCH v2 3/7] apic: avoid passing CPUState from devices

2010-06-12 Thread Blue Swirl
Pass only APICState from pc.c. Signed-off-by: Blue Swirl --- hw/apic.c | 32 ++-- hw/apic.h |8 +--- hw/pc.c | 10 ++ 3 files changed, 25 insertions(+), 25 deletions(-) diff --git a/hw/apic.c b/hw/apic.c index 7fbd79b..c4dc52c 100644 --- a/hw/ap

[Qemu-devel] [PATCH v2 5/7] apic: avoid using CPUState internals

2010-06-12 Thread Blue Swirl
Move the actual CPUState contents handling to cpu.h and cpuid.c. Handle CPU reset and set env->halted in pc.c. Add a function to get the local APIC state of the current CPU for the MMIO. Signed-off-by: Blue Swirl --- hw/apic.c | 39 ++- hw/apic.h

[Qemu-devel] [PATCH v2 6/7] apic: convert to qdev

2010-06-12 Thread Blue Swirl
Convert to qdev. Use an opaque CPUState pointer because of missing VMState implementation for CPUState. Signed-off-by: Blue Swirl --- hw/apic.c | 88 +--- hw/apic.h |2 +- 2 files changed, 61 insertions(+), 29 deletions(-) diff --gi

[Qemu-devel] [PATCH v2 1/7] ioapic: unexport ioapic_set_irq

2010-06-12 Thread Blue Swirl
There's no need to use ioapic_set_irq() outside of ioapic.c, so make it static. Signed-off-by: Blue Swirl --- hw/apic.h |1 - hw/ioapic.c |2 +- 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/apic.h b/hw/apic.h index 132fcab..e1954f4 100644 --- a/hw/apic.h +++ b/hw/a

[Qemu-devel] [PATCH v2 4/7] apic: avoid passing CPUState from CPU code

2010-06-12 Thread Blue Swirl
Pass only APICState when accessing APIC from CPU code. Signed-off-by: Blue Swirl --- hw/apic.c | 39 --- target-i386/cpu.h | 13 +++-- target-i386/helper.c|4 ++-- target-i386/kvm.c | 14 +++--- target-i3

[Qemu-devel] [PATCH v2 2/7] ioapic: convert to qdev

2010-06-12 Thread Blue Swirl
Convert to qdev. Signed-off-by: Blue Swirl --- hw/apic.h|2 -- hw/ioapic.c | 45 ++--- hw/pc.h |4 +++- hw/pc_piix.c | 19 ++- 4 files changed, 51 insertions(+), 19 deletions(-) diff --git a/hw/apic.h b/hw/apic.h inde

[Qemu-devel] [PATCH v2 7/7] apic: qdev conversion cleanup

2010-06-12 Thread Blue Swirl
Make APICState completely private to apic.c by using DeviceState in external APIs. Move apic_init() to pc.c. Signed-off-by: Blue Swirl --- hw/apic.c | 86 +++- hw/apic.h | 24 +++--- hw/pc.c | 32 +++

[Qemu-devel] [Bug 581737] Re: Can't read e1000 NIC EEPROM on NetBSD guest

2010-06-12 Thread Izumi Tsutsui
> Please email the patch to qemu-devel@nongnu.org via git-send-email. Isn't the following post enough? What's incomplete on this? http://lists.nongnu.org/archive/html/qemu-devel/2010-06/msg00449.html (sorry I'm not familiar with git) -- Can't read e1000 NIC EEPROM on NetBSD guest https://bugs.lau

Re: [Qemu-devel] [PATCH 09/16] Enable message delivery via IRQs

2010-06-12 Thread Blue Swirl
On Sat, Jun 12, 2010 at 8:32 PM, Blue Swirl wrote: > On Sat, Jun 12, 2010 at 7:33 PM, Blue Swirl wrote: >> On Sat, Jun 12, 2010 at 3:58 PM, Paul Brook wrote: I think message passing interrupts are only used in bus based systems, like PCI or UPA/JBUS etc. I don't know how LAPIC/IOA