Aurelien Jarno wrote: > On Sat, Jun 12, 2010 at 02:25:10PM +0200, Jan Kiszka wrote: >> Aurelien Jarno wrote: >>> On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote: >>>> From: Jan Kiszka <jan.kis...@siemens.com> >>>> >>>> Only match on true dir variable assignments, avoid generating garbage >>>> due to the "# Configured with: ..." line which may contain "*dir=" as >>>> well. >>> Wouldn't it be better to skip all lines starting with '#', as this >>> problem might happen again after some more changes? >>> >>> Or maybe we should do both. >> This is what the patch (implicitly) does. > > Yes, but only for this line. What I mean is something more generic > like: > > "#"*) # comment > continue > ;; >
IMO, that would only paper over suboptimally expressed patterns for the other line evaluations. Jan
signature.asc
Description: OpenPGP digital signature
