[Qemu-devel] [PATCH 1/3] export tdb_hash()

2010-06-08 Thread Prerna Saxena
This exports tdb_hash() for use by tracing framework. Signed-off-by: Prerna Saxena --- qdict.c |2 +- qdict.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/qdict.c b/qdict.c index 175bc17..5261872 100644 --- a/qdict.c +++ b/qdict.c @@ -56,7 +56,7 @@ QDict *qobject

[Qemu-devel] [PATCH 2/3] Monitor command 'trace'

2010-06-08 Thread Prerna Saxena
This introduces the monitor command 'trace' to read current contents of trace buffer. Signed-off-by: Prerna Saxena --- configure |3 +++ monitor.c |3 +++ qemu-monitor.hx | 16 simpletrace.c | 15 +++ tracetool |4 5 files

[Qemu-devel] [PATCH 3/3] Toggle tracepoint state

2010-06-08 Thread Prerna Saxena
This patch adds support for dynamically enabling/disabling of tracepoints. Monitor commands added : 1) info tracepoints : to view all available tracepoints and their state. 2) tracepoint NAME on|off : to enable/disable data logging from a

[Qemu-devel] Hyra av lokal

2010-06-08 Thread DokuMera Nyhetsbrev
Om du har problem med att läsa detta e-postmeddelande, klicka här (http://www.anp.se/newsletter/729562/444059437941455D4B7142445C43) för en webb-version. Vårt nyhetsbrev skickas automatiskt till våra kunder och intressenter. Vill du inte ha detta nyhetsbrev framöver, klicka här för att avprenu

[Qemu-devel] Re: [PATCH] Fix regression for "-drive file="

2010-06-08 Thread Markus Armbruster
Did this fall through the cracks? Markus Armbruster writes: > Empty file used to create an empty drive (no media). Since commit > 9dfd7c7a, it's an error: "qemu: could not open disk image : No such > file or directory". Older versions of libvirt can choke on this. > > Signed-off-by: Markus Arm

[Qemu-devel] RE: Qemu-devel Digest, Vol 87, Issue 177

2010-06-08 Thread 孙澈
我怎么退订邮件 > Date: Mon, 7 Jun 2010 19:52:22 -0400 > From: qemu-devel-requ...@nongnu.org > Subject: Qemu-devel Digest, Vol 87, Issue 177 > To: qemu-devel@nongnu.org > > Send Qemu-devel mailing list submissions to > qemu-devel@nongnu.org > > To subscribe or unsubscribe via the World Wide Web,

Re: [Qemu-devel] [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Gerd Hoffmann
On 06/08/10 01:51, Anthony Liguori wrote: Right now, if you set a QemuOpts option in a section twice, when you get the option you'll receive the value that was set the first time. This is less than ideal because if you're manipulating options in two places like a global config followed by the co

[Qemu-devel] Re: KVM call agenda for June 8

2010-06-08 Thread Juan Quintela
Anthony Liguori wrote: > On 06/07/2010 05:26 PM, Chris Wright wrote: >> Please send in any agenda items you are interested in covering. >> >> If we have a lack of agenda items I'll cancel the week's call. >> >> > > - Accelerating counters (aka moving PIT to userspace, keeping HPET in > userspa

Re: [Qemu-devel] [PATCH 05/22] machine: pass all init options as a single QemuOpts

2010-06-08 Thread Gerd Hoffmann
On 06/08/10 01:51, Anthony Liguori wrote: This patch redefines the machine init signature to just take a QemuOpts. It also passes the machine as the first parameter to allow multiple boards to be defined with one init function. +typedef void QEMUMachineInitFunc(QemuOpts *opts); Hmm? Where

[Qemu-devel] [Bug 521994] Re: Windows 98 doesn't detect mouse on qemu and SeaBIOS.

2010-06-08 Thread jopo
I confirm also that mouse is not detected on Kubuntu 10.04 running qemu and Windows 98. -- Windows 98 doesn't detect mouse on qemu and SeaBIOS. https://bugs.launchpad.net/bugs/521994 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Statu

Re: [Qemu-devel] Re: [PATCH] Fix regression for "-drive file="

2010-06-08 Thread Kevin Wolf
Am 08.06.2010 09:38, schrieb Markus Armbruster: > Did this fall through the cracks? Looks like it. Rebased and applied to the block branch. Kevin > Markus Armbruster writes: > >> Empty file used to create an empty drive (no media). Since commit >> 9dfd7c7a, it's an error: "qemu: could not op

Re: [Qemu-devel] [PATCH v4] savevm: Really verify if a drive supports snapshots

2010-06-08 Thread Kevin Wolf
Am 08.06.2010 06:39, schrieb MORITA Kazutaka: > At Fri, 4 Jun 2010 16:35:59 -0300, > Miguel Di Ciurcio Filho wrote: >> >> Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. >> >> First issue: Their names implies different porpouses, but they do the same >> thing >> and

Re: [Qemu-devel] [PATCH 10/22] machine: allow boards to specify default values and use it in isapc

2010-06-08 Thread Gerd Hoffmann
static QEMUMachine pc_machine = { .name = "pc-0.13", .alias = "pc", .desc = "Standard PC", -.init = pc_init_pci, +.init = pc_init, .max_cpus = 255, .is_default = 1, .opts_desc = pc_opts_desc, +.opts_default = (QemuOptValue[]) { +{ +

Re: [Qemu-devel] [RFC 0/3] Tracing framework for QEMU

2010-06-08 Thread Prerna Saxena
Hi Stefan, Interesting to see your patches, tracepoint definitions/declarations look similar to in-kernel tracepoints :). The choice of a kernel-tracepoint approach had advantages since it places no inherent limitation on maximum number of arguments that can be logged. Also, it is flexible e

Re: [Qemu-devel] [PATCH 16/19] Add a query-netdev command to QMP

2010-06-08 Thread Daniel P. Berrange
On Mon, Jun 07, 2010 at 04:13:48PM -0300, Miguel Di Ciurcio Filho wrote: > On Mon, Jun 7, 2010 at 11:42 AM, Daniel P. Berrange > wrote: > > This adds a new QMP command called query-netdev to provide information > > about the available netdev backends in the QEMU binary. There is no > > existing '

Re: [Qemu-devel] [PATCH 3/3] cow: use qemu block API

2010-06-08 Thread Christoph Hellwig
On Mon, Jun 07, 2010 at 02:27:40PM +0200, Markus Armbruster wrote: > Christoph Hellwig writes: > > > Use bdrv_pwrite to access the backing device instead of pread, and > > convert the driver to implementing the bdrv_open method which gives > > it an already opened BlockDriverState for the underly

[Qemu-devel] Re: KVM call agenda for June 8

2010-06-08 Thread Avi Kivity
On 06/08/2010 01:26 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. APIC wiring problems (attached slides) -- error compiling committee.c: too many arguments to function apic-wiring-mess.odp Description: application/vnd.oasis.opendocument.present

[Qemu-devel] Do we still need the hack to set qdev id from NICInfo.name?

2010-06-08 Thread Markus Armbruster
In pci_nic_init(): pci_dev = pci_create(bus, devfn, pci_nic_names[i]); dev = &pci_dev->qdev; if (nd->name) dev->id = qemu_strdup(nd->name); Blatant violation of the DeviceState abstraction. Which even carries a comment advising against this: /* This structure should not be a

[Qemu-devel] Re: Do we still need the hack to set qdev id from NICInfo.name?

2010-06-08 Thread Gerd Hoffmann
pci_dev = pci_create(bus, devfn, pci_nic_names[i]); dev =&pci_dev->qdev; if (nd->name) dev->id = qemu_strdup(nd->name); Blatant violation of the DeviceState abstraction. Which even carries a comment advising against this: Do we still need this? Anybody wanting ID can

[Qemu-devel] Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Peter Lieven
sorry, the subject should read 2.6.35-rc2 Peter Lieven wrote: Hi, I freshly installed kernel 2.6.35-rc2 using userspace qemu-kvm 0.12.4. When I live migrate a 32-bit opensuse-11.2 VM, the incoming VM shows the following error after the mem transfer has finished: kvm: unhandled exit 8022 k

Re: [Qemu-devel] [PATCH] Fix and simplify gui timer logic.

2010-06-08 Thread Gerd Hoffmann
On 06/07/10 18:12, Paul Brook wrote: Kill nographic timer. Have a global gui_timer instead. Have the gui timer enabled unconditionally. We need a timer running anyway for mmio flush, so the whole have-gui-timer-only-when-needed logic is pretty pointless. It also simplifies displaylisteners co

[Qemu-devel] Re: RFC: blockdev_add & friends, brief rationale, QMP docs

2010-06-08 Thread Markus Armbruster
Avi Kivity writes: > On 06/04/2010 05:16 PM, Markus Armbruster wrote: >> - "protocol": json-array of json-object >>Each element object has a member "name" >> - Possible values: "file", "nbd", ... >>Additional members depend on the value of "name". >>For "name" = "file": >> -

Re: [Qemu-devel] Re: Qemu-KVM Livate Migration 0.12.2 -> 0.12.3/4 broken?

2010-06-08 Thread Peter Lieven
Jan Kiszka wrote: Juan Quintela wrote: Jan Kiszka wrote: Juan Quintela wrote: Lack of "proper" subsections. IDE is something like: const VMStateDescription vmstate_ide_drive = { .version_id = 4, } static const VMStateDescription vmstate_bmdma = { .name = "ide bm

[Qemu-devel] Re: KVM call agenda for June 8

2010-06-08 Thread Avi Kivity
On 06/08/2010 11:50 AM, Avi Kivity wrote: On 06/08/2010 01:26 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. APIC wiring problems (attached slides) See also http://www.intel.com/design/pentium/datashts/242016.HTM. -- error compiling committee.c: to

[Qemu-devel] Re: [PATCH 0/22] Refactor machine support

2010-06-08 Thread Paolo Bonzini
On 06/08/2010 05:12 AM, Paul Brook wrote: This series introduces a rather radical change in the way we deal with machine definitions in QEMU. I think we should aim to eliminate machine_register_core, and design appropriately. In particular I'd try and avoid adding options that become trivially

[Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Paolo Bonzini
On 06/08/2010 09:51 AM, Gerd Hoffmann wrote: On 06/08/10 01:51, Anthony Liguori wrote: Right now, if you set a QemuOpts option in a section twice, when you get the option you'll receive the value that was set the first time. This is less than ideal because if you're manipulating options in two p

[Qemu-devel] [PATCH] un-register kbd driver for USB kbd unplug

2010-06-08 Thread Jes . Sorensen
From: Jes Sorensen Hi, This is a fairly simple fix for the problem where the keyboard event handler is left in place when a keyboard is unplugged, eg. USB. The long term solution would be to use Shahar Havivi's multi-keyboard support patch[1] from March, but until Shahar's patch is ready, this

[Qemu-devel] [PATCH] un-register kbd driver in case of USB kbd unplug.

2010-06-08 Thread Jes . Sorensen
From: Jes Sorensen If a USB keyboard is unplugged, the keyboard eventhandler is never removed, and events will continue to be passed through to the device, causing crashes or memory corruption. Signed-off-by: Jes Sorensen --- console.h|1 + hw/usb-hid.c |3 +++ input.c |6

[Qemu-devel] Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Avi Kivity
On 06/08/2010 12:13 PM, Peter Lieven wrote: sorry, the subject should read 2.6.35-rc2 Peter Lieven wrote: Hi, I freshly installed kernel 2.6.35-rc2 using userspace qemu-kvm 0.12.4. When I live migrate a 32-bit opensuse-11.2 VM, the incoming VM shows the following error after the mem transfer

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote: > On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: >> >> So I see two ways to go forward: switch default value in my patch, >> or disable vlans unconditionally. >> > > The problem with disabling vlans unconditionally is that you

[Qemu-devel] Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Avi Kivity
On 06/08/2010 02:29 PM, Avi Kivity wrote: On 06/08/2010 12:13 PM, Peter Lieven wrote: sorry, the subject should read 2.6.35-rc2 Peter Lieven wrote: Hi, I freshly installed kernel 2.6.35-rc2 using userspace qemu-kvm 0.12.4. When I live migrate a 32-bit opensuse-11.2 VM, the incoming VM shows

Re: [Qemu-devel] Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Peter Lieven
Avi Kivity wrote: On 06/08/2010 12:13 PM, Peter Lieven wrote: sorry, the subject should read 2.6.35-rc2 Peter Lieven wrote: Hi, I freshly installed kernel 2.6.35-rc2 using userspace qemu-kvm 0.12.4. When I live migrate a 32-bit opensuse-11.2 VM, the incoming VM shows the following error afte

Re: [Qemu-devel] [PATCH] Fix and simplify gui timer logic.

2010-06-08 Thread Paul Brook
> >> Kill nographic timer. Have a global gui_timer instead. Have the gui > >> timer enabled unconditionally. We need a timer running anyway for mmio > >> flush, so the whole have-gui-timer-only-when-needed logic is pretty > >> pointless. It also simplifies displaylisteners coming and going at >

[Qemu-devel] Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Avi Kivity
On 06/08/2010 02:31 PM, Avi Kivity wrote: On 06/08/2010 02:29 PM, Avi Kivity wrote: On 06/08/2010 12:13 PM, Peter Lieven wrote: sorry, the subject should read 2.6.35-rc2 Peter Lieven wrote: Hi, I freshly installed kernel 2.6.35-rc2 using userspace qemu-kvm 0.12.4. When I live migrate a 32-b

[Qemu-devel] [PATCH] qdev: Revert the hack to let -net nic and pci_add set qdev ID

2010-06-08 Thread Markus Armbruster
Setting the ID in pci_nic_init() is a blatant violation of the DeviceState abstraction. Which even carries a comment advising against this: /* This structure should not be accessed directly. We declare it here so that it can be embedded in individual device state structures. */ What's worse

[Qemu-devel] [PATCH] qemu-option: Reject anti-social IDs

2010-06-08 Thread Markus Armbruster
Restrict IDs to letters, digits, '-', '.', '_', starting with a letter. This takes care of '/' in qdev IDs breaking qbus_find(). Signed-off-by: Markus Armbruster --- qemu-option.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/qemu-option.c b/qemu-o

Re: [Qemu-devel] [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-08 Thread Markus Armbruster
Paul Brook writes: >> Paul Brook writes: >> >> Also require IDs to start with a letter to provide for possible future >> >> extensions. >> > >> > I'd go further than that, and require that user specified IDs match >> > [A-Za-z][A-Za-z0-9_-]* >> >> I talked with Dan (cc'ed) to make sure we don'

[Qemu-devel] Re: [PATCH] un-register kbd driver for USB kbd unplug

2010-06-08 Thread Shahar Havivi
On Tue, Jun 08, 2010 at 12:43:50PM +0200, jes.soren...@redhat.com wrote: > Date: Tue, 8 Jun 2010 12:43:50 +0200 > From: jes.soren...@redhat.com > To: anth...@codemonkey.ws > Cc: qemu-devel@nongnu.org, shav...@redhat.com, > Jes Sorensen > Subject: [PATCH] un-register kbd driver for USB kbd u

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 04:57:09PM -0500, Anthony Liguori wrote: > On 06/07/2010 04:37 PM, Anthony Liguori wrote: >> On 06/07/2010 03:58 PM, Michael S. Tsirkin wrote: >>> On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote: On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: > So

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: > > With -netdev, there now seems to be little need to support vlans, > > enabling them leads to user confusion and bad performance. > > Disable support for vlans by default, add config option to enable. > > No. If you want to remove vlan

[Qemu-devel] [RFC] QMP: new query-snapshots command

2010-06-08 Thread Miguel Di Ciurcio Filho
Hi there, This is just an initial draft. I would like to align everybody's opinions and expectations about this feature before starting coding and submitting patches. (although I've already started to hack some stuff [1]) The way QEMU tracks snapshot identification is not consistent and lacks var

[Qemu-devel] Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Peter Lieven
Avi Kivity wrote: On 06/08/2010 02:31 PM, Avi Kivity wrote: On 06/08/2010 02:29 PM, Avi Kivity wrote: On 06/08/2010 12:13 PM, Peter Lieven wrote: sorry, the subject should read 2.6.35-rc2 Peter Lieven wrote: Hi, I freshly installed kernel 2.6.35-rc2 using userspace qemu-kvm 0.12.4. When

[Qemu-devel] Disable PS/2 mouse

2010-06-08 Thread Peter Lieven
Hi, is there any way to disable the PS/2 mouse emulation from command line? BR, Peter

[Qemu-devel] Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Avi Kivity
On 06/08/2010 03:49 PM, Peter Lieven wrote: And finally, perhaps you have NX disabled in the bios of one of the machines? What does 'dmesg | grep NX' show on both hosts? nx was disabled on one of the nodes. That explains the problem. i will retry the case later today and send info reg

[Qemu-devel] Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Peter Lieven
Avi Kivity wrote: On 06/08/2010 03:49 PM, Peter Lieven wrote: And finally, perhaps you have NX disabled in the bios of one of the machines? What does 'dmesg | grep NX' show on both hosts? nx was disabled on one of the nodes. That explains the problem. i will retry the case later toda

Re: [Qemu-devel] [PATCH 10/22] machine: allow boards to specify default values and use it in isapc

2010-06-08 Thread Anthony Liguori
On 06/08/2010 03:03 AM, Gerd Hoffmann wrote: static QEMUMachine pc_machine = { .name = "pc-0.13", .alias = "pc", .desc = "Standard PC", -.init = pc_init_pci, +.init = pc_init, .max_cpus = 255, .is_default = 1, .opts_desc = pc_opts_desc, +.opts_def

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Anthony Liguori
On 06/08/2010 06:09 AM, Michael S. Tsirkin wrote: On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote: On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: So I see two ways to go forward: switch default value in my patch, or disable vlans unconditionally. The probl

[Qemu-devel] [PATCH v2] un-register kbd driver for USB kbd unplug

2010-06-08 Thread Jes . Sorensen
From: Jes Sorensen Hi, Kevin pointed out the TODO comment was obsolete and also suggested turning the if lines into a switch statement. It seems cleaner, so here is a second version of the patch. This is a fairly simple fix for the problem where the keyboard event handler is left in place when

[Qemu-devel] [PATCH] un-register kbd driver in case of USB kbd unplug.

2010-06-08 Thread Jes . Sorensen
From: Jes Sorensen If a USB keyboard is unplugged, the keyboard eventhandler is never removed, and events will continue to be passed through to the device, causing crashes or memory corruption. Signed-off-by: Jes Sorensen --- console.h|1 + hw/usb-hid.c |8 ++-- input.c |

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Anthony Liguori
On 06/08/2010 07:13 AM, Michael S. Tsirkin wrote: On Mon, Jun 07, 2010 at 04:57:09PM -0500, Anthony Liguori wrote: On 06/07/2010 04:37 PM, Anthony Liguori wrote: On 06/07/2010 03:58 PM, Michael S. Tsirkin wrote: On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote:

[Qemu-devel] Re: [PATCH 00/35] S390 TCG target, version 2

2010-06-08 Thread Alexander Graf
On 04.06.2010, at 21:14, Richard Henderson wrote: > Changes v1->v2 > * Disassembler doesn't include GPLv3 code. > > * Smashed about 20 commits into the "New TCG Target" patch, >which is fully functional from the beginning. > > * Merged a lot of the follow-on patches such that introducing

Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Anthony Liguori
On 06/08/2010 05:32 AM, Paolo Bonzini wrote: On 06/08/2010 09:51 AM, Gerd Hoffmann wrote: On 06/08/10 01:51, Anthony Liguori wrote: Right now, if you set a QemuOpts option in a section twice, when you get the option you'll receive the value that was set the first time. This is less than ideal b

[Qemu-devel] Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Peter Lieven
Avi Kivity wrote: On 06/08/2010 03:49 PM, Peter Lieven wrote: And finally, perhaps you have NX disabled in the bios of one of the machines? What does 'dmesg | grep NX' show on both hosts? nx was disabled on one of the nodes. That explains the problem. i will retry the case later toda

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Michael S. Tsirkin
On Tue, Jun 08, 2010 at 08:03:33AM -0500, Anthony Liguori wrote: > On 06/08/2010 07:13 AM, Michael S. Tsirkin wrote: >> On Mon, Jun 07, 2010 at 04:57:09PM -0500, Anthony Liguori wrote: >> >>> On 06/07/2010 04:37 PM, Anthony Liguori wrote: >>> On 06/07/2010 03:58 PM, Michael S. Tsirki

Re: [Qemu-devel] [PATCH] Fix and simplify gui timer logic.

2010-06-08 Thread Gerd Hoffmann
On 06/08/10 13:50, Paul Brook wrote: Kill nographic timer. Have a global gui_timer instead. Have the gui timer enabled unconditionally. We need a timer running anyway for mmio flush, so the whole have-gui-timer-only-when-needed logic is pretty pointless. It also simplifies displaylisteners co

Re: [Qemu-devel] [PATCH 10/22] machine: allow boards to specify default values and use it in isapc

2010-06-08 Thread Gerd Hoffmann
On 06/08/10 15:09, Anthony Liguori wrote: On 06/08/2010 03:03 AM, Gerd Hoffmann wrote: + .opts_default = (QemuOptValue[]) { + { + .name = "acpi", + .value = "on", + }, Should be moved into a separate struct and just referenced as it is identical for pc-0.* Would need to be macros because in

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Michael S. Tsirkin
On Tue, Jun 08, 2010 at 08:02:27AM -0500, Anthony Liguori wrote: > On 06/08/2010 06:09 AM, Michael S. Tsirkin wrote: >> On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote: >> >>> On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: >>> So I see two ways to go forward: switc

[Qemu-devel] Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Avi Kivity
On 06/08/2010 04:28 PM, Peter Lieven wrote: i will retry the case later today and send info register output. what is the recommended value for nx (and why)? Enabled (so you get no-execute memory protection). do you have a guideline which flags should be identical to ensure proper live migr

[Qemu-devel] Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Avi Kivity
On 06/08/2010 04:44 PM, Peter Lieven wrote: -cpu host is good if you have identical machines and don't plan to add new ones. i will likely add new ones, but my plan would be to use qemu64 and then add all flags manually that are common to all cpus in the pool. would that be safe? Yes. -- e

[Qemu-devel] [PATCH] Clarify error message when a PCI slot is already in use

2010-06-08 Thread Daniel P. Berrange
When mistakenly configuring two devices in the same PCI slot, QEMU gives a not entirely obvious message about a 'devfn' being in use: $ qemu -device rtl8139 -device virtio-balloon-pci,bus=pci.0,addr=0x3 qemu-kvm: -device virtio-balloon-pci,bus=pci.0,addr=0x3: PCI: devfn 24 not available for virti

[Qemu-devel] Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Peter Lieven
Avi Kivity wrote: On 06/08/2010 04:38 PM, Peter Lieven wrote: Avi Kivity wrote: On 06/08/2010 04:28 PM, Peter Lieven wrote: i will retry the case later today and send info register output. what is the recommended value for nx (and why)? Enabled (so you get no-execute memory protection).

Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Gerd Hoffmann
On 06/08/10 15:07, Anthony Liguori wrote: Note that this reverses the ordering for users which want multiple values (slirp forwarding for example). And qemu_opt_find seems to have thought about this too: static QemuOpt *qemu_opt_find(QemuOpts *opts, const char *name) { QemuOpt *opt; QTAILQ_FO

[Qemu-devel] Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Peter Lieven
Avi Kivity wrote: On 06/08/2010 04:28 PM, Peter Lieven wrote: i will retry the case later today and send info register output. what is the recommended value for nx (and why)? Enabled (so you get no-execute memory protection). do you have a guideline which flags should be identical to ensur

[Qemu-devel] [PATCH v5] savevm: Really verify if a drive supports snapshots

2010-06-08 Thread Miguel Di Ciurcio Filho
Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. First issue: Their names implies different porpouses, but they do the same thing and have exactly the same code. Maybe copied and pasted and forgotten? bdrv_has_snapshot() is called in various places for actually checkin

[Qemu-devel] Re: Live Migration of 32-bit Linux guest broken since 2.6.35-rc2

2010-06-08 Thread Avi Kivity
On 06/08/2010 04:38 PM, Peter Lieven wrote: Avi Kivity wrote: On 06/08/2010 04:28 PM, Peter Lieven wrote: i will retry the case later today and send info register output. what is the recommended value for nx (and why)? Enabled (so you get no-execute memory protection). do you have a guide

Re: [Qemu-devel] [PATCH 0/22] Refactor machine support

2010-06-08 Thread Anthony Liguori
On 06/07/2010 10:12 PM, Paul Brook wrote: This series introduces a rather radical change in the way we deal with machine definitions in QEMU. I think we should aim to eliminate machine_register_core, and design appropriately. In particular I'd try and avoid adding options that become triv

[Qemu-devel] [PATCH] megasas: Update to version 1.01

2010-06-08 Thread Hannes Reinecke
This patch updates the megasas HBA emulation to version 1.01. It fixes the following issues: - Remove hand-crafted inquiry command - Remove bounce-buffer for direct commands - Implements qdev properties to set 'max_sge', 'max_cmds'. - Implement JBOD mode - Improve direct command handling - Minor

[Qemu-devel] Re: [PATCH v5] savevm: Really verify if a drive supports snapshots

2010-06-08 Thread Kevin Wolf
Am 08.06.2010 15:40, schrieb Miguel Di Ciurcio Filho: > Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. > > First issue: Their names implies different porpouses, but they do the same > thing > and have exactly the same code. Maybe copied and pasted and forgotten? > b

Re: [Qemu-devel] [PATCH] Clarify error message when a PCI slot is already in use

2010-06-08 Thread Isaku Yamahata
On Tue, Jun 08, 2010 at 02:58:25PM +0100, Daniel P. Berrange wrote: > When mistakenly configuring two devices in the same PCI slot, > QEMU gives a not entirely obvious message about a 'devfn' being > in use: > > $ qemu -device rtl8139 -device virtio-balloon-pci,bus=pci.0,addr=0x3 > qemu-kvm: -devi

[Qemu-devel] [PATCH] Clarify error message when a PCI slot is already in use (v2)

2010-06-08 Thread Daniel P. Berrange
When mistakenly configuring two devices in the same PCI slot, QEMU gives a not entirely obvious message about a 'devfn' being in use: $ qemu -device rtl8139 -device virtio-balloon-pci,bus=pci.0,addr=0x3 qemu-kvm: -device virtio-balloon-pci,bus=pci.0,addr=0x3: PCI: devfn 24 not available for virti

Re: [Qemu-devel] [PATCH] Clarify error message when a PCI slot is already in use

2010-06-08 Thread Daniel P. Berrange
On Tue, Jun 08, 2010 at 11:16:48PM +0900, Isaku Yamahata wrote: > On Tue, Jun 08, 2010 at 02:58:25PM +0100, Daniel P. Berrange wrote: > > When mistakenly configuring two devices in the same PCI slot, > > QEMU gives a not entirely obvious message about a 'devfn' being > > in use: > > > > $ qemu -de

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Gerd Hoffmann
On 06/08/10 15:02, Anthony Liguori wrote: On 06/08/2010 06:09 AM, Michael S. Tsirkin wrote: On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote: On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: So I see two ways to go forward: switch default value in my patch, or disable vlans unc

Re: [Qemu-devel] Re: [PATCH 0/22] Refactor machine support

2010-06-08 Thread Paul Brook
> > I'm undecided how much parameterisation it's worth trying to support in > > the device tree. IMO the current code has way too much magic, because > > creating a new variant involves hacking and rebuilding pc.c. > > See patch 22/22. There is really no magic involved, even though the > compat m

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Paul Brook
> I see three possible options to handle this. > >(1) Write a hub (or morph the current vlan code into this). Then >you can do something like: > > qemu -netdev socket,id=p1 \ > -netdev user,id=p2 \ > -netdev dump,id=p3 \ >

Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Paul Brook
> The problem I was trying to address can be seen with something like: > > -drive file=foo.img,if=virtio,file=bar.img > > You get no error, and foo.img is what gets used. It's fair to argue > this is a silly use case but what I'm trying to achieve is to make it > possible to do: > > -drive file

Re: [Qemu-devel] Re: [PATCH 0/22] Refactor machine support

2010-06-08 Thread Paolo Bonzini
> The magic I'm preferring to is precisely things like pci="on". Hmm, pci=on is magic indeed. :-) > What I'm objecting to is making machine construction be controlled by an > arbitrary set of hardcoded parameters. > My argument is that in the short term this parameterization provides limited >

Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Anthony Liguori
On 06/08/2010 09:38 AM, Paul Brook wrote: The problem I was trying to address can be seen with something like: -drive file=foo.img,if=virtio,file=bar.img You get no error, and foo.img is what gets used. It's fair to argue this is a silly use case but what I'm trying to achieve is to make it po

[Qemu-devel] [PATCH] net: Fix hotplug with pci_add

2010-06-08 Thread Amit Shah
The correct model type wasn't getting added when hotplugging nics with pci_add. Testcase: start VM with default nic type. In the qemu_monitor: (qemu) pci_add auto nic model=virtio This results in a nic hot-plug of the same nic type as the default. Signed-off-by: Amit Shah --- net.c |6 +++

[Qemu-devel] [RFC PATCH 1/2] USB Video Class device emulation.

2010-06-08 Thread Natalia Portillo
Signed-off-by: Natalia Portillo --- hw/usb-uvc.c | 1096 ++ 1 files changed, 1096 insertions(+), 0 deletions(-) create mode 100644 hw/usb-uvc.c diff --git a/hw/usb-uvc.c b/hw/usb-uvc.c new file mode 100644 index 000..b711f51 --- /dev/n

[Qemu-devel] [RFC PATCH 2/2] Adds device to Makefile.

2010-06-08 Thread Natalia Portillo
Signed-off-by: Natalia Portillo --- Makefile.objs |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 110f8fd..1535b61 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -70,6 +70,7 @@ common-obj-y += scsi-disk.o cdrom.o common-obj-y += scs

Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Gerd Hoffmann
What'd expect is: [net "user"] guestfwd = .. I think multiple entry options are probably not a good thing to have. We already have them though (-net switch so QemuOpts added them). cheers, Gerd

[Qemu-devel] [RFC PATCH 0/2] Add USB Video Class device emulation.

2010-06-08 Thread Natalia Portillo
Hi, This currently adds an emulated USB webcam compliant with USB Video Class Specification 1.0a. It only works on Linux guests and feeds the emulated device using a Video4Linux 2 host device, as long as it supports 320x240 MJPEG format. This is a Request for Comments as surely code needs some

[Qemu-devel] [PATCH v2] net: Fix hotplug with pci_add

2010-06-08 Thread Amit Shah
The correct model type wasn't getting added when hotplugging nics with pci_add. Testcase: start VM with default nic type. In the qemu_monitor: (qemu) pci_add auto nic model=virtio This results in a nic hot-plug of the same nic type as the default. This was broken in 5294e2c774f120e10b44652ac143

[Qemu-devel] Re: [PATCH v2] net: Fix hotplug with pci_add

2010-06-08 Thread Juan Quintela
Amit Shah wrote: > The correct model type wasn't getting added when hotplugging nics with > pci_add. > > Testcase: start VM with default nic type. In the qemu_monitor: > > (qemu) pci_add auto nic model=virtio > > This results in a nic hot-plug of the same nic type as the default. > > This was brok

[Qemu-devel] [Bug 591320] [NEW] [ARM]: SIMD add/sub instructions are incorrect

2010-06-08 Thread Bradley Smith
Public bug reported: The thumb2 and unsigned arm state SIMD add/sub instructions are implemented incorrectly, for example: UQSUB8 r0, r1, r0 gives r0 as 0, where r0 is 0x12345678 and r1 is 0x23456789 in ARM state, and: UHSUB8 r0, r1, r0 gives r0 as 0xbe01, where r0 is 0x12345678 and r

Re: [Qemu-devel] Re: [PATCH 0/22] Refactor machine support

2010-06-08 Thread Paolo Bonzini
On 06/08/2010 05:36 PM, Paul Brook wrote: Once you eliminate machine_register_core that knowledge has somehow got to come from your device tree description file. Having a single device tree that can morph into significantly different machines seems like unnecessary complexity given this is a

[Qemu-devel] KVM call minutes for June 8

2010-06-08 Thread Chris Wright
Accelerating counters (aka moving PIT to userspace, keeping HPET in userspace) - PIT (in-kernel, userspace, or split) - userspace PIT, too slow - kernel PIT (already seen bugs) - split PIT, not realistic w/out a sane interface (see bugs above) - exit to userspace is a base cost, add MSR save/restor

Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Anthony Liguori
On 06/08/2010 08:44 AM, Gerd Hoffmann wrote: On 06/08/10 15:07, Anthony Liguori wrote: Note that this reverses the ordering for users which want multiple values (slirp forwarding for example). And qemu_opt_find seems to have thought about this too: static QemuOpt *qemu_opt_find(QemuOpts *opts

Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Anthony Liguori
On 06/08/2010 10:37 AM, Gerd Hoffmann wrote: What'd expect is: [net "user"] guestfwd = .. I think multiple entry options are probably not a good thing to have. We already have them though (-net switch so QemuOpts added them). Yeah, but let's ignore that for the moment. If we didn't have

Re: [Qemu-devel] Re: [PATCH 0/22] Refactor machine support

2010-06-08 Thread Anthony Liguori
On 06/08/2010 09:30 AM, Paul Brook wrote: I'm undecided how much parameterisation it's worth trying to support in the device tree. IMO the current code has way too much magic, because creating a new variant involves hacking and rebuilding pc.c. See patch 22/22. There is really no magic

[Qemu-devel] Re: [PATCH] net: Fix hotplug with pci_add

2010-06-08 Thread Gerd Hoffmann
On 06/08/10 17:17, Amit Shah wrote: The correct model type wasn't getting added when hotplugging nics with pci_add. Testcase: start VM with default nic type. In the qemu_monitor: (qemu) pci_add auto nic model=virtio > This results in a nic hot-plug of the same nic type as the default. Same

Re: [Qemu-devel] Re: [PATCH 0/22] Refactor machine support

2010-06-08 Thread Anthony Liguori
On 06/08/2010 10:58 AM, Paolo Bonzini wrote: On 06/08/2010 05:36 PM, Paul Brook wrote: Once you eliminate machine_register_core that knowledge has somehow got to come from your device tree description file. Having a single device tree that can morph into significantly different machines s

Re: [Qemu-devel] Re: [PATCH 0/22] Refactor machine support

2010-06-08 Thread Paul Brook
> > Once you eliminate machine_register_core that knowledge has > > > > somehow got to come from your device tree description file. Having a > > single device tree that can morph into significantly different machines > > seems like unnecessary complexity given this is a user-specified file. >

[Qemu-devel] [PATCH 1/2] virtio-blk: stop tracking old_bs

2010-06-08 Thread Christoph Hellwig
There is a 1:1 relation between VirtIOBlock and BlockDriverState instances, no need to track it because it won't change. Signed-off-by: Christoph Hellwig Index: qemu/hw/virtio-blk.c === --- qemu.orig/hw/virtio-blk.c 2010-05-26 13:

[Qemu-devel] [PATCH 2/2] virtio-blk: simplify multiwrite calling conventions

2010-06-08 Thread Christoph Hellwig
Pass the MultiReqBuffer structure down all the way to the I/O submission instead of takin it apart. Also mark num_writes unsigned as it can't go negative, and take the check for any pending I/O requests into the submission function. Last but not least rename do_multiwrite to virtio_submit_multiwr

[Qemu-devel] [Bug 586420] Re: WinXP install cd hangs at boot time if machine started with floppy

2010-06-08 Thread tekditt
Well, I tried your command line and I've got the bug "qemu: could not load PC BIOS 'bios.bin'" It seems something went wrong with my compiled qemu. I'll try qemu.git now. -- WinXP install cd hangs at boot time if machine started with floppy https://bugs.launchpad.net/bugs/586420 You received thi

[Qemu-devel] Re: KVM call minutes for June 8

2010-06-08 Thread Anthony Liguori
On 06/08/2010 10:05 AM, Chris Wright wrote: Accelerating counters (aka moving PIT to userspace, keeping HPET in userspace) - PIT (in-kernel, userspace, or split) - userspace PIT, too slow - kernel PIT (already seen bugs) - split PIT, not realistic w/out a sane interface (see bugs above) - exit to

Re: [Qemu-devel] [PATCH 3/3] cow: use qemu block API

2010-06-08 Thread Kevin Wolf
Am 07.06.2010 12:06, schrieb Christoph Hellwig: > Use bdrv_pwrite to access the backing device instead of pread, and > convert the driver to implementing the bdrv_open method which gives > it an already opened BlockDriverState for the underlying device. > > Signed-off-by: Christoph Hellwig Thank

Re: [Qemu-devel] [PATCH v2] net: Fix hotplug with pci_add

2010-06-08 Thread Markus Armbruster
Amit Shah writes: > The correct model type wasn't getting added when hotplugging nics with > pci_add. > > Testcase: start VM with default nic type. In the qemu_monitor: > > (qemu) pci_add auto nic model=virtio > > This results in a nic hot-plug of the same nic type as the default. Works fine for

[Qemu-devel] Re: [PATCH] net: Fix hotplug with pci_add

2010-06-08 Thread Amit Shah
On (Tue) Jun 08 2010 [17:31:04], Gerd Hoffmann wrote: > On 06/08/10 17:17, Amit Shah wrote: > >The correct model type wasn't getting added when hotplugging nics with > >pci_add. > > > >Testcase: start VM with default nic type. In the qemu_monitor: > > > >(qemu) pci_add auto nic model=virtio > > > >

  1   2   >