Paul Brook <p...@codesourcery.com> writes: >> Paul Brook <p...@codesourcery.com> writes: >> >> Also require IDs to start with a letter to provide for possible future >> >> extensions. >> > >> > I'd go further than that, and require that user specified IDs match >> > [A-Za-z][A-Za-z0-9_-]* >> >> I talked with Dan (cc'ed) to make sure we don't trample on existing >> libvirt usage without need. What about >> >> [A-Za-z][A-Za-z0-9_-:.]* >> >> i.e. your regexp plus ':' and '.' in the second bracket? > > I was deliberately avoiding those as they're often used as separators - we > already use ':' in other contexts so there's potential ambiguity and > parsing/quoting issues. I'm not aware of any current issues with '.'.
I checked with Dan, and we can outlaw ':'. I just posted a new patch that covers all qemu-option IDs, not just qdev. [...]
