pci_dev = pci_create(bus, devfn, pci_nic_names[i]); dev =&pci_dev->qdev; if (nd->name) dev->id = qemu_strdup(nd->name);Blatant violation of the DeviceState abstraction. Which even carries a comment advising against this:
Do we still need this? Anybody wanting ID can use -device.
I think it is only used for -net nic,...,name=something. I think this predates working -device for nics. So, yes, it shouldn't be needed any more ...
cheers, Gerd
