[Qemu-devel] [Build-Failure] hw/pc: undefined reference's

2010-05-15 Thread Kamalesh Babulal
Hi, Build fails with following error, arch_init.o:(.data+0x44): undefined reference to `SB16_init' arch_init.o:(.data+0x58): undefined reference to `ac97_init' arch_init.o:(.data+0x6c): undefined reference to `es1370_init' pc.o: In function `pc_init1': /other/srcs/qemu-kvm/hw/pc.c:1005: undefine

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-15 Thread Jan Kiszka
Alexander Graf wrote: > On 14.05.2010, at 18:17, Jan Kiszka wrote: >> Alexander Graf wrote: >>> Now that I can finally reproduce the bug with --enable-io-thread, I can >>> verify that it does *not* fix the issue. >> I do not trust your tests. :p >> >> I just tried to reproduce with --enable-io-thr

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-15 Thread Alexander Graf
On 15.05.2010, at 10:36, Jan Kiszka wrote: > Alexander Graf wrote: >> On 14.05.2010, at 18:17, Jan Kiszka wrote: >>> Alexander Graf wrote: Now that I can finally reproduce the bug with --enable-io-thread, I can verify that it does *not* fix the issue. >>> I do not trust your tests. :p

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-15 Thread Jan Kiszka
Luiz Capitulino wrote: > On Fri, 14 May 2010 19:08:07 +0200 > Jan Kiszka wrote: > >> Avi Kivity wrote: >>> On 05/14/2010 08:01 PM, Avi Kivity wrote: On 05/14/2010 07:52 PM, Jan Kiszka wrote: >> In order not to compromise QMP adoption and make users' life easier, >> this commit adds a

[Qemu-devel] Re: [PATCH 3/8] Add QBuffer

2010-05-15 Thread Jan Kiszka
Anthony Liguori wrote: > On 05/14/2010 08:20 AM, Jan Kiszka wrote: >> diff --git a/qjson.c b/qjson.c >> index 483c667..4d1c21a 100644 >> --- a/qjson.c >> +++ b/qjson.c >> @@ -19,7 +19,9 @@ >> #include "qlist.h" >> #include "qbool.h" >> #include "qfloat.h" >> +#include "qbuffer.h" >> #includ

Re: [Qemu-devel] [Build-Failure] hw/pc: undefined reference's

2010-05-15 Thread Isaku Yamahata
Hi. Which change set/patches are you using? 'make clean; make' doesn't work? On Sat, May 15, 2010 at 02:00:00PM +0530, Kamalesh Babulal wrote: > Hi, > > Build fails with following error, > > arch_init.o:(.data+0x44): undefined reference to `SB16_init' > arch_init.o:(.data+0x58): undefined refer

[Qemu-devel] Re: [PATCH 3/8] Add QBuffer

2010-05-15 Thread Avi Kivity
On 05/15/2010 11:45 AM, Jan Kiszka wrote: Instead of encoding just as a string, it would be a good idea to encode it as something like: {'__class__': 'base64', 'data': ...} We've discussed using hidden properties to describe special things like abstract classes and since we already have this

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-15 Thread Jan Kiszka
Alexander Graf wrote: > On 15.05.2010, at 10:36, Jan Kiszka wrote: > >> Alexander Graf wrote: >>> On 14.05.2010, at 18:17, Jan Kiszka wrote: Alexander Graf wrote: > Now that I can finally reproduce the bug with --enable-io-thread, I can > verify that it does *not* fix the issue.

[Qemu-devel] Re: [PATCH 3/8] Add QBuffer

2010-05-15 Thread Jan Kiszka
Avi Kivity wrote: > On 05/15/2010 11:45 AM, Jan Kiszka wrote: >> >>> Instead of encoding just as a string, it would be a good idea to encode >>> it as something like: >>> >>> {'__class__': 'base64', 'data': ...} >>> >>> We've discussed using hidden properties to describe special things like >>> abs

Re: [Qemu-devel] [Build-Failure] hw/pc: undefined reference's

2010-05-15 Thread Kamalesh Babulal
* Isaku Yamahata [2010-05-15 17:46:59]: > Hi. > Which change set/patches are you using? > 'make clean; make' doesn't work? > Sorry for the noise. 'make defconfig' helped. Kamalesh

[Qemu-devel] [PATCH 0/2] pckbd improvements

2010-05-15 Thread Blue Swirl
In 2/2, A20 logic changes a bit but I doubt any guest would be broken if A20 line written through I/O port 92 couldn't be read via i8042. The reverse (write using i8042 and read port 92) will work. Blue Swirl (2): pc: improve onboard I/O port debugging Compile pckbd only once Makefile.objs

[Qemu-devel] [PATCH 1/2] pc: improve onboard I/O port debugging

2010-05-15 Thread Blue Swirl
Signed-off-by: Blue Swirl --- hw/pc.c | 18 +- 1 files changed, 17 insertions(+), 1 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index db2b9a2..938b2e0 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -51,6 +51,16 @@ /* output Bochs bios info messages */ //#define DEBUG_BIOS +/* debug b

[Qemu-devel] [PATCH 2/2] Compile pckbd only once

2010-05-15 Thread Blue Swirl
Use a qemu_irq to indicate A20 line changes. This changes the A20 logic so that when checking A20 line, i8042 and I/O port 92 may see different values if the other method is used to change the A20 line. Signed-off-by: Blue Swirl --- Makefile.objs|1 + Makefile.target

[Qemu-devel] [PATCH] Clean libhw subdirs as well

2010-05-15 Thread Jan Kiszka
From: Jan Kiszka Signed-off-by: Jan Kiszka --- Makefile.hw |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.hw b/Makefile.hw index be35359..b9181ab 100644 --- a/Makefile.hw +++ b/Makefile.hw @@ -18,7 +18,7 @@ all: $(hw-obj-y) @true clean: - rm

[Qemu-devel] [PATCH] Put dependency files in proper subdir

2010-05-15 Thread Jan Kiszka
From: Jan Kiszka This seems to resolve subtle breakages of our build system: Dependency files generated for targets like 'dir/foo.o' were saved as 'foo.d'. Now, if there was also a target 'foo.o', one of the dependency file was overwritten. Concrete example: libhw*/macio.o vs. libhw*/ide/macio.o

[Qemu-devel] Re: [PATCH] Put dependency files in proper subdir

2010-05-15 Thread Jan Kiszka
Jan Kiszka wrote: > From: Jan Kiszka > > This seems to resolve subtle breakages of our build system: > > Dependency files generated for targets like 'dir/foo.o' were saved as > 'foo.d'. Now, if there was also a target 'foo.o', one of the dependency > file was overwritten. Concrete example: libhw

[Qemu-devel] [PATCH v2 0/6] vmstate: Drop post_save / allow instance ID aliases

2010-05-15 Thread Jan Kiszka
This series comes with two major contributions: - after moving away the last user of post_save (tmp105), this vmstate callback is dropped - introduction of an instance ID alias to vmstate, allowing to drop a few more explicit vmstate_register calls Changes in v2: - incorporated Blue Swirl

[Qemu-devel] [PATCH v2 3/6] vmstate: Add support for alias ID

2010-05-15 Thread Jan Kiszka
From: Jan Kiszka Some legacy users (mostly PC devices) of vmstate_register manage instance IDs on their own, and that unfortunately in a way that is incompatible with automatically generated ones. This so far prevents switching those users to vmstates that are registered by qdev. To establish a

[Qemu-devel] [PATCH v2 5/6] fdc: Register vmstate via qdev

2010-05-15 Thread Jan Kiszka
From: Jan Kiszka Establish vmstate containers for ISA and sysbus variant, define the iobase as instance ID alias, and let qdev do the vmstate registration work. Signed-off-by: Jan Kiszka --- hw/fdc.c | 35 ++- 1 files changed, 30 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH v2 4/6] serial: Register vmstate via qdev

2010-05-15 Thread Jan Kiszka
From: Jan Kiszka At least for isa-serial, we can already let qdev do the vmstate registration for us. It just takes wrapping vmstate for the encapsulating ISASerialState and defining the proper instance ID aliases. Signed-off-by: Jan Kiszka --- hw/serial.c | 13 - 1 files changed

[Qemu-devel] [PATCH v2 2/6] vmstate: Drop unused post_save handler

2010-05-15 Thread Jan Kiszka
From: Jan Kiszka No device makes use of it anymore. Signed-off-by: Jan Kiszka --- hw/hw.h |1 - savevm.c |3 --- 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 328b704..2d39724 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -321,7 +321,6 @@ struct VMStat

[Qemu-devel] [PATCH v2 6/6] mc146818rtc: Register vmstate via qdev

2010-05-15 Thread Jan Kiszka
From: Jan Kiszka After defining the required alias ID, we can push vmstate registration of mc146818rtc to qdev. Signed-off-by: Jan Kiszka --- hw/mc146818rtc.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index 89a423e..905e670 1

[Qemu-devel] [PATCH v2 1/6] tmp105: Drop unused faults field

2010-05-15 Thread Jan Kiszka
From: Jan Kiszka It was only written, but never read. Signed-off-by: Jan Kiszka CC: Andrzej Zaborowski --- hw/tmp105.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/hw/tmp105.c b/hw/tmp105.c index 8343aff..cac5f2b 100644 --- a/hw/tmp105.c +++ b/hw/tmp105.c

[Qemu-devel] Re: [PATCH v2] sh: sm501: add 2D engine support

2010-05-15 Thread Shin-ichiro KAWASAKI
(2010/05/15 5:44), Blue Swirl wrote: On 5/11/10, Shin-ichiro KAWASAKI wrote: Hello Blue Swirl, and thank you for the review. Here's the patch modified according to your comments. abort() is used instead of assert(), and const modifier added for CPU*MemoryFunc. The patch does not apply. I

[Qemu-devel] [PATCH v3] sh: sm501: add 2D engine support

2010-05-15 Thread Shin-ichiro KAWASAKI
This patch reflects Blue Swirl's second review. Rebased with recent commit, and modified field name with underscore prefix. Best Regards, Shin-ichiro KAWASAKI --- In linux kernel v2.6.33, sm501 frame buffer driver modified

[Qemu-devel] Re: [PATCH v2 1/6] tmp105: Drop unused faults field

2010-05-15 Thread andrzej zaborowski
Hi Jan, On 15 May 2010 13:32, Jan Kiszka wrote: > From: Jan Kiszka > > It was only written, but never read. I pushed an alternate version to just move the update from post_save to post_load. If you think of code as documentation, the struct becomes less complete in representing the state of th

Re: [Qemu-devel] Re: sparc64 lazy conditional codes evaluation

2010-05-15 Thread Mark Cave-Ayland
Blue Swirl wrote: Guest time can be unreliable, it could also indicate that Linux executes a lot more timer interrupts. Could you retest and measure the wall clock time? I think the C flag change should only increase performance. The next commit may have negative effects because more work is do

[Qemu-devel] Re: [PATCH v2 1/6] tmp105: Drop unused faults field

2010-05-15 Thread Jan Kiszka
andrzej zaborowski wrote: > Hi Jan, > > On 15 May 2010 13:32, Jan Kiszka wrote: >> From: Jan Kiszka >> >> It was only written, but never read. > > I pushed an alternate version to just move the update from post_save > to post_load. If you think of code as documentation, the struct > becomes le

[Qemu-devel] Re: [PATCH v3] sh: sm501: add 2D engine support

2010-05-15 Thread Blue Swirl
Thanks, applied. On 5/15/10, Shin-ichiro KAWASAKI wrote: > This patch reflects Blue Swirl's second review. > Rebased with recent commit, and modified field name with underscore prefix. > > > Best Regards, > Shin-ichiro KAWASAKI > > > > --

[Qemu-devel] Re: [PATCH v2 0/6] vmstate: Drop post_save / allow instance ID aliases

2010-05-15 Thread Blue Swirl
Thanks, applied all. On 5/15/10, Jan Kiszka wrote: > This series comes with two major contributions: > - after moving away the last user of post_save (tmp105), this vmstate >callback is dropped > - introduction of an instance ID alias to vmstate, allowing to drop a few >more explicit

[Qemu-devel] Re: [PATCH 00/26] split out piix specific part from pc emulator and some clean ups

2010-05-15 Thread Blue Swirl
Thanks, applied all. On 5/14/10, Isaku Yamahata wrote: > patch series description: > This patch series is for spliting out piix specific part from pc emulator > to make it easier to implement other pc chipset emulator. > > I observed that make was confused not to rebuild files sometimes due to

[Qemu-devel] Re: [PATCH 3/8] Add QBuffer

2010-05-15 Thread Avi Kivity
On 05/15/2010 11:59 AM, Jan Kiszka wrote: Is this __class__ stuff documented anywhere? Not yet. Also, we should clarify the proposed private extension section that only "__some_key" is reserved for downstream, not '__some_other_key__' (i.e. downstream names must not end with '__').

[Qemu-devel] [PATCH 0/3] mingw32 compile fixes

2010-05-15 Thread Blue Swirl
Hi, With this mingw32 compiler: $ i586-mingw32msvc-gcc -v Using built-in specs. Target: i586-mingw32msvc Configured with: /tmp/buildd/gcc-mingw32-4.4.2/build-tree/gcc-4.4.2/configure --build=x86_64-linux-gnu --prefix=/usr --includedir='/usr/include' --mandir='/usr/share/man' --infodir='/usr/share

[Qemu-devel] [PATCH 1/3] Fix %lld or %llx printf format use

2010-05-15 Thread Blue Swirl
Signed-off-by: Blue Swirl --- audio/audio_template.h |2 +- block/curl.c|9 --- block/parallels.c |7 - block/qcow2.c |8 -- darwin-user/commpage.c |2 +- darwin-user/syscall.c |2 +- hw/vga.c|2 +- hw/vhost_n

[Qemu-devel] [PATCH 2/3] mingw32: avoid using %hh format which is not known by the compiler

2010-05-15 Thread Blue Swirl
Signed-off-by: Blue Swirl --- arch_init.c | 18 ++ sysemu.h|4 2 files changed, 22 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index cfc03ea..110421b 100644 --- a/arch_init.c +++ b/arch_init.c @@ -441,10 +441,28 @@ int qemu_uuid_parse(const

[Qemu-devel] [PATCH 3/3] mingw32: avoid using %zd etc. formats which are not known by the compiler

2010-05-15 Thread Blue Swirl
Signed-off-by: Blue Swirl --- audio/audio.c | 11 ++- audio/audio_template.h|2 +- audio/esdaudio.c |8 audio/mixeng.c|3 ++- audio/ossaudio.c |8 block/curl.c |4 ++-

Re: [Qemu-devel] [PATCH 1/3] Fix %lld or %llx printf format use

2010-05-15 Thread malc
On Sat, 15 May 2010, Blue Swirl wrote: > Signed-off-by: Blue Swirl > --- > audio/audio_template.h |2 +- > block/curl.c|9 --- > block/parallels.c |7 - > block/qcow2.c |8 -- > darwin-user/commpage.c |2 +- > darwin-user/syscall.c

Re: [Qemu-devel] [PATCH 3/3] mingw32: avoid using %zd etc. formats which are not known by the compiler

2010-05-15 Thread malc
On Sat, 15 May 2010, Blue Swirl wrote: > Signed-off-by: Blue Swirl > --- > audio/audio.c | 11 ++- > audio/audio_template.h|2 +- > audio/esdaudio.c |8 > audio/mixeng.c|3 ++- > audio/ossaudio.c |

Re: [Qemu-devel] [PATCH 0/3] mingw32 compile fixes

2010-05-15 Thread Stefan Weil
Am 15.05.2010 22:49, schrieb Blue Swirl: Hi, With this mingw32 compiler: $ i586-mingw32msvc-gcc -v Using built-in specs. Target: i586-mingw32msvc Configured with: /tmp/buildd/gcc-mingw32-4.4.2/build-tree/gcc-4.4.2/configure --build=x86_64-linux-gnu --prefix=/usr --includedir='/usr/include' --ma

[Qemu-devel] [PATCH 0/2] fix HelenOS illegal instruction issue on sparc64

2010-05-15 Thread Igor V. Kovalenko
The following series fix a couple of typos in sparc target which cause illegal instruction issue booting HelenOS on sparc64. --- Igor V. Kovalenko (2): sparc64: fix mmu demap operand typo sparc64: fix TT_WOTHER value target-sparc/cpu.h |2 +- target-sparc/op_helper.c |

[Qemu-devel] [PATCH 1/2] sparc64: fix mmu demap operand typo

2010-05-15 Thread Igor V. Kovalenko
From: Igor V. Kovalenko - must use store address operand to demap, not store value Signed-off-by: Igor V. Kovalenko --- target-sparc/op_helper.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-sparc/op_helper.c b/target-sparc/op_helper.c index fcfd3f3..ec3924

[Qemu-devel] [PATCH 2/2] sparc64: fix TT_WOTHER value

2010-05-15 Thread Igor V. Kovalenko
From: Igor V. Kovalenko - fix off by one error in spill trap number bit for other window (must be bit 5) - fixes invalid instruction issue with HelenOS --- target-sparc/cpu.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h index 2

[Qemu-devel] Re: Qemu-KVM with 3x IDE HDD + CDROM not working

2010-05-15 Thread Kevin O'Connor
On Wed, May 12, 2010 at 03:19:26PM +0200, Peter Lieven wrote: > Hi Qemu/KVM Devel Team, > > if I create a VM with more than 2 harddisks and a CDROM Image and > want to boot from CDROM this is not working. > From my understanding at least 3 IDE Drives + 1 IDE CDROM should work. > > cmdline: > /usr

Re: [Qemu-devel] [PATCH] Add QEMU DirectFB display driver

2010-05-15 Thread Paul Brook
> The other solution would be to use the DirectFB driver for SDL which > would allow to do slightly the same as this patch. But that would mean > having to deal with an additional layer in the graphical stack, which is > not exactly what one wants from a performance or a complexity point of > view.

Re: [Qemu-devel] [PATCH] Add QEMU DirectFB display driver

2010-05-15 Thread Alexander Graf
On 16.05.2010, at 03:10, Paul Brook wrote: >> The other solution would be to use the DirectFB driver for SDL which >> would allow to do slightly the same as this patch. But that would mean >> having to deal with an additional layer in the graphical stack, which is >> not exactly what one wants fr