andrzej zaborowski wrote: > Hi Jan, > > On 15 May 2010 13:32, Jan Kiszka <jan.kis...@web.de> wrote: >> From: Jan Kiszka <jan.kis...@siemens.com> >> >> It was only written, but never read. > > I pushed an alternate version to just move the update from post_save > to post_load. If you think of code as documentation, the struct > becomes less complete in representing the state of the device if you > remove the register. State doesn't have to be readable through the > busses, some state may be readable through qemu monitor and the like.
That particular state is unreadable via any existing interface (except a debugger). For pretty-printing TMP105State::config, there will once be better mechanisms based on vmstate. I don't mind if that dead code remains, I just want to underline that it's useless (code as documentation was important before versioning control entered the scene). Jan
signature.asc
Description: OpenPGP digital signature
