[Qemu-devel] [PATCH 1/2] pc: add machine type for 0.12

2009-11-25 Thread Gerd Hoffmann
Add a new machine type for qemu 0.12. Also fixup the 0.11 machine type: msi for virtio-blk-pci was enabled after the 0.11 release, so turn it off in the 0.11 machine type. Signed-off-by: Gerd Hoffmann --- hw/pc.c | 18 +- 1 files changed, 17 insertions(+), 1 deletions(-) diff

Re: [Qemu-devel] [PATCH 12/13] Add zipl bootloader interpreter

2009-11-25 Thread Hannes Reinecke
On Tue, Nov 24, 2009 at 03:10:24PM -0600, Anthony Liguori wrote: > Hi Mark! > > Mark Williamson wrote: >> Way back in the mists of time (uh, something like that 2004-05) I had some >> discussions with some of the S390 people about using kboot for more >> flexible boot, since it tallied with their

Re: [Qemu-devel] [PATCH 12/13] Add zipl bootloader interpreter

2009-11-25 Thread Alexander Graf
On 25.11.2009, at 09:35, Hannes Reinecke wrote: > On Tue, Nov 24, 2009 at 03:10:24PM -0600, Anthony Liguori wrote: >> Hi Mark! >> >> Mark Williamson wrote: >>> Way back in the mists of time (uh, something like that 2004-05) I had some >>> discussions with some of the S390 people about using kbo

Re: [Qemu-devel] [PATCH 12/13] Add zipl bootloader interpreter

2009-11-25 Thread Carsten Otte
Anthony Liguori wrote: This is a bit unfortunate. Wouldn't it be better to write a custom version of zipl that ran in the guest? This is like implementing grub in qemu (or pygrub in Xen). The level of security exposure this introduces is really scary. Oh that's really the wrong way to see it

Re: [Qemu-devel] Re: [PATCH] Fix TAP networking on host kernels without IFF_VNET_HDR support

2009-11-25 Thread Mark McLoughlin
On Tue, 2009-11-24 at 22:27 +0100, Pierre Riteau wrote: > On 24 nov. 2009, at 12:22, Mark McLoughlin wrote: > > > On Tue, 2009-11-24 at 12:17 +0100, Pierre Riteau wrote: > >> Isn't there a way to detect whether the kernel supports the > >> TUNSETOFFLOAD ioctl at all? > > > > The kernel will set

Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-25 Thread Carsten Otte
Anthony Liguori wrote: What is this used for? On x86 the kernel uses bios output for early prints. We don't have bios and do therefore need to bring up a console device as early as possible so that we can see kernel panics during I/O subsystem detection/startup. All s390 console devices do sup

[Qemu-devel] [PATCH 2/2] virtio: enable msi-x for console+balloon

2009-11-25 Thread Gerd Hoffmann
Enable MSI-X for virtio-console-pci and virtio-balloon-pci. Add entries to the compatibility machine types so MSI-X will be disabled for pc-0.10 and pc-0.11. Signed-off-by: Gerd Hoffmann --- hw/pc.c | 16 hw/virtio-pci.c | 11 +++ 2 files changed, 27 insertio

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Tue, Nov 24, 2009 at 03:21:34PM +0100, Juan Quintela wrote: > A device already supports load for a range > of versions between X and Y. We want to support > saving to a range of versions. > > Which versions to use is a separate decision > which should be taken on

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Michael S. Tsirkin
On Wed, Nov 25, 2009 at 10:30:47AM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Tue, Nov 24, 2009 at 03:21:34PM +0100, Juan Quintela wrote: > > > A device already supports load for a range > > of versions between X and Y. We want to support > > saving to a range of versions. >

Re: [Qemu-devel] [PATCH 0/6] Fix -kernel with SeaBIOS v2

2009-11-25 Thread Alexander Graf
Christoph Hellwig wrote: > On Mon, Nov 23, 2009 at 10:28:44PM +0100, Alexander Graf wrote: > >>> Is this on an x86_64 box or i386? I can boot the same kernel with >>> upstream qemu on another box with an x86_64 kernel and qemu. >>> >> I only test things on x86_64. so you're saying it bre

Re: [Qemu-devel] [PATCH 12/13] Add zipl bootloader interpreter

2009-11-25 Thread Carsten Otte
Anthony Liguori wrote: Can't you just use kboot? Use a kernel loader to load the kboot module/initrd, include kboot as our firmware, then let kboot do the magic to launch the real linux kernel from disk. Hehe, and how would you load that initial kernel if you don't have bios? No matter what,

Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-25 Thread Carsten Otte
Anthony Liguori wrote: Oh, that's bad :-) That should really be it's own character device. We don't really have a way to connect two character devices like that. Maybe muxing? It will be a character device, once the device tree is initialized. Better ideas are welcome, just keep in mind basi

Re: [Qemu-devel] [PATCH 12/13] Add zipl bootloader interpreter

2009-11-25 Thread Carsten Otte
Anthony Liguori wrote: I do, that's why I brought it up. AFAICT, there hasn't been a lot of progress with kboot. Carsten or Alex would probably know better if anyone is actually using it on s390s. I fail to see how kboot would solve this problem.

[Qemu-devel] [PATCH] Check for TUNSETOFFLOAD support before trying to enable offload features

2009-11-25 Thread Pierre Riteau
This avoids the "TUNSETOFFLOAD ioctl() failed: Invalid argument" message on kernels without TUNSETOFFLOAD support. Signed-off-by: Pierre Riteau --- net/tap-linux.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/net/tap-linux.c b/net/tap-linux.c index 0f621a2..e038e1

Re: [Qemu-devel] [PATCH 12/13] Add zipl bootloader interpreter

2009-11-25 Thread Carsten Otte
Hannes Reinecke wrote: So back to the zipl question, it might be an idea to support initially the SCSI disk layout only. This has the advantage of being far simpler as the DASD disk layout and should be pretty straightforward to handle. Issue is, the dasd disk layout is made for dasds. For eckd,

Re: [Qemu-devel] [PATCH] Check for TUNSETOFFLOAD support before trying to enable offload features

2009-11-25 Thread Mark McLoughlin
On Wed, 2009-11-25 at 11:04 +0100, Pierre Riteau wrote: > This avoids the "TUNSETOFFLOAD ioctl() failed: Invalid argument" message > on kernels without TUNSETOFFLOAD support. > > Signed-off-by: Pierre Riteau Acked-by: Mark McLoughlin Thanks, Mark. > --- > net/tap-linux.c |5 + > 1 fi

Re: [Qemu-devel] Re: [PATCH 5/6] Convert linux bootrom to external rom and fw_cfg

2009-11-25 Thread Alexander Graf
On 13.11.2009, at 07:37, Paolo Bonzini wrote: > On 11/12/2009 09:53 PM, Alexander Graf wrote: >> +/* Set DS to SS+SP - 0x10, so we can write our GDT descriptor there */ >> +mov %ss, %eax >> +shl $4, %eax >> +add %esp, %eax >> +sub

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-25 Thread Gleb Natapov
On Wed, Nov 25, 2009 at 12:27:06AM +0100, Sebastian Herbszt wrote: > Gleb Natapov wrote: > >On Mon, Nov 23, 2009 at 10:30:56PM +0100, Sebastian Herbszt wrote: > >>Gleb Natapov wrote: > >>>On Mon, Nov 23, 2009 at 08:19:54PM +0100, Sebastian Herbszt wrote: > Gleb Natapov wrote: > >On Sun, Nov

[Qemu-devel] [PATCH] qcow2: Store exact backing format length

2009-11-25 Thread Kevin Wolf
Currently qcow2 unnecessarily rounds up the length of the backing format string to the next multiple of 8. At the same time, the array in BlockDriverState can only hold 15 characters, so in effect backing formats with 9 characters or more don't work (e.g. host_device). Save the real string length

[Qemu-devel] [PATCH 0/5] msix: multiple PCI compliance fixes

2009-11-25 Thread Michael S. Tsirkin
Here's a patch set fixing sevral PCI compliance issues, found by testing with windows guests. Applies on top of msix patch I sent previously. Michael S. Tsirkin (5): msix: fix mask bit state after reset msix: fix reset value for enable bit msix: macro rename for function mask support msix:

[Qemu-devel] [PATCH 1/5] msix: fix mask bit state after reset

2009-11-25 Thread Michael S. Tsirkin
PCI spec states that mask bit must be 1 after reset. Make it so. Signed-off-by: Michael S. Tsirkin --- hw/msix.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index d499441..45f83dd 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -217,6 +217,

[Qemu-devel] [PATCH 2/5] msix: fix reset value for enable bit

2009-11-25 Thread Michael S. Tsirkin
On reset, we currently clear all bits in msix control register *except* enable bit. This is wrong: the spec says we should clear writeable bits: function mask and enable bit. Correct this. Signed-off-by: Michael S. Tsirkin --- hw/msix.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(

[Qemu-devel] [PATCH 3/5] msix: macro rename for function mask support

2009-11-25 Thread Michael S. Tsirkin
rename ENABLE_OFFSET -> CONTROL_OFFSET, since same byte includes function mask. This is in preparation for function mask support. Signed-off-by: Michael S. Tsirkin --- hw/msix.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 785e

[Qemu-devel] [PATCH 4/5] msix: function mask support

2009-11-25 Thread Michael S. Tsirkin
Function mask is a mandatory feature in MSIX spec so not implementing it is a spec violation. Implement. Signed-off-by: Michael S. Tsirkin --- hw/msix.c | 64 +++- 1 files changed, 46 insertions(+), 18 deletions(-) diff --git a/hw/msix.c

[Qemu-devel] [PATCH 5/5] msix: clear pending bit of an unused vector

2009-11-25 Thread Michael S. Tsirkin
PCI spec states: if a masked vector has its Pending bit set, and the associated underlying interrupt events are somehow satisfied (usually by software though the exact manner is function-specific), the function must clear the Pending bit, to avoid sending a spurious interrupt message later when sof

Re: [Qemu-devel] [PATCH 06/13] Add support for S390x system emulation

2009-11-25 Thread Paul Brook
> --- a/target-s390x/cpu.h > +++ b/target-s390x/cpu.h > @@ -30,8 +30,7 @@ > > #include "softfloat.h" > > -#define NB_MMU_MODES 2 // guess > -#define MMU_USER_IDX 0 // guess > +#define NB_MMU_MODES 2 The fact that you're modifying a file you added earlier in the same patch series gives me very

Re: [Qemu-devel] [PATCH 06/13] Add support for S390x system emulation

2009-11-25 Thread Alexander Graf
On 25.11.2009, at 12:46, Paul Brook wrote: >> --- a/target-s390x/cpu.h >> +++ b/target-s390x/cpu.h >> @@ -30,8 +30,7 @@ >> >> #include "softfloat.h" >> >> -#define NB_MMU_MODES 2 // guess >> -#define MMU_USER_IDX 0 // guess >> +#define NB_MMU_MODES 2 > > The fact that you're modifying a file y

[Qemu-devel] [PATCH] chardev: make chardevs specified in config file work.

2009-11-25 Thread Gerd Hoffmann
The patch decuples the -chardev switch and the actual chardev initialization. Without this patch qemu ignores chardev entries coming via -readconfig. Signed-off-by: Gerd Hoffmann --- vl.c | 16 +--- 1 files changed, 13 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-25 Thread Gleb Natapov
On Wed, Nov 25, 2009 at 06:09:51AM +, Jamie Lokier wrote: > Gleb Natapov wrote: > > > But QEMU is used to run old OSes too. > > > > > That's OK. I don't expect BIOS to be reloaded if OS restart by jumping > > to BIOS reset code. > > That's good then. > > What about DOS and DOS-extender progr

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-25 Thread Gerd Hoffmann
On 11/25/09 00:05, H. Peter Anvin wrote: On 11/23/2009 12:11 PM, H. Peter Anvin wrote: On 11/23/2009 02:52 AM, Gerd Hoffmann wrote: All not needed. Simply registering as qdev device is enougth. You can then add a debug port like this, without adding new cmd line options: -chardev vc,id=

[Qemu-devel] [PATCH] Fix thinko in linuxboot.S

2009-11-25 Thread Paolo Bonzini
The %gs segment that was used was not matching the comments. I just moved the GDT descriptor on the stack instead. Signed-off-by: Paolo Bonzini --- pc-bios/optionrom/linuxboot.S | 20 1 files changed, 8 insertions(+), 12 deletions(-) diff --git a/pc-bios/optionrom/linuxbo

[Qemu-devel] Re: [PATCH] Fix thinko in linuxboot.S

2009-11-25 Thread Alexander Graf
On 25.11.2009, at 13:49, Paolo Bonzini wrote: > The %gs segment that was used was not matching the comments. > I just moved the GDT descriptor on the stack instead. > > Signed-off-by: Paolo Bonzini Looks good. Have you verified it works? :-) Alex

[Qemu-devel] Re: [PATCH 2/2] qdev: add command line option to set global defaults for properties.

2009-11-25 Thread Gerd Hoffmann
On 11/24/09 15:11, Michael S. Tsirkin wrote: On Tue, Nov 24, 2009 at 12:06:28PM +0100, Gerd Hoffmann wrote: This patch adds infrastructure and command line option for setting global defaults for device properties, i.e. you can for example use -global virtio-blk-pci.vectors=0 to turn off msi

Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-25 Thread Arnd Bergmann
On Wednesday 25 November 2009, Carsten Otte wrote: > Anthony Liguori wrote: > > Oh, that's bad :-) > > > > That should really be it's own character device. We don't really have a > > way to connect two character devices like that. Maybe muxing? > It will be a character device, once the device t

[Qemu-devel] Re: [PATCH 2/2] qdev: add command line option to set global defaults for properties.

2009-11-25 Thread Michael S. Tsirkin
On Wed, Nov 25, 2009 at 01:55:18PM +0100, Gerd Hoffmann wrote: > On 11/24/09 15:11, Michael S. Tsirkin wrote: >> On Tue, Nov 24, 2009 at 12:06:28PM +0100, Gerd Hoffmann wrote: >>> This patch adds infrastructure and command line option for setting >>> global defaults for device properties, i.e. you

[Qemu-devel] Re: [PATCH] Fix thinko in linuxboot.S

2009-11-25 Thread Paolo Bonzini
On 11/25/2009 01:53 PM, Alexander Graf wrote: On 25.11.2009, at 13:49, Paolo Bonzini wrote: The %gs segment that was used was not matching the comments. I just moved the GDT descriptor on the stack instead. Signed-off-by: Paolo Bonzini ^^

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Gerd Hoffmann
On 11/24/09 15:05, Michael S. Tsirkin wrote: On Mon, Nov 23, 2009 at 03:13:59PM +0100, Juan Quintela wrote: But this would only kick in when using pc-0.11 or something, right? Yeap. At this point, pc-0.10 is just: static QEMUMachine pc_machine_v0_10 = { .name = "pc-0.10", .desc = "

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Wed, Nov 25, 2009 at 10:30:47AM +0100, Juan Quintela wrote: >> "Michael S. Tsirkin" wrote: >> > On Tue, Nov 24, 2009 at 03:21:34PM +0100, Juan Quintela wrote: >> >> > A device already supports load for a range >> > of versions between X and Y. We want to support

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Gerd Hoffmann
And this is also the trivial part to describe: I want a machine like the one in qemu-0.11. Yes, but there might be a ton of reasons to want a machine like the one in qemu 0.11. The need to migrate to old qemu is very rare, it is a completely separate decision one might take long after starting

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Michael S. Tsirkin
On Wed, Nov 25, 2009 at 02:36:49PM +0100, Gerd Hoffmann wrote: > On 11/24/09 15:05, Michael S. Tsirkin wrote: >> On Mon, Nov 23, 2009 at 03:13:59PM +0100, Juan Quintela wrote: But this would only kick in when using pc-0.11 or something, right? >>> >>> Yeap. >>> >>> At this point, pc-0.10 is ju

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Michael S. Tsirkin
On Wed, Nov 25, 2009 at 02:42:25PM +0100, Gerd Hoffmann wrote: >>> And this is also the trivial part to describe: I want a >>> machine like the one in qemu-0.11. >> >> Yes, but there might be a ton of reasons to want a >> machine like the one in qemu 0.11. >> The need to migrate to old qemu is ve

Re: [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console

2009-11-25 Thread Carsten Otte
Arnd Bergmann wrote: Can't you just leave it out for this release? Early printk is great for debugging, but not essential if you just want to run a guest as long as you get it past the virtio init phase. The upstream kernel assumes to have this hypercall available when running on kvm. You won't

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Gerd Hoffmann
On 11/25/09 14:40, Michael S. Tsirkin wrote: We could add a DeviceState->savevm field and make that available as property for devices which need to support multiple versions. Then you we can use the compat properties to switch back to the older format with -M pc-0.10. I'm confused sorry. Of

Re: [Qemu-devel] Re: [PATCH 2/2] qdev: add command line option to set global defaults for properties.

2009-11-25 Thread Paul Brook
> So maybe add "use -device ? to get list of all devices" > to help text? > > [...@tuck qemu]$ ~/qemu-git/bin/qemu-system-x86_64 -device ? > /home/mst/qemu-git/bin/qemu-system-x86_64: invalid option -- '-device' You need to stop your shell eating the ? Paul

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Michael S. Tsirkin
On Wed, Nov 25, 2009 at 02:59:58PM +0100, Gerd Hoffmann wrote: > On 11/25/09 14:40, Michael S. Tsirkin wrote: > >>> We could add a DeviceState->savevm field and make that available as >>> property for devices which need to support multiple versions. Then you >>> we can use the compat properties to

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Gerd Hoffmann
Hi, Doesn't work. If you have a qemu 0.11 machine, a virtio nic and your guest uses MSI-X you simply can't migrate to qemu 0.10. End of story. If you want to be able to migrate to 0.10 you have to start in 0.10 compat mode with MSI-X disabled. So IMHO it does makes sense to tie the savevm f

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Michael S. Tsirkin
On Wed, Nov 25, 2009 at 03:10:16PM +0100, Gerd Hoffmann wrote: > Hi, > >>> Doesn't work. If you have a qemu 0.11 machine, a virtio nic and your >>> guest uses MSI-X you simply can't migrate to qemu 0.10. End of story. >>> If you want to be able to migrate to 0.10 you have to start in 0.10 >>> c

[Qemu-devel] Re: [PATCH] kvm: x86: Add support for VCPU event states

2009-11-25 Thread Avi Kivity
On 11/25/2009 01:33 AM, Jan Kiszka wrote: This patch extends the qemu-kvm state sync logic with support for KVM_GET/SET_VCPU_EVENTS, giving access to yet missing exception, interrupt and NMI states. Looks good. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Gerd Hoffmann
On 11/25/09 15:09, Michael S. Tsirkin wrote: We were discussing features that are (mostly) not user-visible. It is clear that if you have a user-visible change you have a different machine, so you can not migrate. Now if you fix a bug by changing savevm format, without user visible changes you *

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Wed, Nov 25, 2009 at 02:59:58PM +0100, Gerd Hoffmann wrote: >> On 11/25/09 14:40, Michael S. Tsirkin wrote: >> We could add a DeviceState->savevm field and make that available as property for devices which need to support multiple versions. Then you

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Michael S. Tsirkin
On Wed, Nov 25, 2009 at 03:53:40PM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Wed, Nov 25, 2009 at 02:59:58PM +0100, Gerd Hoffmann wrote: > >> On 11/25/09 14:40, Michael S. Tsirkin wrote: > >> > We could add a DeviceState->savevm field and make that available as > p

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-25 Thread Kevin O'Connor
On Wed, Nov 25, 2009 at 02:20:39PM +0200, Gleb Natapov wrote: > On Wed, Nov 25, 2009 at 06:09:51AM +, Jamie Lokier wrote: > > But the BIOS must be reloaded from ROM, I'm guessing, if the keyboard > > controller method is used and the word asking for a branch back to the > > application has not

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

2009-11-25 Thread Michael S. Tsirkin
On Wed, Nov 25, 2009 at 04:10:34PM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Tue, Nov 24, 2009 at 08:33:11AM -0600, Anthony Liguori wrote: > >> Michael S. Tsirkin wrote: > >>> It's very easy: if their guest runs fine on the old qemu, > >>> it should be safe to migrate there.

Re: [Qemu-devel] [sneak preview] major scsi overhaul

2009-11-25 Thread Gerd Hoffmann
On 11/24/09 14:51, Paul Brook wrote: On Tuesday 24 November 2009, Gerd Hoffmann wrote: On 11/16/09 19:53, Paul Brook wrote: Capping the amount of memory required for a transfer *is* implemented, in both LSI and virtio-blk. The exception being SCSI passthrough where the kernel API makes it impo

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

2009-11-25 Thread Gleb Natapov
On Wed, Nov 25, 2009 at 10:31:16AM -0500, Kevin O'Connor wrote: > On Wed, Nov 25, 2009 at 02:20:39PM +0200, Gleb Natapov wrote: > > On Wed, Nov 25, 2009 at 06:09:51AM +, Jamie Lokier wrote: > > > But the BIOS must be reloaded from ROM, I'm guessing, if the keyboard > > > controller method is us

[Qemu-devel] [PATCH 0/4] pci: interrupt status/interrupt disable support

2009-11-25 Thread Michael S. Tsirkin
This patchset adds support for mandatory interupt status and interrupt disable bits to all PCI devices. This is required for PCI compliancy. These patches are on top of my pci tree, including Isaku Yamahata's fixes. If this is a problem, let me know and I will rebase. This works fine for me, but

[Qemu-devel] [PATCH 1/4] pci: rearrange code for interrupts

2009-11-25 Thread Michael S. Tsirkin
Rearranges code slightly in preparation for interrupt status and interrupt disable support: split actual irq change from irq_state management. Signed-off-by: Michael S. Tsirkin --- hw/pci.c | 26 -- 1 files changed, 16 insertions(+), 10 deletions(-) diff --git a/hw/pci

[Qemu-devel] [PATCH 2/4] pci: track IRQ status

2009-11-25 Thread Michael S. Tsirkin
track IRQ status in preparation for PCI_STATUS_INTERRUPT support Signed-off-by: Michael S. Tsirkin --- hw/pci.c | 10 +- hw/pci.h |3 +++ 2 files changed, 12 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 5ff0d46..7717461 100644 --- a/hw/pci.c +++ b/hw/pci.c

[Qemu-devel] [PATCH 4/4] pci: interrupt disable bit support

2009-11-25 Thread Michael S. Tsirkin
interrupt disable bit is mandatory in PCI spec, so we must implement it to be spec compliant. Signed-off-by: Michael S. Tsirkin --- hw/pci.c | 57 - hw/pci.h |4 2 files changed, 44 insertions(+), 17 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 3/4] pci: interrupt status bit implementation

2009-11-25 Thread Michael S. Tsirkin
interrupt status is a mandatory feature in PCI spec, so devices must implement it to be spec compliant. Signed-off-by: Michael S. Tsirkin --- hw/pci.c | 22 ++ hw/pci.h |1 + 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 77174

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-25 Thread H. Peter Anvin
Gerd Hoffmann wrote: You can stick it into a config file[1] like this: [chardev "debuglog"] backend = "file" path = "/path/to/debug.log" [device] driver = "isa-debugcon" chardev = "debuglog" Then use "qemu -readconfig $file". Great... at least in my opinion, one of the things that

[Qemu-devel] [PATCH 03/44] net: move socket backend code from net.c to net/socket.c

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile |1 + net.c| 530 +-- net/socket.c | 561 ++ net/socket.h | 33 4 files changed, 596 insertions(+), 529 deletions(-) cr

[Qemu-devel] [PATCH 00/44] Fix announce_self(), misc net fixes and cleanups

2009-11-25 Thread Mark McLoughlin
Hi, Here's a new series of patches mainly to fix qemu_announce_self() with -netdev as discussed earlier on the list. I would have liked to have split the series in three, but there would be conflicts between each, so here goes: 1) Patches 01 to 05 - net.c cleanups These p

[Qemu-devel] [PATCH 02/44] net: move vde code from net.c to net/vde.c

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile |1 + net.c | 102 +- net/vde.c | 124 + net/vde.h | 36 ++ 4 files changed, 162 insertions(+), 101 deletions(-) cr

[Qemu-devel] [PATCH 04/44] net: move dump backend code from net.c to net/dump.c

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile |1 + net.c | 127 +-- net/dump.c | 151 net/dump.h | 33 + 4 files changed, 186 insertions(+), 126 deletions(-) cre

[Qemu-devel] [PATCH 01/44] net: move slirp code from net.c to net/slirp.c

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile|1 + monitor.c |1 + net.c | 718 +--- net.h |8 +- net/slirp.c | 752 +++ net/slirp.h | 51 vl.c|

[Qemu-devel] [PATCH 06/44] net: remove NICInfo::vc

2009-11-25 Thread Mark McLoughlin
Since 1cc33683, this field is not set for most devices, so just remove it and its remaining few uses. Signed-off-by: Mark McLoughlin --- hw/dp8393x.c | 10 +- hw/etraxfs_eth.c | 10 +- hw/mcf_fec.c | 10 +- hw/mipsnet.c | 10 +- hw/usb-net.c

[Qemu-devel] [PATCH 09/44] net: introduce qemu_new_net_client()

2009-11-25 Thread Mark McLoughlin
A replacement for qemu_new_vlan_client(), using NetClientInfo to replace most arguments. Signed-off-by: Mark McLoughlin --- net.c | 70 +--- net.h |5 2 files changed, 54 insertions(+), 21 deletions(-) diff --git a/net.c b/n

[Qemu-devel] [PATCH 17/44] net: introduce NICState and qemu_new_nic()

2009-11-25 Thread Mark McLoughlin
Common state for all NICs. The opaque member will replace the opaque member in VLANClientState since only NICs need it. The conf member will allow us to iterate over NICs, access the MAC addr for the NIC and send a packet from each NIC in qemu_announce_self(). Signed-off-by: Mark McLoughlin ---

[Qemu-devel] [PATCH 10/44] qdev: move DO_UPCAST() into osdep.h

2009-11-25 Thread Mark McLoughlin
Nothing qdev specific about this, make it available throughtout. Signed-off-by: Mark McLoughlin --- hw/qdev.h | 10 -- osdep.h | 10 ++ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/qdev.h b/hw/qdev.h index 41642ee..8d53754 100644 --- a/hw/qdev.h +++ b

[Qemu-devel] [PATCH 11/44] net: convert tap to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/tap.c | 82 +--- 1 files changed, 45 insertions(+), 37 deletions(-) diff --git a/net/tap.c b/net/tap.c index b2e5908..d34feec 100644 --- a/net/tap.c +++ b/net/tap.c @@ -47,7 +47,7 @@ #define TAP_BUF

[Qemu-devel] [PATCH 28/44] net: convert mipsnet to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/mipsnet.c | 45 +++-- 1 files changed, 27 insertions(+), 18 deletions(-) diff --git a/hw/mipsnet.c b/hw/mipsnet.c index 67160a4..a066f63 100644 --- a/hw/mipsnet.c +++ b/hw/mipsnet.c @@ -35,7 +35,8 @@ typedef struct M

[Qemu-devel] [PATCH 34/44] net: move parse_macaddr() to net/util.[ch]

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- Makefile |2 +- net.c | 35 ++- net/util.c | 60 net/util.h | 32 4 files changed, 95 insertions(+), 34 deletions(-) c

[Qemu-devel] [PATCH 35/44] net: convert xen to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/xen_nic.c | 46 +- 1 files changed, 29 insertions(+), 17 deletions(-) diff --git a/hw/xen_nic.c b/hw/xen_nic.c index bcf161c..08055b8 100644 --- a/hw/xen_nic.c +++ b/hw/xen_nic.c @@ -41,6 +41,7 @@ #include "hw.h

[Qemu-devel] [PATCH 22/44] net: convert pcnet to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/lance.c | 14 +++--- hw/pcnet.c | 43 +++ hw/pcnet.h |7 --- 3 files changed, 38 insertions(+), 26 deletions(-) diff --git a/hw/lance.c b/hw/lance.c index 0a96644..98033a4 100644 --- a/hw/lance.c ++

[Qemu-devel] [PATCH 12/44] net: convert tap-win32 to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/tap-win32.c | 39 +++ 1 files changed, 23 insertions(+), 16 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index ea66471..ef63782 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -630,25 +630,24 @@ sta

[Qemu-devel] [PATCH 21/44] net: convert ne2000 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/ne2000-isa.c | 22 ++ hw/ne2000.c | 35 +-- hw/ne2000.h |2 +- 3 files changed, 36 insertions(+), 23 deletions(-) diff --git a/hw/ne2000-isa.c b/hw/ne2000-isa.c index 729e8e2..0260f84 100644

[Qemu-devel] [PATCH 07/44] net: remove NICInfo::private

2009-11-25 Thread Mark McLoughlin
Was used by hot-unplug, but not anymore. Signed-off-by: Mark McLoughlin --- net.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/net.h b/net.h index bc8392b..9ffcfe3 100644 --- a/net.h +++ b/net.h @@ -124,7 +124,6 @@ struct NICInfo { char *devaddr; VLANState *

[Qemu-devel] [PATCH 05/44] net: clean up includes in net.c

2009-11-25 Thread Mark McLoughlin
This is probably a little drastic, but the includes in this file are now totally out of control when compared with what includes are actually needed. This may break the build on e.g. *BSD, but it will be easily fixed by re-instating an include. Signed-off-by: Mark McLoughlin --- net.c | 74 +-

[Qemu-devel] [PATCH 13/44] net: convert slirp to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/slirp.c | 61 +++--- 1 files changed, 37 insertions(+), 24 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index d6d5772..3f91c4b 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -64,8 +64,8 @@ struct s

[Qemu-devel] [PATCH 26/44] net: convert LAN9118 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/lan9118.c | 45 + 1 files changed, 25 insertions(+), 20 deletions(-) diff --git a/hw/lan9118.c b/hw/lan9118.c index 6394f3a..ba982d1 100644 --- a/hw/lan9118.c +++ b/hw/lan9118.c @@ -137,7 +137,7 @@ typedef struct

[Qemu-devel] [PATCH 39/44] net: fix qemu_announce_self()

2009-11-25 Thread Mark McLoughlin
Now that we have a way to iterate NICs. Signed-off-by: Mark McLoughlin --- savevm.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/savevm.c b/savevm.c index 4668843..3cfc5aa 100644 --- a/savevm.c +++ b/savevm.c @@ -123,24 +123,24 @@ static int

[Qemu-devel] [PATCH 41/44] net: fix TAP networking on host kernels without IFF_VNET_HDR support

2009-11-25 Thread Mark McLoughlin
From: Pierre Riteau vnet_hdr is initialized at 1 by default. We need to reset it to 0 if the kernel doesn't support IFF_VNET_HDR. Signed-off-by: Pierre Riteau Signed-off-by: Mark McLoughlin --- net/tap-linux.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/tap-l

[Qemu-devel] [PATCH 14/44] net: convert vde to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/vde.c | 45 - 1 files changed, 28 insertions(+), 17 deletions(-) diff --git a/net/vde.c b/net/vde.c index 4d09967..42b4633 100644 --- a/net/vde.c +++ b/net/vde.c @@ -34,7 +34,7 @@ #include "sysemu.h" typedef

[Qemu-devel] [PATCH 33/44] net: convert xilinx_ethlite to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/xilinx_ethlite.c | 35 --- 1 files changed, 20 insertions(+), 15 deletions(-) diff --git a/hw/xilinx_ethlite.c b/hw/xilinx_ethlite.c index b7129d5..37e33ec 100644 --- a/hw/xilinx_ethlite.c +++ b/hw/xilinx_ethlite.c @@ -51,7

[Qemu-devel] [PATCH 36/44] net: remove qemu_new_vlan_client()

2009-11-25 Thread Mark McLoughlin
... and VLANClientState::opaque and qemu_find_vlan_client(). All of these are now unused Signed-off-by: Mark McLoughlin --- net.c | 44 net.h | 13 - 2 files changed, 0 insertions(+), 57 deletions(-) diff --git a/net.c b/net.c index

[Qemu-devel] [PATCH 38/44] net: add qemu_foreach_nic()

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net.c | 20 net.h |2 ++ 2 files changed, 22 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index a1ec243..c71699d 100644 --- a/net.c +++ b/net.c @@ -326,6 +326,26 @@ qemu_find_vlan_client_by_name(Monitor *mon, int vlan_id,

[Qemu-devel] [PATCH 40/44] net: print correct error for '-netdev ""'

2009-11-25 Thread Mark McLoughlin
Reported-by: Markus Armbruster Signed-off-by: Mark McLoughlin --- net.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/net.c b/net.c index c71699d..13bdbb2 100644 --- a/net.c +++ b/net.c @@ -1055,12 +1055,18 @@ int net_client_init(Monitor *mon, QemuOpts

[Qemu-devel] [PATCH 32/44] net: convert usb-net to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/usb-net.c | 57 +++-- 1 files changed, 31 insertions(+), 26 deletions(-) diff --git a/hw/usb-net.c b/hw/usb-net.c index 7b8cc7a..2556e05 100644 --- a/hw/usb-net.c +++ b/hw/usb-net.c @@ -610,7 +610,6 @@ ty

[Qemu-devel] [PATCH 43/44] net: initialize vnet_hdr in net_init_tap()

2009-11-25 Thread Mark McLoughlin
net_tap_init() always sets vnet_hdr using qemu_opt_get_bool(), but initialize it in net_init_tap() just to reduce confusion. Signed-off-by: Mark McLoughlin --- net/tap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/tap.c b/net/tap.c index a327a9a..0d8b424 100644

[Qemu-devel] [PATCH 25/44] net: convert etrax to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/etraxfs_eth.c | 45 +++-- 1 files changed, 27 insertions(+), 18 deletions(-) diff --git a/hw/etraxfs_eth.c b/hw/etraxfs_eth.c index 2cc2332..dedd107 100644 --- a/hw/etraxfs_eth.c +++ b/hw/etraxfs_eth.c @@ -319,7 +319

[Qemu-devel] [PATCH 42/44] net: check for TUNSETOFFLOAD support before trying to enable offload features

2009-11-25 Thread Mark McLoughlin
From: Pierre Riteau This avoids the "TUNSETOFFLOAD ioctl() failed: Invalid argument" message on kernels without TUNSETOFFLOAD support. Signed-off-by: Pierre Riteau Signed-off-by: Mark McLoughlin --- net/tap-linux.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/n

[Qemu-devel] [PATCH 27/44] net: convert mcf_fec to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/mcf_fec.c | 58 +- 1 files changed, 33 insertions(+), 25 deletions(-) diff --git a/hw/mcf_fec.c b/hw/mcf_fec.c index 8242c8a..4e7fbed 100644 --- a/hw/mcf_fec.c +++ b/hw/mcf_fec.c @@ -25,7 +25,8 @@ do

[Qemu-devel] [PATCH 37/44] net: remove VLANClientState members now in NetClientInfo

2009-11-25 Thread Mark McLoughlin
Add a NetClientInfo pointer to VLANClientState and use that for the typecode and function pointers. Signed-off-by: Mark McLoughlin --- hw/dp8393x.c|4 ++-- hw/virtio-net.c |2 +- net.c | 45 - net.h | 10 +-

[Qemu-devel] [PATCH 23/44] net: convert eepro100 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/eepro100.c | 43 --- 1 files changed, 24 insertions(+), 19 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 8734907..eb16a51 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -195,7 +195,7 @@ typedef str

[Qemu-devel] [PATCH 30/44] net: convert smc91c111 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/smc91c111.c | 35 --- 1 files changed, 20 insertions(+), 15 deletions(-) diff --git a/hw/smc91c111.c b/hw/smc91c111.c index b7398c9..c1a88c9 100644 --- a/hw/smc91c111.c +++ b/hw/smc91c111.c @@ -18,7 +18,7 @@ typedef struc

[Qemu-devel] [PATCH 19/44] net: convert e1000 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/e1000.c | 47 ++- 1 files changed, 26 insertions(+), 21 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index 00f6a57..683fdcc 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -75,7 +75,7 @@ enum { typedef struct

[Qemu-devel] [PATCH] virtio-blk: add max sectors feature

2009-11-25 Thread Avishay Traeger1
This is a patch to have the guest virtio-blk driver get the value for the maximum I/O size from the host bdrv, rather than assume that there is no limit. Right now we use it for an in-house bdrv driver that needs this option. The patches are below, against the latest gits, split into kernel (kvm

[Qemu-devel] [PATCH 20/44] net: convert rtl8139 to NICState

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- hw/rtl8139.c | 43 --- 1 files changed, 24 insertions(+), 19 deletions(-) diff --git a/hw/rtl8139.c b/hw/rtl8139.c index c166db0..931cde9 100644 --- a/hw/rtl8139.c +++ b/hw/rtl8139.c @@ -459,7 +459,7 @@ typedef struct R

[Qemu-devel] [PATCH 15/44] net: convert socket to NetClientInfo

2009-11-25 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- net/socket.c | 74 +++-- 1 files changed, 45 insertions(+), 29 deletions(-) diff --git a/net/socket.c b/net/socket.c index 551fc2b..7331d87 100644 --- a/net/socket.c +++ b/net/socket.c @@ -33,7 +33,7 @@ #in

  1   2   >