On 25.11.2009, at 12:46, Paul Brook wrote: >> --- a/target-s390x/cpu.h >> +++ b/target-s390x/cpu.h >> @@ -30,8 +30,7 @@ >> >> #include "softfloat.h" >> >> -#define NB_MMU_MODES 2 // guess >> -#define MMU_USER_IDX 0 // guess >> +#define NB_MMU_MODES 2 > > The fact that you're modifying a file you added earlier in the same patch > series gives me very little confidence...
I tried to keep the later patches as close to what they were in previous version as possible. If you like I can merge the changes, but I figured this makes is easier for review. Alex