Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-04-27 Thread Alexander Graf
On 27.04.14 18:16, Paolo Bonzini wrote: Il 11/04/2014 14:27, Eric Blake ha scritto: But with just this patch, you have caused the situation where it is neither introspectible, nor consistent across qemu versions. The only way to code that up in libvirt is to do MULTIPLE version checks and corr

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-04-27 Thread Paolo Bonzini
Il 11/04/2014 14:27, Eric Blake ha scritto: But with just this patch, you have caused the situation where it is neither introspectible, nor consistent across qemu versions. The only way to code that up in libvirt is to do MULTIPLE version checks and correlate it with architecture checks - and t

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-04-11 Thread Alexander Graf
On 11.04.14 14:27, Eric Blake wrote: On 04/11/2014 05:40 AM, Alexey Kardashevskiy wrote: but AFAICT nothing got merged to change this for all the other boards as discussed here :-( This is painful for libvirt since we have todo even more hacks triggered off machine names now, instead of being

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-04-11 Thread Eric Blake
On 04/11/2014 05:40 AM, Alexey Kardashevskiy wrote: >> but AFAICT nothing got merged to change this for all the other boards as >> discussed here :-( This is painful for libvirt since we have todo even >> more hacks triggered off machine names now, instead of being able to >> rely on pci.0 naming

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-04-11 Thread Alexey Kardashevskiy
On 04/10/2014 07:24 PM, Daniel P. Berrange wrote: > On Wed, Mar 05, 2014 at 03:33:39PM +0100, Paolo Bonzini wrote: >> Il 05/03/2014 15:21, Daniel P. Berrange ha scritto: alpha/typhoon.c:b = pci_register_bus(dev, "pci", mips/gt64xxx_pci.c: phb->bus = pci_register_bus(dev, "pci", >>

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-04-10 Thread Daniel P. Berrange
On Wed, Mar 05, 2014 at 03:33:39PM +0100, Paolo Bonzini wrote: > Il 05/03/2014 15:21, Daniel P. Berrange ha scritto: > >>alpha/typhoon.c:b = pci_register_bus(dev, "pci", > >>mips/gt64xxx_pci.c: phb->bus = pci_register_bus(dev, "pci", > >>pci-host/apb.c:phb->bus = pci_register_bus(DEVICE

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread hong-hua....@freescale.com
> -Original Message- > From: Alexey Kardashevskiy [mailto:a...@ozlabs.ru] > Sent: Thursday, March 06, 2014 3:08 PM > To: Yin Olivia-R63875; Paolo Bonzini; da...@gibson.dropbear.id.au; > ag...@suse.de > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; Li Zhang > Subject: Re: QEMU: PCI bus nam

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread Alexey Kardashevskiy
On 03/06/2014 06:04 PM, hong-hua@freescale.com wrote: > Hi Alexey, > > Even though you change the default PCI bus naming, it will need detect > the QEMU version in libvirt to keep compatibility with old QEMU version. So? > Best Regards, > Olivia > >> -Original Message- >> From:

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread hong-hua....@freescale.com
Hi Alexey, Even though you change the default PCI bus naming, it will need detect the QEMU version in libvirt to keep compatibility with old QEMU version. Best Regards, Olivia > -Original Message- > From: Alexey Kardashevskiy [mailto:a...@ozlabs.ru] > Sent: Wednesday, March 05, 2014 11

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread hong-hua....@freescale.com
Hi Alexey, I just clone qemu from git://git.qemu.org/qemu.git. commit f55ea6297cc0224fe4934b90ff5343b620b14669 $ ./configure --target-list=ppc64-softmmu --disable-sdl --disable-guest-agent --prefix="/usr/local" $ make $ ./ppc64-softmmu/qemu-system-ppc64 --version QEMU emulator version 1.7.50, Co

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread Alexey Kardashevskiy
On 03/06/2014 12:35 AM, Paolo Bonzini wrote: > Il 05/03/2014 12:43, Alexey Kardashevskiy ha scritto: >> >> I just tried current upstresm QEMU and it handles bus=pci fine, it prints >> an error on bus=pci.0 so I am confused - what qemu are you trying? > > See below: I understand, just got confused

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 15:21, Daniel P. Berrange ha scritto: alpha/typhoon.c:b = pci_register_bus(dev, "pci", mips/gt64xxx_pci.c: phb->bus = pci_register_bus(dev, "pci", pci-host/apb.c:phb->bus = pci_register_bus(DEVICE(phb), "pci", pci-host/bonito.c:phb->bus = pci_register_bus(DEVICE(dev)

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 15:38, Andreas Färber ha scritto: > > I believe so, yes. See > https://github.com/afaerber/qemu-cpu/commit/ce1c9b4302a4458e73ae6a6a13f4e4ee121f79ea Err, on second thoughts that depends on the device not having an id=. If it does, then it's foo.0, not pci.0. Yeah, but builtin dev

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread Daniel P. Berrange
On Wed, Mar 05, 2014 at 03:33:39PM +0100, Paolo Bonzini wrote: > Il 05/03/2014 15:21, Daniel P. Berrange ha scritto: > >>alpha/typhoon.c:b = pci_register_bus(dev, "pci", > >>mips/gt64xxx_pci.c: phb->bus = pci_register_bus(dev, "pci", > >>pci-host/apb.c:phb->bus = pci_register_bus(DEVICE

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread Andreas Färber
Am 05.03.2014 15:35, schrieb Andreas Färber: > Am 05.03.2014 15:21, schrieb Daniel P. Berrange: >> On Wed, Mar 05, 2014 at 03:12:40PM +0100, Paolo Bonzini wrote: >>> Il 05/03/2014 14:40, Daniel P. Berrange ha scritto: FWIW, I had requested this rename in the past but it was rejected :-( >

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread Andreas Färber
Am 05.03.2014 15:21, schrieb Daniel P. Berrange: > On Wed, Mar 05, 2014 at 03:12:40PM +0100, Paolo Bonzini wrote: >> Il 05/03/2014 14:40, Daniel P. Berrange ha scritto: >>> FWIW, I had requested this rename in the past but it was rejected :-( >>> >>>http://comments.gmane.org/gmane.comp.emulator

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread Daniel P. Berrange
On Wed, Mar 05, 2014 at 03:12:40PM +0100, Paolo Bonzini wrote: > Il 05/03/2014 14:40, Daniel P. Berrange ha scritto: > > FWIW, I had requested this rename in the past but it was rejected :-( > > > >http://comments.gmane.org/gmane.comp.emulators.qemu/70783 > > I think we should revisit that. >

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 14:40, Daniel P. Berrange ha scritto: > FWIW, I had requested this rename in the past but it was rejected :-( > >http://comments.gmane.org/gmane.comp.emulators.qemu/70783 I think we should revisit that. Path-based bus names are a good idea, but unfortunately it's not how thing

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread Daniel P. Berrange
On Wed, Mar 05, 2014 at 02:35:17PM +0100, Paolo Bonzini wrote: > Il 05/03/2014 12:43, Alexey Kardashevskiy ha scritto: > > > >I just tried current upstresm QEMU and it handles bus=pci fine, it prints > >an error on bus=pci.0 so I am confused - what qemu are you trying? > > See below: > > 1) virte

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 12:43, Alexey Kardashevskiy ha scritto: I just tried current upstresm QEMU and it handles bus=pci fine, it prints an error on bus=pci.0 so I am confused - what qemu are you trying? See below: 1) virtex-ml507 2) pseries Warning: Disabling some instructions which are not emulated

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread Alexey Kardashevskiy
On 03/05/2014 09:42 PM, hong-hua@freescale.com wrote: > Hi Gibson, > > I noticed your patch http://git.qemu.org/?p=qemu.git;a=commitdiff;h=89dfd6e1 > and have some question about PCI bus name on PowerPC. > > When I use libvirt to start VM on PowerPC platforms, it failed as below: > # virsh s