On Wed, Mar 05, 2014 at 03:33:39PM +0100, Paolo Bonzini wrote: > Il 05/03/2014 15:21, Daniel P. Berrange ha scritto: > >>alpha/typhoon.c: b = pci_register_bus(dev, "pci", > >>mips/gt64xxx_pci.c: phb->bus = pci_register_bus(dev, "pci", > >>pci-host/apb.c: phb->bus = pci_register_bus(DEVICE(phb), "pci", > >>pci-host/bonito.c: phb->bus = pci_register_bus(DEVICE(dev), "pci", > >>sh4/sh_pci.c: phb->bus = pci_register_bus(DEVICE(dev), "pci", > >>pci-host/versatile.c: pci_bus_new_inplace(&s->pci_bus, > >>sizeof(s->pci_bus), DEVICE(obj), "pci", > >> > >>plus pseries which has its own rules because it supports multiple PCI > >>host bridges, but probably can also be changed from "pci" to NULL. > > > >I'm not sure I understand the effect of changing 'pci' to NULL in this > >code, from libvirt's POV. Would using NULL mean we can rely on using > >"pci.0" as the default PCI bus name or not ? > > Yes. But the next bus that the user creates (e.g. from a PCI bridge > without an "id") would be "pci.1" instead of having a duplicate > "pci.0"). Needs a bit more testing of course.
That sounds OK from libvirt's POV, since when we create secondary buses we'll always set an ID value explicitly anyway. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
