> -----Original Message----- > From: Alexey Kardashevskiy [mailto:a...@ozlabs.ru] > Sent: Thursday, March 06, 2014 3:08 PM > To: Yin Olivia-R63875; Paolo Bonzini; da...@gibson.dropbear.id.au; > ag...@suse.de > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; Li Zhang > Subject: Re: QEMU: PCI bus name on PowerPC platforms > > On 03/06/2014 06:04 PM, hong-hua....@freescale.com wrote: > > Hi Alexey, > > > > Even though you change the default PCI bus naming, it will need detect > > the QEMU version in libvirt to keep compatibility with old QEMU version. > > > So? >
My comment is not related to your patch for QEMU. I mean that we need add version detection in libvirt like below after your patch accepted: libvirt/src/qemu/qemu_capabilities.c: virQEMUCapsComputeCmdFlags() ... if (version >= 9000) virQEMUCapsSet(qemuCaps, QEMU_CAPS_VNC_COLON); if (is_kvm && (version >= 10000 || kvm_version >= 74)) virQEMUCapsSet(qemuCaps, QEMU_CAPS_VNET_HDR); ... We need judge which version of QEMU support 'pci' for pseries and which version support 'pci.0'. > > Best Regar