Re: [Qemu-devel] [PATCH 3/7] NUMA: parse guest numa nodes memory policy

2013-06-19 Thread Wanlong Gao
On 06/20/2013 01:39 AM, Paolo Bonzini wrote: > Il 19/06/2013 10:01, Wanlong Gao ha scritto: >> On 06/19/2013 04:19 AM, Bandan Das wrote: >>> Eduardo Habkost writes: >>> On Tue, Jun 18, 2013 at 11:20:37AM +0200, Paolo Bonzini wrote: [...] > Also, please use QemuOpts instead of yet ano

Re: [Qemu-devel] [PATCH 3/7] NUMA: parse guest numa nodes memory policy

2013-06-19 Thread Paolo Bonzini
Il 19/06/2013 10:01, Wanlong Gao ha scritto: > On 06/19/2013 04:19 AM, Bandan Das wrote: >> Eduardo Habkost writes: >> >>> On Tue, Jun 18, 2013 at 11:20:37AM +0200, Paolo Bonzini wrote: >>> [...] Also, please use QemuOpts instead of yet another homegrown parser. Eduardo, I think you had

Re: [Qemu-devel] [PATCH 3/7] NUMA: parse guest numa nodes memory policy

2013-06-19 Thread Wanlong Gao
On 06/19/2013 04:19 AM, Bandan Das wrote: > Eduardo Habkost writes: > >> On Tue, Jun 18, 2013 at 11:20:37AM +0200, Paolo Bonzini wrote: >> [...] >>> Also, please use QemuOpts instead of yet another homegrown parser. >>> Eduardo, I think you had the most recent attempt to convert -numa to >>> Qemu

Re: [Qemu-devel] [PATCH 3/7] NUMA: parse guest numa nodes memory policy

2013-06-18 Thread Bandan Das
Eduardo Habkost writes: > On Tue, Jun 18, 2013 at 11:20:37AM +0200, Paolo Bonzini wrote: > [...] >> Also, please use QemuOpts instead of yet another homegrown parser. >> Eduardo, I think you had the most recent attempt to convert -numa to >> QemuOpts? > > I had one, but I believe it is more compl

Re: [Qemu-devel] [PATCH 3/7] NUMA: parse guest numa nodes memory policy

2013-06-18 Thread Eduardo Habkost
On Tue, Jun 18, 2013 at 11:20:37AM +0200, Paolo Bonzini wrote: [...] > Also, please use QemuOpts instead of yet another homegrown parser. > Eduardo, I think you had the most recent attempt to convert -numa to > QemuOpts? I had one, but I believe it is more complex than it should have been. I was c

Re: [Qemu-devel] [PATCH 3/7] NUMA: parse guest numa nodes memory policy

2013-06-18 Thread Wanlong Gao
On 06/18/2013 05:20 PM, Paolo Bonzini wrote: > Il 18/06/2013 10:09, Wanlong Gao ha scritto: >> +static unsigned int numa_node_parse_mpol(const char *str, unsigned long *bm) >> +{ >> +unsigned long long value, endvalue; >> +char *endptr; >> +unsigned int flags = 0; >> + >> +if (str[0

Re: [Qemu-devel] [PATCH 3/7] NUMA: parse guest numa nodes memory policy

2013-06-18 Thread Paolo Bonzini
Il 18/06/2013 10:09, Wanlong Gao ha scritto: > +static unsigned int numa_node_parse_mpol(const char *str, unsigned long *bm) > +{ > +unsigned long long value, endvalue; > +char *endptr; > +unsigned int flags = 0; > + > +if (str[0] == '!') { > +flags |= 2; clear = true; > +