Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-07 Thread Michael S. Tsirkin
On Wed, Sep 07, 2011 at 08:23:10AM -0500, Anthony Liguori wrote: > On 09/07/2011 08:17 AM, Michael S. Tsirkin wrote: > >On Wed, Sep 07, 2011 at 03:13:00PM +0200, Jan Kiszka wrote: > >>On 2011-09-07 15:06, Michael S. Tsirkin wrote: > >>>But if the command is not for users at all, if it's > >>>for qe

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-07 Thread Jan Kiszka
On 2011-09-07 15:23, Anthony Liguori wrote: > On 09/07/2011 08:17 AM, Michael S. Tsirkin wrote: >> On Wed, Sep 07, 2011 at 03:13:00PM +0200, Jan Kiszka wrote: >>> On 2011-09-07 15:06, Michael S. Tsirkin wrote: But if the command is not for users at all, if it's for qemu debugging, then ex

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-07 Thread Anthony Liguori
On 09/07/2011 08:17 AM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2011 at 03:13:00PM +0200, Jan Kiszka wrote: On 2011-09-07 15:06, Michael S. Tsirkin wrote: But if the command is not for users at all, if it's for qemu debugging, then exposing internals is a very logical thing. Only problem is

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-07 Thread Michael S. Tsirkin
On Wed, Sep 07, 2011 at 03:13:00PM +0200, Jan Kiszka wrote: > On 2011-09-07 15:06, Michael S. Tsirkin wrote: > > But if the command is not for users at all, if it's > > for qemu debugging, then exposing internals is a very > > logical thing. Only problem is - we must make it very very clear > > wh

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-07 Thread Jan Kiszka
On 2011-09-07 15:06, Michael S. Tsirkin wrote: > But if the command is not for users at all, if it's > for qemu debugging, then exposing internals is a very > logical thing. Only problem is - we must make it very very clear > which commands are for qemu debugging. This command it also for users,

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-07 Thread Michael S. Tsirkin
On Wed, Sep 07, 2011 at 11:37:20AM +0200, Kevin Wolf wrote: > Am 06.09.2011 19:05, schrieb Michael S. Tsirkin: > > On Tue, Sep 06, 2011 at 11:28:09AM -0500, Anthony Liguori wrote: > >> On 09/06/2011 11:09 AM, Michael S. Tsirkin wrote: > >>> On Tue, Sep 06, 2011 at 10:51:26AM -0500, Anthony Liguori

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-07 Thread Kevin Wolf
Am 06.09.2011 19:05, schrieb Michael S. Tsirkin: > On Tue, Sep 06, 2011 at 11:28:09AM -0500, Anthony Liguori wrote: >> On 09/06/2011 11:09 AM, Michael S. Tsirkin wrote: >>> On Tue, Sep 06, 2011 at 10:51:26AM -0500, Anthony Liguori wrote: On 09/06/2011 10:45 AM, Jan Kiszka wrote: > On 2011-

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-06 Thread Michael S. Tsirkin
On Tue, Sep 06, 2011 at 11:28:09AM -0500, Anthony Liguori wrote: > On 09/06/2011 11:09 AM, Michael S. Tsirkin wrote: > >On Tue, Sep 06, 2011 at 10:51:26AM -0500, Anthony Liguori wrote: > >>On 09/06/2011 10:45 AM, Jan Kiszka wrote: > >>>On 2011-09-06 16:48, Michael S. Tsirkin wrote: > I'm afraid

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-06 Thread Jan Kiszka
On 2011-09-06 18:08, Anthony Liguori wrote: > On 09/06/2011 11:05 AM, Jan Kiszka wrote: >> On 2011-09-06 17:51, Anthony Liguori wrote: >>> I'm still contemplating how we go about doing this. This series >>> introduces a couple new concepts like QMP class hinting anonymous IDs. >>> I'm concerned th

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-06 Thread Jan Kiszka
On 2011-09-06 18:09, Michael S. Tsirkin wrote: > On Tue, Sep 06, 2011 at 10:51:26AM -0500, Anthony Liguori wrote: >> On 09/06/2011 10:45 AM, Jan Kiszka wrote: >>> On 2011-09-06 16:48, Michael S. Tsirkin wrote: I'm afraid that won't be enough to stop people scripting this command - libvirt

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-06 Thread Anthony Liguori
On 09/06/2011 11:09 AM, Michael S. Tsirkin wrote: On Tue, Sep 06, 2011 at 10:51:26AM -0500, Anthony Liguori wrote: On 09/06/2011 10:45 AM, Jan Kiszka wrote: On 2011-09-06 16:48, Michael S. Tsirkin wrote: I'm afraid that won't be enough to stop people scripting this command - libvirt accessed H

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-06 Thread Anthony Liguori
On 09/06/2011 11:05 AM, Jan Kiszka wrote: On 2011-09-06 17:51, Anthony Liguori wrote: I'm still contemplating how we go about doing this. This series introduces a couple new concepts like QMP class hinting anonymous IDs. I'm concerned that we'll further complicate the need to support backwards

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-06 Thread Michael S. Tsirkin
On Tue, Sep 06, 2011 at 10:51:26AM -0500, Anthony Liguori wrote: > On 09/06/2011 10:45 AM, Jan Kiszka wrote: > >On 2011-09-06 16:48, Michael S. Tsirkin wrote: > >>I'm afraid that won't be enough to stop people > >>scripting this command - libvirt accessed > >>HMP for years. > >> > >>On the other ha

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-06 Thread Jan Kiszka
On 2011-09-06 17:51, Anthony Liguori wrote: > I'm still contemplating how we go about doing this. This series > introduces a couple new concepts like QMP class hinting anonymous IDs. > I'm concerned that we'll further complicate the need to support > backwards compatibility. Anonymous IDs must

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-06 Thread Anthony Liguori
On 09/06/2011 10:45 AM, Jan Kiszka wrote: On 2011-09-06 16:48, Michael S. Tsirkin wrote: I'm afraid that won't be enough to stop people scripting this command - libvirt accessed HMP for years. On the other hand, no QMP command means e.g. libvirt users don't get any benefit from this. What I th

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-06 Thread Jan Kiszka
On 2011-09-06 16:48, Michael S. Tsirkin wrote: > On Fri, Aug 26, 2011 at 04:48:10PM +0200, Jan Kiszka wrote: >> More than one year ago I posted some patches to add a monitor command >> callend device_show. The purpose of that command is to dump the state of >> some qdev device based on its vmstate.

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-06 Thread Michael S. Tsirkin
On Fri, Aug 26, 2011 at 04:48:10PM +0200, Jan Kiszka wrote: > More than one year ago I posted some patches to add a monitor command > callend device_show. The purpose of that command is to dump the state of > some qdev device based on its vmstate. > > To improve the usability of that interface, th

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-02 Thread Luiz Capitulino
On Fri, 26 Aug 2011 16:48:10 +0200 Jan Kiszka wrote: > More than one year ago I posted some patches to add a monitor command > callend device_show. The purpose of that command is to dump the state of > some qdev device based on its vmstate. > > To improve the usability of that interface, the pre

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-08-29 Thread Jan Kiszka
On 2011-08-29 21:22, Anthony Liguori wrote: > On 08/26/2011 09:48 AM, Jan Kiszka wrote: >> More than one year ago I posted some patches to add a monitor command >> callend device_show. The purpose of that command is to dump the state of >> some qdev device based on its vmstate. > > I have a series

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-08-29 Thread Anthony Liguori
On 08/26/2011 09:48 AM, Jan Kiszka wrote: More than one year ago I posted some patches to add a monitor command callend device_show. The purpose of that command is to dump the state of some qdev device based on its vmstate. I have a series that does the same thing as this in a totally different