On 04/25/2013 06:36 AM, Luiz Capitulino wrote:
>>> One other concern - you document that if a flag parameter is omitted,
>>> then it defaults to 1. Is that really true?
>>
>>
>> I'm wrong. If it's omitted in cmdline, we will give it a default value.
>>
>> This kind of default info is only added
On Thu, 25 Apr 2013 11:52:58 +0800
Amos Kong wrote:
> On Wed, Apr 24, 2013 at 01:39:08PM -0600, Eric Blake wrote:
> > On 04/24/2013 12:20 PM, Luiz Capitulino wrote:
> > > On Thu, 25 Apr 2013 01:33:24 +0800
> > > Amos Kong wrote:
> > >
> > >> Libvirt has no way to probe if an option or property
On Thu, Apr 25, 2013 at 12:27:16PM +0800, Osier Yang wrote:
> On 25/04/13 11:52, Amos Kong wrote:
> >On Wed, Apr 24, 2013 at 01:39:08PM -0600, Eric Blake wrote:
> >>On 04/24/2013 12:20 PM, Luiz Capitulino wrote:
> >>>On Thu, 25 Apr 2013 01:33:24 +0800
> >>>Amos Kong wrote:
> >>>
> Libvirt has
On 25/04/13 11:52, Amos Kong wrote:
On Wed, Apr 24, 2013 at 01:39:08PM -0600, Eric Blake wrote:
On 04/24/2013 12:20 PM, Luiz Capitulino wrote:
On Thu, 25 Apr 2013 01:33:24 +0800
Amos Kong wrote:
Libvirt has no way to probe if an option or property is supported,
This patch introdues a new qmp
On Wed, Apr 24, 2013 at 01:39:08PM -0600, Eric Blake wrote:
> On 04/24/2013 12:20 PM, Luiz Capitulino wrote:
> > On Thu, 25 Apr 2013 01:33:24 +0800
> > Amos Kong wrote:
> >
> >> Libvirt has no way to probe if an option or property is supported,
> >> This patch introdues a new qmp command to query
On 25/04/13 09:14, Amos Kong wrote:
On Wed, Apr 24, 2013 at 02:20:20PM -0400, Luiz Capitulino wrote:
On Thu, 25 Apr 2013 01:33:24 +0800
Amos Kong wrote:
Libvirt has no way to probe if an option or property is supported,
This patch introdues a new qmp command to query configuration schema
info
On Wed, 24 Apr 2013 19:44:37 -0600
Eric Blake wrote:
> On 04/24/2013 07:35 PM, Luiz Capitulino wrote:
>
> >> case QEMU_OPT_SIZE:
> >>
> >> param_info->type = CONFIG_PARAM_TYPE_SIZE;
> >>
On Wed, Apr 24, 2013 at 07:44:37PM -0600, Eric Blake wrote:
> On 04/24/2013 07:35 PM, Luiz Capitulino wrote:
>
> >> case QEMU_OPT_SIZE:
> >>
> >> param_info->type = CONFIG_PARAM_TYPE_SIZE;
>
On 04/24/2013 07:35 PM, Luiz Capitulino wrote:
>> case QEMU_OPT_SIZE:
>>
>> param_info->type = CONFIG_PARAM_TYPE_SIZE;
>>
>> break;
>>
On 04/24/2013 07:14 PM, Amos Kong wrote:
>>> +##
>>> +{'command': 'query-config-schema', 'data': {'*option': 'str'},
>>
>> Please, let's not make option optional. It makes the code slightly more
>> complex for no good reason.
>
> For the human, if they don't know the detail name of one option, the
On Thu, 25 Apr 2013 09:14:51 +0800
Amos Kong wrote:
> On Wed, Apr 24, 2013 at 02:20:20PM -0400, Luiz Capitulino wrote:
> > On Thu, 25 Apr 2013 01:33:24 +0800
> > Amos Kong wrote:
> >
> > > Libvirt has no way to probe if an option or property is supported,
> > > This patch introdues a new qmp co
On Wed, Apr 24, 2013 at 02:20:20PM -0400, Luiz Capitulino wrote:
> On Thu, 25 Apr 2013 01:33:24 +0800
> Amos Kong wrote:
>
> > Libvirt has no way to probe if an option or property is supported,
> > This patch introdues a new qmp command to query configuration schema
> > information. hmp command i
On 04/24/2013 01:39 PM, Eric Blake wrote:
> On 04/24/2013 12:20 PM, Luiz Capitulino wrote:
>> On Thu, 25 Apr 2013 01:33:24 +0800
>> Amos Kong wrote:
>>
>>> Libvirt has no way to probe if an option or property is supported,
>>> This patch introdues a new qmp command to query configuration schema
>>
On 04/24/2013 12:20 PM, Luiz Capitulino wrote:
> On Thu, 25 Apr 2013 01:33:24 +0800
> Amos Kong wrote:
>
>> Libvirt has no way to probe if an option or property is supported,
>> This patch introdues a new qmp command to query configuration schema
>> information. hmp command isn't added because it
On Thu, 25 Apr 2013 01:33:24 +0800
Amos Kong wrote:
> Libvirt has no way to probe if an option or property is supported,
> This patch introdues a new qmp command to query configuration schema
> information. hmp command isn't added because it's not needed.
>
> V2: fix jaso schema and comments (Er
On Tue, 23 Apr 2013 09:32:31 -0600
Eric Blake wrote:
> On 04/23/2013 07:20 AM, Luiz Capitulino wrote:
> > On Mon, 22 Apr 2013 09:00:05 -0600
> > Eric Blake wrote:
> >
> >> At any rate, we really DO want introspection, and having it in 1.5 is a
> >> worthwhile goal. Even if the introspection tu
On 04/23/2013 07:20 AM, Luiz Capitulino wrote:
> On Mon, 22 Apr 2013 09:00:05 -0600
> Eric Blake wrote:
>
>> At any rate, we really DO want introspection, and having it in 1.5 is a
>> worthwhile goal. Even if the introspection turns up empty on legacy
>> options, having it for the sake of new op
On Mon, 22 Apr 2013 09:00:05 -0600
Eric Blake wrote:
> At any rate, we really DO want introspection, and having it in 1.5 is a
> worthwhile goal. Even if the introspection turns up empty on legacy
> options, having it for the sake of new options is worth the effort.
Agreed. But as you said in a
On Mon, Apr 22, 2013 at 05:16:02PM +0200, Paolo Bonzini wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Il 22/04/2013 17:00, Eric Blake ha scritto:
> > On 04/22/2013 06:07 AM, Paolo Bonzini wrote:
> >> Il 22/04/2013 13:48, Amos Kong ha scritto:
> >>> Libvirt doesn't have a stable
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Il 22/04/2013 17:00, Eric Blake ha scritto:
> On 04/22/2013 06:07 AM, Paolo Bonzini wrote:
>> Il 22/04/2013 13:48, Amos Kong ha scritto:
>>> Libvirt doesn't have a stable way to know option
>>> support detail. This patch introdued a new qmp com
On 04/22/2013 06:07 AM, Paolo Bonzini wrote:
> Il 22/04/2013 13:48, Amos Kong ha scritto:
>> Libvirt doesn't have a stable way to know option support
>> detail. This patch introdued a new qmp command to query
>> configuration schema information. hmp command isn't added.
Can yo
Il 22/04/2013 13:48, Amos Kong ha scritto:
>>> > > Libvirt doesn't have a stable way to know option support
>>> > > detail. This patch introdued a new qmp command to query
>>> > > configuration schema information. hmp command isn't added.
>> >
>> > Can you introspect QemuOpts instead? All new opt
On Fri, Apr 19, 2013 at 05:21:37PM +0200, Paolo Bonzini wrote:
> Il 19/04/2013 11:52, Amos Kong ha scritto:
> > Libvirt doesn't have a stable way to know option support
> > detail. This patch introdued a new qmp command to query
> > configuration schema information. hmp command isn't added.
>
> Ca
Il 19/04/2013 11:52, Amos Kong ha scritto:
> Libvirt doesn't have a stable way to know option support
> detail. This patch introdued a new qmp command to query
> configuration schema information. hmp command isn't added.
Can you introspect QemuOpts instead? All new options are added there.
Paolo
On 19/04/13 20:39, Eric Blake wrote:
On 04/19/2013 03:52 AM, Amos Kong wrote:
Libvirt doesn't have a stable way to know option support
detail. This patch introdued a new qmp command to query
configuration schema information. hmp command isn't added.
Agreed; HMP is not needed: by the time you ca
On 19/04/13 20:02, Osier Yang wrote:
On 19/04/13 17:52, Amos Kong wrote:
Libvirt doesn't have a stable way to know option support
Actually no way now.
Libvirt swtiched to use qmp to collect the qemu capabilities
for qemu newer than 1.2.0, thus there is no way to probe either
if a option or a
On 04/19/2013 03:52 AM, Amos Kong wrote:
> Libvirt doesn't have a stable way to know option support
> detail. This patch introdued a new qmp command to query
> configuration schema information. hmp command isn't added.
Agreed; HMP is not needed: by the time you can connect to a human
monitor, you'
On 04/19/2013 06:02 AM, Osier Yang wrote:
> On 19/04/13 17:52, Amos Kong wrote:
>> Libvirt doesn't have a stable way to know option support
>
> Actually no way now.
>
>> +
>> +##
>> +# @ConfigSchemaInfo:
>> +#
>> +# Configration schema information.
>> +#
>> +# @option: option name
>> +#
>> +# @c
On 19/04/13 17:52, Amos Kong wrote:
Libvirt doesn't have a stable way to know option support
Actually no way now.
Libvirt swtiched to use qmp to collect the qemu capabilities
for qemu newer than 1.2.0, thus there is no way to probe either
if a option or a property is supported or not by QEMU.
29 matches
Mail list logo