On 04/24/2013 07:14 PM, Amos Kong wrote:
>>> +##
>>> +{'command': 'query-config-schema', 'data': {'*option': 'str'},
>>
>> Please, let's not make option optional. It makes the code slightly more
>> complex for no good reason.
>
> For the human, if they don't know the detail name of one option, they just
> list all the options, then find the useful one.
>
> Not sure the use-case of full list for libvirt. Osier?I think I already answered that - having the whole list (single QMP call) is more efficient than calling multiple times per command we are interested in. Also, most other query-* commands do NOT filter; having the 'option' argument introduces filtering. It's up to Luiz whether we leave it as is, or omit '*option' for now and save filtering for later, but I'd rather not have mandatory 'option' as then you have to know in advance which command line options you care about. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
