On Wed, 24 Apr 2013 19:44:37 -0600 Eric Blake <ebl...@redhat.com> wrote:
> On 04/24/2013 07:35 PM, Luiz Capitulino wrote: > > >> case QEMU_OPT_SIZE: > >> > >> param_info->type = CONFIG_PARAM_TYPE_SIZE; > >> > >> break; > >> } > > > > Looks good. > > > >> I think we don't need default here, until some add new items in enum > >> QemuOptType without update this code. > > > > Maybe we can have: > > > > default: > > abort(); > > > > So that we catch new QEmuOpts types not accompanied by a new ConfigParamType > > type. > > gcc is able to warn about missed options if you omit a default case (and > if the switch was on an actual enum type); but does not warn about > missed options if you do have a default case. Libvirt has actually been > switching to default-free coding styles on any switch statement where we > expect an enum will grow in the future, for that reason. Ah, didn't know that. Fine with me then.
