Re: [PATCH 4/5] hw/arm/smmuv3: Move reset to exit phase

2025-02-12 Thread Cédric Le Goater
On 2/10/25 15:22, Peter Maydell wrote: On Mon, 10 Feb 2025 at 14:14, Peter Xu wrote: On Fri, Feb 07, 2025 at 06:18:50PM +, Peter Maydell wrote: On Fri, 7 Feb 2025 at 17:48, Peter Xu wrote: On Fri, Feb 07, 2025 at 04:58:39PM +, Peter Maydell wrote: (I wonder if we ought to suggest

Re: [PATCH 4/5] hw/arm/smmuv3: Move reset to exit phase

2025-02-10 Thread Peter Xu
On Mon, Feb 10, 2025 at 09:35:53AM +0100, Eric Auger wrote: > Hi Peter, Eric, > > > On 2/7/25 6:47 PM, Peter Xu wrote: > > On Fri, Feb 07, 2025 at 04:58:39PM +, Peter Maydell wrote: > >> (I wonder if we ought to suggest quiescing outstanding > >> DMA in the enter phase? But it's probably ea

Re: [PATCH 4/5] hw/arm/smmuv3: Move reset to exit phase

2025-02-10 Thread Peter Maydell
On Mon, 10 Feb 2025 at 14:14, Peter Xu wrote: > > On Fri, Feb 07, 2025 at 06:18:50PM +, Peter Maydell wrote: > > On Fri, 7 Feb 2025 at 17:48, Peter Xu wrote: > > > > > > On Fri, Feb 07, 2025 at 04:58:39PM +, Peter Maydell wrote: > > > > (I wonder if we ought to suggest quiescing outstandi

Re: [PATCH 4/5] hw/arm/smmuv3: Move reset to exit phase

2025-02-10 Thread Peter Xu
On Fri, Feb 07, 2025 at 06:18:50PM +, Peter Maydell wrote: > On Fri, 7 Feb 2025 at 17:48, Peter Xu wrote: > > > > On Fri, Feb 07, 2025 at 04:58:39PM +, Peter Maydell wrote: > > > (I wonder if we ought to suggest quiescing outstanding > > > DMA in the enter phase? But it's probably easier t

Re: [PATCH 4/5] hw/arm/smmuv3: Move reset to exit phase

2025-02-10 Thread Eric Auger
Hi Peter, On 2/7/25 7:18 PM, Peter Maydell wrote: > On Fri, 7 Feb 2025 at 17:48, Peter Xu wrote: >> On Fri, Feb 07, 2025 at 04:58:39PM +, Peter Maydell wrote: >>> (I wonder if we ought to suggest quiescing outstanding >>> DMA in the enter phase? But it's probably easier to fix >>> the iommu

Re: [PATCH 4/5] hw/arm/smmuv3: Move reset to exit phase

2025-02-10 Thread Eric Auger
Hi Peter, On 2/7/25 5:58 PM, Peter Maydell wrote: > On Fri, 7 Feb 2025 at 16:50, Eric Auger wrote: >> >> >> >> On 2/7/25 5:37 PM, Peter Maydell wrote: >>> On Thu, 6 Feb 2025 at 14:23, Eric Auger wrote: Currently the iommu may be reset before the devices it protects. For example this

Re: [PATCH 4/5] hw/arm/smmuv3: Move reset to exit phase

2025-02-10 Thread Eric Auger
Hi Peter, On 2/7/25 6:47 PM, Peter Xu wrote: > On Fri, Feb 07, 2025 at 04:58:39PM +, Peter Maydell wrote: >> (I wonder if we ought to suggest quiescing outstanding >> DMA in the enter phase? But it's probably easier to fix >> the iommus like this series does than try to get every >> dma-capab

Re: [PATCH 4/5] hw/arm/smmuv3: Move reset to exit phase

2025-02-07 Thread Peter Maydell
On Fri, 7 Feb 2025 at 17:48, Peter Xu wrote: > > On Fri, Feb 07, 2025 at 04:58:39PM +, Peter Maydell wrote: > > (I wonder if we ought to suggest quiescing outstanding > > DMA in the enter phase? But it's probably easier to fix > > the iommus like this series does than try to get every > > dma-

Re: [PATCH 4/5] hw/arm/smmuv3: Move reset to exit phase

2025-02-07 Thread Peter Xu
On Fri, Feb 07, 2025 at 04:58:39PM +, Peter Maydell wrote: > (I wonder if we ought to suggest quiescing outstanding > DMA in the enter phase? But it's probably easier to fix > the iommus like this series does than try to get every > dma-capable pci device to do something different.) I wonder i

Re: [PATCH 4/5] hw/arm/smmuv3: Move reset to exit phase

2025-02-07 Thread Peter Maydell
On Fri, 7 Feb 2025 at 16:50, Eric Auger wrote: > > > > > On 2/7/25 5:37 PM, Peter Maydell wrote: > > On Thu, 6 Feb 2025 at 14:23, Eric Auger wrote: > >> Currently the iommu may be reset before the devices > >> it protects. For example this happens with virtio-scsi-pci. > >> when system_reset is i

Re: [PATCH 4/5] hw/arm/smmuv3: Move reset to exit phase

2025-02-07 Thread Eric Auger
On 2/7/25 5:37 PM, Peter Maydell wrote: > On Thu, 6 Feb 2025 at 14:23, Eric Auger wrote: >> Currently the iommu may be reset before the devices >> it protects. For example this happens with virtio-scsi-pci. >> when system_reset is issued from qmp monitor, spurious >> "virtio: zero sized buffer

Re: [PATCH 4/5] hw/arm/smmuv3: Move reset to exit phase

2025-02-07 Thread Peter Maydell
On Thu, 6 Feb 2025 at 14:23, Eric Auger wrote: > > Currently the iommu may be reset before the devices > it protects. For example this happens with virtio-scsi-pci. > when system_reset is issued from qmp monitor, spurious > "virtio: zero sized buffers are not allowed" warnings can > be observed. >