On Tue, Apr 21, 2020 at 10:50:25AM -0700, Richard Henderson wrote:
> On 4/20/20 3:34 AM, Alex Bennée wrote:
> >> +GEN_VXFORM_VSPLTI(vspltisb, MO_8, 6, 12);
> >> +GEN_VXFORM_VSPLTI(vspltish, MO_16, 6, 13);
> >> +GEN_VXFORM_VSPLTI(vspltisw, MO_32, 6, 14);
> >
> > There are unused parameters opc2/opc
On 4/20/20 3:34 AM, Alex Bennée wrote:
>> +GEN_VXFORM_VSPLTI(vspltisb, MO_8, 6, 12);
>> +GEN_VXFORM_VSPLTI(vspltish, MO_16, 6, 13);
>> +GEN_VXFORM_VSPLTI(vspltisw, MO_32, 6, 14);
>
> There are unused parameters opc2/opc3 parameters here.
Yes, but all of the other GEN_* macros retain them as well.
Richard Henderson writes:
> We can now unify the implementation of the 3 VSPLTI instructions.
>
> Signed-off-by: Richard Henderson
> ---
> target/ppc/translate/vmx-impl.inc.c | 32 -
> target/ppc/translate/vsx-impl.inc.c | 2 +-
> 2 files changed, 19 insertions(+)
On Sat, Apr 18, 2020 at 08:04:07AM -0700, Richard Henderson wrote:
> We can now unify the implementation of the 3 VSPLTI instructions.
>
> Signed-off-by: Richard Henderson
Acked-by: David Gibson
> ---
> target/ppc/translate/vmx-impl.inc.c | 32 -
> target/ppc/trans