On Tue, Apr 21, 2020 at 10:50:25AM -0700, Richard Henderson wrote: > On 4/20/20 3:34 AM, Alex Bennée wrote: > >> +GEN_VXFORM_VSPLTI(vspltisb, MO_8, 6, 12); > >> +GEN_VXFORM_VSPLTI(vspltish, MO_16, 6, 13); > >> +GEN_VXFORM_VSPLTI(vspltisw, MO_32, 6, 14); > > > > There are unused parameters opc2/opc3 parameters here. > > Yes, but all of the other GEN_* macros retain them as well. > Without looking at the actual history, I'd say once upon a time they were > actually used, but we've now split opcode from implementation. > > > With the removed extra unused macro params: > > > > Reviewed-by: Alex Bennée <alex.ben...@linaro.org> > > I wouldn't do that without David's approval. And possibly stripping out the > opcodes everywhere else.
Yeah. Sounds like one of a nearly infinite number of global cleanups
that the target-ppc tcg code could do with. Patches welcome.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
