On 4/20/20 3:34 AM, Alex Bennée wrote: >> +GEN_VXFORM_VSPLTI(vspltisb, MO_8, 6, 12); >> +GEN_VXFORM_VSPLTI(vspltish, MO_16, 6, 13); >> +GEN_VXFORM_VSPLTI(vspltisw, MO_32, 6, 14); > > There are unused parameters opc2/opc3 parameters here.
Yes, but all of the other GEN_* macros retain them as well. Without looking at the actual history, I'd say once upon a time they were actually used, but we've now split opcode from implementation. > With the removed extra unused macro params: > > Reviewed-by: Alex Bennée <alex.ben...@linaro.org> I wouldn't do that without David's approval. And possibly stripping out the opcodes everywhere else. r~
