On 07/20/2017 12:06 PM, Daniel P. Berrange wrote:
>>> IMHO your patch is ok, or we could be alittle more explicit about
>>> catching just the case where you pass -1 for bytes, and have
>>>
>>> && bytes != -1
>>
>> This seems bizarre to me since bytes is size_t bytes and size_t
>> is unsigned,
On Thu, Jul 20, 2017 at 06:04:44PM +0100, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrange (berra...@redhat.com) wrote:
> > On Thu, Jul 20, 2017 at 05:15:49PM +0100, Dr. David Alan Gilbert wrote:
> > > * Daniel P. Berrange (berra...@redhat.com) wrote:
> > > > On Fri, Apr 07, 2017 at 03:38:47PM
* Daniel P. Berrange (berra...@redhat.com) wrote:
> On Thu, Jul 20, 2017 at 05:15:49PM +0100, Dr. David Alan Gilbert wrote:
> > * Daniel P. Berrange (berra...@redhat.com) wrote:
> > > On Fri, Apr 07, 2017 at 03:38:47PM +0100, Dr. David Alan Gilbert wrote:
> > > > Hi,
> > > >Fedora 26 has gcc 7.
On Thu, Jul 20, 2017 at 05:15:49PM +0100, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrange (berra...@redhat.com) wrote:
> > On Fri, Apr 07, 2017 at 03:38:47PM +0100, Dr. David Alan Gilbert wrote:
> > > Hi,
> > >Fedora 26 has gcc 7.0.1 which has the normal compliment
> > > of new fussy warni
* Daniel P. Berrange (berra...@redhat.com) wrote:
> On Fri, Apr 07, 2017 at 03:38:47PM +0100, Dr. David Alan Gilbert wrote:
> > Hi,
> >Fedora 26 has gcc 7.0.1 which has the normal compliment
> > of new fussy warnings; so far I've posted :
> >
> > tests/check-qdict: Fix missing brackets
> > sli
On 07/20/2017 05:50 AM, Daniel P. Berrange wrote:
> On Fri, Apr 07, 2017 at 03:38:47PM +0100, Dr. David Alan Gilbert wrote:
>> Hi,
>>Fedora 26 has gcc 7.0.1 which has the normal compliment
>> of new fussy warnings; so far I've posted :
>>
>> +++ b/include/qemu/iov.h
>> @@ -46,7 +46,7 @@ static
On Fri, Apr 07, 2017 at 03:38:47PM +0100, Dr. David Alan Gilbert wrote:
> Hi,
>Fedora 26 has gcc 7.0.1 which has the normal compliment
> of new fussy warnings; so far I've posted :
>
> tests/check-qdict: Fix missing brackets
> slirp/smb: Replace constant strings by glib string
>
> that fix on
On 18.07.2017 17:10, Eric Blake wrote:
> On 07/18/2017 10:04 AM, Philippe Mathieu-Daudé wrote:
>>> We should be consistent -- if we can't trust assert() to
>>> be marked nonreturn, as it seems we can't, then we shouldn't
>>> write new code that assumes it always is, even if today
>>> it doesn't hap
On 07/18/2017 06:59 PM, Richard Henderson wrote:
>> +++ w/hw/usb/bus.c
>> @@ -407,8 +407,9 @@ void usb_register_companion(const char *masterbus,
>> USBPort *ports[],
>> void usb_port_location(USBPort *downstream, USBPort *upstream, int
>> portnr)
>> {
>> if (upstream) {
>> -snpri
On 07/17/2017 03:48 AM, Eric Blake wrote:
On 07/17/2017 08:42 AM, Eric Blake wrote:
On 07/13/2017 08:07 AM, Philippe Mathieu-Daudé wrote:
On 04/07/2017 04:21 PM, Philippe Mathieu-Daudé wrote:
Hi Dave,
On 04/07/2017 11:38 AM, Dr. David Alan Gilbert wrote:
Hi,
Fedora 26 has gcc 7.0.1 which
On 07/18/2017 10:04 AM, Philippe Mathieu-Daudé wrote:
>> We should be consistent -- if we can't trust assert() to
>> be marked nonreturn, as it seems we can't, then we shouldn't
>> write new code that assumes it always is, even if today
>> it doesn't happen to bite us on the compiler/host combinati
On 07/17/2017 02:36 PM, Peter Maydell wrote:
On 17 July 2017 at 18:29, Eric Blake wrote:
On 07/17/2017 11:46 AM, Dr. David Alan Gilbert wrote:
[...]
You may find this doesn't help in some windows builds; the assert
functions aren't always marked as noreturn (because they pop up a dialog
that
On Tue, Jul 18, 2017 at 07:35:58AM -0500, Eric Blake wrote:
> On 07/18/2017 02:23 AM, Daniel P. Berrange wrote:
> >> How would it not help? Are we using gcc 7 on windows builds? Adding
> >> the assert is enough to shut up new gcc; old gcc was already silent; and
> >> if mingw is still on old gcc,
On 07/18/2017 02:23 AM, Daniel P. Berrange wrote:
>> How would it not help? Are we using gcc 7 on windows builds? Adding
>> the assert is enough to shut up new gcc; old gcc was already silent; and
>> if mingw is still on old gcc, it doesn't matter whether assert() is
>> marked noreturn for what t
On Mon, Jul 17, 2017 at 12:29:08PM -0500, Eric Blake wrote:
> On 07/17/2017 11:46 AM, Dr. David Alan Gilbert wrote:
>
> >> +++ w/hw/usb/bus.c
> >> @@ -407,8 +407,9 @@ void usb_register_companion(const char *masterbus,
> >> USBPort *ports[],
> >> void usb_port_location(USBPort *downstream, USBPort
* Eric Blake (ebl...@redhat.com) wrote:
> On 07/17/2017 12:36 PM, Peter Maydell wrote:
> > On 17 July 2017 at 18:29, Eric Blake wrote:
> >> On 07/17/2017 11:46 AM, Dr. David Alan Gilbert wrote:
> >>
> +++ w/hw/usb/bus.c
> @@ -407,8 +407,9 @@ void usb_register_companion(const char *master
On 07/17/2017 12:36 PM, Peter Maydell wrote:
> On 17 July 2017 at 18:29, Eric Blake wrote:
>> On 07/17/2017 11:46 AM, Dr. David Alan Gilbert wrote:
>>
+++ w/hw/usb/bus.c
@@ -407,8 +407,9 @@ void usb_register_companion(const char *masterbus,
USBPort *ports[],
void usb_port_loca
* Eric Blake (ebl...@redhat.com) wrote:
> On 07/17/2017 11:46 AM, Dr. David Alan Gilbert wrote:
>
> >> +++ w/hw/usb/bus.c
> >> @@ -407,8 +407,9 @@ void usb_register_companion(const char *masterbus,
> >> USBPort *ports[],
> >> void usb_port_location(USBPort *downstream, USBPort *upstream, int port
On 17 July 2017 at 18:29, Eric Blake wrote:
> On 07/17/2017 11:46 AM, Dr. David Alan Gilbert wrote:
>
>>> +++ w/hw/usb/bus.c
>>> @@ -407,8 +407,9 @@ void usb_register_companion(const char *masterbus,
>>> USBPort *ports[],
>>> void usb_port_location(USBPort *downstream, USBPort *upstream, int port
On 07/17/2017 11:46 AM, Dr. David Alan Gilbert wrote:
>> +++ w/hw/usb/bus.c
>> @@ -407,8 +407,9 @@ void usb_register_companion(const char *masterbus,
>> USBPort *ports[],
>> void usb_port_location(USBPort *downstream, USBPort *upstream, int portnr)
>> {
>> if (upstream) {
>> -snprin
On 17 July 2017 at 17:46, Dr. David Alan Gilbert wrote:
> You may find this doesn't help in some windows builds; the assert
> functions aren't always marked as noreturn (because they pop up a dialog
> that asks you whether you want to run into a debugger etc).
Oh, is that why?
In any case, we r
* Eric Blake (ebl...@redhat.com) wrote:
> On 07/17/2017 08:42 AM, Eric Blake wrote:
> > On 07/13/2017 08:07 AM, Philippe Mathieu-Daudé wrote:
> >> On 04/07/2017 04:21 PM, Philippe Mathieu-Daudé wrote:
> >>> Hi Dave,
> >>>
> >>> On 04/07/2017 11:38 AM, Dr. David Alan Gilbert wrote:
> Hi,
>
On 07/17/2017 09:16 AM, Gerd Hoffmann wrote:
> Hi,
>
>> FWIW, most of these have been fixed in the meantime; the only
>> remaining
>> hack I had to add was:
>>
>> diff --git i/hw/usb/bus.c w/hw/usb/bus.c
>> index 5939b273b9..bce011058b 100644
>> --- i/hw/usb/bus.c
>> +++ w/hw/usb/bus.c
>> @@ -40
Hi,
> FWIW, most of these have been fixed in the meantime; the only
> remaining
> hack I had to add was:
>
> diff --git i/hw/usb/bus.c w/hw/usb/bus.c
> index 5939b273b9..bce011058b 100644
> --- i/hw/usb/bus.c
> +++ w/hw/usb/bus.c
> @@ -407,8 +407,9 @@ void usb_register_companion(const char
> *m
On 07/13/2017 08:07 AM, Philippe Mathieu-Daudé wrote:
> On 04/07/2017 04:21 PM, Philippe Mathieu-Daudé wrote:
>> Hi Dave,
>>
>> On 04/07/2017 11:38 AM, Dr. David Alan Gilbert wrote:
>>> Hi,
>>>Fedora 26 has gcc 7.0.1 which has the normal compliment
>>> of new fussy warnings; so far I've posted
On 07/17/2017 08:42 AM, Eric Blake wrote:
> On 07/13/2017 08:07 AM, Philippe Mathieu-Daudé wrote:
>> On 04/07/2017 04:21 PM, Philippe Mathieu-Daudé wrote:
>>> Hi Dave,
>>>
>>> On 04/07/2017 11:38 AM, Dr. David Alan Gilbert wrote:
Hi,
Fedora 26 has gcc 7.0.1 which has the normal complim
On 04/07/2017 04:21 PM, Philippe Mathieu-Daudé wrote:
Hi Dave,
On 04/07/2017 11:38 AM, Dr. David Alan Gilbert wrote:
Hi,
Fedora 26 has gcc 7.0.1 which has the normal compliment
of new fussy warnings; so far I've posted :
tests/check-qdict: Fix missing brackets
slirp/smb: Replace constant st
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20170407143847.GM2138@work-vm
Subject: [Qemu-devel] Hacks for building on gcc 7 / Fedora 26
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline
Hi Dave,
On 04/07/2017 11:38 AM, Dr. David Alan Gilbert wrote:
Hi,
Fedora 26 has gcc 7.0.1 which has the normal compliment
of new fussy warnings; so far I've posted :
tests/check-qdict: Fix missing brackets
slirp/smb: Replace constant strings by glib string
that fix one actual mistake and w
Hi,
Fedora 26 has gcc 7.0.1 which has the normal compliment
of new fussy warnings; so far I've posted :
tests/check-qdict: Fix missing brackets
slirp/smb: Replace constant strings by glib string
that fix one actual mistake and work around something it's being
fussy over.
But I've also got a p
30 matches
Mail list logo
