On 07/18/2017 02:23 AM, Daniel P. Berrange wrote: >> How would it not help? Are we using gcc 7 on windows builds? Adding >> the assert is enough to shut up new gcc; old gcc was already silent; and >> if mingw is still on old gcc, it doesn't matter whether assert() is >> marked noreturn for what this patch is doing. > > Mingw isn't using a fork of GCC anymore, its all mainline. Thus Fedora's > mingw gcc packages track native gcc packages. IOW i686-w64-mingw32-gcc > is already on version 7.1.0 in Fedora
So I guess that means running 'make docker-test-mingw@fedora' on Fedora 26 will find out if we need further tweaks? Trying it now... Nope, didn't get very far :( $ make docker-test-mingw@fedora BUILD fedora make[1]: Entering directory '/home/eblake/qemu' ARCHIVE qemu.tgz usage: git archive [<options>] <tree-ish> [<path>...] ... make[1]: *** [/home/eblake/qemu/tests/docker/Makefile.include:35: docker-src.2017-07-18-07.35.20.4101] Error 129 make[1]: Leaving directory '/home/eblake/qemu' make: *** [/home/eblake/qemu/tests/docker/Makefile.include:156: docker-run-test-mingw@fedora] Error 2 Am I not doing it right? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
