Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-09 Thread Paolo Bonzini
On 09/10/2015 15:02, Pavel Fedin wrote: >> It is needed for use with vhost-user. If the file descriptor you >> pass to the vhost-user server is mapped with MAP_PRIVATE, the >> vhost-user server will not get the guest's memory contents. At >> least I think so. :) > > Aha, so it actually tested o

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-09 Thread Marc-André Lureau
Hi - Original Message - > Hello! > > > file_ram_alloc() only allocates with temporary files, even when using > > share=true. > > Yes. I wonder, what's the purpose of share=true then. Paolo added it, I am not sure either. > > We could teach it to use an existing file instead. This is

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-09 Thread Pavel Fedin
Hello! > It is needed for use with vhost-user. If the file descriptor you pass > to the vhost-user server is mapped with MAP_PRIVATE, the vhost-user > server will not get the guest's memory contents. At least I think so. :) Aha, so it actually tested only when file descriptor is passed from o

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-09 Thread Pavel Fedin
Hello! > Yeah, I wish to solve this quickly. Unfortunately, Andreas didn't reply to my > proposal. Tbh, I > am really tempted to just change the copyright lines, resend, and call it a > day (I could even > give him authorship after all ;) I didn't read the whole thing thoroughly, but IIRC he

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-09 Thread Marc-André Lureau
Hi - Original Message - > Hello! > > I have merged this PULL into our local repository and my colleague gave it a > try. > It seems to work, but looks like ivshmem + memdev + hugetlbfs doesn't do the > right thing. Memdev does attach itself to a hugetlb, but we cannot actually > shar

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-09 Thread Pavel Fedin
Hello! > file_ram_alloc() only allocates with temporary files, even when using > share=true. Yes. I wonder, what's the purpose of share=true then. > We could teach it to use an existing file instead. This is an additional > feature that could be > considered after this series, since it's not

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-09 Thread Pavel Fedin
Hello! I have merged this PULL into our local repository and my colleague gave it a try. It seems to work, but looks like ivshmem + memdev + hugetlbfs doesn't do the right thing. Memdev does attach itself to a hugetlb, but we cannot actually share data with it. Our command line was: --- cut

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-09 Thread Paolo Bonzini
On 09/10/2015 14:45, Marc-André Lureau wrote: > Hi > > - Original Message - >> Hello! >> >>> file_ram_alloc() only allocates with temporary files, even when using >>> share=true. >> >> Yes. I wonder, what's the purpose of share=true then. > > Paolo added it, I am not sure either. It i

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 14:31, Andreas Färber wrote: > It is non-technical and called plagiarism. I don't think the text g_strdup_printf("-device ivshmem,shm=%s,size=1M", (yes, even the final argument differs between your version and Marc-André) counts as plagiarism. > The common denominator is that

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 14:05, Andreas Färber wrote: > my "make test" patch (which Peter keeps refusing to apply for two > releases now) For what it's worth, I am not currently aware of a patch from you that I am refusing to apply. There's a lot of traffic on the list, and it's very easy for things

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-07 Thread Marc-André Lureau
Hi - Original Message - > Drew, > > Am 07.10.2015 um 14:42 schrieb Andrew Jones: > > On Wed, Oct 07, 2015 at 08:16:40AM -0400, Marc-André Lureau wrote: > >> - Original Message - > >>> Am 06.10.2015 um 21:18 schrieb marcandre.lur...@redhat.com: > Marc-André Lureau (45): > >>>

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-07 Thread Andreas Färber
Drew, Am 07.10.2015 um 14:42 schrieb Andrew Jones: > On Wed, Oct 07, 2015 at 08:16:40AM -0400, Marc-André Lureau wrote: >> - Original Message - >>> Am 06.10.2015 um 21:18 schrieb marcandre.lur...@redhat.com: Marc-André Lureau (45): >>> [...] tests: add ivshmem qtest >>> >>>

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-07 Thread Marc-André Lureau
Hi - Original Message - > Am 07.10.2015 um 14:16 schrieb Marc-André Lureau: > > - Original Message - > >> Am 06.10.2015 um 21:18 schrieb marcandre.lur...@redhat.com: > >>> Marc-André Lureau (45): > >> [...] > >>> tests: add ivshmem qtest > >> > >> I had NAK'ed this patch in v

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-07 Thread Andrew Jones
On Wed, Oct 07, 2015 at 08:16:40AM -0400, Marc-André Lureau wrote: > > Hi Andreas > > - Original Message - > > Am 06.10.2015 um 21:18 schrieb marcandre.lur...@redhat.com: > > > From: Marc-André Lureau > > > > > > The following changes since commit > > > 5fdb4671b08e0d1631447e81348b2b50a

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-07 Thread Andreas Färber
Am 07.10.2015 um 14:16 schrieb Marc-André Lureau: > - Original Message - >> Am 06.10.2015 um 21:18 schrieb marcandre.lur...@redhat.com: >>> Marc-André Lureau (45): >> [...] >>> tests: add ivshmem qtest >> >> I had NAK'ed this patch in v1 and it has not been fixed. If this pull >> gets

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-07 Thread Marc-André Lureau
Hi Andreas - Original Message - > Am 06.10.2015 um 21:18 schrieb marcandre.lur...@redhat.com: > > From: Marc-André Lureau > > > > The following changes since commit > > 5fdb4671b08e0d1631447e81348b2b50a6b85bf7: > > > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-requ

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-07 Thread Andreas Färber
Am 06.10.2015 um 21:18 schrieb marcandre.lur...@redhat.com: > From: Marc-André Lureau > > The following changes since commit 5fdb4671b08e0d1631447e81348b2b50a6b85bf7: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into > staging (2015-10-06 13:42:33 +0100) > > are

[Qemu-devel] [PULL 00/48] ivshmem series

2015-10-06 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 5fdb4671b08e0d1631447e81348b2b50a6b85bf7: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into staging (2015-10-06 13:42:33 +0100) are available in the git repository at: https://github.com/elmarco/qemu tags/