Re: [Qemu-devel] [PATCH v6 21/25] replay: replay BH for IDE trim operation

2018-09-17 Thread John Snow
On 09/17/2018 08:00 AM, Pavel Dovgalyuk wrote: >> From: John Snow [mailto:js...@redhat.com] >> On 09/14/2018 03:27 AM, Pavel Dovgalyuk wrote: From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] > From: John Snow [mailto:js...@redhat.com] > On 09/12/2018 04:19 AM, Pavel Dovgalyuk wrote

Re: [Qemu-devel] [PATCH v6 21/25] replay: replay BH for IDE trim operation

2018-09-17 Thread Paolo Bonzini
On 17/09/2018 13:57, Pavel Dovgalyuk wrote: >> From: Peter Maydell [mailto:peter.mayd...@linaro.org] >> On 14 September 2018 at 16:19, Paolo Bonzini wrote: >>> On 14/09/2018 16:00, John Snow wrote: > Maybe not. We can hardly analyze all peripheral devices code and fix all > the calls. >>>

Re: [Qemu-devel] [PATCH v6 21/25] replay: replay BH for IDE trim operation

2018-09-17 Thread Pavel Dovgalyuk
> From: John Snow [mailto:js...@redhat.com] > On 09/14/2018 03:27 AM, Pavel Dovgalyuk wrote: > >> From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] > >>> From: John Snow [mailto:js...@redhat.com] > >>> On 09/12/2018 04:19 AM, Pavel Dovgalyuk wrote: > This patch makes IDE trim BH deterministic,

Re: [Qemu-devel] [PATCH v6 21/25] replay: replay BH for IDE trim operation

2018-09-17 Thread Pavel Dovgalyuk
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > On 14 September 2018 at 16:19, Paolo Bonzini wrote: > > On 14/09/2018 16:00, John Snow wrote: > >>> Maybe not. We can hardly analyze all peripheral devices code and fix all > >>> the calls. > >>> But I think we can improve that patch and a

Re: [Qemu-devel] [PATCH v6 21/25] replay: replay BH for IDE trim operation

2018-09-14 Thread Peter Maydell
On 14 September 2018 at 16:19, Paolo Bonzini wrote: > On 14/09/2018 16:00, John Snow wrote: >>> Maybe not. We can hardly analyze all peripheral devices code and fix all >>> the calls. >>> But I think we can improve that patch and at least look through ide core to >>> fix other calls. >>> >>> Pav

Re: [Qemu-devel] [PATCH v6 21/25] replay: replay BH for IDE trim operation

2018-09-14 Thread Paolo Bonzini
On 14/09/2018 16:00, John Snow wrote: >> Maybe not. We can hardly analyze all peripheral devices code and fix all the >> calls. >> But I think we can improve that patch and at least look through ide core to >> fix other calls. >> >> Pavel Dovgalyuk >> > It just seems odd that if you're working on

Re: [Qemu-devel] [PATCH v6 21/25] replay: replay BH for IDE trim operation

2018-09-14 Thread John Snow
On 09/14/2018 03:27 AM, Pavel Dovgalyuk wrote: >> From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] >>> From: John Snow [mailto:js...@redhat.com] >>> On 09/12/2018 04:19 AM, Pavel Dovgalyuk wrote: This patch makes IDE trim BH deterministic, because it affects the device state. Therefor

Re: [Qemu-devel] [PATCH v6 21/25] replay: replay BH for IDE trim operation

2018-09-14 Thread John Snow
On 09/14/2018 01:48 AM, Pavel Dovgalyuk wrote: >> From: John Snow [mailto:js...@redhat.com] >> On 09/12/2018 04:19 AM, Pavel Dovgalyuk wrote: >>> This patch makes IDE trim BH deterministic, because it affects >>> the device state. Therefore its invocation should be replayed >>> instead of runnin

Re: [Qemu-devel] [PATCH v6 21/25] replay: replay BH for IDE trim operation

2018-09-14 Thread Pavel Dovgalyuk
> From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] > > From: John Snow [mailto:js...@redhat.com] > > On 09/12/2018 04:19 AM, Pavel Dovgalyuk wrote: > > > This patch makes IDE trim BH deterministic, because it affects > > > the device state. Therefore its invocation should be replayed > > > instead

Re: [Qemu-devel] [PATCH v6 21/25] replay: replay BH for IDE trim operation

2018-09-13 Thread Pavel Dovgalyuk
> From: John Snow [mailto:js...@redhat.com] > On 09/12/2018 04:19 AM, Pavel Dovgalyuk wrote: > > This patch makes IDE trim BH deterministic, because it affects > > the device state. Therefore its invocation should be replayed > > instead of running at the random moment. > > > > Signed-off-by: Pavel

Re: [Qemu-devel] [PATCH v6 21/25] replay: replay BH for IDE trim operation

2018-09-13 Thread John Snow
On 09/12/2018 04:19 AM, Pavel Dovgalyuk wrote: > This patch makes IDE trim BH deterministic, because it affects > the device state. Therefore its invocation should be replayed > instead of running at the random moment. > > Signed-off-by: Pavel Dovgalyuk > Reviewed-by: Paolo Bonzini > --- > h

[Qemu-devel] [PATCH v6 21/25] replay: replay BH for IDE trim operation

2018-09-12 Thread Pavel Dovgalyuk
This patch makes IDE trim BH deterministic, because it affects the device state. Therefore its invocation should be replayed instead of running at the random moment. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Paolo Bonzini --- hw/ide/core.c |3 ++- 1 file changed, 2 insertions(+), 1 deleti