Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread Cédric Le Goater
On 09/06/2016 02:49 AM, David Gibson wrote: > On Mon, Sep 05, 2016 at 06:28:10PM +1000, Benjamin Herrenschmidt wrote: >> On Mon, 2016-09-05 at 09:41 +0200, Cédric Le Goater wrote: >>> yeah. I have not found a clear definition of all the bits. >>> >>> I will try to make a macro with what I can colle

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread David Gibson
On Mon, Sep 05, 2016 at 09:56:03AM +0200, Cédric Le Goater wrote: > On 09/05/2016 04:58 AM, David Gibson wrote: > > On Wed, Aug 31, 2016 at 06:34:10PM +0200, Cédric Le Goater wrote: > >> This is is an abstraction of a POWER8 chip which is a set of cores > >> plus other 'units', like the pervasive u

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread David Gibson
On Mon, Sep 05, 2016 at 06:28:10PM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2016-09-05 at 09:41 +0200, Cédric Le Goater wrote: > > yeah. I have not found a clear definition of all the bits. > > > > I will try to make a macro with what I can collect from the  > > specs and the code. > > It's

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread David Gibson
On Mon, Sep 05, 2016 at 11:10:05AM +0200, Cédric Le Goater wrote: > On 09/05/2016 09:41 AM, David Gibson wrote: > > On Mon, Sep 05, 2016 at 04:59:23PM +1000, Benjamin Herrenschmidt wrote: > >> On Mon, 2016-09-05 at 12:58 +1000, David Gibson wrote: > >>> > >>> With the new chip class per cpu class,

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread Cédric Le Goater
On 09/05/2016 09:41 AM, David Gibson wrote: > On Mon, Sep 05, 2016 at 04:59:23PM +1000, Benjamin Herrenschmidt wrote: >> On Mon, 2016-09-05 at 12:58 +1000, David Gibson wrote: >>> >>> With the new chip class per cpu class, does this chip_type field >>> serve >>> any purpose any more? >>> +

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread David Gibson
On Mon, Sep 05, 2016 at 04:59:23PM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2016-09-05 at 12:58 +1000, David Gibson wrote: > > > > With the new chip class per cpu class, does this chip_type field > > serve > > any purpose any more? > > > > > +    k->chip_f000f = 0x120d30498000ull; > >

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread Benjamin Herrenschmidt
On Mon, 2016-09-05 at 09:41 +0200, Cédric Le Goater wrote: > yeah. I have not found a clear definition of all the bits. > > I will try to make a macro with what I can collect from the  > specs and the code. It's the CFAM stuff, there's some doco internally but nothing releasable publicly... Chee

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread Cédric Le Goater
On 09/05/2016 04:58 AM, David Gibson wrote: > On Wed, Aug 31, 2016 at 06:34:10PM +0200, Cédric Le Goater wrote: >> This is is an abstraction of a POWER8 chip which is a set of cores >> plus other 'units', like the pervasive unit, the interrupt controller, >> the memory controller, the on-chip micro

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread Cédric Le Goater
On 09/05/2016 08:59 AM, Benjamin Herrenschmidt wrote: > On Mon, 2016-09-05 at 12:58 +1000, David Gibson wrote: >> >> With the new chip class per cpu class, does this chip_type field >> serve >> any purpose any more? >> >>> +k->chip_f000f = 0x120d30498000ull; >> >> A comment somewhere explai

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-05 Thread Benjamin Herrenschmidt
On Mon, 2016-09-05 at 12:58 +1000, David Gibson wrote: > > With the new chip class per cpu class, does this chip_type field > serve > any purpose any more? > > > +    k->chip_f000f = 0x120d30498000ull; > > A comment somewhere explaining what this cryptic value is would be > nice. It's snaps

Re: [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-09-04 Thread David Gibson
On Wed, Aug 31, 2016 at 06:34:10PM +0200, Cédric Le Goater wrote: > This is is an abstraction of a POWER8 chip which is a set of cores > plus other 'units', like the pervasive unit, the interrupt controller, > the memory controller, the on-chip microcontroller, etc. The whole can > be seen as a soc

[Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object

2016-08-31 Thread Cédric Le Goater
This is is an abstraction of a POWER8 chip which is a set of cores plus other 'units', like the pervasive unit, the interrupt controller, the memory controller, the on-chip microcontroller, etc. The whole can be seen as a socket. It depends on a cpu model and its characteristics, max cores, specifi