Re: [Qemu-devel] [PATCH v2 09/14] hw/timer: QOM'ify milkymist_sysctl

2016-02-17 Thread xiaoqiang zhao
I have sent the v3, which fix this problem. > 在 2016年2月16日,02:14,Peter Maydell 写道: > >> On 27 January 2016 at 02:54, xiaoqiang zhao wrote: >> * split milkymist_sysctl_init into milkymist_sysctl_info.instance_init and >> milkymist_sysctl_realize > > I think the "info" in this function name is

Re: [Qemu-devel] [PATCH v2 09/14] hw/timer: QOM'ify milkymist_sysctl

2016-02-16 Thread hitmoon
在 2016年02月16日 17:41, Peter Maydell 写道: On 16 February 2016 at 09:34, hitmoon wrote: 在 2016年02月16日 02:14, Peter Maydell 写道: On 27 January 2016 at 02:54, xiaoqiang zhao wrote: * split milkymist_sysctl_init into milkymist_sysctl_info.instance_init and milkymist_sysctl_realize I think the "i

Re: [Qemu-devel] [PATCH v2 09/14] hw/timer: QOM'ify milkymist_sysctl

2016-02-16 Thread Peter Maydell
On 16 February 2016 at 09:34, hitmoon wrote: > > > 在 2016年02月16日 02:14, Peter Maydell 写道: >> >> On 27 January 2016 at 02:54, xiaoqiang zhao wrote: >>> >>> >* split milkymist_sysctl_init into milkymist_sysctl_info.instance_init >>> > and milkymist_sysctl_realize >> >> I think the "info" in this fu

Re: [Qemu-devel] [PATCH v2 09/14] hw/timer: QOM'ify milkymist_sysctl

2016-02-16 Thread hitmoon
在 2016年02月16日 02:14, Peter Maydell 写道: On 27 January 2016 at 02:54, xiaoqiang zhao wrote: >* split milkymist_sysctl_init into milkymist_sysctl_info.instance_init and milkymist_sysctl_realize I think the "info" in this function name is wrong ? I can not understand , can you give me more de

Re: [Qemu-devel] [PATCH v2 09/14] hw/timer: QOM'ify milkymist_sysctl

2016-02-15 Thread Peter Maydell
On 27 January 2016 at 02:54, xiaoqiang zhao wrote: > * split milkymist_sysctl_init into milkymist_sysctl_info.instance_init and > milkymist_sysctl_realize I think the "info" in this function name is wrong ? > * use DeviceClass::realize instead of SysBusDeviceClass::init Please make sure you li

[Qemu-devel] [PATCH v2 09/14] hw/timer: QOM'ify milkymist_sysctl

2016-01-26 Thread xiaoqiang zhao
* split milkymist_sysctl_init into milkymist_sysctl_info.instance_init and milkymist_sysctl_realize * use DeviceClass::realize instead of SysBusDeviceClass::init Signed-off-by: xiaoqiang zhao --- hw/timer/milkymist-sysctl.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions