I have sent the v3, which fix this problem. > 在 2016年2月16日，02:14，Peter Maydell <peter.mayd...@linaro.org> 写道： > >> On 27 January 2016 at 02:54, xiaoqiang zhao <zxq_yx_...@163.com> wrote: >> * split milkymist_sysctl_init into milkymist_sysctl_info.instance_init and >> milkymist_sysctl_realize > > I think the "info" in this function name is wrong ? > >> * use DeviceClass::realize instead of SysBusDeviceClass::init > > Please make sure you line wrap your commit messages (at somewhere > around 70-72 columns is usual). > > Otherwise: > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> > > Again, you should cc the maintainer for this device. > > thanks > -- PMM >
