[Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2016-01-08 Thread Denis V. Lunev
'name' attribute is made mandatory in distinction with HMP command. The patch also moves hmp_savevm implementation into hmp.c. This function is just a simple wrapper now and does not have knowledge about migration internals. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Mar

[Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2016-01-08 Thread Denis V. Lunev
'name' attribute is made mandatory in distinction with HMP command. The patch also moves hmp_savevm implementation into hmp.c. This function is just a simple wrapper now and does not have knowledge about migration internals. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Mar

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2016-01-08 Thread Denis V. Lunev
On 12/24/2015 12:40 AM, Eric Blake wrote: On 12/04/2015 07:44 AM, Denis V. Lunev wrote: 'name' attribute is made mandatory in distinction with HMP command. The patch also moves hmp_savevm implementation into hmp.c. This function is just a simple wrapper now and does not have knowledge about mig

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-12-23 Thread Denis V. Lunev
On 12/24/2015 12:40 AM, Eric Blake wrote: On 12/04/2015 07:44 AM, Denis V. Lunev wrote: 'name' attribute is made mandatory in distinction with HMP command. The patch also moves hmp_savevm implementation into hmp.c. This function is just a simple wrapper now and does not have knowledge about mig

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-12-23 Thread Eric Blake
On 12/04/2015 07:44 AM, Denis V. Lunev wrote: > 'name' attribute is made mandatory in distinction with HMP command. > > The patch also moves hmp_savevm implementation into hmp.c. This function > is just a simple wrapper now and does not have knowledge about > migration internals. > > Signed-off-b

[Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-12-04 Thread Denis V. Lunev
'name' attribute is made mandatory in distinction with HMP command. The patch also moves hmp_savevm implementation into hmp.c. This function is just a simple wrapper now and does not have knowledge about migration internals. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Mar

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-12-01 Thread Denis V. Lunev
On 12/01/2015 06:05 PM, Markus Armbruster wrote: "Denis V. Lunev" writes: On 11/17/2015 01:10 PM, Markus Armbruster wrote: "Denis V. Lunev" writes: Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake --- migration/savevm.c | 5 +

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-12-01 Thread Markus Armbruster
"Denis V. Lunev" writes: > On 11/17/2015 01:10 PM, Markus Armbruster wrote: >> "Denis V. Lunev" writes: >> >>> Signed-off-by: Denis V. Lunev >>> CC: Juan Quintela >>> CC: Amit Shah >>> CC: Markus Armbruster >>> CC: Eric Blake >>> --- >>> migration/savevm.c | 5 + >>> qapi-schema.jso

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-12-01 Thread Markus Armbruster
"Denis V. Lunev" writes: > On 11/18/2015 02:36 PM, Juan Quintela wrote: >> Markus Armbruster wrote: >>> "Denis V. Lunev" writes: >>> Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake --- migration/savevm.

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-12-01 Thread Eric Blake
On 12/01/2015 07:28 AM, Denis V. Lunev wrote: +void qmp_savevm(bool has_name, const char *name, Error **errp) +{ +do_savevm(has_name ? name : NULL, errp); +} + >>> Please name do_savevm() qmp_savevm() and drop this wrapper. >>> >>> We're working on omitting has_FOO fo

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-12-01 Thread Denis V. Lunev
On 11/17/2015 01:10 PM, Markus Armbruster wrote: "Denis V. Lunev" writes: Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake --- migration/savevm.c | 5 + qapi-schema.json | 13 + qmp-commands.hx| 25 ++

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-12-01 Thread Denis V. Lunev
On 11/18/2015 02:36 PM, Juan Quintela wrote: Markus Armbruster wrote: "Denis V. Lunev" writes: Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake --- migration/savevm.c | 5 + qapi-schema.json | 13 + qmp-commands.hx

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-11-18 Thread Juan Quintela
Markus Armbruster wrote: > "Denis V. Lunev" writes: > >> Signed-off-by: Denis V. Lunev >> CC: Juan Quintela >> CC: Amit Shah >> CC: Markus Armbruster >> CC: Eric Blake >> --- >> migration/savevm.c | 5 + >> qapi-schema.json | 13 + >> qmp-commands.hx| 25 +

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-11-17 Thread Markus Armbruster
"Denis V. Lunev" writes: > Signed-off-by: Denis V. Lunev > CC: Juan Quintela > CC: Amit Shah > CC: Markus Armbruster > CC: Eric Blake > --- > migration/savevm.c | 5 + > qapi-schema.json | 13 + > qmp-commands.hx| 25 + > 3 files changed, 43 in

[Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-11-16 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake --- migration/savevm.c | 5 + qapi-schema.json | 13 + qmp-commands.hx| 25 + 3 files changed, 43 insertions(+) diff --git a/migration/savevm.c b/