"Denis V. Lunev" <d...@openvz.org> writes:
> On 11/18/2015 02:36 PM, Juan Quintela wrote:
>> Markus Armbruster <arm...@redhat.com> wrote:
>>> "Denis V. Lunev" <d...@openvz.org> writes:
>>>
>>>> Signed-off-by: Denis V. Lunev <d...@openvz.org>
>>>> CC: Juan Quintela <quint...@redhat.com>
>>>> CC: Amit Shah <amit.s...@redhat.com>
>>>> CC: Markus Armbruster <arm...@redhat.com>
>>>> CC: Eric Blake <ebl...@redhat.com>
>>>> ---
>>>> migration/savevm.c | 5 +++++
>>>> qapi-schema.json | 13 +++++++++++++
>>>> qmp-commands.hx | 25 +++++++++++++++++++++++++
>>>> 3 files changed, 43 insertions(+)
>>>>
>>>> diff --git a/migration/savevm.c b/migration/savevm.c
>>>> index f83ffd0..565b10a 100644
>>>> --- a/migration/savevm.c
>>>> +++ b/migration/savevm.c
>>>> @@ -2010,6 +2010,11 @@ void hmp_savevm(Monitor *mon, const QDict *qdict)
>>>> }
>>>> }
>>>> +void qmp_savevm(bool has_name, const char *name, Error **errp)
>>>> +{
>>>> + do_savevm(has_name ? name : NULL, errp);
>>>> +}
>>>> +
>>> Please name do_savevm() qmp_savevm() and drop this wrapper.
>>>
>>> We're working on omitting has_FOO for pointer-valued FOO.
>> Agreed.
>>
>
> is there a tree with this stuff in or something I could be based on?
> This series is simple enough to be written fast and be merged
> early when the hard freeze will be done.
>
> Above stuff could have a way harder way due to the amount of
> changes to be performed.
I recommend not to base on our qapi work just for the has_FOO change. I
mentioned it only because once it lands, the wrapper I want you to drop
would become entirely pointless. Go ahead and get your patches in, and
let us deal with cleaning up all has_FOO.
