Re: [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change

2017-07-19 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> The password would have to be NULL to disallow further login, is that >> what your other series will allow to do? > > Disallow logins can be done using "expire-password vnc now". > > I think having multiple ways to archive the same thing is a bad idea > from a s

Re: [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change

2017-07-19 Thread Gerd Hoffmann
Hi, > The password would have to be NULL to disallow further login, is that > what your other series will allow to do? Disallow logins can be done using "expire-password vnc now". I think having multiple ways to archive the same thing is a bad idea from a security point of view, so I'd suggest

Re: [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change

2017-07-19 Thread Eric Blake
On 07/19/2017 07:10 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Hi >> >> On Wed, Jul 19, 2017 at 9:09 AM, Markus Armbruster wrote: >>> QMP command >>> >>> { "execute": "change", >>> "arguments": { "device": "vnc", "target": "password", "arg": PWD } } >>> >>> behaves j

Re: [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change

2017-07-19 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Hi >> >> On Wed, Jul 19, 2017 at 9:09 AM, Markus Armbruster wrote: >>> QMP command >>> >>> { "execute": "change", >>> "arguments": { "device": "vnc", "target": "password", "arg": PWD } } >>> >>> behaves just like >>> >>> {

Re: [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change

2017-07-19 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Wed, Jul 19, 2017 at 9:09 AM, Markus Armbruster wrote: >> QMP command >> >> { "execute": "change", >> "arguments": { "device": "vnc", "target": "password", "arg": PWD } } >> >> behaves just like >> >> { "execute": "change-vnc-password", >>

Re: [Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change

2017-07-19 Thread Marc-André Lureau
Hi On Wed, Jul 19, 2017 at 9:09 AM, Markus Armbruster wrote: > QMP command > > { "execute": "change", > "arguments": { "device": "vnc", "target": "password", "arg": PWD } } > > behaves just like > > { "execute": "change-vnc-password", > "arguments": { "password", "arg": PWD }

[Qemu-devel] [PATCH] vnc: Clarify documentation of QMP command change

2017-07-19 Thread Markus Armbruster
QMP command { "execute": "change", "arguments": { "device": "vnc", "target": "password", "arg": PWD } } behaves just like { "execute": "change-vnc-password", "arguments": { "password", "arg": PWD } } Their documentation differs, however. According to change-vnc-password's d