On 07/19/2017 07:10 AM, Markus Armbruster wrote:
> Marc-André Lureau <marcandre.lur...@gmail.com> writes:
>
>> Hi
>>
>> On Wed, Jul 19, 2017 at 9:09 AM, Markus Armbruster <arm...@redhat.com> wrote:
>>> QMP command
>>>
>>> { "execute": "change",
>>> "arguments": { "device": "vnc", "target": "password", "arg": PWD } }
>>>
>>> behaves just like
>>>
>>> { "execute": "change-vnc-password",
>>> "arguments": { "password", "arg": PWD } }
>>>
>>> Their documentation differs, however. According to
>>> change-vnc-password's documentation, "an empty password [...] will set
>>> the password to the empty string", while change's documentation claims
>>> "no future logins will be allowed". The former is actually correct.
>>> Replace the incorrect claim by a reference to change-vnc-password.
>>>
>>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>>
>> Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
>>
>>
>> The password would have to be NULL to disallow further login, is that
>> what your other series will allow to do?
>
> I guess it could be applied to change-vnc-password that way.Ideally, 'change' will be deprecated (and certainly we shouldn't add anything further to it), but yes, 'change-vnc-password' could be enhanced in 2.11 to use the StrOrNull alternate to use null as the request for no password (since the empty string "" _is_ hashable as a password, whether or not we currently allow it to be one). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
